| 00:13.23 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:d844:2a12:59a1:179d) |
| 00:13.24 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 00:20.33 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 00:20.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 00:21.21 | *** join/#asterisk-dev pohvak (~pohvak@fixed-187-189-210-146.totalplay.net) |
| 01:12.40 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:b5e7:89e:a721:b16a) |
| 01:12.40 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:58.33 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:156b:e7e0:3431:6f4f) |
| 01:58.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:09.19 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 06:53.02 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:53.02 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:07.14 | *** join/#asterisk-dev jkroon (~jkroon@154.73.35.201) |
| 07:07.34 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:07.34 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:28.13 | *** join/#asterisk-dev hehol (~Adium@ip-109-90-164-163.hsi11.unitymediagroup.de) |
| 07:39.54 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:06.57 | *** join/#asterisk-dev sh_smith (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 08:16.39 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 08:17.57 | *** join/#asterisk-dev sh_smith (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 10:05.08 | *** join/#asterisk-dev pnlarsson (~niklas@2a02:760:1000:e:48ac:e5b7:5663:136d) |
| 10:07.58 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 12:27.51 | *** join/#asterisk-dev tuxian_ (~tuxian@igilmour.plus.com) |
| 13:17.33 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-caioznsgkawbczbg) |
| 13:17.34 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:32.29 | seanbright | can i get a second pair of eyes on something... |
| 13:32.39 | seanbright | 13, res/res_smdi.c |
| 13:32.55 | seanbright | lines 613-619 |
| 13:33.49 | seanbright | allocating room for md_msg twice? |
| 13:34.03 | file | looks leaky |
| 13:34.27 | seanbright | k |
| 13:52.36 | seanbright | the SMDI spec costs $655? wtf |
| 13:53.43 | file | interesting |
| 13:53.53 | seanbright | does anyone actually use this? |
| 13:55.09 | file | I think it was a custom dev job a LONG time ago |
| 13:55.16 | file | so whether it is still in use as a module, dunno |
| 13:55.25 | file | whether it is in use as a protocol, probably |
| 13:55.33 | seanbright | right |
| 13:55.50 | file | there's your two answers :D |
| 13:56.04 | seanbright | trying to close one of these coverity bugs and i want to make sure that the code is correct if i change it |
| 13:56.10 | seanbright | right off the bat, this line is suspect: |
| 13:56.11 | seanbright | while ((c = fgetc(iface->file))) { |
| 13:56.32 | seanbright | unless the file ends in a 0 byte |
| 13:59.05 | seanbright | hmm, well iface->file is a serial port |
| 13:59.21 | seanbright | i'll just assume that line is correct |
| 14:00.10 | file | serial ports, more like cereal ports, amIrite? |
| 14:00.13 | file | no, no I'm not |
| 14:06.34 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-nnpgrwyeogjnavop) |
| 14:06.35 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:10.00 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:10.00 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:11.34 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:11.34 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:20.06 | seanbright | i think i killed jira |
| 14:20.47 | file | fine here, as fine as JIRA can be |
| 14:22.35 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qrwrbfhjjhcmvpjt) |
| 14:22.35 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:46.23 | stefan27 | Regarding app_queue in asterisk 13.15: It seems that within the wait loop for the header caller in the queue_exec function, asterisk checks its "makeannouncement-logic" *twice* each loop, it checks it first before calling try_calling, and it checks it a second time within the call-stack of try_calling, more precisely by the end of the wait_for_answer function... |
| 14:47.02 | stefan27 | I tried commenting out those announcements at the end of the wait_for_answer function and I have not seen any harmful side effects yet, do you know why they are there? |
| 14:50.23 | stefan27 | The way that it is unpatched, the queue starts ringing an agent for <ringtime> seconds, then on no answer it may make an announcement to the caller, but the queue only cancels the ringing attempt to the agent after making the announcement to the caller (since hangupcalls is called after wait_for_answer is finished) |
| 14:51.06 | stefan27 | so the actual time the queue has an outgoing call in ringing state is not always <ringtime> seconds but sometimes <ringtime> + <length of announcements>. Is that intended feature? |
| 14:52.15 | rmudgett | git blame is your friend when trying to find out why a line is the way it is. |
| 14:52.42 | file | rmudgett: I've got one word for you - autoservice |
| 14:53.03 | seanbright | that's not a word |
| 14:53.10 | stefan27 | autoservice? |
| 14:53.10 | seanbright | its two words without a space |
| 14:53.15 | seanbright | it's* |
| 14:53.41 | stefan27 | blame sounds wrong; I just want to investigate |
| 14:53.56 | file | there's also git annotate and git praise |
| 14:53.57 | file | :D |
| 14:54.02 | rmudgett | audoservice not found in that context |
| 14:54.04 | seanbright | stefan27: 'git blame' tells you who/when/why code was changed |
| 14:54.48 | stefan27 | all right, git is not on my everyday workflow |
| 14:57.52 | stefan27 | 465d0f4a (Olle Johansson 2013-04-29 13:38:59 |
| 14:58.06 | stefan27 | He's not here by any chance? |
| 14:58.58 | seanbright | https://github.com/asterisk/asterisk/commit/465d0f4a22aa38d01e16cc49138d701249de52e4 |
| 14:59.35 | seanbright | he's oej on IRC (not signed in at the moment) |
| 14:59.49 | stefan27 | Oh I recall that name |
| 15:00.26 | stefan27 | How did you locate that based on "465d0f4a" ? |
| 15:01.37 | seanbright | well, 'git show 465d0f4a' |
| 15:02.00 | seanbright | for github you just take the base commit URL (https://github.com/asterisk/asterisk/commit/) and append the SHA |
| 15:02.45 | stefan27 | Right, but the SHA of what? |
| 15:03.00 | seanbright | the SHA of the commit, which is 465d0f4a |
| 15:03.11 | stefan27 | thanks |
| 15:03.16 | seanbright | it's not the full SHA |
| 15:03.24 | seanbright | but it's enough to be unique (most of the time) |
| 15:09.40 | stefan27 | I see, I commented the https://github.com/asterisk/asterisk/commit/465d0f4a22aa38d01e16cc49138d701249de52e4 commit, but that commit is 4 year's old |
| 15:09.58 | seanbright | oh |
| 15:10.07 | seanbright | commenting on github will do nothing |
| 15:10.09 | seanbright | it's just a mirror |
| 15:10.24 | stefan27 | oh right, gerrit is what I need |
| 15:10.28 | seanbright | if you believe it is a bug, raise an issue in jira - https://issues.asterisk.org |
| 15:12.38 | stefan27 | what complicates making a jira is that the issue is produced in an app_queue that is patched; jira wants you to produce issues in clean latest versions? But I can still request review for old commits? |
| 15:16.55 | stefan27 | https://gerrit.asterisk.org/#/q/commit:465d0f4a gives no results? |
| 15:17.59 | seanbright | this was pre-gerrit |
| 15:18.02 | seanbright | if you believe it is a bug, raise an issue in jira - https://issues.asterisk.org |
| 15:18.17 | seanbright | sorry, didn't see your previous message |
| 15:18.18 | stefan27 | ok I will |
| 15:18.39 | seanbright | i'm sorry, i haven't really been following your question |
| 15:19.14 | seanbright | i have zero interest in app_queue |
| 15:19.29 | seanbright | just trying to help you navigate - poorly it seems |
| 15:20.25 | stefan27 | you're helpful; I just wish I was better at reproducing issues in latest versions |
| 15:20.53 | stefan27 | it's easier to question a code-line than to build a use case |
| 15:21.27 | stefan27 | but I guess commits are driven by test cases, not by "this looks wrong" |
| 15:22.03 | seanbright | stefan27: https://reviewboard.asterisk.org/r/2263/ |
| 15:22.56 | seanbright | don't bother commenting there, either. reviewboard is no longer used for anything. |
| 15:23.24 | stefan27 | pretty sure I'll get scolded for my jira for not providing a good context |
| 15:23.39 | seanbright | stefan27: so if you undo oej's patch |
| 15:23.56 | seanbright | you shouldn't hear periodic announcements if you are at the head of the queue |
| 15:25.19 | stefan27 | which I believe you do, based on the fact that it does for me, but I did not *exactly* undo his patch and my app_queue is slightly different (in places that should not be relevant) |
| 15:25.20 | seanbright | my favorite part of that review/patch is that two people commented to update doxygen comments before merging, and that wasn't done |
| 15:26.09 | seanbright | stefan27: ok, like i said, my interest level is near zero, but if ultimately you're just saying "there is some unnecessary code in app_queue" i don't think you will get a lot of traction without supplying a patch. |
| 15:26.20 | seanbright | if something was broken, that would be one thing. but there is plenty of useless code in asterisk. |
| 15:26.22 | stefan27 | this app queue of mine is just in development environment; so I'm not stressed by time to get a ptch |
| 15:26.47 | seanbright | most of file's code for example... uselsss |
| 15:26.53 | seanbright | useless* |
| 15:27.03 | stefan27 | yeah, if I was in charge of the code base I would want people to submit failing test cases too |
| 15:27.07 | stefan27 | when submitting issues |
| 15:27.13 | seanbright | ok |
| 15:27.17 | seanbright | so i'm glad we had this talk |
| 15:27.38 | seanbright | interest level is now officially at 0 |
| 15:27.45 | seanbright | dipping into negative territory |
| 15:29.22 | stefan27 | you should engage in something you like |
| 15:35.21 | file | I'm in a meeting, I'll respond to your remark soon seanbright... soon |
| 15:37.14 | stefan27 | Yay I created a jira. I remember when I created my first Jira. It was the happiest day of my life |
| 15:44.22 | file | seanbright: yes - all my code is sad ;( |
| 16:08.33 | tm1000 | res_mwi_devstate.c:25:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] |
| 16:08.33 | tm1000 | <PROTECTED> |
| 16:08.46 | tm1000 | file: Asterisk 15. Anything I can read about this? |
| 16:08.54 | tm1000 | (custom module. blah blah) |
| 16:09.30 | file | I know nothing of that. |
| 16:10.05 | tm1000 | ASTERISK-26480 |
| 16:10.08 | tm1000 | found it |
| 16:10.12 | tm1000 | removal of it completely |
| 16:36.10 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.163) |
| 17:37.34 | *** join/#asterisk-dev tzafrir (~tzafrir@77.139.195.52) |
| 17:37.35 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 17:39.06 | *** join/#asterisk-dev tzafrir (~tzafrir@77.139.195.52) |
| 17:39.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:03.43 | *** join/#asterisk-dev oej (~oej@h-205-12.A165.corp.bahnhof.se) |
| 18:03.43 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:07.01 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-qtcgealcxcmmvaxr) |
| 18:07.01 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 18:33.00 | seanbright | hmmm |
| 18:33.08 | seanbright | what does "identical tree" mean when trying to cherry pick in gerrit? |
| 18:35.19 | seanbright | oh... it's already fixed in 14 and beyond |
| 18:35.20 | seanbright | weird |
| 18:39.23 | seanbright | i wish mjordan was here so that we could bask in our collective smartness |
| 18:41.46 | file | he's going/on vacation |
| 23:16.49 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-nnpgrwyeogjnavop) |
| 23:31.55 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 23:31.56 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 23:33.37 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 23:33.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:54.39 | *** join/#asterisk-dev Gugge (gugge@92.246.2.105) |