| 00:01.35 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 00:28.19 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:6ca2:22c4:be8a:749d) |
| 00:28.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 00:35.41 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 00:58.57 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 01:12.38 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 01:22.26 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 01:36.32 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 02:00.02 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 02:04.48 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 02:04.48 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:11.56 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 02:16.10 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:119d:e7fe:a08b:d417) |
| 02:16.10 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:25.11 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 02:37.27 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 03:00.53 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 03:26.41 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 03:55.57 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 04:20.10 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 04:33.51 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 04:59.19 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 05:09.56 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 05:30.14 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 05:52.24 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 06:14.04 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 06:14.55 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:29.36 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 06:42.09 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:42.09 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:45.00 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 06:50.55 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 06:51.11 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:51.11 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:00.33 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 07:10.31 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 07:17.07 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:17.07 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:20.51 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 07:31.32 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 07:44.55 | *** join/#asterisk-dev jkroon (~jkroon@154.73.35.201) |
| 07:48.26 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 07:59.03 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 08:19.33 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 08:40.03 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 09:10.32 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 09:33.05 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 09:33.31 | *** join/#asterisk-dev xarash (~arash@84.241.49.178) |
| 09:57.36 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 10:09.45 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 10:24.14 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 10:44.50 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 10:57.21 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 11:13.38 | seanbright | file: interesting |
| 11:14.02 | tsearle | good morning interesting |
| 11:14.25 | file | I think it's because the negotiation isn't complete yet maybe |
| 11:16.48 | file | So if unknown don't change our stored role I think |
| 11:16.55 | seanbright | alrighty |
| 11:17.42 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 11:33.08 | seanbright | i've grown to dislike this patch |
| 11:35.51 | file | that's fine, if you abandon it just make sure an issue exists |
| 11:37.58 | file | and now that I'm back from le dog walk I see you updated it |
| 11:38.11 | seanbright | yes, the update is what i am not keen on |
| 11:38.18 | seanbright | feels verbose |
| 11:38.36 | file | doesn't sweat the small stuff |
| 11:38.57 | seanbright | i shall let the review god's decide |
| 11:38.59 | seanbright | gods* |
| 11:39.54 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 11:47.21 | tsearle | now is there a god of the review gods? like a gerrit Zeus? |
| 11:48.23 | seanbright | when are you going to fix your review against master? |
| 11:50.02 | tsearle | soon, tracking down another issue at the moment, do you need it today? |
| 11:51.31 | seanbright | no |
| 11:52.14 | tsearle | ok, then I'll get to it after I figure out this rtcp issue |
| 11:52.31 | tsearle | so I'll get master fixed today or tomorrow |
| 11:58.05 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 11:58.05 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 12:00.58 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 12:07.30 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 12:07.30 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 12:28.20 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-50-184-200.dialup.adsl.anteldata.net.uy) |
| 12:40.35 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-vqvkrnzlrqsbsazy) |
| 12:40.35 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:55.12 | *** join/#asterisk-dev joshelson (~joshelson@206.205.80.228) |
| 13:08.24 | tsearle | hey, got a quick Q ref bridge_p2p_rtp_write |
| 13:09.01 | tsearle | is it a mistake that it's incrementing rxcount? |
| 13:09.30 | tsearle | this is the send function, rxcount should be incremented inside the ast_rtp_read function |
| 13:11.52 | file | it's a function only called on the receive path, so it doesn't really matter either way |
| 13:12.37 | tsearle | well, it's incrementing the wrong counter |
| 13:13.15 | file | in what way? |
| 13:13.22 | file | instance and rtp are what the packet came in on |
| 13:13.31 | file | instance1 and bridged are where it is being sent out on |
| 13:13.57 | tsearle | yeah, it's incrementing the rx count of instance1 instead of instance0 |
| 13:14.34 | tsearle | now that I'm trying to get rtcp stats working on native bridge, I moved p2p_bridge to later in the read |
| 13:14.44 | file | there is no instance0 in here? |
| 13:15.11 | tsearle | well the calling function ast_rtp_read has instance0 |
| 13:15.18 | tsearle | it's instance0 that received a packet |
| 13:15.28 | tsearle | instance1 is sending the packet |
| 13:15.42 | tsearle | so it should be txcount that's incremented for it |
| 13:15.52 | tsearle | (which does happen in ast_rtp_sendto) |
| 13:16.00 | *** join/#asterisk-dev spditner (~simon@45.72.160.157) |
| 13:16.36 | tsearle | and when I fixed ast_rtp_read to increment rxcount even when native bridge |
| 13:16.54 | tsearle | I found that pxlost calculation always eneded up being 0 because rx count was being double incremented |
| 13:17.03 | tsearle | (incremented for every send and for every receive) |
| 13:17.16 | file | I still don't see what you are referring to |
| 13:17.39 | tsearle | ok |
| 13:18.27 | tsearle | so a rtp packet arrives on an rtp instance (instance0) |
| 13:18.45 | tsearle | instance0 should have it's rxcount incremented to report instance0 got a packet |
| 13:18.49 | tsearle | then it sees it's bridged |
| 13:19.05 | file | what version of Asterisk? |
| 13:19.07 | tsearle | so it send that packet to the bridged (instance1) for forwarding |
| 13:19.10 | tsearle | ast13 |
| 13:19.52 | file | okay, so instance and instance1 |
| 13:20.58 | tsearle | so instance1 is passed to bridge_p2p_rtp_write as parameter 1 |
| 13:21.09 | tsearle | but that is the instance sending the packet, not receiving |
| 13:21.15 | file | um |
| 13:21.22 | file | !bridge_p2p_rtp_write(instance, instance1, rtpheader, res, hdrlen)) |
| 13:21.33 | file | instance is first, then instance1? |
| 13:21.42 | tsearle | ha oops |
| 13:21.45 | tsearle | ok both are passed |
| 13:21.50 | tsearle | nvm then |
| 13:23.44 | tsearle | it's a bug introduced by me then, in my current patch I make sure rxcount is always called in the calling function |
| 13:24.05 | tsearle | so then the increment in p2p_write isn't needed |
| 13:35.54 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-50-99-15.dialup.adsl.anteldata.net.uy) |
| 13:39.43 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 13:51.32 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 13:51.32 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 13:57.31 | seanbright | do we use c99 variable length arrays anywhere? |
| 13:57.51 | seanbright | or do we prefer ast_alloca for those cases? |
| 13:59.10 | file | variable length arrays are used in a few places |
| 14:20.31 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:20.32 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:29.36 | seanbright | tsearle: you have two &&s on lines 5168 and 5169 |
| 14:29.46 | seanbright | surprised that actually compiles |
| 14:29.51 | tsearle | thanks |
| 14:29.52 | tsearle | fixed |
| 14:30.09 | tsearle | it was a bit to hasty fix of a merge conflict |
| 14:30.30 | tsearle | seems between 13.70 and head p2p_fwd variable dissapeared |
| 14:30.36 | tsearle | so I had to remove that |
| 14:30.42 | tsearle | but forgot to remove the && |
| 14:30.43 | tsearle | :-P |
| 14:31.05 | tsearle | 13.17 I mean |
| 14:31.33 | tsearle | btw, thanks for fixing master on the DTMF_MODE patch |
| 14:36.04 | seanbright | i'm not sure that i fixed it. |
| 14:36.13 | seanbright | i mean... i got it to compile |
| 14:36.56 | seanbright | in dtmf_mode_refresh_cb, i just added NULL as the last parameter of ast_sip_session_refresh() |
| 14:36.59 | seanbright | i'm not sure that is correct |
| 14:37.09 | seanbright | so you might want to give it a whirl in your test environment |
| 14:37.17 | file | it should be correct |
| 14:37.25 | seanbright | then i am awesome and you're welcome |
| 14:37.35 | tsearle | :-) |
| 14:44.45 | seanbright | i just paid for eyebeam |
| 14:44.47 | seanbright | wtf is wrong with me? |
| 14:45.05 | seanbright | also, why hasn't someone written a free version of X-Lite/eyeBeam/Bria? |
| 14:45.19 | file | seanbright: you seem to like paying for VoIP stuff |
| 14:45.26 | seanbright | it's kinda my thing |
| 14:45.36 | tsearle | what's wrong with linphone? |
| 14:45.44 | seanbright | i now have eyeBeam, Bria 4, and Bria X |
| 14:45.50 | seanbright | does it run on windows? |
| 14:46.02 | seanbright | and most importantly - does it look like absolute dogshit? |
| 14:46.13 | tsearle | it should have a window port |
| 14:46.21 | tsearle | only tried it under linux, osx, and android |
| 14:46.24 | seanbright | fancy |
| 14:46.29 | seanbright | will give it a whirl later |
| 14:47.03 | *** join/#asterisk-dev newtonr (newtonr@nat/digium/x-hqncsqtkijmnbgfi) |
| 14:47.03 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:47.09 | seanbright | "Qt/QML interface for Windows, Mac and GNU/Linux" |
| 14:47.11 | seanbright | nooooooooooooope |
| 14:47.12 | seanbright | i'm out |
| 14:47.30 | tsearle | QT? that's new |
| 14:47.33 | file | systemd-gui is the future |
| 14:47.36 | tsearle | thought they were GTK / C |
| 14:47.53 | seanbright | on windows, you better use native controls |
| 14:47.57 | seanbright | or i will stab you |
| 14:48.04 | seanbright | of course eyebeam & bria have their own themes |
| 14:48.10 | file | don't get blood on the carpet |
| 14:48.10 | seanbright | as does skype for business |
| 14:48.12 | file | it's hell to get out |
| 14:48.29 | cresl1n | seanbright: why do you have an ast_assert in your ice role conversion functions in https://gerrit.asterisk.org/#/c/6092/ |
| 14:48.44 | tsearle | really? I assumed it would be like red wine, just use club soda (or white wine) |
| 14:49.05 | cresl1n | in ast2pj_rtp_ice_role function specifically |
| 14:49.11 | seanbright | leftover cruft |
| 14:49.12 | seanbright | will remove |
| 14:49.17 | cresl1n | ok |
| 14:49.20 | cresl1n | cool, thanks |
| 14:49.23 | cresl1n | I'll tag it with a comment |
| 14:50.04 | seanbright | cresl1n: actually... |
| 14:50.19 | cresl1n | ???? |
| 14:50.21 | seanbright | i need one in pj2ast_rtp_ice_role but i don't have it |
| 14:50.34 | seanbright | if pjsip adds a new value to that enumeration, we'll silently ignore it |
| 14:50.41 | seanbright | which could lead to boogs |
| 14:50.42 | cresl1n | I'm cool with that |
| 14:50.47 | cresl1n | just can the other one |
| 14:53.02 | seanbright | fixed |
| 14:53.19 | seanbright | UGGGGH |
| 14:53.20 | seanbright | not fixed |
| 14:54.13 | cresl1n | yeah, I was about to say... |
| 14:54.22 | cresl1n | did you mean to change those breaks to returns? |
| 14:54.32 | seanbright | already done and updated |
| 14:54.35 | seanbright | (yes, i did) |
| 14:54.38 | cresl1n | thanks |
| 14:54.41 | cresl1n | :-) |
| 14:55.24 | cresl1n | I must be looking at an old patch revision |
| 14:56.17 | cresl1n | do you need a default case on pj2ast_rtp_ice_role? |
| 14:56.35 | cresl1n | crud, gtg |
| 14:57.00 | seanbright | no, i don't want a default case there in case _we_ add to that enum |
| 14:57.27 | seanbright | if we add to the enum and don't handle it in that switch, we'll fail to compile |
| 14:57.46 | seanbright | oh, i misunderstood your question |
| 14:58.05 | seanbright | short version: i believe that 6089.6 is "correct" |
| 14:58.46 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-edhaqsbrdnvcnniz) |
| 14:58.46 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:02.39 | tsearle | anyhow, I hope OEJ will be happy, I just pushed a small part of pinefrog |
| 15:03.30 | tsearle | anyhow, on that's done, I guess it's time to run away :-P |
| 15:12.24 | seanbright | if ((int)rtp->lastrxseqno - (int)seqno > 100) |
| 15:12.31 | seanbright | both of those are unsigned ints |
| 15:12.56 | seanbright | (just saw this looking at tsearle's patch and thought it was wonky) |
| 15:24.34 | file | I did it for a reason, but I do not recall |
| 15:26.33 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 15:45.07 | bford | regarding this review https://gerrit.asterisk.org/#/c/5980/ did we reach a decision on whether the AMI version should be bumped for it or wait until later for a release (and is it documented somewhere)? |
| 15:45.57 | gtjoseph | no clue |
| 15:46.08 | *** join/#asterisk-dev jbrouwers (~jbrouwers@196.22.251.238) |
| 15:46.36 | bford | the review itself looks fine, I'm hesitant to +1 it though because of versioning |
| 15:53.02 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:53.02 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:57.45 | gtjoseph | bford: ask cresl1n |
| 15:59.02 | bford | cresl1n: do you know what decision was made for AMI version concerning https://gerrit.asterisk.org/#/c/5980/? bump it now or wait until release? |
| 16:03.54 | cresl1n | bford: I think he bumped the version on it appropriately? |
| 16:03.56 | cresl1n | :- |
| 16:03.57 | cresl1n | :-) |
| 16:04.38 | cresl1n | it doesn't appear to be "breaking", it's the addition of a new field |
| 16:05.27 | bford | I mean is the version bump ok to do now, rather than waiting for next release? Is it documented somewhere so that we don't keep bumping it if we do other AMI changes? |
| 16:06.53 | cresl1n | I think it's fine to do now |
| 16:07.15 | cresl1n | The likelihood of another AMI change happening is low |
| 16:07.25 | cresl1n | What does everybody else think? |
| 16:09.20 | file | cresl1n: +1 |
| 16:11.43 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 16:11.44 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 16:11.57 | bford | Sounds good to me. Should this be going into 15 / master as well? |
| 16:12.29 | file | oui |
| 16:15.49 | seanbright | bford: it's already there |
| 16:15.52 | seanbright | in 15/master |
| 16:16.03 | rmudgett | since neither has been released yet |
| 17:00.47 | bford | Ah ok, cool |
| 17:46.20 | rmudgett | gtjoseph: Well, with rewrite_contact enabled A now uses the connection the INVITE came in on to send the UPDATE. So it uses only one connection for the call. |
| 17:46.55 | gtjoseph | ok cool. as expected |
| 17:48.41 | rmudgett | It doesn't affect the outgoing register request contact so the incoming INVITE creates a new connection. |
| 17:49.27 | rmudgett | I thought rewrite_contact was going to change the contact header. |
| 17:49.57 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 17:50.06 | gtjoseph | it does |
| 17:51.14 | rmudgett | It only changed the UPDATE's request line. |
| 17:51.21 | gtjoseph | if you do pjsip show contact on the "server" side, it should show the ephemeral port |
| 17:58.26 | rmudgett | Which command is that? pjsip show contact doesn't show anything more than pjsip show contacts. |
| 17:58.41 | gtjoseph | that's it. look at the client uri |
| 17:58.56 | gtjoseph | if rewwrite_contact is on, the port will be an ephemeral port |
| 17:59.14 | gtjoseph | if not, then it'll be whatever port was in the register contact |
| 17:59.22 | rmudgett | It doesn't show there. |
| 17:59.30 | gtjoseph | then rewrite_contact isn't om |
| 17:59.39 | gtjoseph | pjsip show endpoint ... |
| 18:01.06 | gtjoseph | rewrite_contact only applies to the server btw |
| 18:01.34 | rmudgett | The commands are only showing config settings. |
| 18:01.44 | rmudgett | Server side as in who originated the call? |
| 18:01.54 | rmudgett | s/originated/answered/ |
| 18:02.03 | gtjoseph | no the server side as in the instance that accepts registratrion |
| 18:04.02 | rmudgett | Rewrite_contact needs to be enabled on the side receiving the registration? |
| 18:04.09 | gtjoseph | yes |
| 18:04.25 | gtjoseph | it rewrites the incoming contact to use the connection info and that's what it stores |
| 18:04.42 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LFbn-1-5197-25.w90-105.abo.wanadoo.fr) |
| 18:05.33 | gtjoseph | a "client" can't change a contact port because at the time we create it, we have no idea what port it will go out on |
| 18:05.42 | rmudgett | Dang it. My understanding of that option was backwards too. |
| 18:12.14 | seanbright | dan_j: can you please test https://gerrit.asterisk.org/#/c/6096/ when you have some (precious) free time? |
| 18:15.36 | gtjoseph | rmudgett: actually i'm looking in res_pjsip_nat and it does look like we rewrite on any incoming message that has a Contact header |
| 18:16.34 | gtjoseph | but setting it on a "client" isn't really going to do anything |
| 18:17.50 | rmudgett | It helped with the UPDATE sent by the client to the server to use the connection opened by the servers INVITE. |
| 18:18.05 | gtjoseph | hmmm |
| 18:18.15 | gtjoseph | not sure why it would |
| 18:18.31 | rmudgett | A registers to B. B calls A. A sends UPDATE over connection opened by B's INVITE |
| 18:19.06 | rmudgett | otherwise A would have sent it over the connection it opened by the REGISTER. |
| 18:19.14 | gtjoseph | so what? |
| 18:19.41 | rmudgett | That's what happened when I set rewrite_contact on A |
| 18:19.56 | gtjoseph | yeah but why is that a "help" |
| 18:20.38 | gtjoseph | although i suppose if the contacts were static there'd be no register |
| 18:22.19 | rmudgett | Well anyway. With rewrite_contact on the server side only one connection gets used. :) |
| 18:26.23 | *** join/#asterisk-dev bford_ (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 18:26.23 | *** mode/#asterisk-dev [+o bford_] by ChanServ |
| 18:41.11 | seanbright | fuck i really hate the testsuite |
| 18:58.25 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 18:58.25 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 19:01.22 | dan_j | seanbright: message received. I'll try tomorrow. A little difficult with the kids on holiday. |
| 19:05.09 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 19:09.16 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 19:09.16 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 19:10.30 | seanbright | dan_j: good deal |
| 19:15.09 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 19:15.09 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:36.06 | jameswf | @newtonr PM? |
| 19:53.34 | newtonr | jameswf, I don't get anything from you... unless you are asking if you can, yeah? |
| 20:35.13 | seanbright | so how does one run the testsuite without /tmp filling up? |
| 20:50.45 | rmudgett | map /tmp to a larger drive? |
| 20:51.39 | rmudgett | run testsuite on a subset of tests. |
| 20:53.10 | rmudgett | and run cleanup-test-remnants.sh between runs |
| 21:10.30 | seanbright | all of these ideas are awful |
| 21:10.44 | seanbright | gives rmudgett a -1 and lots of commentary |
| 21:13.16 | seanbright | rmudgett: so your suggestion is to just add a default case to the switch in that function and move the ast_assert there, correct? |
| 21:13.44 | seanbright | should have just opened an issue for this instead of offering to fix |
| 21:13.57 | rmudgett | yes. It is the simpler than remembering to add conditional code when more cases have to be added. |
| 21:14.52 | seanbright | ok, let's see if i can do it all through the web interface |
| 21:19.21 | rmudgett | Apparently it did get nasty when the unknown role case happened. |
| 21:20.18 | rmudgett | Beware of the web interface insisting on using spaces instead of tabs. |
| 21:21.36 | seanbright | i copypasta'd |
| 21:21.40 | seanbright | the leading spacing |
| 21:22.15 | rmudgett | That's the only way I've found to get tabs into the edited source from the web interface. |
| 21:31.48 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 21:31.48 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 22:28.00 | *** join/#asterisk-dev joshelson (~joshelson@206.205.80.228) |
| 23:16.37 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 23:18.50 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:68cd:534d:b520:803b) |
| 23:18.50 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:21.23 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:5100:5091:8cb7:6508) |
| 23:21.23 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:27.21 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 23:59.27 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:1867:b9c0:578:1789) |
| 23:59.27 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |