| 00:19.23 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 00:19.23 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:49.59 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 01:14.19 | *** join/#asterisk-dev leedm777 (~textual@216.186.181.138) |
| 01:14.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:22.10 | *** join/#asterisk-dev leedm777 (~textual@216.186.181.138) |
| 01:22.10 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:31.21 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 01:31.21 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 02:12.48 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 02:45.12 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 02:45.12 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:54.53 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:d82a:a6af:2569:1b60) |
| 02:54.53 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:02.18 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 03:08.46 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:f147:6216:beeb:1f85) |
| 03:08.46 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:29.19 | *** join/#asterisk-dev joshelson (~joshelson@50-206-51-2-static.hfc.comcastbusiness.net) |
| 04:44.19 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:3cc2:efb6:57c:b70f) |
| 04:44.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 05:03.22 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 05:20.06 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-240-195.try.wideopenwest.com) |
| 05:20.06 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 06:49.51 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:57.31 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:762f:68ff:fedf:4a19) |
| 06:59.06 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:27.30 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.34) |
| 09:01.13 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:07.49 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 11:23.20 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:48.19 | tsearle | good afternoon |
| 11:48.47 | tsearle | I'm trying to write an asterisk testsuite test that will validate the output of a dialplan function |
| 11:48.55 | tsearle | is there an easy to do that? |
| 11:51.17 | file | https://github.com/asterisk/testsuite/tree/master/tests/channels/pjsip/dialplan_functions |
| 11:51.49 | file | pjsip_endpoint or pjsip_channel probably being the best for that particular use case |
| 11:52.51 | tsearle | now these directives in the yaml, do they still work if you also have a run-test script? |
| 11:53.16 | file | I don't know if/how to use them from a run-test |
| 12:00.37 | tsearle | https://github.com/asterisk/testsuite/blob/master/tests/channels/pjsip/dialplan_functions/pjsip_channel/configs/ast1/extensions.conf |
| 12:01.07 | tsearle | I don't see an include directive, but I don't see a defintion for test_variable in the script either |
| 12:01.29 | file | test_variable is the extension |
| 12:01.41 | file | it's used as a subroutine further down by the GoSub calls |
| 12:02.35 | tsearle | ha ok, all the "sames" are throwing me off a bit |
| 12:02.48 | tsearle | so the beggining is extension test_variable |
| 12:02.54 | tsearle | and then the rest is extension alice |
| 12:04.01 | tsearle | was thinking like a macro and looking for a [test_variable] |
| 12:08.34 | tsearle | I had an issue earlier when I pushed my review, it seemed like it couldn't connect to jira to verify my jira reference |
| 12:08.50 | tsearle | remote: Failed to check whether or not issue ASTERISK-27085 exists |
| 12:08.50 | tsearle | remote: java.io.IOException: Request failed |
| 12:08.50 | tsearle | remote: Non-existing issue ids referenced in commit message |
| 12:08.50 | tsearle | remote: The issue-ids |
| 12:08.50 | tsearle | remote: * ASTERISK-27085 |
| 12:08.51 | tsearle | remote: are referenced in the commit message of |
| 12:08.53 | tsearle | remote: b6190585f5fc91df86eaf408bbec947e3f417f41, |
| 12:13.51 | gtjoseph | tsearle: it may be related to the gerrit/openid issue we're having this morning |
| 12:27.36 | *** join/#asterisk-dev oej (~oej@host-95-199-0-145.mobileonline.telia.com) |
| 12:27.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:10.13 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 13:19.46 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-krxwtoudiupicmzn) |
| 13:19.46 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:37.14 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:03.08 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 14:03.08 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 14:10.38 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-gfqtiychwlyhopaz) |
| 14:10.38 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:48.18 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hbehlxtnluxrqjpc) |
| 14:48.18 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:52.49 | tsearle | hello |
| 14:52.56 | tsearle | I have a quick question ref dialplan functions |
| 14:53.18 | tsearle | is the channel alread locked before the dialplan function is invoked? |
| 14:53.41 | tsearle | I don't see any functions in channels/pjsip/dialplan_functions.c grabbing the channel lock |
| 14:54.58 | file | it isn't locked, but PJSIP marshals the request off to a serialized thread which guarantees nothing else will touch things |
| 14:55.20 | file | and some of the objects it accesses provide a guarantee they won't change |
| 14:57.06 | tsearle | ok, so then for the PJSIP_DTMF_MODE patch, I need to add a lock? |
| 14:58.29 | file | you either have to marshal it to a serialized thread which would provide the guarantee, or introduce locking |
| 14:58.42 | file | everything else uses the marshaling approach |
| 14:59.21 | tsearle | ok, I guess that's to figure out next week |
| 15:17.44 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 15:57.09 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-tvvgqnwpwgzhhuww) |
| 15:57.09 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:20.47 | *** join/#asterisk-dev newtonr (~newtonr@99-104-129-136.lightspeed.brhmal.sbcglobal.net) |
| 17:20.47 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 17:34.17 | *** join/#asterisk-dev elguero (~miguel323@74.95.21.41) |
| 18:00.27 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00144cb52483cba6ea.ipv6.abo.wanadoo.fr) |
| 19:19.40 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01cb0583d31d00144cb52483cba6ea.ipv6.abo.wanadoo.fr) |
| 20:00.25 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-saqkxzjzkucycpef) |
| 20:18.14 | *** join/#asterisk-dev jkroon (~jkroon@41.13.56.54) |
| 21:14.43 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 21:20.39 | kharwell | if we send back an sdp in a 200ok with two formats is it safe to assume the remote endpoint will always choose the first one in the list? |
| 21:23.08 | file | it "should" as that is the preferred one |
| 21:23.19 | file | but it is free to change between them |
| 21:33.01 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 21:33.17 | kharwell | are you an rfc? |
| 21:34.03 | file | sometimes |
| 21:38.29 | kharwell | hrm. If we send back two video formats for the stream and one format originally negotiated fir and the other did not then do we allow fir? |
| 21:38.54 | kharwell | I'm thinking yes since both formats are considered valid |
| 21:52.04 | *** join/#asterisk-dev joshelson (~joshelson@206.205.80.228) |
| 21:55.45 | file | kharwell: my head is mush, ask next week |
| 23:01.29 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-gfqtiychwlyhopaz) |
| 23:16.59 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 23:16.59 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |