| 14:16.36 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 14:16.36 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 14:36.05 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-neieqrmwjsefjgyn) |
| 14:36.09 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:14.49 | file | whoops. |
| 15:29.02 | cresl1n | waves |
| 15:29.46 | file | hola |
| 15:48.29 | file | is anyone looking at the multistream reviews? cresl1n? rmudgett? |
| 15:48.58 | file | I ask because I did a test squash to see the actual remove impact, and it's not that much |
| 15:49.04 | file | er review impact |
| 15:49.18 | file | it'd probably make it easier over all |
| 15:49.32 | rmudgett | Kevin was looking. I do plan to look again too. |
| 15:49.33 | cresl1n | kharwell is spending some sweet time on it |
| 15:49.37 | cresl1n | I haven't started them yet |
| 15:49.46 | file | yeah, he's fine squashing |
| 15:49.51 | file | https://www.irccloud.com/pastebin/OxcpyWeM/ |
| 15:50.02 | file | that's the diffstat between my part3 review, and a squashed version of all changes |
| 15:51.02 | kharwell | ya squashing is fine by me |
| 15:51.12 | cresl1n | Me too |
| 15:51.25 | file | cool cool |
| 15:53.56 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-ifjnsuextfegaxgi) |
| 15:53.56 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:58.52 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0074c30c87bce5b8df.ipv6.abo.wanadoo.fr) |
| 16:09.36 | rmudgett | file: Did you squash all three of marks reviews into yours? |
| 16:09.43 | file | yes |
| 16:09.47 | rmudgett | k |
| 16:15.02 | file | expects findings as he hasn't given it a thorough go-through yet either |
| 17:27.25 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 17:54.37 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-aeshwcytjtztcslr) |
| 17:54.37 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:58.57 | *** join/#asterisk-dev oej (~oej@95.209.25.225.bredband.tre.se) |
| 17:58.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:46.39 | *** join/#asterisk-dev danny_phonism (~danny@static-47-206-103-229.tamp.fl.frontiernet.net) |
| 18:48.18 | danny_phonism | Hey all, I'm trying to get a list of extensions through AMI. FreePBX is generating longer password than AMI reports. The command I'm using is 'sip show users' |
| 18:48.23 | danny_phonism | Is there an alternative? |
| 19:07.55 | *** join/#asterisk-dev danny_ph_ (~danny@static-47-206-103-229.tamp.fl.frontiernet.net) |
| 20:04.53 | jameswf | you can make FreePBX generate shorter passwords (it is an advanced setting) you could pull from FreePBX directly |
| 20:04.59 | jameswf | or not whatever |
| 20:36.54 | rmudgett | file: I added a few findings. |
| 20:37.14 | file | rmudgett: yeah, minor stuff so far :P |
| 20:38.57 | file | rmudgett: I don't agree on the reentrancy issue comment though - the active media state is only ever updated with the channel lock held which is only done on success, and chan_pjsip accesses it with channel lock held |
| 20:39.10 | file | and it is never modified after that happens |
| 20:44.38 | rmudgett | Oh. Didn't see that. It was an earlier concern that didn't seem to be resolved. |
| 20:45.03 | file | yeah, it was a side effect of making things sane - I could provide that guarantee |
| 20:45.30 | file | I'll mention it in le place where it is in the session |
| 20:46.03 | file | rmudgett: otherwise seem sane to you? |
| 20:47.22 | rmudgett | I know mark was trying to keep the struct the same once created. They stream type could change but the object would always exist once created. |
| 20:48.36 | file | yeah, I do some light reuse of the session media itself, but don't touch it in core session land, it's up to the handlers/outside stuff to deal with that |
| 20:48.48 | file | which is how it was done in ye ol' times |
| 20:50.24 | file | cresl1n: do you plan on doing any looking? (I'll hold off on making updates for a day and do everything at once if so) |
| 20:50.31 | file | same for you kharwell I s'pose |
| 20:50.51 | cresl1n | I would - it'll be tomorrow probably when I can get to it though |
| 20:50.59 | file | ack ack |
| 20:51.24 | kharwell | same here. Be tomorrow before I can prob take a look |
| 20:59.59 | seanbright | i will not be taking a look |
| 21:00.06 | seanbright | just sayin' |
| 21:02.50 | cresl1n | awww |
| 21:03.07 | file | my HVAC just filled up with water again |
| 21:03.13 | file | time to take a look inside |
| 21:03.18 | cresl1n | draino draino draino.... |
| 21:29.58 | *** join/#asterisk-dev tzafrir (~tzafrir@37.26.148.128) |
| 21:29.58 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:39.49 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.174) |
| 22:01.14 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-zryvkkmugwfgdsxv) |
| 22:22.35 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-pfscymtzmkjuxfcl) |
| 22:22.35 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 23:31.48 | snuff-work | mmm.. any1 have thoughts as to why pjsip.. might put garbage in the 2nd re-invite SDP header for the IP address? |
| 23:44.02 | snuff-work | (when using external_signalling_address) |
| 23:44.52 | file | nope |
| 23:46.12 | snuff-work | i've tried 3 times all with the same result.. garbage or nothing at all in the SDP for owner_address.. everything else in the general sip packet is fine |
| 23:56.53 | snuff-work | is it worth trying to turn on any more debug info? |
| 23:57.16 | snuff-work | i already have a core verbose 5 / debug 8 / pcap sessions |