| 00:12.25 | *** join/#asterisk-dev sh_smith_ (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 00:14.03 | *** join/#asterisk-dev seanbright_ (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 00:14.03 | *** mode/#asterisk-dev [+o seanbright_] by ChanServ |
| 00:20.12 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 00:20.12 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:24.36 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 00:24.36 | *** mode/#asterisk-dev [+o Qwell] by verne.freenode.net |
| 00:25.32 | *** join/#asterisk-dev dustinm (~dustinm@68.ip-149-56-14.net) |
| 02:04.39 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8021:3197:5489:fcf4:d13f) |
| 02:04.39 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:36.40 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8021:cd2:b20f:4353:bae8) |
| 03:36.41 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 06:44.53 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:46.59 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 06:53.59 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 06:54.00 | *** mode/#asterisk-dev [+o wdoekes] by ChanServ |
| 06:54.00 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:14.38 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:14.38 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:16.06 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.34) |
| 07:24.34 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 07:25.13 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 07:48.07 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:e532:1d6a:6d16:ce1a) |
| 10:56.00 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8021:9de8:9ac6:a318:c789) |
| 10:56.00 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 11:35.11 | tsearle | good morn'n y'all! |
| 11:36.10 | file | 404 People Not Found |
| 11:37.29 | tsearle | damn people! so unreliable! |
| 12:21.27 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8021:e8d1:4a35:1f58:b12b) |
| 12:21.27 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:50.43 | file | soon time for releases methinks |
| 12:58.52 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-lqbuazmdoysrirvq) |
| 12:58.52 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:33.57 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:e532:1d6a:6d16:ce1a) |
| 13:59.58 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 13:59.58 | *** mode/#asterisk-dev [+o DivideBy0] by ChanServ |
| 14:11.23 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-hsqcbonqygllbzcw) |
| 14:11.23 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:25.11 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-byyjjkqeefcrnkwr) |
| 14:25.11 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:40.21 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 14:48.41 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 15:15.38 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 15:15.38 | *** mode/#asterisk-dev [+o wdoekes] by ChanServ |
| 15:45.39 | *** join/#asterisk-dev danjenkins (danjenkins@gateway/shell/firrre/x-sdsrjjqeiemdqvxo) |
| 15:45.39 | *** mode/#asterisk-dev [+o danjenkins] by ChanServ |
| 16:03.58 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00c873929e162f958a.ipv6.abo.wanadoo.fr) |
| 16:04.34 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-iuyfyajjccoywtad) |
| 16:04.34 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 18:38.11 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-yhdycwamjzwpexfk) |
| 18:38.11 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 18:43.01 | rmudgett | gtjoseph: ping |
| 18:43.07 | gtjoseph | yep? |
| 18:43.10 | gtjoseph | how bad? |
| 18:44.05 | rmudgett | I gave a few paragraphs on the review. |
| 18:44.18 | gtjoseph | yeah i'm reading now. |
| 18:44.36 | rmudgett | I think the vector approach isn't going to actually work like I thought. |
| 18:44.57 | gtjoseph | why? |
| 18:45.03 | gtjoseph | it does actually work |
| 18:45.20 | gtjoseph | even across blind/blonde/attended transfers |
| 18:45.26 | gtjoseph | hold and unhold |
| 18:45.47 | gtjoseph | as well as changing from direct media to local media as the result of a transfer |
| 18:45.53 | gtjoseph | and vide versa |
| 18:46.00 | gtjoseph | s/vide/vice/ |
| 18:46.45 | rmudgett | suspend/unsuspend will cause unconstrained growth of the vector |
| 18:47.23 | rmudgett | When you unsuspend the vector is added to while suspend doesn't remove the previous vector entry. |
| 18:47.47 | gtjoseph | well, i can fix that |
| 18:48.05 | gtjoseph | remove n suspend |
| 18:49.47 | gtjoseph | or i can go back to bridge_channel->bridge_pvt :) |
| 18:50.18 | rmudgett | Course if you want to go in for a complete restructure you could use the native dahdi tech as an example. :) |
| 18:50.32 | rmudgett | Don't you mean bridge_channel->tech_pvt? |
| 18:51.16 | gtjoseph | depends. the description of bridge_pvt and tech_pvt bridge is push/pull, tech is join/leave |
| 18:51.26 | gtjoseph | not very clear |
| 18:51.31 | gtjoseph | tech_pvy I guess |
| 18:51.34 | gtjoseph | pvt |
| 18:51.43 | rmudgett | bridge_channel->bridge_pvt is for a bridge class |
| 18:51.50 | gtjoseph | ok |
| 18:52.03 | rmudgett | bridge_channel->tech_pvt is for the technology being used. |
| 18:53.03 | rmudgett | And yes I am thinking of going back to the bridge_channel->tech_pvt to hold the cached instances and the other glue values. |
| 18:53.16 | gtjoseph | ok, that's easy |
| 18:53.58 | rmudgett | It just won't be entirely for the frame hook's exclusive use anymore. |
| 18:54.14 | gtjoseph | the "extra" debug statements actually are valuable since turning verbose on generates a ton of unrelated stuff. by having the debugs, you can debug just this module |
| 18:54.35 | gtjoseph | no dev_mode = noop |
| 18:54.41 | rmudgett | So the frame hook attach/detach functions cannot create/destroy the bridge_channel->tech_pvt anymore. |
| 18:55.08 | gtjoseph | yeah |
| 18:56.01 | gtjoseph | but that's fine as long as the hook data is passed in to the attach |
| 18:56.12 | gtjoseph | and added to the channek_instance structire |
| 18:57.38 | gtjoseph | and channel_instance holds a ref to it |
| 18:57.52 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-pfzqltsfkunrzlpi) |
| 18:57.52 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 18:58.33 | rmudgett | channel_instance? |
| 18:59.12 | gtjoseph | the channel_instance_data structure that holds the glue and instances |
| 18:59.35 | gtjoseph | although.... |
| 19:00.05 | gtjoseph | i don't think we need to keep the hook data as the framehook will clean it up when it's done |
| 19:00.14 | rmudgett | The stored chan pointer isn't really needed. You should already have that pointer anyway. |
| 19:00.49 | gtjoseph | it was there mostly for debugging |
| 19:01.05 | gtjoseph | since it was in a vector |
| 19:01.13 | gtjoseph | i can remove it now |
| 19:01.54 | gtjoseph | don't need bridge there either |
| 19:01.57 | rmudgett | The hook data should be the tech_pvt. You would just be adding the rtp instances and other glue stuff to it. |
| 19:02.10 | rmudgett | Yeah. The bridge pointer was only used for a debug message. |
| 19:02.43 | gtjoseph | i'd like ot keep the structured separate. we don't need the hook data except in the hook callbacks and it's passed in there anyway |
| 19:03.07 | gtjoseph | and the framehook will free it when it's done |
| 19:03.12 | gtjoseph | or unref it |
| 19:04.12 | rmudgett | If the bridge_channel->tech_pvt is an ao2 object it can be given to the frame hook the same as now. It just isn't exclusively for the framehook. |
| 19:04.55 | rmudgett | Two fields are used by the framehook and the new/rest are for the bridge tech channel. |
| 19:05.21 | gtjoseph | i know. i just feel funny about combining them since they serve 2 completely different purposes |
| 19:05.39 | rmudgett | Not really. More like two sides of the same coin |
| 19:05.53 | gtjoseph | yeah, like us :) |
| 19:06.36 | rmudgett | The framehook is just extra data of the bridge_channel. |
| 19:07.33 | gtjoseph | I think you'll have to live with them separated :) |
| 19:08.11 | rmudgett | I'll have to see how you separate them then. |
| 19:30.07 | gtjoseph | rmudgett: dammit. we do need the hook id to detach it. |
| 19:30.15 | gtjoseph | ok, combined structure :) |
| 19:31.50 | rmudgett | gtjoseph: Well you could separate them. The current ao2 object for the frame hook. A new calloced struct that hold a pointer to the framehook ao2 object plus all the new stuff. |
| 19:32.43 | gtjoseph | you just sold past the close... and blew it. :) |
| 19:33.33 | rmudgett | There is an advantage having them separated in that the rtp instances get destroyed when the leave happens and not some time later when the framehook actually gets destroyed. |
| 19:34.54 | gtjoseph | you're making me crazy |
| 19:35.29 | rmudgett | :D |
| 20:02.46 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 20:02.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:08.07 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.174) |
| 20:21.45 | gtjoseph | rmudgett: back at ya. i'm not going to look at it any more until at least tomorrow though. |
| 21:01.16 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8021:4014:afe8:3b26:ecee) |
| 21:01.16 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |