| 00:20.03 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:20.03 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:10.20 | *** join/#asterisk-dev oej (~oej@h-205-12.A165.corp.bahnhof.se) |
| 06:10.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:46.31 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:51.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:4144:fa09:96ad:e925) |
| 06:52.46 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:56.24 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 06:56.24 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:04.25 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.34) |
| 07:08.38 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:31.04 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:4144:fa09:96ad:e925) |
| 08:16.48 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:49.47 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.38.80) |
| 11:24.13 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:69eb:9344:8423:7e60) |
| 11:47.27 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 12:34.49 | *** join/#asterisk-dev fblackburn (~fblackbur@modemcable094.94-70-69.static.videotron.ca) |
| 12:41.58 | *** part/#asterisk-dev fblackburn (~fblackbur@modemcable094.94-70-69.static.videotron.ca) |
| 12:49.40 | file | beep boop |
| 12:50.00 | gtjoseph | did you just join a bridge? |
| 12:50.10 | gtjoseph | or leave one |
| 12:50.59 | file | you may never know |
| 13:06.58 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 13:56.31 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-yevnssfyerubkdah) |
| 13:56.31 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 13:59.41 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:59.41 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:05.18 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-aidqzznnrcmnunne) |
| 14:05.18 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:09.29 | cresl1n | file: were you going to re-review https://gerrit.asterisk.org/#/c/5756/ |
| 14:09.34 | cresl1n | after pushing up the new version |
| 14:10.10 | cresl1n | Or is there something missing still |
| 14:10.44 | file | according to gtjoseph the test still fails under 14/master |
| 14:10.50 | cresl1n | osnap |
| 14:10.57 | cresl1n | That's not cool |
| 14:11.08 | cresl1n | I guess we've gotta figure out what to do about that |
| 14:11.29 | cresl1n | is that still true gtjoseph? |
| 14:11.42 | gtjoseph | i believe so but let me check again |
| 14:11.51 | cresl1n | I wonder why that would be |
| 14:13.22 | gtjoseph | i didn't investigate, just tested them |
| 14:13.33 | file | as scrum master I nominate gtjoseph to take a look |
| 14:13.38 | cresl1n | no biggy, totally understand |
| 14:13.38 | file | that is, as he IS scrum master |
| 14:13.53 | cresl1n | gtjoseph: would you be ok with that? |
| 14:14.00 | gtjoseph | yep |
| 14:14.12 | cresl1n | thanks for being willing to do that |
| 14:14.32 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-vtihlgvjzuhuetfn) |
| 14:14.32 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:14.56 | file | leedm777: I remember you... |
| 14:15.11 | leedm777 | waves |
| 14:18.36 | file | and for my next trick I nominate cresl1n to bake cupcakes |
| 14:18.45 | cresl1n | That's not gonna happen |
| 14:18.57 | file | it was worth a try |
| 14:19.14 | cresl1n | nominated file to bake muffins |
| 14:19.36 | file | 'tis a good thought |
| 14:19.38 | gtjoseph | with files in them? |
| 14:19.44 | cresl1n | Do you still like muffins? |
| 14:19.52 | file | I do I do |
| 14:20.08 | cresl1n | I always forget about the goodness of blueberry muffins |
| 14:20.16 | cresl1n | It's an underestimated breakfast foe |
| 14:20.33 | file | truth |
| 14:21.14 | gtjoseph | @dan_j: if you're around, can you take a look at your eyebeam reviews? |
| 15:05.28 | dan_j | Im just at a client. Ill be back in about 45min. |
| 15:32.28 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 15:32.28 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 15:38.47 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-bbzuglnbfilanatl) |
| 15:38.47 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:47.03 | *** join/#asterisk-dev dakudos (~dakudos@c-73-243-248-133.hsd1.co.comcast.net) |
| 16:01.49 | file | rmudgett: needless ao2_cleanup usage! |
| 16:07.15 | rmudgett | I've been thinking of a campaign lately to just deprecate ao2_ref(obj, -1) usage in favor of the simpler ao2_cleanup(obj). |
| 16:08.12 | rmudgett | You're less likely to confuse 1 with -1. |
| 16:10.03 | rmudgett | Though I don't think there has been a case where ao2_ref(obj, 1) was used when ao2_ref(obj, -1) was supposed to be. |
| 16:11.02 | rmudgett | Its more the ao2_ref(obj, -1) line is missing entirely. |
| 16:11.38 | coreyfarrell | rmudgett: doesn't seem likely it would cause confusion when coding in the first place, but separate calls for bump vs release would make it easier to read later on (or review in first place). |
| 16:15.41 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-xarknijoipojecxy) |
| 16:15.41 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:16.16 | rmudgett | That plus you don't have to worry about obj being NULL like you do with ao2_ref() |
| 16:16.58 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 16:17.35 | coreyfarrell | I've never liked the way NULL is handled in ao2_ref (for bump or release). would rather it just return an error code. |
| 16:20.48 | rmudgett | Well, returning an error code means you should be checking it. An error code in the case of bump or cleanup is a programming error since the object would have to be invalid. |
| 16:23.36 | coreyfarrell | yes but when ao2_ref(obj, 1) is called with obj==NULL, you either check the result or usually crash. |
| 16:27.26 | rmudgett | calling ao2_ref with a NULL object is a programming error. There is no check a return code. |
| 16:31.45 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 17:09.25 | kharwell | https://gerrit.asterisk.org/c/5821/ is failing due to tests that fail against older versions of asterisk because of patches made against the tests themselves and current Asterisk. |
| 17:09.37 | kharwell | I put a review up https://gerrit.asterisk.org/c/5847/ that bumps those test min version |
| 17:10.04 | kharwell | do we want to wait for that to go in and then regate the failing review? |
| 17:10.35 | gtjoseph | probably |
| 17:10.58 | kharwell | okay that's what I was thinking too. Sounds good |
| 17:58.58 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 18:35.47 | *** join/#asterisk-dev JunK-Y (~junky@pdpc/supporter/active/junk-y) |
| 18:42.13 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 18:42.13 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:18.26 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00912f41feb7f5fa3a.ipv6.abo.wanadoo.fr) |
| 19:48.01 | *** join/#asterisk-dev opticron (~opticron@75.76.59.35) |
| 19:48.01 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:10.53 | *** join/#asterisk-dev libardi (~libardi@179.159.11.133) |
| 20:23.55 | kharwell | file: https://gerrit.asterisk.org/c/5843 I think I am missing something. The change does not appear to be doing anything different than before? (from a ref inc/dec perspective) |
| 20:24.43 | file | it is different, take a look at the case where a datastore was already present |
| 20:24.45 | file | with and without the change |
| 20:25.53 | kharwell | okay yeah I see it now. I would blame gerrit's suppression of lines, but I had actually expanded them and still missed it. thanks! |
| 20:32.46 | gtjoseph | Ok so "Surrogate" channels? |
| 20:33.51 | rmudgett | What about them? |
| 20:33.59 | gtjoseph | they're leaking |
| 20:34.08 | gtjoseph | and i'm trying to track down the hole |
| 20:34.31 | gtjoseph | that's why those res_api tests are taking 45 seconds |
| 20:34.36 | gtjoseph | rest_api |
| 20:35.45 | rmudgett | It's probably not the "surrogate" channel that's actually leaking but the original channel that masqueraded into it. |
| 20:36.06 | gtjoseph | well the destructor is never called for Surrogate/yada |
| 20:36.07 | rmudgett | Since masquerade swaps the channel names. |
| 20:37.35 | rmudgett | Could it be that after the masquerade that rest_ari cannot find the channel because it has a new name? |
| 20:38.26 | gtjoseph | not sure. i'm trying to match up pointers |
| 20:51.40 | gtjoseph | yeah it's the original stasis channel that we put into the bridge |
| 20:52.59 | gtjoseph | it comes out of the testsuite app and goes into the bridge but somehow despite all the hangups, there's still a reference left over |
| 20:58.18 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-mfhmjqvtkvdzcmbz) |
| 20:58.18 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:06.08 | kharwell | Anyone else having this problem/notice this? In gerrit everytime I click on a link under "My" (old ui) or "Your" (new ui) it opens the link in a new tab |
| 21:06.42 | gtjoseph | haven't seen that one |
| 21:09.06 | kharwell | the browser is treating it like a new window is being opened |
| 21:09.17 | kharwell | aah well |
| 21:09.35 | seanbright | maybe you have a stuck key? |
| 21:09.51 | seanbright | ctrl mayhaps |
| 21:10.41 | kharwell | don't appear to. And when I click "open" for instance it creates the view in the current tab |
| 21:12.10 | seanbright | can't reproduce |
| 21:12.15 | seanbright | closed as: won't fix |
| 21:12.16 | seanbright | :D |
| 21:13.30 | kharwell | will definitely blame seanbright now |
| 21:30.20 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-sodeyfemydjgsdje) |
| 21:30.20 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 21:40.04 | cresl1n | ok, about to leave everybody |
| 21:40.06 | cresl1n | have a great day |
| 21:44.02 | kharwell | Another gerrit oddity https://gerrit.asterisk.org/c/5841/ won't load for me under the new ui |
| 21:52.11 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-aidqzznnrcmnunne) |
| 23:08.08 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |