| 00:25.06 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:25.06 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 01:11.51 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 01:11.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:47.09 | *** join/#asterisk-dev Nate15329 (~Nate15329@99-72-98-70.lightspeed.oshkwi.sbcglobal.net) |
| 01:55.19 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8065:d943:daea:b9f0:3) |
| 01:55.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:41.07 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 03:02.18 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8065:bd08:499c:cbb2:40ba) |
| 03:02.18 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:06.17 | *** part/#asterisk-dev Nate15329 (~Nate15329@99-72-98-70.lightspeed.oshkwi.sbcglobal.net) |
| 03:35.43 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 04:04.12 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8065:21a2:9463:b5ce:4241) |
| 04:04.12 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:38.47 | *** join/#asterisk-dev dustinm (~dustinm@68.ip-149-56-14.net) |
| 04:56.19 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8065:51e1:691b:d630:5123) |
| 04:56.20 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 06:01.06 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:48.20 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:56.20 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:05.24 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:19.02 | *** join/#asterisk-dev tzafrir (~tzafrir@81.218.177.19) |
| 07:19.02 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:19.23 | wdoekes | tzafrir: how about: # if [ -e /usr/lib64/libc.so ] || [ -e /usr/lib64/libc.so.? ]; then echo we want lib64; fi |
| 07:19.44 | wdoekes | good morning btw |
| 07:19.49 | *** join/#asterisk-dev jkroon (~jkroon@dustpuppy.is.co.za) |
| 07:19.55 | tsearle | wow, people up early in this room today :-) |
| 07:20.12 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::6b2) |
| 07:20.21 | wdoekes | depends on your definition of early or on my timezone |
| 07:20.45 | tsearle | so you are up really late then, heh |
| 07:20.58 | tzafrir | hi |
| 07:21.11 | tsearle | greetings tzafrir! :-) |
| 07:21.46 | tzafrir | Will this work with older redhats? That had a separate /lib? Can you check it with Centos6? |
| 07:22.27 | wdoekes | I created ASTERISK-26909 for it. I have all flavors of ubuntu/debian laying around but only very few other systems |
| 07:23.40 | tzafrir | OK. I see they do have /usr/lib64/libc.so |
| 07:24.44 | tzafrir | tsearle, Hello |
| 07:52.34 | *** join/#asterisk-dev oej (~oej@c-31-209-60-196.cust.bredband2.com) |
| 07:52.34 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:12.14 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 10:56.17 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 11:05.33 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 11:07.26 | *** join/#asterisk-dev fblackburn (~fblackbur@qubcpq0957w-lp130-02-70-53-163-58.dsl.bell.ca) |
| 11:10.09 | *** join/#asterisk-dev oej (~oej@host-95-199-7-124.mobileonline.telia.com) |
| 11:10.09 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:00.55 | *** join/#asterisk-dev Guest70 (~textual@r186-52-203-239.dialup.adsl.anteldata.net.uy) |
| 12:02.02 | *** join/#asterisk-dev Guest70 (~textual@r186-52-203-239.dialup.adsl.anteldata.net.uy) |
| 12:02.47 | *** join/#asterisk-dev Guest70 (~textual@r186-52-203-239.dialup.adsl.anteldata.net.uy) |
| 12:04.36 | *** join/#asterisk-dev scgm11 (~scgm11@r186-52-203-239.dialup.adsl.anteldata.net.uy) |
| 12:15.10 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 12:20.08 | coreyfarrell | wdoekes / tzafrir: sorry to start trouble but what if someone is compiling 32bit asterisk on a multilib system? |
| 12:21.39 | tzafrir | This is already a secondary test to the list of 64bit architectures, right? |
| 12:22.07 | tzafrir | So it should not be a problem? |
| 12:24.46 | coreyfarrell | ah I see that now.. so instead of checking for [ -d /usr/lib64 ] we check for [ -f /usr/lib64/libc.so ] ? |
| 12:26.36 | coreyfarrell | hmm I have 1 remaining centos6 system. it does not have /usr/lib64/libc.so. it's actually found in /lib64/libc.so.6 |
| 12:28.38 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 12:31.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 12:50.11 | *** join/#asterisk-dev scgm11 (~scgm11@r186-50-165-38.dialup.adsl.anteldata.net.uy) |
| 13:03.03 | stefan27 | coreyfarrell, didn't it say if [ -e /usr/lib64/libc.so ] || [ -e /usr/lib64/libc.so.? ]; |
| 13:03.21 | stefan27 | just based on what I read earlier, im not involved |
| 13:04.36 | coreyfarrell | stefan27: no the current tests are: test -d "${exec_prefix}/lib64" || test -d "${ac_default_prefix}/lib64" |
| 13:06.04 | coreyfarrell | wdoekes is suggesting a check for libc.so instead but centos 6 doesn't have any file named 'libc.so'. |
| 13:06.07 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 13:07.33 | stefan27 | Nor does my fedora, but I was just echoing [09:18] <@wdoekes> tzafrir: how about: # if [ -e /usr/lib64/libc.so ] || [ -e /usr/lib64/libc.so.? ]; then echo we want lib64; fi |
| 13:09.50 | coreyfarrell | ahh I missed the "libc.so.?" before. but still would not be found because on centos 6 /lib64 and /usr/lib64 are separate directories, and libc is installed to /lib64. |
| 13:15.43 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-epihzvvixmxuesii) |
| 13:15.43 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:15.57 | seanbright | is there any elegant way to share code across modules that doesn't involve creating a res_* module? |
| 13:16.14 | seanbright | res_config_pgsql, cdr_pgsql, and cel_pgsql duplicate so much code, it would be nice to consolidate |
| 13:17.02 | file | not... really |
| 13:17.09 | seanbright | lamesies |
| 13:18.03 | seanbright | and i assume introducing a new res module for this purpose wouldn't fly for 13 or 14 |
| 13:19.00 | file | probably not |
| 13:19.13 | seanbright | also lamesies |
| 13:19.17 | seanbright | but <3 |
| 13:19.23 | seanbright | happy thursday, mofo. |
| 13:19.53 | file | greetings |
| 13:22.16 | wdoekes | so much for simple solutions... scoot over file, so I can rock in that corner |
| 13:23.22 | file | all actions have consequences |
| 13:23.41 | file | the trick is to find the action that results in the least number of consequences |
| 13:23.57 | file | sometimes the correct choice is not to act |
| 13:27.08 | file | can I get eyes on the test change I did? |
| 13:29.05 | file | merci |
| 13:30.05 | seanbright | eyes applied |
| 13:30.14 | file | directly to the forehead? |
| 13:30.20 | seanbright | aye |
| 13:30.36 | file | very good |
| 13:33.21 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 13:33.21 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 13:42.29 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:42.29 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:42.58 | cresl1n | waves |
| 13:43.12 | file | hola |
| 13:43.16 | cresl1n | file!!!! |
| 13:46.48 | gtjoseph | coreyfarrell, wdoekes, tzafrir, stefan27: based on your discussion, is the description in https://issues.asterisk.org/jira/browse/ASTERISK-26909 still the way you want it? |
| 13:49.54 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-ykyhdufddcxvogoy) |
| 13:49.54 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:01.00 | tzafrir | In my test Centos6 system I do have /usr/lib64/libc.so (not libc.so.6, though) |
| 14:01.10 | tzafrir | So the suggested patch still works |
| 14:01.55 | tzafrir | coreyfarrell, stefan27, what about your systems? |
| 14:03.41 | *** join/#asterisk-dev ggo (~quassel@37.19.10.33) |
| 14:04.14 | seanbright | if i was writing a new module today, what configuration mechanism should i use? |
| 14:04.20 | seanbright | sorcery? |
| 14:04.22 | coreyfarrell | tzafrir: my Centos6 system does not have any file named "libc.so" or any libc files in /usr/lib64, only /lib64/libc.so.6 and /lib64/libc-2.12.so. |
| 14:04.49 | tzafrir | coreyfarrell, does it have glibc-devel installed? |
| 14:05.11 | gtjoseph | seanbright: sorcery would be preferred |
| 14:05.14 | coreyfarrell | ahh.. probably not it's a production system |
| 14:05.31 | seanbright | gtjoseph: roger dodger |
| 14:06.51 | coreyfarrell | gtjoseph / file: what was the reason https://gerrit.asterisk.org/5042 had to be reverted? |
| 14:07.09 | file | DESTDIR. |
| 14:08.44 | coreyfarrell | file: so if that change had just run ldconfig when DESTDIR was blank, would it be sufficient without the current changes to configure.ac? |
| 14:09.11 | file | I have not looked at the current stuff, so I can't comment. |
| 14:09.29 | gtjoseph | it'd fail if you weren't root |
| 14:09.40 | seanbright | can't we just pass an absolute path to dlopen and be done with it? |
| 14:09.47 | seanbright | or am i an idiot? |
| 14:09.48 | seanbright | or both? |
| 14:09.55 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-tebiyocudssnlqys) |
| 14:09.55 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:10.10 | gtjoseph | the problem is gerring the files in the correct place |
| 14:10.21 | gtjoseph | getting |
| 14:11.16 | gtjoseph | we don't want to put 64 bit libraries in a 32 bit directory |
| 14:12.08 | coreyfarrell | gtjoseph: so if we had https://gerrit.asterisk.org/#/c/5344/5/Makefile and revert the changes made to configure.ac, the build/install would work? it would just continue to put lib files where config.site or --libdir tell it to? |
| 14:12.12 | gtjoseph | coreyfarrell: when you guys have an agreed upon approach, a summary on the -dev mailing list would be good |
| 14:12.42 | gtjoseph | looks |
| 14:12.48 | tzafrir | seanbright, no, but you could upgrade to openssl 1.1 and avoid the need for that library. |
| 14:13.14 | gtjoseph | it's also libasteriskpj and where to put the asterisk modules directory |
| 14:13.50 | tzafrir | (asterisk modules are, indeed, dlopen-ed) |
| 14:14.02 | gtjoseph | yes but we have to put them somewhere |
| 14:14.04 | file | stares at the wall |
| 14:14.15 | gtjoseph | unless we put them somewhere neutral |
| 14:14.35 | seanbright | libexec? |
| 14:14.45 | gtjoseph | coreyfarrell: that means that the default centos install will be incorrect. |
| 14:15.04 | seanbright | nevermind, those are for executables |
| 14:15.07 | seanbright | butts out |
| 14:15.14 | gtjoseph | libexec is a possibility |
| 14:15.31 | gtjoseph | a few packages put stuff there |
| 14:15.49 | gtjoseph | gcc and sudo are 2 |
| 14:16.03 | file | erm |
| 14:16.26 | coreyfarrell | gtjoseph: isn't that how it's always been? if you don't use --libdir on centos the libs go in ${prefix}/lib. what other project tries to "fix" the OS like this? |
| 14:16.26 | gtjoseph | a few oddballs also put them in /usr/share |
| 14:17.43 | gtjoseph | well, we can leave it default but we're back to an issue where if you forget, you;ve got them in 2 places |
| 14:19.55 | gtjoseph | as long as all of you agree on the approach and we're not being grossly stupid, i'm ok. |
| 14:20.53 | coreyfarrell | gtjoseph: you are talking about https://gerrit.asterisk.org/#/c/5095/ ? |
| 14:20.56 | gtjoseph | there are othe rchanges that will probably have to be reverted as well though |
| 14:21.07 | gtjoseph | yes |
| 14:22.22 | coreyfarrell | yeah those seem fine.. I was mostly talking about reverting the configure.ac / configure changes and just let autoconf or --libdir tell us where to put libs. |
| 14:23.11 | coreyfarrell | tzafrir: what is your opinion on this? |
| 14:26.39 | tzafrir | As I wrote yesterday: this should work perfectly, |
| 14:26.56 | tzafrir | except maybe for the case of upgrading |
| 14:27.41 | tzafrir | As /usr/lib is in the default load path of centos, even with multilib. |
| 14:29.11 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 14:29.57 | *** join/#asterisk-dev tuxian_ (~tuxian@igilmour.plus.com) |
| 14:45.45 | scgm11 | hello, I've used the branch ASTERISK-26835 in production and was worse |
| 14:45.52 | scgm11 | seems a deadlock occured |
| 14:46.17 | scgm11 | had to go back to the last version where the dtls timeout crash occurs |
| 14:46.47 | cresl1n | scgm11: I'd post that on the issue involved. Doesn't look like rmudgett is in yet |
| 14:47.02 | cresl1n | He'll probably be here in the next 30 min or so |
| 14:47.05 | scgm11 | ok thanks |
| 14:47.11 | file | yeah, I don't think just throwing locking into everything is going to end... well... |
| 14:48.27 | file | elaborates on his thoughts in the review |
| 14:49.34 | cresl1n | scgm11: he probably still has a few kinks in the patch |
| 14:49.51 | cresl1n | it's a pretty significant change from a locking perspective |
| 14:50.10 | scgm11 | yes, he did comment yesterday and in gerrit there are comments about some locking |
| 14:50.19 | scgm11 | issues |
| 14:50.24 | file | cresl1n: yeah... |
| 14:50.38 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-qwawvrmfeyfudxce) |
| 14:50.38 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:50.56 | scgm11 | Im open to help on this and try again when he changes the locking mechanism |
| 14:51.03 | cresl1n | cool |
| 14:51.05 | cresl1n | that's good to know |
| 14:52.50 | cresl1n | scgm11 if you could have grabed a core when it deadlocks that would've helped rmudgett I think |
| 14:53.20 | cresl1n | as of now though, he's got to just guess |
| 14:54.17 | scgm11 | yes but I forgot to compile it with the options core show locks and dont optimize |
| 14:54.22 | scgm11 | but for a next patch I will |
| 14:54.27 | cresl1n | Gotcha |
| 14:54.49 | cresl1n | the other thing you can do is use gdb to grab a core when it's locked up, while it's still live |
| 14:55.04 | scgm11 | how can I dump it ? |
| 14:55.39 | cresl1n | attach to it with gdb |
| 14:56.09 | cresl1n | then if I remember right you just use the `generate-core-file filename.core` at the gdb command line |
| 14:56.11 | gtjoseph | <PROTECTED> |
| 14:56.16 | cresl1n | that works better :-) |
| 14:56.22 | cresl1n | okies, gtg, standup |
| 14:56.30 | cresl1n | be back in 20 min or so |
| 14:57.51 | scgm11 | excelent! |
| 14:58.34 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 15:02.26 | coreyfarrell | anyone have a minute to take a look latest comments on https://issues.asterisk.org/jira/browse/ASTERISK-26639 ? I've posted a simple patch to fix the issue, not sure if it's acceptable as it's technically an ABI change. |
| 15:09.18 | seanbright | ok... something is wrong with me |
| 15:09.25 | seanbright | where is 'struct ast_cel' defined in the code base? |
| 15:11.42 | seanbright | or 'ast_cel_alloc' for that matter |
| 15:11.48 | coreyfarrell | seanbright: doesn't look like it is. also ast_cel_alloc / ast_cel_destroy don't actually exist except in the header. |
| 15:11.48 | seanbright | is all of this dead code mayhaps? |
| 15:11.57 | seanbright | coreyfarrell: well that explains it |
| 15:11.58 | seanbright | thanks |
| 15:22.07 | coreyfarrell | seanbright: https://gerrit.asterisk.org/5368 |
| 15:28.05 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-bltmxxcrimaikzij) |
| 15:28.05 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 15:28.12 | seanbright | coreyfarrell: actually, the reason i was in that file in the first place was because it uses 'struct json' but doesn't include json.h |
| 15:28.20 | seanbright | maybe piggyback that into your review? |
| 15:28.25 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-phxmgcgrogzafjjn) |
| 15:28.25 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:28.47 | seanbright | well look what the cat dragged in |
| 15:31.41 | rmudgett | :) |
| 15:31.49 | seanbright | MORNING |
| 15:31.54 | seanbright | morning, rather |
| 15:31.55 | coreyfarrell | seanbright: do we want to include json.h or just add 'struct ast_json;' forward declaration since that's all cel.h really needs? |
| 15:31.56 | file | afternoon |
| 15:32.14 | seanbright | coreyfarrell: i don't have a preference. |
| 15:32.27 | seanbright | whichever allows me to include cel.h and not have to include json.n |
| 15:32.29 | seanbright | .h* |
| 15:32.42 | gtjoseph | coreyfarrell, tzafrir: we'd like to cut the new RCs tomorrow morning at the latest so if we can get an agreement on the libdir approach before 1730Z today that'd help. |
| 15:32.45 | *** join/#asterisk-dev jkroon (~jkroon@197.96.224.13) |
| 15:33.24 | gtjoseph | that's 2 hours from now |
| 15:34.30 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:34.30 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:35.51 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 15:50.13 | rmudgett | seanbright: You must not have been awake when you asked that question on the res_xmpp deadlock review. |
| 15:51.21 | rmudgett | Either that or I didn't understand what you were trying to ask about. |
| 15:58.25 | scgm11 | hi @rmudgett I´ve testes the patch and seems to deadlock I comment your issue, Im open to test other patch (and do thing right this time compile with the dont optimize and debug threads so we can get core show locks) |
| 15:58.33 | scgm11 | let me know if I can be of help |
| 15:59.11 | rmudgett | I did say I was working on fixing a deadlock with that patch. I should have a new version up today. |
| 15:59.26 | scgm11 | yes yes I know |
| 15:59.38 | scgm11 | but Im confirming :) |
| 16:00.26 | scgm11 | just let me know and I´l try the patch again for tomorrow and get detailed info in case something goes wrong |
| 16:03.56 | *** join/#asterisk-dev dakudos (~dakudos@c-73-243-248-133.hsd1.co.comcast.net) |
| 16:11.20 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-cxtmktcnybxkqskj) |
| 16:11.20 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:12.28 | rmudgett | Why hasn't ASTERISK-26896 closed? |
| 16:12.39 | rmudgett | Is it because it is in triage state? |
| 16:13.00 | file | yes |
| 16:13.54 | file | Triage->Closed and (Open->Closed or In Progress->Closed) are separate transitions |
| 16:23.19 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 16:30.13 | seanbright | rmudgett: i was awake, i'm just maybe not the sharpest tool in the shed |
| 16:30.59 | seanbright | rmudgett: when you say "Nothing happens" what do you mean exactly? the RAII_VARs fail? |
| 16:31.13 | coreyfarrell | gtjoseph: I think tzafrir agreed with me that we should just let libdir be set by config.site or --libdir, that we should not mess with it. I can update the current reviews if you'd like? |
| 16:31.34 | gtjoseph | i can do it. did you see his note about upgrade? |
| 16:32.17 | gtjoseph | about 10:26 your time |
| 16:32.28 | rmudgett | seanbright: After ao2_global_obj_release() there is nothing held by the global object so ao2_global_obj_ref() returns NULL. |
| 16:33.03 | coreyfarrell | yes, but isn't the configure.ac change new to current RC's (never been in a final release)? |
| 16:33.15 | gtjoseph | correct |
| 16:33.32 | gtjoseph | i just wanted to make sure you saw it |
| 16:35.07 | seanbright | rmudgett: ok. will give it a whirl. |
| 16:36.34 | coreyfarrell | if the upgrade issue is only a concern when upgrading from the current RC I don't think that's a big concern? plus didn't you put something in the Makefile to detect asterisk libs in the other path? |
| 16:36.43 | gtjoseph | yes |
| 16:36.54 | gtjoseph | and that will stay |
| 16:36.59 | gtjoseph | i think |
| 16:37.40 | coreyfarrell | oh does your wrong-lib detection work both ways? IE if I install to /usr/lib will it complain about things in /usr/lib64? |
| 16:37.56 | gtjoseph | i'm re-looking now |
| 16:39.05 | gtjoseph | no it won't |
| 16:39.46 | gtjoseph | it only checks that if lib64 is in astlibdir that there are no libs in lib |
| 16:40.11 | gtjoseph | so it should be "safe" |
| 16:40.23 | gtjoseph | i.e it doesn't test for the existence of lib64 |
| 16:40.35 | gtjoseph | just that it's in astlibdir |
| 16:41.09 | gtjoseph | i suppose i can make it check the reverse |
| 16:45.28 | coreyfarrell | gtjoseph: up to you. the main point of the reverse check would be to warn people upgrading from current rc1, and even then only when they did not configure with --libdir. |
| 16:46.04 | gtjoseph | well it's also to warn anyone who did it with libdir then subsequently didn't or the reverse |
| 16:46.23 | gtjoseph | so they stay consistent |
| 16:50.40 | rmudgett | Crap. The "cel_pgsql.c: Fix buffer overflow calling libpq" patch merged in the 13.15.0-rc branch. |
| 16:51.28 | file | where... |
| 16:51.29 | rmudgett | How do we get the 13.15.0-rc tag and the earlier 13.12.0 tag removed? |
| 16:51.34 | file | what? |
| 16:52.05 | file | be more coherent. |
| 16:52.22 | rmudgett | That cel_pgsql.c patch also merged the 13.15.0-rc branch |
| 16:52.29 | rmudgett | into the 13 branch |
| 16:52.49 | file | um |
| 16:53.01 | gtjoseph | there is no 13.15-rc branch |
| 16:53.13 | coreyfarrell | seanbright: I'm thinking 'struct ast_json;' should just go into asterisk.h near the other forward struct's. it's used by a bunch of headers that don't include json.h. will do a separate commit for that though. |
| 16:53.17 | gtjoseph | or 13.15.0-rc branch |
| 16:53.18 | rmudgett | 13.15 branch with the 13.15.0-rc1 tag |
| 16:53.55 | rmudgett | If you now run a build from the 13 branch it now says it is version 13.15.0-rc1 |
| 16:54.26 | file | I'm not quite sure why it did that or how |
| 16:54.41 | seanbright | coreyfarrell: kk |
| 16:55.25 | rmudgett | The review poster made the patch against the 13.15 branch. Somehow when the patch was merged to 13 it dragged along the 13.15 branch. |
| 16:55.45 | file | how mildly interesting |
| 16:56.16 | rmudgett | Now the 13 branch has the changelog and release summary files |
| 16:57.03 | seanbright | yeesh |
| 16:57.09 | seanbright | i blame myself |
| 16:58.16 | gtjoseph | i'm not cleaning THAT up :) |
| 16:59.04 | seanbright | git reset --hard HEAD~1 |
| 16:59.13 | seanbright | when in doubt, pass the --hard flag |
| 16:59.18 | file | seanbright: this is why you can't have nice things |
| 16:59.19 | seanbright | it's more destructive that way |
| 17:00.17 | file | best we can probably sanely do is a revert |
| 17:00.23 | file | to clean up the tree |
| 17:01.59 | file | which there is now a review to do |
| 17:04.27 | rmudgett | I suppose we'll need to be more careful about new committers when they appear to be posting a patch made off of a release branch. |
| 17:04.49 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 17:06.38 | seanbright | i was so tempted to -1 that |
| 17:07.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00e53857e2db0b711a.ipv6.abo.wanadoo.fr) |
| 17:08.51 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 17:09.47 | gtjoseph | i think we need to force that revert through or it's going to get bad if anyone else submits a review off of current 13 or rebases an existing review |
| 17:10.13 | gtjoseph | file: ^^ |
| 17:10.27 | file | you can, I don't think it'll cause that much of a mess though :P |
| 17:10.30 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-meyqshozbrceszux) |
| 17:10.30 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:10.45 | gtjoseph | ok, i'll blame you then :) |
| 17:12.40 | rmudgett | Now the 13 branch revision will be relative to the 13.15.0-rc1 tag instead of the 13.12.0 tag. :) |
| 17:16.05 | file | I did it |
| 17:18.00 | rmudgett | What did you do ray? |
| 17:18.36 | file | Classified. |
| 17:20.51 | rmudgett | I wonder what this version will do to the testsuite version parsing. |
| 17:21.51 | seanbright | ast_log(LOG_ERROR, "Failed to open SIP sorcery failed to open\n"); |
| 17:22.00 | seanbright | ... i think something failed to open |
| 17:22.05 | rmudgett | Asterisk GIT-13-13.15.0-rc1-34-g1d1309b built by... |
| 17:22.17 | file | we've been fine with 13.12.whatever |
| 17:22.39 | file | seanbright: what did it fail to do? |
| 17:22.55 | rmudgett | Apparently open a file. :D |
| 17:28.15 | coreyfarrell | seanbright: just in case you don't see gerrit comments without the -1, I commented on https://gerrit.asterisk.org/5361 |
| 17:29.31 | seanbright | coreyfarrell: i see it. i'll take a look |
| 17:31.31 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-ohjvdeeghyrnzboo) |
| 17:31.31 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:33.14 | gtjoseph | coreyfarrell: reviews for libdir are back up |
| 17:54.40 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 17:54.40 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 17:57.16 | coreyfarrell | seanbright: about master, I think you can just remove the '__ao2_global_obj_release' function entirely, nothing uses it directly (still needed in 13/14 for ABI reasons) |
| 17:59.03 | coreyfarrell | gtjoseph: looks good I want to do some testing installing to /usr/lib then /usr/lib64 then /usr/lib again, make sure it gives no surprises. |
| 17:59.40 | seanbright | coreyfarrell: done |
| 17:59.43 | gtjoseph | cool. I did the same |
| 18:00.11 | coreyfarrell | gtjoseph: I should be able to +1 in about an hour, have to step away from computer for a bit. |
| 18:00.25 | gtjoseph | no problem |
| 18:29.05 | file | gtjoseph: putnopvut and I chatted - he's fine with my changes, so he's going to rebase his merging work on them once they go in |
| 18:29.13 | gtjoseph | kk |
| 18:29.37 | file | there's still the sticky part of reusing RTP instances, but he's going to work that out as part of merging |
| 18:30.26 | gtjoseph | ok, makes sense |
| 18:30.49 | file | he's also promised to get us all ice cream |
| 18:30.56 | putnopvut | Only if it's chocolate |
| 18:31.17 | putnopvut | Vanilla makes my car not start. |
| 18:31.35 | gtjoseph | I'll take chocolate |
| 18:31.43 | putnopvut | http://www.kepner-tregoe.com/blog/help-my-car-is-allergic-to-vanilla-ice-cream-a-study-in-problem-solving-part-ii/ |
| 18:31.57 | putnopvut | In case the vanilla ice cream story hadn't made it through to any of you |
| 18:32.41 | putnopvut | Ugh, that's actually a pretty shitty link to the story, but meh |
| 18:35.22 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 18:35.22 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 18:49.05 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 18:49.05 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 18:50.57 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-vmwdqojzqrjqzicv) |
| 18:50.57 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:11.11 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:11.11 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 19:17.04 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-kfftuubyzfmdjwcw) |
| 19:17.04 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 20:10.09 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 20:10.09 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:15.54 | *** join/#asterisk-dev Dovid (~dovid@ool-3f8fef18.dyn.optonline.net) |
| 20:23.17 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 20:23.17 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 20:41.33 | rmudgett | scgm11: New patch up on gerrit. Still at https://gerrit.asterisk.org/#/c/5341/ |
| 20:41.44 | scgm11 | great! |
| 20:41.57 | scgm11 | I will try to put it and have feedback for tomorrow |
| 20:42.05 | rmudgett | thanks |
| 20:52.05 | *** join/#asterisk-dev scgm11__ (~scgm11@r186-52-124-188.dialup.adsl.anteldata.net.uy) |
| 21:53.06 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 21:57.51 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 22:11.01 | gtjoseph | coreyfarrell: if you're still around, the libdir reviews are back up again. |
| 22:27.06 | coreyfarrell | gtjoseph: thanks, I'm a bit busy at the moment but I'll be able to retest tonight. |
| 22:27.17 | gtjoseph | cool, thanks |
| 22:29.47 | coreyfarrell | weird, only the review for 13 showed up on the mailing list |
| 22:30.13 | gtjoseph | hmmm, yeah |
| 22:30.28 | gtjoseph | not sure why |
| 22:31.06 | file | I blame Google. |
| 22:31.12 | file | also: SES-10. |
| 22:33.43 | coreyfarrell | I blame Java. |
| 22:34.31 | rmudgett | Everybody blames Java |
| 22:39.51 | rmudgett | Should blame file for DOSing the internets |
| 22:40.01 | file | computer says no |
| 22:41.20 | seanbright | i want to work at spacex |
| 22:41.44 | file | seanbright: get on that |
| 22:42.18 | seanbright | i can't even get a fucking postgresql patch right |
| 22:42.33 | seanbright | i don't think you want me to help write flight control software |
| 22:42.35 | seanbright | :D |
| 22:43.02 | rmudgett | Need space? Come to spacex and get spaced. |
| 22:49.13 | seanbright | rmudgett: i want another review before you leave for the day |
| 22:49.15 | seanbright | so hop to |
| 22:49.18 | seanbright | :P |
| 22:54.23 | seanbright | i like that spacex's visual trajectory animation looks like kerbal space program |
| 22:58.11 | coreyfarrell | gtjoseph: looks good to me, tested fine. |
| 22:58.17 | gtjoseph | cool |
| 22:58.20 | gtjoseph | thanks! |
| 22:58.35 | gtjoseph | i'm going to cut the RCs first thing in the AM then |
| 23:25.58 | rmudgett | seanbright: Hopped over to +1 :) |