| 00:22.39 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:22.39 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:46.41 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 00:46.42 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 05:02.49 | *** join/#asterisk-dev dakudos (~dakudos@c-73-243-248-133.hsd1.co.comcast.net) |
| 05:59.35 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:44.23 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:44.25 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.44) |
| 06:50.39 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 06:50.39 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:59.47 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:05.06 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:21.33 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::141c) |
| 07:28.58 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::379) |
| 08:00.02 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:11.12 | *** join/#asterisk-dev CELYA_ (~Thunderbi@glo44-1-82-67-130-221.fbx.proxad.net) |
| 08:24.45 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 08:51.34 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 08:53.23 | *** join/#asterisk-dev ggo (~quassel@37.19.10.33) |
| 09:08.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 09:21.07 | *** join/#asterisk-dev Dovid (~dovid@static-173-63-105-210.nwrknj.fios.verizon.net) |
| 11:11.20 | *** join/#asterisk-dev fblackburn (~fblackbur@qubcpq0957w-lp130-02-70-53-160-248.dsl.bell.ca) |
| 11:28.49 | *** join/#asterisk-dev tuxian (~tuxian@194.12.3.78) |
| 11:29.15 | tsearle | good afternoon all |
| 11:32.48 | *** part/#asterisk-dev fblackburn (~fblackbur@qubcpq0957w-lp130-02-70-53-160-248.dsl.bell.ca) |
| 11:33.53 | *** join/#asterisk-dev JensV (~JensV@85.195.255.242) |
| 11:37.07 | file | moo |
| 11:53.49 | tsearle | oom |
| 11:54.50 | tsearle | I have a question ref, rtp_timeout |
| 11:55.05 | tsearle | currently if it occurs it's release cause 44 channel unavailable |
| 11:55.37 | tsearle | but this release cause can happen for other reasons, (e.g. malformed uri in dial, or certain 6xx responses) |
| 11:56.12 | tsearle | would it be possible to set an additional channel variable giving a more precise reason in this case? |
| 11:57.21 | file | it's code, so of course it could be changed to do so |
| 11:58.14 | file | :D |
| 11:58.27 | tsearle | indeed |
| 11:59.07 | tsearle | but the point of me talking with you guys up front is to get your input so that any resulting patch has a better chance of getting accepted for merging :-) |
| 11:59.19 | file | I don't have an opinion either way really |
| 11:59.25 | file | and it's early, so not many people are here |
| 11:59.43 | tsearle | yeah, yeah, we're on the wrong side of the planet :-P |
| 12:33.08 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 12:45.21 | seanbright | tsearle: would those 'other reasons' occur with an already active dialog? |
| 12:51.52 | seanbright | tsearle: plus, we already patched pjsip for you |
| 12:52.16 | tsearle | well I'm grepping the code now to see if there are other cases |
| 12:52.28 | seanbright | gotcha |
| 12:52.38 | tsearle | but I don't see any other case |
| 12:54.16 | tsearle | ok, nvm |
| 12:54.33 | tsearle | seems this is guaranteed to only be caused by no audio |
| 12:57.20 | file | yay |
| 12:58.07 | tsearle | makes life easier that way |
| 13:10.23 | seanbright | so i was looking at a res_musiconhold bug on jira the other day and was wondering |
| 13:10.38 | seanbright | why does moh_scan_files chdir() into the specified moh directory? |
| 13:10.45 | seanbright | i can't think of any reason we actually need to do that |
| 13:11.17 | seanbright | 'git blame' wasn't helpful because it was part of a much larger patch |
| 13:23.19 | file | I... don't know |
| 13:24.26 | tzafrir | seanbright, it supports relative paths |
| 13:31.57 | seanbright | tzafrir: ok... but it's relative to the lib dir, so we could just build the absolute path |
| 13:32.38 | tzafrir | (moh dir is relative to the data dir) |
| 13:34.32 | seanbright | tzafrir: ok... but it's relative to the data dir, so we could just build the absolute path |
| 13:36.47 | file | I do like all the removal of stuff for embedded |
| 13:45.06 | seanbright | tzafrir: not to mention the first thing we do is build an absolute path |
| 13:45.17 | tzafrir | right |
| 13:47.04 | seanbright | ok, i'm going to remove it |
| 13:47.08 | seanbright | because i'm CRAZY |
| 13:51.43 | tzafrir | I guess it was inspired by the other chdir there (which is just before the exec of the mp3 program, after the fork) |
| 13:55.23 | seanbright | right. in that case we don't care because it's not us anymore. |
| 13:55.54 | seanbright | in ASTERISK-23996, the user can't find his core files because they are being written to a read-only directory (the MoH dir) |
| 13:57.16 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:57.16 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:58.43 | cresl1n | waves |
| 14:01.16 | seanbright | cresl1n: how are you? |
| 14:01.21 | seanbright | good weekend? |
| 14:02.40 | cresl1n | it was excellent |
| 14:02.48 | cresl1n | how are you doing Mr. Bright? |
| 14:02.54 | seanbright | not too bad. |
| 14:03.04 | seanbright | couples wedding shower yesterday |
| 14:03.08 | seanbright | so today i am dragging ass |
| 14:03.14 | seanbright | but i'll survive |
| 14:03.21 | cresl1n | oh wow |
| 14:03.33 | cresl1n | yeah, I've heard about this phenomenon - the couples wedding shower |
| 14:03.38 | cresl1n | haven't been to one though |
| 14:03.42 | cresl1n | how was it? |
| 14:04.11 | seanbright | it turned out really good. lots of food. lots of booze. |
| 14:04.18 | seanbright | we got a shit ton of stuff that we will never used |
| 14:04.26 | cresl1n | Wait - this is for you? |
| 14:04.26 | seanbright | use* |
| 14:04.30 | seanbright | indeed |
| 14:04.36 | cresl1n | When are you getting married? |
| 14:04.41 | seanbright | may 6th |
| 14:04.42 | cresl1n | And biggest congats by the way :-) |
| 14:04.45 | cresl1n | WOW. |
| 14:04.46 | seanbright | hey thanks |
| 14:04.50 | cresl1n | That's awesome! |
| 14:04.51 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-ffjsbjaezteqcmhv) |
| 14:04.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:05.07 | seanbright | yeah, getting down to the wire. i suggested that we just get married yesterday at the shower. |
| 14:05.10 | seanbright | but that was nixed. |
| 14:05.27 | cresl1n | Yeah, that's how I felt too |
| 14:05.32 | cresl1n | I just wanted to get it over with |
| 14:06.05 | seanbright | yes. it's not even about the money. it's just the stress. |
| 14:06.14 | cresl1n | ^ this |
| 14:06.15 | seanbright | but if yesterday was any indication, the wedding will be a good time |
| 14:06.28 | cresl1n | where are you located again? |
| 14:06.48 | seanbright | baltimore |
| 14:06.57 | file | Good morning Baltimoreeeeeeeeeeeeeeee |
| 14:07.06 | seanbright | http://www.swanharborfarm.org/ |
| 14:07.10 | seanbright | getting married there |
| 14:07.17 | seanbright | everyone in #asterisk-dev is invited |
| 14:07.25 | cresl1n | looks beautiful |
| 14:07.37 | cresl1n | seanbright: I feel so privileged :-) |
| 14:07.40 | seanbright | heh |
| 14:07.47 | seanbright | it's an elite group |
| 14:07.51 | cresl1n | Does she know a bunch of scruffy looking hackers are about swarm her wedding? |
| 14:07.53 | cresl1n | :-P |
| 14:07.59 | seanbright | i'll have some laptops set up for some pair programming during cocktail hour |
| 14:08.03 | cresl1n | and talk about asterisk code? |
| 14:08.04 | cresl1n | :-) |
| 14:08.23 | seanbright | she'll get over it :D |
| 14:09.02 | cresl1n | sounds like you either found a special girl, or the beginning of your first post-marriage argument is already in the makings |
| 14:09.06 | cresl1n | :-) |
| 14:09.10 | seanbright | heh |
| 14:09.13 | cresl1n | or both |
| 14:09.18 | seanbright | we'll say both |
| 14:10.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d007c27e1f692322a76.ipv6.abo.wanadoo.fr) |
| 14:11.24 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-yoroqksjxzobjxwk) |
| 14:11.24 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:18.41 | cresl1n | waves to kharwell |
| 14:19.38 | kharwell | cresl1n: greetings! |
| 14:19.48 | coreyfarrell | file: for the 'remove embedded' UPGRADE.txt am I creating new sections for '13.15.0 -> 13.16.0' and '14.4.0 -> 14.5.0'? |
| 14:20.09 | file | yes |
| 14:20.35 | coreyfarrell | also could you take a look at the file in master? looks like it didn't get cleared from 14? |
| 14:20.56 | coreyfarrell | do I create a 'New in 15.0.0' section? purge everything else? |
| 14:21.49 | gtjoseph | it's not new in 15 |
| 14:22.11 | *** join/#asterisk-dev Dovid (~dovid@static-173-63-105-210.nwrknj.fios.verizon.net) |
| 14:23.12 | gtjoseph | you'll want to add the same 14.4.0 -> 14.5.0 section to master |
| 14:23.34 | coreyfarrell | ok thanks |
| 14:24.04 | gtjoseph | i wonder how many folks will come out of the woodwork when they discover that module embedding is gone? |
| 14:24.11 | gtjoseph | even tyhough it's busted |
| 14:26.16 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 14:26.53 | cresl1n | gtjoseph: build measure learn? |
| 14:26.53 | cresl1n | :-) |
| 14:27.04 | gtjoseph | :) |
| 14:27.05 | coreyfarrell | if they have a patch to fix embedding they can revert the removal and submit a fix? |
| 14:27.18 | gtjoseph | quite true |
| 14:27.21 | cresl1n | yep |
| 14:27.40 | file | indeedy |
| 14:43.35 | seanbright | i like good docs and i cannot lie |
| 14:45.34 | file | is that a lie? |
| 14:45.51 | seanbright | yes |
| 14:46.25 | cresl1n | So I noticed that the tablet experience for gerrit is non-ideal |
| 14:46.40 | cresl1n | it was hard to do things like make comments on lines of code, etc |
| 14:46.52 | cresl1n | is that just me, or did I miss something? |
| 14:47.06 | file | I don't think doing code reviews from a tablet is one of their targets. |
| 14:47.44 | cresl1n | ic. |
| 14:54.43 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-mwvdxktglgkfimnd) |
| 14:54.43 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:58.04 | coreyfarrell | cresl1n: they're working on a new UI based on polymer, maybe https://gerrit-review.googlesource.com/?polygerrit=1 works better for mobile? apparently it's a 2.14 feature, doesn't look very mature yet. |
| 15:30.39 | cresl1n | interesting |
| 15:46.51 | *** part/#asterisk-dev tuxian (~tuxian@194.12.3.78) |
| 16:12.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 16:50.00 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 16:50.00 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 16:51.23 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-vrjeplmlcxsiwqkq) |
| 16:51.24 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:25.18 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 17:25.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:47.02 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 18:27.38 | seanbright | what are you digium people doing today? |
| 18:27.40 | seanbright | meetings? |
| 18:27.51 | seanbright | i need you to start laying down some code |
| 18:27.59 | cresl1n | reviewing code |
| 18:28.03 | seanbright | pffft |
| 18:28.11 | seanbright | unless it's my stuff, i am not interested |
| 18:28.47 | cresl1n | sends seanbright a bag of coal for his xmas present |
| 18:29.03 | seanbright | not AGAIN |
| 18:30.16 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 18:30.16 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:35.09 | cresl1n | what are you up to today seanbright? |
| 18:42.37 | seanbright | cresl1n: well. i've been trying to clear some of the low hanging fruit from jira. |
| 18:43.00 | seanbright | a few weeks ago i did a bunch of res_config_pgsql fixes, but stopped short of closing out the category (a la jeopardy) |
| 18:43.14 | seanbright | so i thought i would do that |
| 18:43.42 | seanbright | of course this means learning postgres |
| 18:43.52 | file | I like postgres. |
| 18:45.19 | seanbright | it's growing on me |
| 18:45.30 | file | like a fungus? |
| 18:45.31 | seanbright | although the tooling isn't great |
| 18:45.39 | seanbright | with mysql i have mysql workbench |
| 18:45.47 | seanbright | postgres doesn't really have anything windows-centric |
| 18:47.59 | file | I remember using Navicat back in the day |
| 18:54.03 | seanbright | i'll check it out |
| 18:54.22 | seanbright | bah. commercial. |
| 19:07.25 | *** join/#asterisk-dev ipengineer (~zconkle@71.252.134.63) |
| 19:53.48 | cresl1n | file: for when you're interested, finally got through your channel fd changes |
| 19:54.19 | cresl1n | For the most part it looks great |
| 19:54.46 | cresl1n | don't have to look at it today, just figured I'd let you know |
| 19:55.37 | file | I already updated it |
| 19:55.53 | file | do you want fd_count to be renamed? |
| 19:59.38 | cresl1n | What do you think? |
| 19:59.43 | cresl1n | It seems a bit - misleading |
| 20:00.05 | cresl1n | but I don't know a better name |
| 20:00.26 | cresl1n | that's not awkward |
| 20:00.49 | cresl1n | fd_vector_count? |
| 20:00.58 | cresl1n | fd_vector_size? |
| 20:01.12 | cresl1n | maybe that's still confusing |
| 20:01.32 | cresl1n | looks at seanbright |
| 20:01.58 | seanbright | let me look |
| 20:03.03 | cresl1n | file: fd_capacity? |
| 20:03.17 | cresl1n | seems more accurate but still a bit awkward |
| 20:03.34 | cresl1n | fd_spots? |
| 20:03.44 | seanbright | i think fd_count is fine, as long as the documentation describes what it is |
| 20:03.49 | cresl1n | num_potential_fds |
| 20:03.50 | coreyfarrell | capacity suggests it can't grow.. |
| 20:03.51 | seanbright | how many consumers of this function will we actually have? |
| 20:03.59 | cresl1n | it's a good point :-) |
| 20:04.21 | seanbright | "Retrieve the number of file decriptor positions present on the channel" |
| 20:04.24 | seanbright | seems adequate to me |
| 20:04.36 | seanbright | fd_positions?! |
| 20:04.37 | seanbright | :D |
| 20:05.43 | seanbright | ast_channel_number_of_file_decriptor_positions_present(â¦) |
| 20:05.54 | cresl1n | :-) |
| 20:06.00 | file | :D |
| 20:06.01 | cresl1n | I'll concede to your original intention file |
| 20:06.07 | file | yay? |
| 20:06.08 | cresl1n | It's not used in many places |
| 20:06.10 | seanbright | and now it's self documenting |
| 20:06.18 | file | 'tis possible internal |
| 20:06.23 | cresl1n | I just didn't know if anybody had any better thoughts |
| 20:06.34 | file | yes - cake |
| 20:06.42 | cresl1n | sends file cake |
| 20:06.48 | file | if you mean better thoughts which are relevant to this discussion, not really |
| 20:06.55 | cresl1n | ok |
| 20:06.57 | cresl1n | naming things⦠|
| 20:06.59 | cresl1n | sucks. |
| 20:07.56 | coreyfarrell | fd_vector_size makes sense to me since it just proxies to AST_VECTOR_SIZE.. but fd_count seems good enough too |
| 20:12.57 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 20:14.05 | cresl1n | oooh oooh |
| 20:14.16 | cresl1n | what do you think of that file, fd_vector_size? |
| 20:14.28 | file | vector is an implementation detail |
| 20:14.30 | cresl1n | steps away from the bikeshed |
| 20:14.41 | cresl1n | Yeah, that's why I shied away from it at first |
| 20:14.49 | file | I don't think the fact it's a vector should be exposed through the API |
| 20:14.55 | cresl1n | but what we're discussing is an implementation artifact anyways |
| 20:15.07 | cresl1n | you have to work around its internal implementation, no? |
| 20:15.19 | file | what we're discussing is the interface a channel provides to get file descriptors on it and to iterate |
| 20:15.26 | file | the fact it's a vector underneath doesn't matter |
| 20:15.31 | cresl1n | sort of |
| 20:16.12 | file | that's my opinion on the use of 'vector' in the name |
| 20:17.09 | cresl1n | Ok, I'll stay away from the bikeshed |
| 20:17.14 | cresl1n | I think count is somewhat misleading |
| 20:17.18 | cresl1n | but it doesn't matter that much |
| 20:17.30 | cresl1n | we've got much worse areas that could use naming improvement |
| 20:18.35 | cresl1n | Alright, just +1'd it |
| 20:34.11 | seanbright | cresl1n: what are your thoughts on https://gerrit.asterisk.org/#/c/5288/ |
| 20:34.12 | seanbright | ? |
| 20:34.38 | seanbright | it's already merged to 14 and master, so what the heck, amirite? |
| 20:35.32 | cresl1n | Looks pretty safe to me |
| 20:35.45 | cresl1n | is there a reason we didn't merge it into 13? |
| 20:35.58 | seanbright | merge failures and i re-based |
| 20:36.03 | cresl1n | nice |
| 20:36.10 | cresl1n | I'll just send it to +2 heaven then |
| 20:36.16 | seanbright | bless you, sir |
| 20:36.20 | cresl1n | no problems |
| 20:36.35 | seanbright | samesies with 5289 |
| 20:36.37 | seanbright | just saying |
| 20:37.01 | seanbright | do we have a bot in here anymore? |
| 20:37.17 | seanbright | besides Qwell, anyway |
| 20:37.34 | file | in here? no |
| 20:37.50 | cresl1n | is 5289 already merged in 14 and master? |
| 20:37.53 | cresl1n | goes to check |
| 20:37.53 | Qwell | what did I do? |
| 20:37.54 | seanbright | yes |
| 20:38.03 | file | cresl1n: yes |
| 20:38.04 | seanbright | Qwell: nothing... this time |
| 20:38.13 | Qwell | seanbright: Sleep with 1 eye open. |
| 20:38.24 | cresl1n | sends Qwell fresh bread |
| 20:38.27 | seanbright | Qwell: i sleep with both eyes open |
| 20:38.30 | file | the others were not dependent on each other, so they merged in individually |
| 20:38.43 | Qwell | cresl1n: My wife has expressed an interest in a bread maker recently. |
| 20:38.51 | cresl1n | I approve. |
| 20:38.54 | Qwell | also ohai |
| 20:39.04 | cresl1n | I advise you to use it primarily on the dough cycle |
| 20:39.11 | cresl1n | you will find much happiness |
| 20:39.22 | cresl1n | I have an awesome bread dough recipe if you decide to get it |
| 20:39.24 | cresl1n | please let me know |
| 20:39.28 | Qwell | will do |
| 20:39.42 | cresl1n | also, ohai back :-) |
| 21:16.00 | seanbright | ok folks. gotta jet. |
| 21:16.22 | seanbright | back in the morning to spam gerrit. |
| 21:27.39 | gtjoseph | google is failing me. when we send a line parameter on a registration contact, we should get it back on either the To header or the request URI correct? |
| 21:32.02 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 21:32.03 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:39.18 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8065:1c16:133a:50f6:3887) |
| 21:39.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:43.33 | file | should, yes |
| 21:59.29 | cresl1n | time for dad school |
| 21:59.33 | cresl1n | cya everybody |
| 21:59.52 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 21:59.53 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:57.20 | *** join/#asterisk-dev tripleslash (~triplesla@unaffiliated/imsaguy) |
| 23:00.22 | *** join/#asterisk-dev tripleslash (~triplesla@unaffiliated/imsaguy) |
| 23:13.15 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-yoroqksjxzobjxwk) |