| 00:22.17 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:22.17 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:54.42 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:48.27 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:49.57 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:49.57 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:55.05 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 08:01.11 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 08:08.06 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:16.33 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:17.04 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::10de) |
| 08:35.37 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::152e) |
| 09:07.45 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 10:04.25 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:45.29 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 11:08.10 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 11:12.57 | *** join/#asterisk-dev fblackburn (~fblackbur@qubcpq0957w-lp130-02-70-53-163-228.dsl.bell.ca) |
| 11:13.32 | *** part/#asterisk-dev fblackburn (~fblackbur@qubcpq0957w-lp130-02-70-53-163-228.dsl.bell.ca) |
| 12:35.40 | tsearle | good afternoon! |
| 12:50.27 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-nmgewvrlayilexal) |
| 12:50.27 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:25.09 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:25.09 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:57.16 | tsearle | hey, I see a post from 2012 saying that "core show channels concise" is deprecated |
| 13:57.20 | tsearle | is that still the case? |
| 14:01.15 | tsearle | http://lists.digium.com/pipermail/asterisk-dev/2012-January/053284.html |
| 14:11.59 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:11.59 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:12.35 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-hyfqirhevyjdyonx) |
| 14:12.35 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:13.17 | cresl1n | gerrit, gerrit, gerrit |
| 14:13.20 | cresl1n | how you forget me |
| 14:13.27 | cresl1n | EVERY DAY. |
| 14:14.02 | seanbright | i thought we talked about this |
| 14:14.04 | seanbright | :P |
| 14:14.13 | cresl1n | We did |
| 14:14.26 | cresl1n | It makes my morning complete to talk about it though |
| 14:15.42 | tsearle | I'm starting to find gerrit almost usuable |
| 14:15.55 | tsearle | I think you guys have improved your wiki page ref gerrit too |
| 14:15.58 | tsearle | and that helps alot |
| 14:16.03 | cresl1n | Excellent |
| 14:16.26 | tsearle | though I think you still don't cover how to get out of a review once done |
| 14:16.42 | tsearle | e.g. switch back to stock master |
| 14:16.54 | cresl1n | like 'git checkout master'? |
| 14:16.56 | tsearle | yeah |
| 14:16.59 | cresl1n | oh |
| 14:16.59 | cresl1n | ok |
| 14:17.04 | cresl1n | thanks for the feedback :-) |
| 14:18.03 | tsearle | until ast astricon where file showed me to branch first, my standadard procedure was to rm -rf the repo and re-clone |
| 14:18.06 | tsearle | was a bit heavy :-P |
| 14:18.45 | tsearle | the other Q I have with gerrit |
| 14:18.49 | tsearle | when I re-push a review |
| 14:19.05 | tsearle | do I still need to pass the topic & branch |
| 14:19.12 | tsearle | or it will remember based on the commit-id? |
| 14:19.27 | file | you have to pass the branch |
| 14:19.33 | file | you don't have to pass the topic |
| 14:19.36 | tsearle | ok |
| 14:20.03 | tsearle | so for updating it's git commit -a --amend & git review 13 |
| 14:20.09 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-lgjpnrhdankpjtvo) |
| 14:20.09 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:20.18 | gtjoseph | && |
| 14:20.22 | tsearle | and -t jiraname is just for the first push |
| 14:20.28 | gtjoseph | yep |
| 14:20.34 | seanbright | throw a --no-edit in there too |
| 14:20.37 | tsearle | :thumbsup: |
| 14:20.39 | seanbright | cuz why not |
| 14:20.50 | gtjoseph | you can add --no-edit to the commit if the commit message isn't going to change |
| 14:22.09 | tsearle | why does it feel like with git, the default behaviour is one nobody wants, so you always have to pass 20 flags for the basic operations, heh |
| 14:22.27 | seanbright | the default behavior for commit is what everyone wants |
| 14:22.45 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 14:22.50 | seanbright | ammending commits is the exception, not the rule |
| 14:22.53 | tsearle | and how about pull? seems nobody likes the default behaviour of merge and prefer rebase |
| 14:22.54 | seanbright | amending* |
| 14:22.59 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:22.59 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:23.40 | seanbright | if a git pull isn't just a simple fast forward, you're probably doing something wrong |
| 14:24.03 | tsearle | ok |
| 14:24.24 | gtjoseph | well, in one og the base branches |
| 14:24.33 | tsearle | even then |
| 14:24.38 | seanbright | i could count on one hand the number of times i have passed the --rebase flag to git pull |
| 14:24.41 | gtjoseph | git pull in a review branch is likely to result in issues |
| 14:24.53 | tsearle | if you don't do git pull --ff-only and there is an upstream commit, then it will still make a merge commit |
| 14:25.42 | gtjoseph | normally, you shouldn't make any changes in the upstream branches directly that way your local copy is always pristine |
| 14:26.31 | tsearle | so always make a local branch is the trick then? |
| 14:26.40 | seanbright | yes |
| 14:26.42 | file | yes |
| 14:26.45 | cresl1n | yes |
| 14:26.46 | gtjoseph | yes |
| 14:26.47 | seanbright | branches are cheap with git |
| 14:26.57 | tsearle | ok, so that's what I've been missing |
| 14:27.00 | tsearle | :-P |
| 14:27.30 | gtjoseph | if that's not in the wiki, let me know |
| 14:27.35 | gtjoseph | i thought it was |
| 14:28.17 | seanbright | personally i prefer github's pull request review system better than gerrit. you can push as many commits as you want, and whoever ends up merging it can squash them at merge time. |
| 14:28.51 | gtjoseph | "whoever ends up merging it" = more work :) |
| 14:29.02 | tsearle | You'll want to keep the local branches that track remote branches, like 13, 14 and master, in a pristine condition so create a new working branch that's based on the remote branch you're making the change against. |
| 14:29.05 | tsearle | it says that |
| 14:29.08 | seanbright | no more work than a +2 review |
| 14:29.17 | tsearle | but it doesn't say how to create a branch |
| 14:29.26 | seanbright | git checkout 13 |
| 14:29.26 | gtjoseph | i'll update |
| 14:29.32 | tsearle | e.g. no "git branch my_awesome_new_feature" |
| 14:29.36 | seanbright | git checkout -b branch-off-of-13 |
| 14:29.47 | seanbright | ugh, don't use 'git branch' |
| 14:29.48 | tsearle | -b creates a branch? |
| 14:29.52 | seanbright | yeah |
| 14:30.00 | tsearle | I thought that was to switch to an existing branch |
| 14:30.07 | seanbright | git checkout <existing> |
| 14:30.12 | gtjoseph | and git review will automatically take the branch name as the topic |
| 14:30.12 | seanbright | git checkout -b <new> |
| 14:30.19 | file | it's a shortcut for "create a branch and switch to it" |
| 14:31.03 | gtjoseph | git checkout -b ASTERISK-99999 will allow you to skip the git review -t ASTERISK-99999 |
| 14:31.27 | tsearle | ha |
| 14:31.37 | tsearle | so by default the branch name becomes the topic |
| 14:31.45 | gtjoseph | yep |
| 14:32.02 | gtjoseph | you still have to specify the base branch though (13, 14) |
| 14:32.29 | file | on an unrelated note, https://issues.asterisk.org/jira/browse/ASTERISK-26856 any thoughts? |
| 14:33.38 | cresl1n | First time I've seen that used in a while |
| 14:33.55 | cresl1n | Sounds like it might be busted |
| 14:33.57 | gtjoseph | yeah me too. i remember trying it about 6 years ago and it didn't work then |
| 14:34.05 | file | cresl1n: yes |
| 14:34.18 | cresl1n | I remember when we added support for it, I think for the AA50 |
| 14:34.27 | cresl1n | but since then I don't think we've really used it |
| 14:34.31 | file | it was |
| 14:34.35 | file | and we haven't |
| 14:34.58 | tsearle | embedding is to statically link the modules? |
| 14:35.41 | cresl1n | as I recall, yes |
| 14:35.53 | cresl1n | we had to hack up the module system quite a bit to make it work |
| 14:37.04 | file | yeahhhh |
| 14:40.43 | rmudgett | seanbright: The patch for ASTERISK-26400 fixed that issue when I +1'ed it. That could have gone in to fix one of those issues. |
| 14:41.09 | rmudgett | Making it also fix the other issue was overloading that patch. |
| 14:41.47 | seanbright | yeah |
| 14:41.59 | seanbright | if i'm honest, the whole back and forth on jira really rubbed me the wrong way |
| 14:42.11 | seanbright | and i've burned myself out a bit |
| 14:42.39 | seanbright | i'll get back to it after i get chan_sip rtcp-mux working |
| 14:43.09 | rmudgett | yeah we're waiting to get that in for the next release |
| 14:49.07 | *** join/#asterisk-dev tuxian_ (~tuxian@igilmour.plus.com) |
| 14:55.54 | file | notes these comments haven't quite helped him decide what to do with this particular issue |
| 14:56.20 | *** join/#asterisk-dev sh_smith (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 14:56.58 | seanbright | which issue? the queue one? |
| 14:58.03 | file | nah, module embedding |
| 14:58.29 | seanbright | ah |
| 14:59.31 | file | create an issue to remove it in master is an option, accept it as community supported till then |
| 15:21.59 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 15:21.59 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 15:22.24 | gtjoseph | the issue we're seeing on CentOS and Ubuntu is definitely an issue in 2.3.1 and fixed in 2.3.4 |
| 15:22.29 | file | ; The maximum number of connections to have open at any given time. |
| 15:22.29 | file | ; This defaults to 1 and it is highly recommended to only set this higher |
| 15:22.29 | file | ; if using a version of UnixODBC greater than 2.3.1. |
| 15:22.29 | file | ;max_connections => 20 |
| 15:22.54 | gtjoseph | hmmmm. |
| 15:23.06 | file | the default behavior, within the context of pooling, works for all |
| 15:23.53 | gtjoseph | Well, we can update our CentOS and Ubuntu Jenkins slaves to 2.3.4 so they'll work. Do we make that recommendation to the user community? |
| 15:24.11 | file | I don't remember that far back |
| 15:24.17 | gtjoseph | This issue would only affect those using realtime for contacts and subscription persistence |
| 15:24.33 | file | but 2.3.1 did work |
| 15:24.35 | gtjoseph | i.e writes |
| 15:24.54 | file | at least for MySQL |
| 15:25.19 | gtjoseph | Hmmm. Let me test with a MySQL backend |
| 15:25.28 | file | went through various combinations during the great pooling massacre |
| 15:26.28 | file | in fact I distinctly remember 2.3.1 because that's what a lot of people were running, both MySQL and Postgresql |
| 15:26.50 | gtjoseph | i wonder if folks were writing though. |
| 15:27.10 | file | that I don't know |
| 15:27.19 | file | a few maybe contacts |
| 15:27.24 | file | subscription persistence no |
| 15:28.06 | rmudgett | I recall a -dev or -users list about unixODBC versions for pooling support. |
| 15:28.36 | rmudgett | file might remember how to locate it. :D |
| 15:28.53 | file | I gave the gist above :P |
| 15:33.41 | seanbright | rmudgett: for the ASTERISK-26400 review, i rolled back to the code review that you +1'd |
| 15:33.53 | seanbright | you're right. we might as well get one bug closed. |
| 15:34.02 | rmudgett | :) |
| 15:34.14 | gtjoseph | oh dear: 'Specified key was too long; max key length is 767 bytes') [SQL: u'ALTER TABLE ps_contacts MODIFY id VARCHAR(255) NULL'] |
| 15:34.29 | gtjoseph | from alembic |
| 15:34.43 | seanbright | 255 chars != 255 bytes unfortunately |
| 15:35.24 | seanbright | what's the table charset? |
| 15:35.35 | gtjoseph | yeha i need to check |
| 15:35.53 | seanbright | i've never liked varchars as PKs |
| 15:36.06 | seanbright | even when they are technically correct |
| 15:36.14 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 15:36.40 | file | "The Xerox won't do scan to email." "Have you tried turning it off and on?" "It works now!" |
| 15:36.51 | file | Xerox: Where random software components crash without any indication. |
| 15:45.39 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-yxohdbklxnziqqhl) |
| 15:45.39 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:52.50 | gtjoseph | anyone know what the mysql/mariadb odbc package is for ubuntu? |
| 15:54.25 | file | Something myodbc? |
| 15:54.56 | opticron | libmyodbc - the MySQL ODBC driver |
| 15:55.01 | gtjoseph | did a search for odbc and nothing came upo related to mysql or mariadb |
| 15:55.11 | gtjoseph | hmmm |
| 15:55.20 | seanbright | can't find that on xenial |
| 15:55.25 | opticron | that's from 14.04 |
| 15:55.27 | seanbright | is it non-free? |
| 15:55.51 | mjordan | file: when defining multiple backends for an object in sorcery, do you list each backending wizard on separate lines? |
| 15:55.52 | opticron | unlikely |
| 15:56.00 | gtjoseph | yeah not seeing it in 16 |
| 15:56.32 | file | mjordan: yes |
| 15:56.32 | gtjoseph | @mjordan: in sorcery.conf? yes |
| 15:56.38 | file | And they are queried in order given |
| 15:56.39 | mjordan | thanks |
| 15:56.47 | mjordan | yup |
| 15:59.11 | seanbright | if (!*(read_area)) { |
| 15:59.17 | seanbright | are those inner parens requierd? |
| 16:00.02 | gtjoseph | not really |
| 16:00.10 | gtjoseph | gcc complaining? |
| 16:00.16 | gtjoseph | or rmudgett ? |
| 16:00.23 | gtjoseph | :) |
| 16:00.25 | seanbright | dunno, just looking at the rtcp-mux patch |
| 16:02.04 | rmudgett | That would look like a search and replace resulting from an expression being turned into a single variable reference. |
| 16:07.17 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 16:09.40 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 16:24.32 | tsearle | git checkout 14 |
| 16:24.32 | tsearle | error: pathspec '14' did not match any file(s) known to git. |
| 16:24.40 | tsearle | am I missing somthing? |
| 16:24.57 | gtjoseph | the remote name |
| 16:25.09 | file | if you are doing the cherry pick for your change, you can do it from gerrit by clicking the "Cherry Pick" button and specifying the branch |
| 16:25.47 | tsearle | @file thanks |
| 16:26.09 | tsearle | @gtjoseph so it should be git checkout origin/13 |
| 16:26.10 | tsearle | ? |
| 16:26.25 | tsearle | tried that and it puts me into detached head |
| 16:26.51 | gtjoseph | git checkout -b 14 origin/14 |
| 16:26.56 | gtjoseph | or gerrit/14 |
| 16:27.09 | tsearle | ok |
| 16:27.19 | gtjoseph | that'll create a new local branch that tracks the remote branch |
| 16:27.42 | tsearle | can the wiki be updated to add origin|gerrit? |
| 16:27.45 | tsearle | $ git checkout 13 |
| 16:27.45 | tsearle | $ git checkout -b ASTERISK-12345 |
| 16:27.56 | tsearle | is the current example (and that doesn't work) |
| 16:28.10 | gtjoseph | wilco |
| 17:00.50 | rmudgett | file: Re https://issues.asterisk.org/jira/browse/ASTERISK-26867 It is a problem. I think I have a way to fix it. |
| 17:01.06 | rmudgett | more locks. :) |
| 17:01.37 | rmudgett | Just think of the Allstate commercial about more pillows. |
| 17:03.08 | file | I only needed a yes or no on valid for triaging. |
| 17:15.58 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 17:15.59 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 17:28.31 | *** join/#asterisk-dev joshelson (~joshelson@64.55.128.243) |
| 17:48.25 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-cpbfhafzxugvgjuk) |
| 17:48.26 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 18:44.21 | joshelson | mjordan: So the weirdness on this continues, though you appear correct that the issue stems from pjxpidf_print. If I simply make it -2 instead of -1 on size = pjxpidf_print(pres, ast_str_buffer(*str), ast_str_size(*str) - 2); the crash stops. Also, changing the size of the initial allocation subscription body text - anything from 10 to 512 - seems to stop it. 128 is the only size where I've been able to duplicate the corruption. Any |
| 18:44.21 | joshelson | additional thoughts, by chance? |
| 18:46.19 | joshelson | With my body size of 357, pj_xml_print recursively calls xml_print_node multiple times, but still not sure why just that one pattern is causing this. I can set the initial allocation to 10 and call it more times than that without issue. |
| 18:46.26 | mjordan | given the valgrind errors, it looked like we were hitting off by one errors with the string length, although as putnopvut pointed out, I'm not entirely sure why either. It seems like the correct fix is to use -2, but I'm not entirely sure of why that is the case. It'd be interesting to step into that code with gdb, although that may not be easy to do. |
| 18:54.53 | joshelson | Yeah... that might be tricky. Is it worth submitting a fix to make the -1 to -2 change? Any potential for other issues there? |
| 19:04.46 | mjordan | Well, it'd be good to fix the crash, for sure. Crashes are bad. My only concern is that I'm not that familiar with this code, so it's hard for me to know if that's the right answer. putnopvut or others may have more insight. |
| 19:13.20 | joshelson | Yeah.. there's something magical about the 128 initial value allocation for the body I may be able to track down. If I change to 127 or 128, it crashes with -2 and not -1. Something definitely weird is going on here. |
| 19:15.22 | joshelson | Err.. 129 |
| 20:11.35 | *** join/#asterisk-dev jkroon (~jkroon@154.73.32.15) |
| 20:23.48 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 20:30.23 | putnopvut | 128 when doubled is 356. 129 when doubled is 358. 357 is right in that sweet spot. Since the buffer is doubling in size, there could be some off-by-x error that happens after the doubling. |
| 20:36.19 | rmudgett | That's not doubling... |
| 20:38.36 | putnopvut | ...go on. |
| 20:39.27 | file | 128 when doubled is 256 |
| 20:40.24 | putnopvut | oh yeah. doubled 178 instead of 128 |
| 20:40.52 | putnopvut | A common off-by-50 error |
| 20:43.31 | *** join/#asterisk-dev joshelson (~joshelson@67.41.170.94) |
| 21:53.18 | cresl1n | see you all later - time to get on out of here |
| 22:32.49 | *** join/#asterisk-dev Dovid (~dovid@ool-4573a525.dyn.optonline.net) |
| 22:33.04 | Dovid | Is there any reason this is not in Asterisk 13 or is it and I just need to download the sound files on my own? |
| 22:34.32 | file | you're going to need to be more specific... |
| 22:35.51 | Dovid | when I go to compile Asteirsk 13 and I look at extra sound files there is French, Russian, Spanish etc but no Hebrew. If this was added back in 1.4 why wouldn't there be an option in make menuselect download Hebrew? |
| 22:37.52 | file | I don't believe there were Hebrew extra sound files contributed... |
| 22:38.34 | Dovid | It's in the Jira ticket |
| 22:38.41 | Dovid | https://issues.asterisk.org/jira/secure/attachment/29548/asterisk-sounds-il.zip |
| 22:39.07 | file | what is the issue? |
| 22:40.07 | file | I checked within 1.4, and they aren't in menuselect there |
| 22:40.13 | Dovid | I can manually put it together and download to my box but I was curious if it was given to the project why it isnt an option under core sound packages |
| 22:41.10 | file | for core sounds we will remove them if noone is actively maintaining the sounds or able to provide updates |
| 22:41.20 | Dovid | file: Correct I am asking why. The patch was put in way back then. just trying to understand if there was a reason it was never added to menuelect. For me it's easier if I can install the sound files directly via make menuselect as opposed to grabbing it from the ticket |
| 22:41.32 | Dovid | file: ah ok. That explains it |
| 22:41.44 | Dovid | so I assume there is a list of core files that are the same across all languages? |
| 22:41.52 | file | yes |
| 22:42.17 | Dovid | ok. I am going to speak to Nir to see what the cost would be to keep it updated |
| 22:49.14 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 22:49.14 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 23:16.11 | kharwell | should https://gerrit.asterisk.org/#/c/5218 be cherry-picked into master? |
| 23:16.51 | kharwell | oh wait it is. |
| 23:17.48 | file | stares at kharwell |
| 23:18.06 | kharwell | file: you're getting sleepy |
| 23:18.14 | file | there is no getting |
| 23:18.17 | file | I am sleepy |
| 23:22.26 | rmudgett | Are the other dwarfs there too? |
| 23:22.50 | file | I'm afraid not |
| 23:23.42 | rmudgett | Well spying should be safer now. :) |
| 23:28.45 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-hyfqirhevyjdyonx) |