| 00:16.57 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-ugdknqztpgzdsinh) |
| 01:19.51 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:19.51 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:45.13 | danjenkins | bonjour all from the philippines |
| 03:45.20 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 04:53.34 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 05:06.05 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 06:17.51 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.45) |
| 06:45.19 | dan_j | gtjoseph: i updated the 13 branch patch but didnt know how to cherrypick the update to the other ones. |
| 06:48.14 | snuff-work | dan_j: u can always try n cherrypick using the web interface.. (normally how i do it) |
| 06:49.58 | dan_j | Does that cherrypick into existing code? |
| 06:50.27 | snuff-work | it can cherry pick your changes into a different branch.. |
| 06:50.40 | snuff-work | which is what you want correct? |
| 06:50.50 | dan_j | Or does it create a brand new review, even if one already exists for thay branch? |
| 06:51.10 | snuff-work | it will create another review that is linked to the current 1 |
| 06:51.28 | snuff-work | u probably see some examples on gerrit atm.. |
| 06:52.15 | snuff-work | like the rtcp-mux support one.. |
| 06:54.11 | dan_j | See the ones with my name on? Ive updated 13 and need to update master and 14. If I cherrypick from 13, will that update the master+14 reviews, or will it make new ones? |
| 06:54.55 | snuff-work | ah.. i forget.. +( |
| 06:55.22 | snuff-work | i do somethingn on this once every 6 months.. enough time to forget what happens |
| 06:55.44 | dan_j | Ok. Ill play around with it. |
| 06:55.55 | snuff-work | i think.. |
| 06:56.00 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:56.24 | snuff-work | after ur initial update.. it should play nice / maybe auto update cherrypick |
| 06:57.38 | snuff-work | so you haven't pushed ur update yet? |
| 06:58.09 | snuff-work | push your updated code to gerrit.. i believe it should to the 'rest' of the magic |
| 07:19.54 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 07:26.28 | dan_j | I pushed to 13 but its not updated the other ones that i previously cherrypicked. |
| 07:27.06 | snuff-work | i think u may just have to 're-cherrypick' from the one you updated |
| 07:27.27 | snuff-work | worst case it makes new gerrit changes |
| 07:44.09 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 07:44.09 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:52.40 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:03.42 | dan_j | Perfect. Seems to work fine. |
| 08:03.44 | dan_j | Thanks |
| 08:05.29 | dan_j | gtjoseph: See my comments on the 13 branch. Change 5120. |
| 08:17.05 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::10de) |
| 08:17.39 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:19.51 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:19.51 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:23.37 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 09:06.09 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 09:06.09 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:06.24 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 10:18.03 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:25.34 | *** join/#asterisk-dev tuxian (~tuxian@194.12.3.78) |
| 11:12.14 | seanbright | ah ross. the support vampire. |
| 11:12.26 | seanbright | has anyone suggested he use -cert and get a support contract? |
| 11:23.20 | file | achoo |
| 11:39.25 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 12:54.31 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 13:14.44 | seanbright | dan_j: you don't have a lot of faith in us 'community users' :P |
| 13:14.58 | dan_j | ? |
| 13:15.00 | seanbright | i fixed IAX2 trunking for fuck's sake |
| 13:15.11 | seanbright | you have no idea what i am capable of!! |
| 13:15.12 | seanbright | heh |
| 13:15.21 | seanbright | dan_j: you're 'Dan Jenkins' from jira? |
| 13:15.28 | file | he's not |
| 13:15.28 | dan_j | Nope |
| 13:15.32 | seanbright | well fuck me |
| 13:15.37 | seanbright | dan_j: nice talking to you |
| 13:15.41 | dan_j | Thats danjenkins on irc |
| 13:15.42 | file | seanbright: oddly danjenkins is Dan Jenkins |
| 13:15.45 | seanbright | danjenkins: HEY |
| 13:15.57 | seanbright | danjenkins: you don't have a lot of faith in us 'community users' :P |
| 13:16.00 | seanbright | (that's better) |
| 13:16.08 | file | he's also in Manilla right now if I remember right |
| 13:16.12 | danjenkins | LOL |
| 13:16.16 | seanbright | i love manilla |
| 13:16.25 | seanbright | but i prefer mocolate |
| 13:16.27 | danjenkins | of course I do :D |
| 13:16.30 | dan_j | Think I need to change my nick |
| 13:16.32 | file | oh no, he espeaks |
| 13:16.52 | danjenkins | you know what i meant @seanbright ;) |
| 13:17.05 | seanbright | i do |
| 13:17.14 | seanbright | i'll have you a chan_sip patch for rtcp-mux by COB (eastern) |
| 13:17.17 | seanbright | stop being a whiner |
| 13:17.25 | seanbright | no one likes a whiner - unless it's me |
| 13:17.51 | danjenkins | ha! I just like to keep the core team on their toes |
| 13:18.04 | file | danjenkins: we don't do chan_sip bug fixes btw :P |
| 13:18.19 | danjenkins | i thought you did? thats what was discussed at dev con |
| 13:18.22 | file | unless it's a critical regression introduced by something |
| 13:18.23 | seanbright | is not core, i'm just a community user |
| 13:18.27 | seanbright | so i can say whatever i want |
| 13:18.33 | seanbright | it's quite liberating |
| 13:18.55 | danjenkins | its the best way @seanbright |
| 13:19.03 | seanbright | intends to create a critical regression in chan_sip today |
| 13:19.11 | file | seanbright: entirely possible |
| 13:19.18 | seanbright | fingers crossed |
| 13:21.18 | danjenkins | if I'd thought about it I should have sent it to the freepbx guys and girls and told them - they would have had it fixed in no time *jokes* :D |
| 13:21.43 | danjenkins | goes back to working on something that needs done tonight :) |
| 13:22.38 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 13:26.25 | seanbright | hmm... that's an idea |
| 13:26.34 | seanbright | i'll just post a bogus patch to gerrit |
| 13:26.44 | seanbright | and then use the review process to actually implement the feature |
| 13:26.46 | seanbright | it's almost too easy |
| 13:26.46 | danjenkins | ? |
| 13:26.47 | danjenkins | LOL |
| 13:29.04 | seanbright | opinion: should rtcp-mux be a global and peer option? or just peer? |
| 13:29.53 | seanbright | meh, global it is |
| 13:31.16 | file | both probably |
| 13:49.25 | seanbright | file: you son of a bitch. i was expecting a rubber stamp on that review. |
| 13:49.26 | seanbright | UGH |
| 13:49.55 | file | yes, I take into account that stuff these days :P |
| 14:06.06 | seanbright | hmm, why haven't i been using 'make -k' my entire life? |
| 14:06.16 | seanbright | also, why isn't that the default behavior? |
| 14:06.52 | danjenkins | I really enjoy being told what WebRTC is and isn't (incorrectly) |
| 14:07.04 | gtjoseph | it kinda makes things confusing especially if you do parallem builds |
| 14:13.20 | dan_j | file: Is the nativeformats requiring being locked documented anywhere? Or is it something that I'll figure out over time? |
| 14:14.22 | file | all of the channel accessor/setters have to be locked |
| 14:14.59 | file | it's sorta documented in channel.h, there's a "\pre chan is locked" for a large group of functions |
| 14:15.50 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-urkbuytqqvemjkxt) |
| 14:15.50 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:19.32 | dan_j | If I want to add a code review that will require a new field to be added to realtime, I know I need to make changes to the alembic scripts. Do I submit the code-review with #close, or should I leave that off until alembic is sorted? |
| 14:19.54 | dan_j | Also, can't remember how to deal with alembic, but I did it a year or so ago so can look at my irc chat logs. |
| 14:20.26 | file | the change won't be accepted until alembic is sorted, so you can put up a review for the code changes and then amend with alembic |
| 14:21.15 | dan_j | Is alembic included in the same code-review, or is it submitted separately. i cant remember. |
| 14:21.28 | file | same code review |
| 14:21.54 | file | a code review generally represents the entirety of a piece of work, it's only over long running projects that things get split up as parts are done |
| 14:22.08 | dan_j | Ok. Noted. |
| 14:22.18 | file | (that's how I view it, to each their own) |
| 14:22.56 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:22.56 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:23.18 | cresl1n | Oh gerrit, gerrit, gerrit. You forget me so quickly. |
| 14:23.25 | file | cresl1n: haylo |
| 14:24.29 | cresl1n | file!!!!! |
| 14:42.11 | leifmadsen | my arch nemesis and clone |
| 14:51.50 | dan_j | where are the sample conf files stored in the source? |
| 14:52.49 | file | configs/samples? |
| 14:53.16 | dan_j | thanks. only place i didnt look :S |
| 15:12.44 | dan_j | Should I do alembic changes from the 'master' branch, or can I be in the 13 branch? |
| 15:14.29 | file | wherever your original change is done |
| 15:14.33 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-wwzyvftgldwdtstr) |
| 15:14.33 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:14.33 | dan_j | Ok. |
| 15:15.27 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:15.27 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:16.52 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-dhxqbonvcwkwakqb) |
| 15:16.52 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:25.58 | dan_j | file: Is the voicemail_users realtime table managed by alembic? It doesnt appear so. |
| 15:26.19 | file | I don't know that information, it would not surprise me if not |
| 15:26.36 | dan_j | ok. |
| 15:26.38 | dan_j | thanks. |
| 15:31.36 | rmudgett | dan_j: app_voicemail does have an alembic table. It just isn't in the main config set of tables. |
| 15:31.51 | rmudgett | The same for cdrs |
| 15:32.12 | dan_j | rmudgett: Yes, but app_voicemail's alembic only has scripts for the messages table and not the users table. |
| 15:35.06 | rmudgett | wonders if we shouldn't merge the voicemail and cdr tables in with the rest of the config tables |
| 15:36.06 | rmudgett | file: Is the change accepted by teluu the same patch that is in the websocket IPv6 review? |
| 15:36.32 | rmudgett | They do have a tendency to modify submitted patches. |
| 15:36.32 | file | let me look again |
| 15:37.05 | file | ah, they altered the formatting |
| 15:38.05 | putnopvut | seanbright: thanks for the feedback on the rtcp-mux review |
| 16:00.47 | seanbright | putnopvut: no problem. hopefully there was something right-ish about something that i said :) |
| 16:33.09 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-130-192.try.wideopenwest.com) |
| 16:33.09 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 17:20.28 | dan_j | file: Is that voicemail code classed as a change or a fix? I considered it a fix which is why i didn't put it in CHANGES. |
| 17:21.13 | file | you're adding a new option for use by a voice mailbox, I consider that a new feature |
| 17:22.53 | dan_j | Ok. I'll add it to CHANGES. |
| 17:23.21 | dan_j | Can't do it now. Will do it in a couple of hours. |
| 17:25.05 | seanbright | the more i think about it... why would rtcp-mux be configurable on the answer side of an offer? |
| 17:25.20 | seanbright | it's either supported or not, why would you not want to use it if offered? |
| 17:36.44 | rmudgett | file: Questions for you on https://gerrit.asterisk.org/#/c/5134/ |
| 17:36.56 | file | yes? |
| 17:37.37 | rmudgett | posted in the review |
| 17:38.16 | file | I am not changing the patch. |
| 17:38.27 | file | the commit message, yes |
| 17:38.29 | file | the contents no |
| 18:32.17 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-twcasalhwjxrzfnc) |
| 18:32.17 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 18:32.53 | mjordan | question: say we wanted to add a new identifier module. In our current configuration nomenclature, an 'identify' section is always mapped to an 'identify by IP address' functionality. |
| 18:33.10 | mjordan | What would we want to call a new 'identifier' configuration section? Or would it be better to extend the existing identify configuration block? |
| 18:35.16 | file | if the logic is in the existing IP module then it could be in there if it made sense, otherwise something new I'd say |
| 18:37.06 | mjordan | k. I'll probably have to make up a somewhat cludgy name for it, like 'identify_by_foobar' or something. Wish we had named 'identify' as 'identify_ip', but naming is hard :-( |
| 18:37.35 | mjordan | I suppose I could reuse the identify object but just consume it in another module... but then you'd have IP only attribute and whatever junk I add |
| 18:38.33 | file | yeahhhhh |
| 19:00.20 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-130-192.try.wideopenwest.com) |
| 19:00.20 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 19:13.17 | *** join/#asterisk-dev kraylo (~kraylo@unaffiliated/kraylo) |
| 19:17.28 | dan_j | rmudgett gtjoseph: Regarding https://gerrit.asterisk.org/#/c/5120/ , I've just checked chan_sip to see if what it uses to keep the functionality the same. Chan_sip doesn't display any codecs in a channel list. So the question is, should that column be removed from pjsip's channelstats? If it should be kept, should it be read or write, both by adding a 2nd |
| 19:17.28 | dan_j | column? Both read and write are equally important. |
| 19:17.54 | dan_j | *Chan_sip doesn't display any codecs in it's channelstats list |
| 19:20.36 | rmudgett | There isn't room to add another column. That's why the ChannelId column skips the PJSIP/ part of the channel name. |
| 19:21.29 | rmudgett | The read format is probably more important there so you know what is coming to you. |
| 19:21.59 | rmudgett | IMHO |
| 19:23.03 | putnopvut | gtjoseph: Not done reviewing the SDP generation stuff yet, but I have to say I'm really impressed with how straightforward and clean it is from what I've looked at. It's going to be a pleasure to work with :) |
| 19:23.15 | dan_j | rmudgett: thanks |
| 19:26.53 | seanbright | i find myself frustrated by not being able to write clean code in chan_sip |
| 19:26.59 | seanbright | but i now realize that task is impossible |
| 19:27.02 | seanbright | so i don't feel that bad |
| 19:27.19 | cresl1n | hums the "that's why we've got chan_pjsip" song |
| 19:27.27 | putnopvut | Yeah, that's how I felt about writing code in res_rtp_asterisk recently |
| 19:28.13 | dan_j | Is http://doxygen.asterisk.org no longer updated? |
| 19:29.15 | seanbright | dan_j: correct |
| 19:29.28 | dan_j | Is there an equivalent? |
| 19:29.33 | seanbright | nope |
| 19:30.02 | rmudgett | I get my doxygen fix from SlickEdit :D |
| 19:30.17 | rmudgett | It's always current |
| 19:30.41 | rmudgett | s/always/almost always/ |
| 19:30.53 | dan_j | Looks cool |
| 19:31.14 | seanbright | i guess |
| 19:31.16 | seanbright | if you like qt |
| 19:31.30 | seanbright | looks like a UI abomination to me |
| 19:31.44 | seanbright | is a hter |
| 19:31.49 | seanbright | hater* |
| 19:32.25 | seanbright | hopes rmudgett is not the creator of slickedit... |
| 19:32.46 | seanbright | ok, he's not. good. |
| 19:33.46 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 19:34.51 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 19:34.55 | rmudgett | doesn't know what he'd do if he couldn't find a Brief keymapped editor. |
| 19:35.17 | seanbright | live a long and fruitful life? |
| 19:35.40 | seanbright | if you don't use emacs key bindings you're dead to me |
| 19:35.41 | seanbright | just sayin' |
| 19:35.58 | dan_j | Are you guys all running linux desktops? |
| 19:36.03 | seanbright | <-- windows 10 |
| 19:37.16 | seanbright | static const pj_str_t STR_NEW = { "new", 3 }; |
| 19:37.24 | seanbright | is there no macro to pretty that stuff up? |
| 19:37.35 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0060f213f34362bc47.ipv6.abo.wanadoo.fr) |
| 19:37.57 | rmudgett | no. There is a pj_str() |
| 19:38.54 | seanbright | does it perform the same operation as the initializer? |
| 19:39.56 | rmudgett | It takes a C string and converts it to a pj_str_t type. |
| 19:40.06 | rmudgett | It is run time because it has to do a strlen. |
| 19:40.14 | seanbright | ah, i see |
| 19:47.50 | file | build build build |
| 19:48.54 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 19:48.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:02.05 | file | rmudgett: update the review |
| 20:02.07 | file | :P |
| 20:02.24 | rmudgett | k |
| 20:02.38 | rmudgett | I'll fix then |
| 20:02.44 | file | I'm done with this back and forth on that part :P |
| 20:06.31 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LFbn-1-5199-183.w90-105.abo.wanadoo.fr) |
| 20:38.22 | seanbright | can't wait for gtjoseph to be done the sdp stuff so he can update chan_sip /s |
| 20:47.32 | seanbright | hey... since you're all smart programmer types |
| 20:47.48 | seanbright | any of you have an interval tree implementation in C floating around? |
| 20:54.57 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 20:54.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:29.09 | gtjoseph | this is odd. i've been sitting here all this time and for some reason hexchat stopped notifying me when i'm mentioned. |
| 21:34.33 | gtjoseph | @putnopvut: got a few minutes to chat about opaqueness? I went back and forth on this and never really came to a conclusion. If we want everything to be opaque (like channel) we certainly can create getters/setters for everything. It's just more cumbersome. |
| 21:35.45 | putnopvut | Yeah, I can chat |
| 21:35.59 | putnopvut | I'm on the fence on the matter, myself. |
| 21:36.20 | file | ditto |
| 21:36.28 | gtjoseph | yeah. For public use I'd say opaque but the translators need access |
| 21:37.23 | gtjoseph | on the other hand... a new feature this major is going to undergo changes and not having to worry about making breaking changes to the structures would be good |
| 21:38.59 | gtjoseph | tell you what, let's go the safe route with getters/setters and let gcc inline them, then evaluate later if we need direct access. |
| 21:40.44 | gtjoseph | as for the t-line and s-line structures, I wanted to keep things consistent with every line having a structure. |
| 21:40.59 | gtjoseph | and an alloc.free |
| 21:41.21 | gtjoseph | Opinions? |
| 21:49.29 | gtjoseph | Also for the stream data. we could make data an array... void *data[STREAM_MAX_DATA] and if another module needs to save data, it can add an entry to the "ast_stream_data" enum. |
| 21:50.37 | gtjoseph | putnopvut: file: ^^ |
| 21:52.39 | putnopvut | The array method for stream data is similar to what PJSIP does with its mod_data arrays. |
| 21:52.45 | gtjoseph | exactly |
| 21:52.52 | gtjoseph | fast and simple |
| 21:53.10 | gtjoseph | it's not going to be arbitrary data. |
| 21:53.19 | file | yeah, that's fine |
| 21:53.30 | gtjoseph | cool cuz i already did it. |
| 21:54.03 | gtjoseph | Comments on my the earlier comments? |
| 21:54.46 | seanbright | opaque is good |
| 21:54.51 | seanbright | you're welcome |
| 21:55.06 | gtjoseph | :) |
| 21:56.33 | seanbright | rmudgett: could i get your feedback on https://gerrit.asterisk.org/#/c/5132/ when you have a moment? |
| 21:57.47 | seanbright | assuming said feedback is a +1. if it's not, then nevermind :P |
| 22:17.06 | rmudgett | seanbright: The implementation of the AST_OUTGOING_ATTEMPT isn't very efficient. It sets that variable repeatedly on the channel until it reaches the latest attempt count. |
| 22:17.57 | rmudgett | On attempt 10 it will set the variable 10 times. |
| 22:18.54 | rmudgett | Could the list not be updated with the new value rather than appending a new variable set to the list. |
| 22:19.16 | seanbright | hmm, let me take a look |
| 22:19.55 | seanbright | rmudgett: apply_outgoing is called once per attempt, no? |
| 22:22.06 | rmudgett | oh. The o is new for each attempt so not a problem. |
| 22:22.20 | seanbright | k |
| 22:22.22 | seanbright | thanks |
| 22:25.22 | rmudgett | however, you don't need to use ast_asnprintf() You could simply use snprintf() with buf since that is available. That way you don't need to allocate and free memory. |
| 22:27.23 | seanbright | but that assumes that LINE_BUFFER_SIZE will be sufficient space |
| 22:27.47 | seanbright | what happens when we have 4096 bit architectures? |
| 22:28.23 | file | chaos |
| 22:30.51 | rmudgett | I think by the time there are 4096 bit architectures computer will no longer work that way. qbits anyone? |
| 22:31.08 | rmudgett | s/computer/computers |
| 22:36.48 | seanbright | so my complete unproven theory on ASTERISK-26835 is that ast_rtp_read() and ast_rtp_destroy() are being called at the same time on two different threads |
| 22:37.08 | seanbright | before i go hunting, is that even possible? |
| 22:37.36 | file | po...tentially... although I don't know why it'd be getting destroyed |
| 22:37.49 | seanbright | i'm determined to help ross beer fix his double free |
| 22:38.06 | file | it could be getting modified for sure, I took a glance when I triaged and we didn't seem to protect it adequately in res_pjsip_sdp_rtp by holding the channel lock |
| 22:38.51 | rmudgett | The way ross has crashes he should run with MALLOC_DEBUG enabled all the time. |
| 22:39.28 | file | I wonder if anyone genuinely likes Comcast as an ISP. |
| 22:40.43 | seanbright | file: as a comcast customer, i can say no |
| 22:40.51 | putnopvut | file: yeah, the answer is a definite "no" |
| 22:41.00 | file | yeahhhh |
| 22:41.11 | putnopvut | And comcast knows it too, based on how they react whenever any sort of competition comes to town. |
| 22:42.42 | rmudgett | panic?? |
| 22:43.10 | file | at the disco? |
| 22:45.23 | putnopvut | file: with regards to https://gerrit.asterisk.org/#/c/5139/1//COMMIT_MSG@17 , why do you suggest a note in UPGRADE.txt? It's not introducing a behavior change or breaking change. |
| 22:46.25 | file | putnopvut: I'm basically trying to cover our bases on making it as clear as possible in multiple places how to enable it, so when the browser thing hits there's a better chance of someone seeing it |
| 22:47.06 | putnopvut | Hm, okay |
| 22:47.32 | file | will it work? who knows! will I probably end up marking multiple issues as duplicates? probably! |
| 23:04.39 | seanbright | holy shite... we're shopping SBCs right now and they are really fucking expensive |
| 23:06.47 | file | yes. |
| 23:36.23 | file | seanbright: sushi? |
| 23:41.21 | seanbright | i ate one too many rolls last night |
| 23:42.09 | rmudgett | Why is ast_file_is_readable() preferred over access() ? |
| 23:42.26 | seanbright | why does ast_file_is_readable() exist? |
| 23:42.29 | file | seanbright: #firstworldproblem |
| 23:42.53 | seanbright | if we have abstractions shouldn't we be using them? |
| 23:43.01 | seanbright | not to mention i am the one that put access() in that code block in the first place |
| 23:45.19 | seanbright | rmudgett: i don't have an issue abandoning. what is your concern? |
| 23:46.03 | rmudgett | It just wasn't plain to me why it is preferred. After looking at the function I can see why. |
| 23:46.10 | seanbright | ah |
| 23:49.02 | seanbright | anyone object to reverting 338a8f in light of ASTERISK-26400? |
| 23:50.07 | seanbright | hmm, there is no 338a8f |
| 23:50.37 | seanbright | 338a8ffed673e4c3a828c7c216575f8e3e712350 |
| 23:50.59 | file | the change went in over a year ago, I'd rather it be looked at a little bit to understand why first tbh |
| 23:51.07 | seanbright | oh shit |
| 23:51.17 | seanbright | i forgot it was 2016 |
| 23:51.21 | seanbright | lol |
| 23:51.22 | seanbright | 2017! |
| 23:51.31 | seanbright | disregard |
| 23:51.35 | seanbright | i'll figure it out |
| 23:51.44 | seanbright | i love app_queue almost as much as chan_sip |
| 23:52.00 | file | time flies when manipulating the space time continuum |
| 23:52.51 | seanbright | who let "InCall" slip through review? |
| 23:52.55 | seanbright | i'm over it |
| 23:53.50 | file | seanbright: I suggest ice cream |
| 23:53.53 | file | or frozen yogurt |
| 23:53.59 | seanbright | increases the S/N ratio of this channel dramatically |