| 00:05.01 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-yvqrqbsfzddoohzf) |
| 00:30.40 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 00:30.40 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:29.18 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 02:25.03 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 02:25.03 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 03:35.53 | *** join/#asterisk-dev kunwon1 (~kunwon1@unaffiliated/kunwon1) |
| 03:47.55 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 03:58.42 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 04:40.19 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 06:42.21 | *** join/#asterisk-dev tzafrir (~tzafrir@91.183.149.114) |
| 06:42.21 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:57.50 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:15.26 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 07:15.26 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:36.57 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 07:52.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:58.40 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:02.21 | tsearle | I confirm @creslin made it to belgium alive! :-) |
| 08:15.52 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 08:15.53 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:37.54 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::152e) |
| 09:09.31 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:52.37 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 10:04.20 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 10:54.14 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 10:54.14 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:32.57 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 11:32.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:00.53 | *** join/#asterisk-dev libardi (~libardi@187.64.235.241) |
| 12:06.14 | danjenkins | @tsearle say hi from me! |
| 12:38.39 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-130-192.try.wideopenwest.com) |
| 12:38.39 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 13:18.41 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 13:22.36 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 13:27.29 | *** join/#asterisk-dev oej (~oej@79.138.128.95.mobile.tre.se) |
| 13:27.29 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:38.22 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-xrehzwiybnygqbfz) |
| 13:38.22 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:53.24 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 14:00.38 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 14:00.38 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:52.54 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 15:04.16 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-enzsfrwvabdojjpy) |
| 15:04.16 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:15.15 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 15:26.04 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:26.04 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:31.21 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 15:48.43 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hebqlrxmqaiwbsue) |
| 15:48.43 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:54.39 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-xftssmimuatgprry) |
| 15:54.39 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:47.43 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-bhelxrxncggswcik) |
| 16:47.43 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 17:14.19 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qcvbfhhlxiumugrv) |
| 17:14.19 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 17:29.48 | *** join/#asterisk-dev tuxd00d (~tuxd00d@wsip-184-179-14-87.ph.ph.cox.net) |
| 17:40.10 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-licutlltmjqhnfgx) |
| 17:40.10 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 18:01.17 | *** join/#asterisk-dev dan_j (sid21651@gateway/web/irccloud.com/x-eljuxkirbmdjvyus) |
| 18:24.24 | *** join/#asterisk-dev sunspots (~tuc0@d14-69-15-127.try.wideopenwest.com) |
| 18:24.51 | sunspots | So I'm trying to increase the gain on a channel in my lil app. Does anyone have a good recommendation as to the best strategy I should take? Can I just turn up a channel or do I need to add in a hook and apply the gain to every frame similar to how the "VOLUME" func does it? |
| 18:27.21 | file | it depends on how exactly you want it to work - if you only want it applied on frames your application is handling then just applying it after reading would be best/easiest |
| 18:29.32 | sunspots | I'm playing a file via ast_streamfile, following that I do want it to go back to normal volume. So creating a callback seems like overkill. How would you recommend I apply it for just this duration of time? And thank you btw. |
| 18:30.08 | file | using func_volume would probably be easiest, you can call it before/after using pbx_builtin_setvar_helper |
| 18:33.23 | sunspots | Yeah. That's probably the simplest route, func_volume has (what I think) is a lot of overhead however. It creates a callback function for each frame that is created on the channel, the call back runs, the call back looks for gain info stored in the datastore and then applies it to each indivudal frame while also checking for DTMF digits in case the volume control option is enabled. Perhaps this isn't as much overhead as I'm making |
| 18:33.23 | sunspots | <PROTECTED> |
| 18:35.01 | file | it's not that bad |
| 18:35.36 | sunspots | I didn't mean a callback for each frame, I meant that a function is executed for each frame and then the gain is applied after a DTMF check. poorly worded. |
| 18:35.56 | sunspots | I guess I was hoping for a ast_channel_set_option(chan, TXGAIN, 5); ya know, something I can't screw up :) |
| 18:36.07 | file | there isn't |
| 18:36.16 | file | just func_volume |
| 18:36.25 | sunspots | Okay, I'll look into what you recommended then. Thank you for your help. |
| 18:37.08 | file | you're welcome! |
| 18:45.13 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 18:53.03 | seanbright | this may demonstrate my misunderstanding of some critical concepts... but does a browser give a shit if dtlscertfile is self-signed? |
| 18:55.13 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00d55c3f7ceb5afb3f.ipv6.abo.wanadoo.fr) |
| 19:22.53 | sunspots | Out of curiosity, what's the typical frequency of frames for say a single connect SIP channel using g711u? I'm curious as to how often this callback is being invoked. |
| 19:27.53 | seanbright | 20ms |
| 19:27.58 | sunspots | 50 frames a second sound about right? That across a couple hundred calls seems like a lot, for func_volume to setup and invoke a function 50 times a second just to increase/decrease the volume. Am I being too conservative here? |
| 19:28.01 | seanbright | unless i don't understand your question |
| 19:28.39 | sunspots | Sorry, I was speaking with file earlier about calling func_volume in my app as the best way to increase volume |
| 19:29.01 | seanbright | yes, 50 times a second (20ms * 50 = 1s) |
| 19:29.21 | sunspots | But what I don't like about func_volume is that it has to setup a call back function, which is called every frame, and then does some DTMF checks and then applies the gain. |
| 19:29.41 | seanbright | let me look |
| 19:29.45 | sunspots | Perhaps that's perfectly reasonable and I'm just being overly conservative |
| 19:29.56 | file | until it was profiled you can only guess the impact |
| 19:30.31 | seanbright | you're being overly conservative |
| 19:30.44 | sunspots | It works great btw. |
| 19:30.50 | seanbright | any audio manipulation is going to be expensive-ish |
| 19:30.58 | seanbright | because math |
| 19:31.02 | sunspots | Right |
| 19:32.39 | sunspots | Well thanks for taking a look, both of you. I'm going to need to do some bench marking here regardless. No reason I can't test with and without. |
| 19:32.51 | seanbright | do you have the volume change flags enabled? |
| 19:32.59 | seanbright | (the 'p' option) |
| 19:33.19 | sunspots | No, unless it's on by default (don't believe it is) |
| 19:33.28 | seanbright | ok, so then it's not doing a dtmf check |
| 19:33.39 | sunspots | I'm calling pbx_builtin_setvar_helper(chan,"VOLUME(TX)",gain); |
| 19:34.45 | sunspots | Yes, you're right. It's just checking the datastore for the option. |
| 19:35.04 | seanbright | if you were to profile, my guess is that most of the time spent in volume_callback() would be at the call to ast_frame_adjust_volume() |
| 19:35.30 | sunspots | because math |
| 19:35.38 | seanbright | yes. |
| 19:36.36 | sunspots | Yeah. Well you guys put my mind at ease. I appreciate it. Time for testing! |
| 19:44.07 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-nwvxgazuyspihbbb) |
| 19:44.07 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 20:02.12 | *** join/#asterisk-dev oej (~oej@dd5fb47a0.static.telenet.be) |
| 20:02.12 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:11.25 | *** join/#asterisk-dev tuxd00d (~tuxd00d@71-209-210-15.phnx.qwest.net) |
| 20:13.17 | *** join/#asterisk-dev oej (~oej@dd5fb47a0.static.telenet.be) |
| 20:13.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:45.27 | *** join/#asterisk-dev tuxd00d (~tuxd00d@71-209-210-15.phnx.qwest.net) |
| 22:02.53 | *** join/#asterisk-dev tzafrir (~tzafrir@91.183.149.106) |
| 22:02.53 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:04.13 | *** join/#asterisk-dev tuxd00d (~tuxd00d@172.56.17.145) |
| 22:17.32 | *** join/#asterisk-dev oej (~oej@dd5fb47a0.static.telenet.be) |
| 22:17.32 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 22:18.56 | *** join/#asterisk-dev sh_smith (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 22:56.46 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-nwvxgazuyspihbbb) |
| 23:06.10 | *** join/#asterisk-dev tzafrir (~tzafrir@91.183.149.106) |
| 23:06.10 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:20.16 | *** part/#asterisk-dev yorick (~yorick@oftn/oswg-member/yorick) |