| 05:37.26 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-13.wall.uls.co.za) |
| 05:56.31 | *** join/#asterisk-dev skrusty (~skrusty@88.150.145.104) |
| 05:56.31 | *** mode/#asterisk-dev [+o skrusty] by ChanServ |
| 06:34.41 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 06:34.41 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:47.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00ec0e82be5ebddeb0.ipv6.abo.wanadoo.fr) |
| 06:58.25 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:13.53 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.182.47) |
| 07:25.16 | *** join/#asterisk-dev oej (~oej@87.96.134.129) |
| 07:25.16 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:54.06 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:04.46 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 08:04.46 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:15.19 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:15.19 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:16.58 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:19.58 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:34.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 09:02.34 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:05.29 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 11:06.47 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 11:30.53 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-130-192.try.wideopenwest.com) |
| 11:30.53 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 12:30.07 | *** join/#asterisk-dev cbeyerlein (~cbeyerlei@huckebein.pecudis.de) |
| 12:32.28 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 13:18.47 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 15:09.07 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-cfcsihcwputbhmgu) |
| 15:27.56 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-rtjfgdxeonpoldlr) |
| 15:27.56 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:44.53 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vdksioyulklbgctl) |
| 15:44.53 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 16:19.36 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 16:23.47 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-cakrkvmuqpohoyjz) |
| 16:23.47 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:25.08 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 16:25.08 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 16:33.25 | *** join/#asterisk-dev sgriepentrog (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 16:53.15 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 17:49.52 | file | rmudgett: could the statsd thing have caused an incorrect count? |
| 17:51.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00c1466343fc0bc85f.ipv6.abo.wanadoo.fr) |
| 17:51.49 | rmudgett | file: Incorrect count? It would -1 registered and then +1 registered. Thus leaving the registered count the same. |
| 17:51.59 | file | ack |
| 17:53.04 | rmudgett | Though in the case of the testsuite test it was extra unregistered events -1 unregistered +1 unregisterd that throws off the expected events the test is looking for. |
| 17:56.32 | file | merci |
| 17:56.48 | rmudgett | Those extra events may or may not be there because of timing. |
| 18:10.23 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 18:10.43 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 18:22.25 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 18:33.00 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 18:35.40 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 18:42.29 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 18:42.29 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:55.54 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 18:55.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:21.58 | *** join/#asterisk-dev Gugge_ (gugge@92.246.2.105) |
| 19:26.28 | *** join/#asterisk-dev _skrusty (~skrusty@88.150.145.104) |
| 19:26.28 | *** mode/#asterisk-dev [+o _skrusty] by ChanServ |
| 20:01.58 | cresl1n | knocks on the walls |
| 20:02.28 | file | cresl1n: you break it you pay to relace it |
| 20:02.30 | file | er replace |
| 20:02.38 | cresl1n | ok |
| 20:02.58 | cresl1n | So, I have a question |
| 20:04.41 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 20:06.32 | file | a rather non-existent question it seems |
| 20:07.49 | cresl1n | returns |
| 20:08.08 | cresl1n | On https://gerrit.asterisk.org/#/c/4325/4 |
| 20:08.19 | file | yes! |
| 20:08.29 | cresl1n | Should he need to write tests for his change or not? |
| 20:08.46 | cresl1n | I draw on the experience of the crowd for this one |
| 20:08.47 | file | technically? yes |
| 20:08.49 | cresl1n | it is a change against 13 |
| 20:09.20 | cresl1n | Although the programmer in me says that it's extremely low risk |
| 20:09.30 | cresl1n | I think the letter of the law is that he must |
| 20:09.38 | cresl1n | has to remember to hold the line |
| 20:09.47 | file | when it comes to app_queue in particular... one really should |
| 20:09.52 | cresl1n | Ok |
| 20:10.14 | cresl1n | That was my natural response as well |
| 20:17.31 | cresl1n | Also, with regards to https://gerrit.asterisk.org/#/c/4000/ |
| 20:17.42 | cresl1n | We should probably close it at this point, no? |
| 20:17.50 | file | looks at date |
| 20:17.51 | file | yes |
| 20:17.54 | cresl1n | Since we've already cut the last bug fix release of 11 |
| 20:18.11 | cresl1n | I'll see if I can catch torrey on facebook and break the news to him |
| 20:18.13 | file | approves of cresl1n doing this stuff |
| 20:18.20 | cresl1n | heh |
| 20:18.29 | file | usually does it on a weekend when he's bored |
| 20:18.40 | cresl1n | Are you giving me a bad time for being in the webinar hole for a business week? |
| 20:18.43 | cresl1n | :-P |
| 20:18.54 | file | no! |
| 20:18.58 | cresl1n | :-) |
| 20:19.03 | file | would you like me to? |
| 20:19.09 | cresl1n | You can if you'd like |
| 20:19.16 | cresl1n | I would deserve it |
| 20:19.19 | file | too much effort involved |
| 20:19.25 | cresl1n | still learning to balance all priorities at the same time |
| 20:20.07 | file | if you glue them they can't fall |
| 20:20.35 | cresl1n | I like that. |
| 20:24.12 | cresl1n | To get rid of a review, do I just need to -2 it? |
| 20:24.52 | file | you click "Abandon" |
| 20:24.59 | file | and then write in a comment why, if still applicable |
| 20:26.15 | cresl1n | Thanks |
| 20:26.25 | cresl1n | I sent him a more detailed message on facebook as well |
| 20:26.59 | file | cresl1n: ice cream? |
| 20:28.23 | cresl1n | mountain dew. |
| 20:29.44 | cresl1n | rmudgett, coreyfarrell, file, what are your thoughts on https://gerrit.asterisk.org/#/c/4013/ |
| 20:30.13 | file | I don't really have one... if it can contain what is needed and is useful in some way then sure... |
| 20:30.25 | cresl1n | that's kind of what I was thinking |
| 20:30.28 | cresl1n | like it can't hurt |
| 20:30.37 | cresl1n | pokes rmudgett |
| 20:30.46 | file | only thing is keeping it up to date |
| 20:30.55 | cresl1n | I guess that's true for most anything |
| 20:31.54 | rmudgett | cresl1n: I'm not sure how useful that list would really be. |
| 20:32.02 | cresl1n | go on... |
| 20:32.21 | cresl1n | Seems like he found it to be useful |
| 20:32.28 | cresl1n | But I want to hear your thoughts |
| 20:33.07 | rmudgett | It is currently even incomplete and isn't it the purpose of the install_prereq script to install the modules. |
| 20:34.24 | cresl1n | Could you reply to response then "Well, the requirements.txt is more for Python Env, using like virtualenv. You can use without install Python dependencies into the global system." |
| 20:36.49 | cresl1n | s/to response/to the response/ |
| 20:37.15 | rmudgett | That made no sense to me anyway. |
| 20:37.29 | cresl1n | Could you reply to his response on the review? |
| 20:37.31 | cresl1n | "Well, the requirements.txt is more for Python Env, using like virtualenv. You can use without install Python dependencies into the global system." |
| 20:37.34 | cresl1n | that's what he said |
| 20:37.41 | cresl1n | in response to your last comment |
| 20:38.12 | rmudgett | He's just adding a simple text file that is likely to be ignored anyway. |
| 20:38.21 | rmudgett | I'm for just abandoning it. |
| 20:38.30 | cresl1n | heh |
| 20:38.39 | coreyfarrell | if it doesn't install the python modules required to run './runtests.py -l' then I don't see the point (and in that case the file is just clutter) |
| 20:39.12 | cresl1n | That's fair |
| 20:40.23 | rmudgett | See a perfect reason to abandon that review. :) |
| 20:40.44 | coreyfarrell | I'm also not a fan of adding a files to the root path for random package management software. |
| 20:42.24 | cresl1n | Alright, I tried to sum up your response as a comment on the review |
| 20:42.31 | cresl1n | if he doesn't say anything we'll abandon the review |
| 20:53.35 | *** join/#asterisk-dev libardi (~kvirc@179.159.9.234) |
| 22:44.34 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |