| 00:04.52 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-rasxrknsyozhsoqc) |
| 00:07.11 | *** join/#asterisk-dev Dovid (~dovid@ool-4573a525.dyn.optonline.net) |
| 00:57.14 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 00:57.14 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 02:46.52 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 02:52.53 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 05:32.42 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 06:29.42 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 06:57.10 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:08.26 | *** join/#asterisk-dev acao (~acao@2602:306:83a7:4d70:15cb:47f6:909c:554e) |
| 07:23.48 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 07:32.10 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:34.16 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 07:42.59 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:03.45 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:03.45 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:07.44 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:48.25 | *** join/#asterisk-dev Dovid (~dovid@ool-4573a525.dyn.optonline.net) |
| 13:19.06 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 14:34.08 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 14:34.08 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:40.05 | *** join/#asterisk-dev Dovid (~dovid@ool-4573a525.dyn.optonline.net) |
| 15:06.34 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-jzpbkrkewpxuyady) |
| 15:06.34 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:55.45 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 16:11.57 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-nwrtbhjllffhanid) |
| 16:11.57 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:15.09 | *** join/#asterisk-dev acao (~acao@104-58-116-215.lightspeed.bcvloh.sbcglobal.net) |
| 16:32.55 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 17:13.10 | *** join/#asterisk-dev libardi (~kvirc@187.64.232.60) |
| 17:43.52 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 18:19.47 | coreyfarrell | file: you have a minute to talk about the tcptls.c change? I'm not 100% sure but it might still break the ABI. |
| 18:20.28 | file | Not really? |
| 18:20.52 | file | Which change? |
| 18:20.58 | file | The reload one? |
| 18:21.20 | coreyfarrell | yep the reload. if you don't have time don't worry. I'll write something up and -1 it. |
| 18:21.24 | file | https://usercontent.irccloud-cdn.com/file/wkls9Z2w/irccloudcapture1036321065.jpg |
| 18:21.33 | file | That is why my answer was not really |
| 18:21.59 | coreyfarrell | enjoy your day :) |
| 18:23.25 | file | Now I can |
| 18:23.34 | file | I reached my destination, for the moment |
| 18:24.50 | file | So! Breaking ABI? |
| 18:25.23 | coreyfarrell | yes. looks like it's unsafe to make any modification to 'struct ast_tls_config' or 'struct ast_tcptls_session_args'. |
| 18:26.30 | file | Argh |
| 18:26.42 | file | Because of embedding directly in a structure? |
| 18:26.54 | coreyfarrell | hmmm.. looks like chan_sip is the only module that uses them as 'static struct ast_tls_config ...' |
| 18:27.08 | file | Yeah... Hum |
| 18:27.16 | file | I do dislike public structures |
| 18:27.27 | coreyfarrell | agreed |
| 18:28.05 | file | I don't think there would be any other external usage... |
| 18:29.02 | file | So while it technically breaks ABI potentially I'm not sure the real world would care, but that's just me |
| 18:31.45 | coreyfarrell | probably right. is this something for the CHANGES file or meh? |
| 18:32.25 | file | Generally changes are for user facing, it may be worth bringing up on Dev just to get feelings |
| 18:33.15 | file | There's no rush to get it in so if no one has anything to say next week we can move forward |
| 18:34.08 | file | How does manager and crew use it? |
| 18:37.08 | coreyfarrell | static. but that doesn't matter because you can't have mismatching manager.o / tcptls.o. |
| 18:37.35 | coreyfarrell | res_http_websocket does ao2_alloc for one of the structs. |
| 18:39.00 | coreyfarrell | app_externalivr also uses 'struct ast_tcptls_session_args' as a local variable in it's app_exec. |
| 18:39.15 | file | Yeah I was just curious. |
| 18:48.05 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 20:34.52 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 20:34.52 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:32.53 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 23:07.40 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 23:51.30 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-jzpbkrkewpxuyady) |
