| 00:03.46 | *** join/#asterisk-dev raspberrypifan (~raspberry@cpe-66-108-70-5.nyc.res.rr.com) |
| 00:20.34 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 00:52.46 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 01:15.06 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 01:24.06 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 02:26.21 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 03:27.46 | *** join/#asterisk-dev piling (~piling@unaffiliated/piling) |
| 03:54.30 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 04:03.58 | *** join/#asterisk-dev babak (uid19622@gateway/web/irccloud.com/x-yjifxdwdshdrzeme) |
| 06:05.35 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:21.07 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 06:38.20 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:51.18 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:7d32:4f6c:6083:a1b0) |
| 06:51.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:14.28 | *** join/#asterisk-dev raspberrypifan (~raspberry@cpe-66-108-70-5.nyc.res.rr.com) |
| 07:38.11 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 07:40.02 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 07:41.14 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 07:45.28 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:45.28 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:49.20 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 07:50.30 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:81aa:6c6c:cb1b:45ee) |
| 07:50.30 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:03.11 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 08:05.44 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:09.58 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 10:15.42 | *** join/#asterisk-dev piling_ (~piling@unaffiliated/piling) |
| 10:23.12 | *** join/#asterisk-dev zerohalo (~zerohalo@uranium.zerohalo.net) |
| 11:58.32 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:ac1c:3ce1:cd86:9b3b) |
| 11:58.32 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:18.17 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 12:35.55 | *** join/#asterisk-dev jkroon (~jkroon@dustpuppy.is.co.za) |
| 12:36.08 | gtjoseph | coreyfarrell: i wonder if it's time to create a min/pbx subdirectory. :) |
| 13:41.55 | *** join/#asterisk-dev oej (~oej@dhcp-b27d.meeting.ietf.org) |
| 13:41.55 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:54.05 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-ngdntgfudljkpubd) |
| 13:58.33 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:60b9:a73:e742:78e5) |
| 13:58.33 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:03.39 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 14:08.23 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:85b9:39b5:3219:fa45) |
| 14:08.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:11.35 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:85b9:39b5:3219:fa45) |
| 14:11.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:16.44 | *** join/#asterisk-dev oej (~oej@dhcp-b27d.meeting.ietf.org) |
| 14:16.45 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:23.22 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:23.23 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:24.11 | file | nods to cresl1n |
| 14:24.22 | cresl1n | waves to file |
| 14:29.56 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-jkazbxayrchwpsbo) |
| 14:29.56 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:30.09 | cresl1n | waves to mjordan |
| 14:30.16 | mjordan | waves to cresl1n |
| 14:31.49 | file | MAKE MJORDAN GREAT AGAIN! |
| 14:32.05 | mjordan | thought he was okay before |
| 14:32.23 | cresl1n | starts building a wall around him |
| 14:32.32 | mjordan | is okay with that, so long as it is yuge |
| 14:33.53 | file | thinks there are already walls around mjordan |
| 14:33.54 | Marquis42 | Oh it'll be the biggest, the best wall ever. |
| 14:34.06 | Marquis42 | It'll be unbelievable. |
| 14:34.18 | file | Who will pay for this wall? |
| 14:34.26 | cresl1n | Canada |
| 14:34.30 | file | Avaya? |
| 14:34.36 | Marquis42 | YES |
| 14:34.37 | cresl1n | Canada. |
| 14:34.39 | Marquis42 | Or Cisco |
| 14:34.42 | file | cresl1n, RUDE |
| 14:35.11 | cresl1n | Bell Canada? |
| 14:35.27 | file | no thanks |
| 14:35.28 | *** join/#asterisk-dev jkroon (~jkroon@dustpuppy.is.co.za) |
| 14:35.37 | Marquis42 | I'd say Nortel if they were still a going concern. |
| 14:36.03 | cresl1n | The lawn mowers keep breaking my concentration |
| 14:36.04 | Marquis42 | But then, Avaya did buy most of their enterprise telephony and network stuff, so... file wins. |
| 14:38.43 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vzrgwhogqhrxyamn) |
| 14:38.54 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:44.56 | file | mjordan, you are predictable |
| 14:52.13 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-zjkfbozzuojiqexz) |
| 14:54.18 | *** join/#asterisk-dev acidfu_ (~acidfoo@198-48-218-90.cpe.pppoe.ca) |
| 15:31.51 | tzafrir | Can someone look at https://issues.asterisk.org/jira/browse/ASTERISK-26213 and say if my patch makes sense?/ |
| 15:32.19 | tzafrir | I would have been more confident if I managed to reproduce it |
| 15:43.10 | *** join/#asterisk-dev oej (~oej@2001:67c:370:176:bd47:54f:445b:3f4d) |
| 15:43.10 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:45.16 | kharwell | tzafrir: It's always tricky on a crash like that to know whether or not a simple NULL check is sufficient. |
| 15:45.41 | kharwell | Admittedly I am quite unfamiliar with app_meetme (never worked with it). However I have to question why the channel is NULL here in the first place or how it got that way? |
| 15:45.49 | *** join/#asterisk-dev oej (~oej@dhcp-b27d.meeting.ietf.org) |
| 15:45.49 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:46.33 | tzafrir | If my guess is correct, user->chan is assigned almost right at the start. So checking it first and then acting should be safe. |
| 15:46.44 | tzafrir | But then again, this is speculation. |
| 15:46.46 | kharwell | Looking through the code for where the user's channel gets used and specifically set I see that within conf_run user-->chan is set to the given channel, but its reference is not bumped |
| 15:47.39 | kharwell | I wonder if bumping the channel reference there and then removing it on user destruction would be better? (not quite sure). If would at least mean the channel would not get pulled out from beneath the user at some point in time |
| 15:50.12 | kharwell | Like I said I'm not quite sure, but if no other responses here you can push it up to gerrit to get some more eyes on it |
| 15:53.32 | tzafrir | ok. Thanks. |
| 16:40.10 | file | gtjoseph, https://issues.asterisk.org/jira/secure/attachment/54157/backtrace_update.txt similar to what you were seeing from an OpenSSL level? |
| 16:40.23 | gtjoseph | looks |
| 16:41.05 | gtjoseph | that one is completely new to me |
| 16:41.56 | file | kk |
| 16:42.43 | gtjoseph | since recompiling and reinstalling i haven't seen an issue on my production pbx (3 days) |
| 16:44.01 | file | ack |
| 16:51.55 | *** join/#asterisk-dev mjordan (~mjordan@50.248.248.69) |
| 16:51.55 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 16:52.24 | coreyfarrell | gtjoseph: I'm not sure about a separate main/pbx directory.. if we were going to separate anything from main/*.c I think it would be better to create a 'libasteriskcore'.. something that would provide what utils/*.c needs, but without all the current nastiness. some pbx*.c stuff would be in, some would not. |
| 16:53.10 | gtjoseph | ah, that's a good idea |
| 16:53.22 | coreyfarrell | gtjoseph: not sure it's even possible to do that, but anyways I don't see main/pbx*.c as a 'single unit' that goes together. |
| 16:54.13 | gtjoseph | maybe we should have chosen a better prefix when we split that stuff up initially. :) |
| 16:55.30 | mjordan | I'd almost prefer to just remove the things in utils that try to link against Asterisk in the first place |
| 16:55.49 | file | mjordan, +1 |
| 16:55.56 | mjordan | I know there's a few people who still use the ael tools, but really, it feels like there's been a massive maintenance burden created for a very small percentage of the user base |
| 16:56.57 | gtjoseph | yeah, especially touching things like ao2 which gets copied into utils is a pain. |
| 16:56.58 | Marquis42 | +1. I'd have preferred (well, before ARI...) to have AEL level up a bunch and get more awesome. But alas, as it is I agree it's a maintenance burden for not much use. |
| 16:58.08 | coreyfarrell | the worst part of utils/*.c is the stuff that doesn't get copied from main. like the code to manage ast_context, ast_exten, etc.. |
| 16:58.57 | coreyfarrell | but I'm 100% behind using an incinerator on utils.. |
| 17:00.07 | coreyfarrell | mjordan: while you're here I wanted to ask, on what distro did you do run the clang scan-build? |
| 17:00.09 | gtjoseph | policy questrion: If someone is amking a change to chan_sip (https://gerrit.asterisk.org/3234) should we also ask that they review chan_pjsip for applicability? |
| 17:03.13 | file | chan_pjsip already supports it, using a config option |
| 17:03.20 | file | but generally it's nice to |
| 17:03.27 | coreyfarrell | I vote for no! beyond the most basic bugs I would not touch chan_pjsip because I don't know jack about it. |
| 17:03.54 | file | yeah I wouldn't say it's mandatory, but mentioning it is fine |
| 17:04.18 | coreyfarrell | +1 yeah I'd say something here to prompt someone who knows pjproject to look into it |
| 17:05.23 | gtjoseph | yeah i'm not suggesting that the submitter HAS to investigate to fix butr mentioning it on the review might be good especially if it's something like sdp that doiesn't touch pjproject. |
| 17:05.33 | gtjoseph | investigate OR fix |
| 17:06.59 | mjordan | coreyfarrell: mint |
| 17:07.49 | gtjoseph | well, i was going to start on rmudgett's patch series but i think i'll have lunch first. :) |
| 17:08.46 | file | gtjoseph, bundled pjproject doesn't turn on -g when you --enable-dev-mode does it? |
| 17:09.21 | gtjoseph | just --enable-dev-mode? it'd better not unless it's also added to the asterisk CFLAGS |
| 17:10.34 | file | I was just wondering if we have any method to have someone turn on symbols for pjproject |
| 17:10.35 | gtjoseph | are you seeing an issue? |
| 17:10.57 | gtjoseph | oh, yeah. bundled respects DONT_OPTIMISE |
| 17:11.22 | file | https://issues.asterisk.org/jira/secure/attachment/54147/backtrace_2016-07-18_16-15.txt cause not exactly useful to me, my kingdom for line numbers and further details |
| 17:11.46 | gtjoseph | better backtraces works as well |
| 17:11.54 | file | can you comment as such? |
| 17:11.59 | gtjoseph | will do |
| 17:12.42 | gtjoseph | oh, no i cant. what's the issue number? |
| 17:12.44 | coreyfarrell | mjordan: cool. have you tried running a clang build on mint yet? I have a patch to make clang build on Fedora but the executable fails with a bunch of runtime checks added by clang. |
| 17:13.47 | gtjoseph | file: ^^ issue number? |
| 17:14.01 | file | ASTERISK-26209 |
| 17:14.02 | mjordan | coreyfarrell: pretty sure I did a long time ago, when we first worked with the patch submitted (Diederick, I think)? But that was over a year and a half ago at least. |
| 17:14.10 | mjordan | I haven't in any recent time period |
| 17:21.21 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 17:21.21 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:13.12 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 18:20.24 | *** join/#asterisk-dev piling (~piling@unaffiliated/piling) |
| 19:33.42 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 19:37.14 | *** join/#asterisk-dev kasanop (~kasanop@ivanpoddubny.com) |
| 20:01.52 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 20:15.08 | file | ugh |
| 20:15.32 | file | gtjoseph, I can't... merge those |
| 20:15.48 | gtjoseph | what's the problem? |
| 20:15.57 | file | a -1 prevents it |
| 20:16.15 | file | you either have to modify/unmodify to make it a fresh thing and ensure it is not verified and merge it then... |
| 20:16.24 | file | or push it manually |
| 20:16.40 | gtjoseph | we're talking about the cherry picks to cert/11.6 right? |
| 20:16.45 | file | yes |
| 20:17.21 | file | huh, it removed it? |
| 20:17.49 | file | why did it do that on that one review... |
| 20:18.08 | gtjoseph | that's strange |
| 20:18.31 | gtjoseph | well, let me see why zuul was unhappy in the first place |
| 20:18.48 | file | 11.6 on the Jenkins nodes hates the world |
| 20:21.47 | gtjoseph | i'm going top abandon them and resubmit 1 at a time |
| 20:23.46 | file | if you can get 'em up as new reviews I shall do the stuff |
| 20:26.40 | *** join/#asterisk-dev klow (~textual@96.81.150.137) |
| 20:26.56 | file | er |
| 20:27.01 | file | gtjoseph, https://gerrit.asterisk.org/#/c/3265/ wat |
| 20:27.19 | gtjoseph | what about it? |
| 20:27.40 | file | that's a GCC fix? |
| 20:27.51 | file | SayNumber in Polish? |
| 20:27.55 | gtjoseph | actually yeah. the original code complains about an array underflow |
| 20:28.07 | gtjoseph | your fix also fixed the underflow |
| 20:28.23 | file | oh good lord it failed already |
| 20:28.29 | file | I'll deal with that all tomorrow morning |
| 20:29.10 | gtjoseph | wtf?? pval.c:5941:1: error: error writing '/dev/null.gcno' [-Werror] |
| 20:31.16 | file | do you only need those two? |
| 20:31.51 | gtjoseph | no the rest as well |
| 20:31.56 | gtjoseph | the 4 i abandoned |
| 20:34.32 | gtjoseph | oh god. just found a few more. 11.6-cert is REALLY behind 11 |
| 20:34.45 | file | yes. |
| 20:38.49 | coreyfarrell | gtjoseph: about /dev/null.gcno that's something I fixed a long time ago, it happens when double-compile and GCC profiling is enabled. |
| 20:39.46 | gtjoseph | well that sucks if even jenkins can't build 11.6-cert |
| 20:45.06 | coreyfarrell | gtjoseph: see commit e55b96ad5 (that was merged to 11) |
| 20:45.21 | gtjoseph | thanks |
| 20:45.27 | gtjoseph | i'll see if i can cherry pick it |
| 20:45.43 | gtjoseph | was that pre or post git do you know? |
| 20:46.06 | coreyfarrell | reviewboard link in the commit msg |
| 20:46.20 | gtjoseph | :) |
| 20:47.10 | coreyfarrell | only modifies 10 lines in Makefile.rules, pretty simple patch. |
| 20:50.23 | gtjoseph | i guess i'm going to have to fire up my centos6 vm to compile this "thing" |
| 20:51.22 | coreyfarrell | gtjoseph: in 11.6 I'm pretty sure the offending combo is ./configure --enable-dev-mode --enable-coverage |
| 20:51.54 | gtjoseph | yep but there's other gcc5 and gcc6 stuff preventing me from compiling |
| 20:52.00 | gtjoseph | i've got to get past that first |
| 20:52.39 | coreyfarrell | gcc fails when coverage is enabled and output is /dev/null. it won't work on any version of gcc without fixing that issue or changing the gerrit configure options. |
| 21:03.25 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 21:18.20 | file | cresl1n, what comes after 13? |
| 21:20.30 | cresl1n | 25 |
| 21:21.02 | cresl1n | file: did I make a mistake on my email? |
| 21:21.03 | file | cresl1n, hrm... not quite - we'll work on your math skills! |
| 21:21.10 | file | no? |
| 21:21.23 | cresl1n | good |
| 21:21.32 | cresl1n | was worries I mistyped a version number |
| 21:21.38 | file | nah |
| 21:25.29 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 21:26.30 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 21:27.28 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 21:28.33 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 21:30.01 | coreyfarrell | gtjoseph: 3267 doesn't include 3268 |
| 21:30.22 | gtjoseph | grrrrrrrrrrrrrrrrr |
| 21:34.55 | gtjoseph | let's see if just re-ordering the commits and re-submitting will amke it work |
| 21:35.40 | gtjoseph | with my luck it wont and i'll have to abandon the reviews and re-commit with new change ids. |
| 21:35.51 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 21:39.41 | coreyfarrell | utils are awesome, we should have a lot more of them |
| 21:39.56 | gtjoseph | :)))) |
| 21:58.40 | rmudgett | Those gcc fixes may have to just be forced in |
| 21:58.53 | gtjoseph | i'm not giving up yet |
| 21:59.13 | rmudgett | Gerrit seems to be guarding its stupidity very well |
| 21:59.56 | gtjoseph | it's not gerrit, it the fact that sometimes it builds on ubuntu14 and other times it's centos6 |
| 22:05.31 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 22:52.12 | *** join/#asterisk-dev raspberrypifan (~raspberry@cpe-66-108-70-5.nyc.res.rr.com) |
| 23:09.22 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-ngdntgfudljkpubd) |
| 23:30.51 | *** join/#asterisk-dev nix8n82 (~AndChat56@67-130-74-235.dia.static.qwest.net) |
| 23:58.55 | *** join/#asterisk-dev babak (uid19622@gateway/web/irccloud.com/x-awfkcregdvxfsefa) |