| 00:48.50 | *** join/#asterisk-dev acidfu_ (~acidfoo@198-48-218-90.cpe.pppoe.ca) |
| 01:15.42 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 01:15.42 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 01:26.53 | *** join/#asterisk-dev raspberrypifan (~raspberry@2604:2000:6016:be00:6355:b61:14e7:dbba) |
| 04:19.19 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 05:00.54 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:17.00 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 06:17.00 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:24.15 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip72-201-239-241.ph.ph.cox.net) |
| 06:52.02 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:58.29 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:01.07 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:01.07 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:01.14 | *** join/#asterisk-dev doome_ (~doome@82.150.48.146) |
| 08:35.57 | *** join/#asterisk-dev oej (~oej@46-22-127-214.bredband.alvsjo.qonet.se) |
| 08:35.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:41.21 | *** join/#asterisk-dev stefan27 (~stefan27@212.247.4.149) |
| 10:59.05 | *** join/#asterisk-dev oej (~oej@46-22-127-214.bredband.alvsjo.qonet.se) |
| 10:59.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:44.52 | *** join/#asterisk-dev acidfu_ (~acidfoo@modemcable002.114-70-69.static.videotron.ca) |
| 12:19.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 12:37.09 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:37.09 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:43.56 | *** join/#asterisk-dev WIMPy (~wimpy@85.183.95.26) |
| 12:46.03 | *** join/#asterisk-dev libardi (~kvirc@187.64.235.154) |
| 13:03.21 | *** join/#asterisk-dev luckman212_ (~luckman21@unaffiliated/luckman212) |
| 13:35.01 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-zkknfzvpikokgyxe) |
| 13:35.01 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:05.52 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-etrdyrljxulqucik) |
| 14:25.35 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:25.35 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:28.29 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-sfoaiwatfxnlxgbz) |
| 14:31.30 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:31.30 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:10.24 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 15:16.12 | file | so I've isolated one of the random crashes at shutdown to the fact that res_pjsip_session is unloaded and afterwards a transaction timer calls into the INVITE session code which then invokes a res_pjsip_session callback |
| 15:16.35 | file | that itself is actually fine - however the callback tries to get the session from the INVITE session using the module ID, which since it's unregistered... is now -1 |
| 15:17.08 | file | I can add a check, however it just lowers the window |
| 15:17.57 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 15:18.55 | gtjoseph | why does it only lower the window? |
| 15:19.29 | file | if I stored the module id I suppose it would be fine |
| 15:20.09 | gtjoseph | isn't the module id already on the registration structure? |
| 15:20.25 | file | it is, it is changed to -1 on unregister |
| 15:20.26 | gtjoseph | or is that gone at this point? |
| 15:21.08 | gtjoseph | then why do you need to store it again? If it's -1, bail. |
| 15:21.27 | file | because the other thread could change it after I check? |
| 15:21.38 | file | it's a narrow window, mind you |
| 15:22.28 | gtjoseph | dialog lock? |
| 15:22.47 | file | the dialog is locked, but that doesn't stop the module from doing its stuff |
| 15:24.08 | gtjoseph | pre-locked when the callback is called? If so, the pjproject timer isn't going to mess with it. |
| 15:24.30 | file | it doesn't matter that the dialog is locked or unlocked |
| 15:24.35 | file | res_pjsip_session can still be unloaded |
| 15:24.48 | file | in that case |
| 15:25.38 | gtjoseph | Oh, the unload thread is what you're talking about |
| 15:25.41 | gtjoseph | gotcha |
| 15:25.43 | file | yes |
| 15:27.35 | gtjoseph | the only thing i can think of is a global rwlock that you rdlock on the callback and wrlock in unload_module |
| 15:28.29 | file | I'll just store the current value, if it's -1 then bail, if it's not then use that |
| 15:29.51 | gtjoseph | you'd still have the narrow window though. |
| 15:30.00 | gtjoseph | although tiny |
| 15:30.35 | file | if I store the value and don't use the module ID directly, then it won't change |
| 15:31.00 | gtjoseph | store it where? |
| 15:31.14 | file | as a variable inside the callback |
| 15:51.30 | stefan27 | your asterisk blog has some interesting topics once in a while |
| 15:51.40 | file | gtjoseph, Alexei asks for an explanation on your comment |
| 15:51.43 | file | stefan27, it's not bad! |
| 15:51.45 | stefan27 | the 13.9.0 registration bug was pretty cool :) |
| 15:52.04 | gtjoseph | looks |
| 15:54.25 | stefan27 | Also the people that write the blog entries seem to have excellent English skills, unlike me! |
| 16:01.58 | stefan27 | I hope each release solves more issues than it produces - We're planning on upgrading all asterisks from 13.5.0 soon. It's nice to get a batch of fixes |
| 16:03.41 | stefan27 | but from the upgrade mails, I couldn't find anything critical to us in 13.6 to 13.9.1 notes |
| 16:16.24 | file | stefan27, we try! a lot of the regressions lately are... weird ones |
| 16:27.05 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip72-201-239-241.ph.ph.cox.net) |
| 16:40.55 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d005c0f0b3d6f46d76d.ipv6.abo.wanadoo.fr) |
| 16:41.06 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 16:55.08 | putnopvut | Funny story on https://issues.asterisk.org/jira/browse/ASTERISK-26128 |
| 16:55.21 | putnopvut | I'm actually getting alembic failures, but even earlier. So cool beans |
| 16:55.40 | file | older alembic? |
| 16:56.07 | putnopvut | Hm, maybe? |
| 16:56.15 | putnopvut | I can attempt upgrading and see what happens. |
| 16:56.26 | gtjoseph | shouldn't need to though. |
| 16:56.29 | putnopvut | I'm getting "sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) constraint "id" of relation "ps_contacts" does not exist |
| 16:56.29 | putnopvut | <PROTECTED> |
| 16:56.29 | putnopvut | " |
| 16:56.30 | gtjoseph | what database? |
| 16:56.35 | putnopvut | Postgres |
| 16:56.45 | gtjoseph | oh yeah, i got that as well |
| 16:56.51 | putnopvut | Problem is in 81b01a191a46_pjsip_add_contact_reg_server.py |
| 16:56.56 | gtjoseph | yep |
| 16:57.03 | gtjoseph | did i not mention that in the issue? |
| 16:57.23 | putnopvut | Nope. The issue mentions two other files |
| 16:57.40 | gtjoseph | sorry. |
| 16:57.41 | putnopvut | But not to worry. I can get this fixed up |
| 16:57.43 | file | gtjoseph, you lose 1 gold coin for filing an incomplete report |
| 16:58.09 | gtjoseph | that puts me at -4398754390873089756 instead of 4398754390873089755 |
| 16:59.06 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 17:05.31 | putnopvut | Heh, alembic's documentation site appears to be having issues. I get permission denied when I try to go to it. |
| 17:05.37 | putnopvut | Today has turned more interesting |
| 17:09.35 | file | putnopvut, ooh |