| 01:46.22 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 02:24.20 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 03:33.09 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 03:34.44 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 05:33.24 | *** join/#asterisk-dev fornax (~fornax@85.183.43.221) |
| 06:54.24 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:34.44 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:34.44 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:01.03 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 12:29.46 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:41.00 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-ybtwyzidvuaupnnp) |
| 13:30.37 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-qyxktokfhtlnxxnv) |
| 13:38.42 | gtjoseph | it's only 7:38am and I'm already on my 3rd Coke. It's going to be a long day. :) |
| 13:40.11 | file | well, at least it's not alcohol? |
| 13:41.03 | gtjoseph | :) |
| 13:41.17 | file | unless you are mixing |
| 13:41.37 | gtjoseph | those days are LONG gone. |
| 13:41.59 | gtjoseph | actually working on something you might be interested in... |
| 13:42.00 | file | unless time is a circle in which case they'll be back |
| 13:42.14 | gtjoseph | a irc client to tapchat bridge |
| 13:42.29 | file | I use a proxy |
| 13:42.41 | gtjoseph | which one? |
| 13:42.47 | file | Laptop -> ZNC, Tapchat -> ZNC, Desktop -> ZNC |
| 13:42.58 | gtjoseph | Ah. |
| 13:44.02 | file | likes to move around without disturbing the channels he is in |
| 13:44.19 | gtjoseph | exactly my thought |
| 13:45.09 | *** join/#asterisk-dev acidfoo_ (~acidfoo@modemcable002.114-70-69.static.videotron.ca) |
| 13:55.20 | seanbright | gtjoseph: full-fat coke? |
| 13:55.31 | gtjoseph | oh yes. |
| 13:55.42 | seanbright | good man |
| 13:56.00 | seanbright | no matter what people try to tell us, we both know that coke zero is NOT the same |
| 13:56.29 | gtjoseph | none of that artificially sweetened, caffeine free stuff for me. |
| 13:57.36 | seanbright | agreed |
| 13:57.50 | seanbright | that stuff'll kill you |
| 13:58.21 | gtjoseph | :) |
| 14:06.50 | [TK]D-Fender | Except for the actual proof that itt's killed anyone... |
| 14:07.10 | [TK]D-Fender | Not counting that guy who fell into the mixing vat and drowned of course... |
| 14:07.31 | file | everything is killing us |
| 14:08.30 | [TK]D-Fender | Life is a sexually transmitted disease which is in all cases ... fatal. |
| 14:08.46 | [TK]D-Fender | If you're reading this you're already fucked |
| 14:11.56 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 14:11.58 | seanbright | very deep |
| 14:13.16 | seanbright | maybe this helps to explain my existential crisis |
| 14:14.57 | seanbright | lays on the couch |
| 14:18.11 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-qsdphkhqriidcxdl) |
| 14:30.52 | *** join/#asterisk-dev pc-m (~user@modemcable094.94-70-69.static.videotron.ca) |
| 14:34.08 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:34.08 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:54.37 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-jiziggkxptorqrsc) |
| 16:08.42 | tm1000 | rmudgett: yo |
| 16:08.53 | rmudgett | yo |
| 16:09.04 | tm1000 | nevermind heh |
| 16:09.15 | tm1000 | I was going to say something that proved I cant read |
| 16:09.17 | tm1000 | so ignroe |
| 16:09.35 | tm1000 | rmudgett: do I need to do the cherry-pick? |
| 16:10.09 | rmudgett | You should |
| 16:13.01 | tm1000 | rmudgett: whats the patch you just did? |
| 16:13.30 | rmudgett | To what are you referring? |
| 16:13.57 | tm1000 | rmudgett: it says you did patch7 |
| 16:14.05 | tm1000 | also it refuses to cherry pick from the gui |
| 16:14.15 | tm1000 | "git review 13" |
| 16:14.23 | file | he did a -1 against patch set 6 |
| 16:14.24 | tm1000 | err |
| 16:14.25 | tm1000 | "Change 2417 is closed" |
| 16:14.31 | file | you uploaded patch set 7 |
| 16:14.43 | tm1000 | file: ah |
| 16:14.45 | tm1000 | he has to approve |
| 16:14.49 | tm1000 | (right?) |
| 16:15.12 | file | anyone can approve |
| 16:15.38 | file | I have restored 2417 |
| 16:15.45 | file | it's when you accidentally put it up against master |
| 16:15.49 | file | cherry pick will work now |
| 16:15.50 | rmudgett | You also wiped out file's issue reference in the commit message |
| 16:15.54 | tm1000 | ah |
| 16:15.55 | tm1000 | yeah |
| 16:15.59 | tm1000 | thanks guys! |
| 16:16.01 | file | I fixed that already |
| 16:16.21 | tm1000 | its always nice being able to do quick patches when the Digium team is willing to walk people through it. Much appreciated!!!! |
| 16:21.19 | file | falls over |
| 17:26.47 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 18:07.21 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-gjnozvdewcfwlloy) |
| 18:07.21 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 18:12.06 | file | gtjoseph, RUN. AWAY. NOW. |
| 18:12.26 | gtjoseph | :) |
| 18:13.03 | gtjoseph | it's hard looking at those patches out of context |
| 18:13.12 | file | it's hard looking at those patches even with context |
| 18:13.47 | gtjoseph | i figure i owe rmudgett |
| 18:18.36 | rmudgett | All those patches are so you don't get lost when everything happens at once. A single patch file would be 94K |
| 18:18.56 | rmudgett | if it were all in one patch |
| 18:19.03 | gtjoseph | well considering chan_sip.c is over 32k lines... |
| 18:20.25 | rmudgett | I'll refresh the patch series later to address any comments. I've already seen a few from coreyfarrell |
| 18:21.31 | gtjoseph | yeah looks like sometimes the caller has to schedule, then call directly on failure and sometimes the direct call wrapper does it |
| 18:23.27 | gtjoseph | rmudgett: hey one question on 2396... |
| 18:23.53 | rmudgett | k |
| 18:24.02 | gtjoseph | new line 23690 does the sched then the next line does sip_scheddestroy() |
| 18:24.21 | gtjoseph | does the destroy drain first? |
| 18:26.27 | rmudgett | I made the sched execute events in the order posted when they expire at the same time. So the destroy would happen after the check_pendings |
| 18:26.37 | gtjoseph | oh, nevermind... scheddestroy doesn't destroy the scheduler, it schedules the destroy of the dialog |
| 18:32.42 | gtjoseph | rmudgett: got another one for ya... 2401... did you mean to NOT call the __functions if the sched failed? |
| 18:35.23 | rmudgett | Do you have a specific reference? The __functions that get scheduled won't get called if they cannot be scheduled. |
| 18:36.08 | gtjoseph | different pattern that the previous ones then where a fail to sched resulted in a direct call to the __functions |
| 18:36.15 | gtjoseph | s/that/than/ |
| 18:38.27 | file | passes the reigns to others for reviews as his brain is mush |
| 18:38.27 | rmudgett | The direct call only happens on one review. The others don't call direct if fail to sched |
| 18:38.42 | gtjoseph | ah, ok. it stuck in my mind. |
| 18:38.54 | file | like glue? |
| 18:39.19 | gtjoseph | well, there are other things that stick. :) |
| 18:39.21 | rmudgett | That one review was https://gerrit.asterisk.org/#/c/2392/ |
| 18:42.14 | rmudgett | These patches to chan_sip are long overdue. We've been kicking the can down the road for sooooo long because the sched API sucks. |
| 18:42.55 | rmudgett | That API was one of the earlier ones in Asterisk so it knows nothing about ao2 |
| 18:45.54 | tm1000 | this patch is nuts https://issues.asterisk.org/jira/browse/ASTERISK-13145 |
| 18:45.57 | tm1000 | 366 comments |
| 18:45.59 | tm1000 | W0W |
| 18:46.34 | file | yes. |
| 18:46.39 | tm1000 | file: also nasty |
| 18:46.54 | tm1000 | (user wanted us to put it into our release of Asterisk)... |
| 18:47.15 | file | due to the PJSIP architecture it could actually be done there completely isolated |
| 18:49.59 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 19:17.34 | tm1000 | patch is in git now yay! |
| 19:21.16 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 19:25.26 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 19:41.02 | *** join/#asterisk-dev lnxslck (~lnxslck@av3-84-90-162-98.netvisao.pt) |
| 19:52.59 | gtjoseph | mmmmm. starburst jelly beans. fake fruit never tasted so good. |
| 19:55.21 | file | who is to say that fruit is real? what if it's actually one big lie and is fake itself? |
| 19:55.42 | gtjoseph | now they taste even better! |
| 19:56.00 | file | the placebo effect! |
| 20:02.53 | rmudgett | I've refreshed my reviews to add verbiage to one of the commit messages. |
| 20:03.21 | rmudgett | file Looks like it may be random where is a series a merge may fail. |
| 20:03.40 | rmudgett | *in a series |
| 20:03.46 | file | that's... odd |
| 20:06.50 | rmudgett | It could also be the length of the series |
| 20:08.14 | gtjoseph | Oh NO! They're Back!! |
| 20:11.39 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 20:14.46 | rmudgett | hopes that the gerrit update will fix the series merge issue |
| 20:15.31 | file | I make no guarantees on ANYTHING |
| 20:20.48 | file | rmudgett, you may like this... we'll get an inline editor, so the entire commit can be edited not just the commit message |
| 20:21.34 | rmudgett | That might be useful. |
| 20:21.50 | file | so for quick fixes (whitespace / misspelling) it may prove useful |
| 20:22.30 | gtjoseph | as long as yo remember to pull the review back down again before making a local change. :) |
| 20:22.38 | file | yeah |
| 20:22.39 | rmudgett | Until the original poster reposts the review from their repository |
| 20:23.13 | file | c'est la vie |
| 20:23.49 | rmudgett | Thought it may not work very well for a patch series... |
| 20:24.15 | rmudgett | s/Thought/Though/ |
| 20:26.19 | file | should be a good upgrade |
| 20:27.28 | tm1000 | I was sort of suprised that didnt already exist in gerrit |
| 20:27.33 | tm1000 | (the inline editor) |
| 20:28.07 | file | it does, we're just on an older version |
| 20:41.58 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-ubnyawrhnzafeomj) |
| 20:41.58 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 20:42.21 | gtjoseph | Can someone give a quick look at 2355? |
| 20:45.14 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 20:51.34 | gtjoseph | Has anyone tried a 'git review -s' recently? Trying to set up a new repo and it's hanging. |
| 21:00.08 | *** join/#asterisk-dev stefan27 (~stefan27@212.247.4.149) |
| 21:03.52 | file | can't say I have, but it does appear to be upset |
| 21:04.16 | file | hopes the upgrade makes this stuff more reliable |
| 21:04.59 | file | it's always the SSH daemon... |
| 21:25.28 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 21:25.29 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:27.38 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 21:34.05 | rmudgett | I did a couple yesterday to setup my libpri and libss7 repositories |
| 21:35.55 | kharwell | gtjoseph: I've taken a look at 2355. It looks fine to me. I also downloaded the changes and ran a couple of tests in the testsuite. They seemed to run okay when Asterisk was configured and not configured with bundled support. |
| 21:36.10 | gtjoseph | cool, thanks! |
| 21:36.25 | kharwell | gtjoseph: what kind of strange stuff did you and file see? |
| 21:36.40 | kharwell | did it have to do with running tests specifically? |
| 21:36.47 | gtjoseph | if pjproject is build without libresample, pjsua can't make calls |
| 21:36.54 | gtjoseph | Asterisk doesn |
| 21:37.07 | gtjoseph | t need it build with libresample but the testsuite does |
| 21:37.13 | kharwell | aah lemme try running a test that uses pjsua |
| 21:37.35 | gtjoseph | let me find one that tries to make a call... |
| 21:37.40 | gtjoseph | i forgot which ones they were |
| 21:38.31 | kharwell | I just ran the transfers/attended_transfer/nominal/callee_local_direct_media which should use pjsua and it passed |
| 21:38.33 | gtjoseph | try ./transfers/attended_transfer/nominal/callee_remote |
| 21:39.04 | kharwell | that one passed as well |
| 21:40.13 | file | nifty |
| 21:40.15 | file | so, just us |
| 21:40.38 | gtjoseph | shouldn't be us anymore either |
| 21:40.52 | gtjoseph | if you've got the latest 13 |
| 21:41.04 | gtjoseph | dmesg |
| 21:41.28 | gtjoseph | kharwell, cool. that was one that caused pjsua to segfault. |
| 21:41.38 | kharwell | oh you know what I built it with master, but probably shouldn't matter |
| 21:42.06 | gtjoseph | nope. |
| 21:42.27 | gtjoseph | make |
| 21:42.38 | gtjoseph | damn... wrong window again. |
| 21:45.28 | rmudgett | No make target defined |
| 21:45.49 | gtjoseph | :) |
| 21:47.15 | klow | hey gtjoseph - what did you think about the idea of listing the codec in 'pjsip show channels' command .. or bonus points how much data/packets etc received/send on that channel ... |
| 21:48.03 | gtjoseph | I haven't had a chance to look at it yet but it's on my list. :) |
| 21:48.40 | klow | ok cool. wasnt sure because feature request is supposed to be discussed by community / irc mailing list and not subimntted in the jira thing |
| 21:48.45 | klow | but cool. .would be cool . ;) |
| 21:49.00 | klow | i just said cool 3 times.. 4 .. blah ! |
| 21:49.06 | gtjoseph | agreed. hit me up again in a few days. |
| 22:12.59 | *** join/#asterisk-dev klow (~textual@c-73-53-31-109.hsd1.wa.comcast.net) |
| 22:19.25 | *** join/#asterisk-dev zerohalo (~zerohalo@c-174-62-142-83.hsd1.ma.comcast.net) |
| 23:14.35 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-qsdphkhqriidcxdl) |
| 23:39.16 | coreyfarrell | file: do you know what is preventing https://gerrit.asterisk.org/2404 from merging? seems like that is the first commit in the chain and approved? |
| 23:39.38 | coreyfarrell | if you are busy don't worry about it, I'm mostly just curious.. |
| 23:39.46 | file | it hasn't gotten through gating yet |
| 23:40.07 | coreyfarrell | ah thanks |
| 23:40.52 | file | will probably take an hour or so |