| 00:27.52 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:27.52 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Hell hath frozen over: Asterisk is moving to Git -=- Follow on Twitter at @AsteriskDev |
| 00:58.13 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 06:49.15 | *** join/#asterisk-dev babak (uid19622@gateway/web/irccloud.com/x-vbwatxpbafozwozd) |
| 06:56.54 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:51.27 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:52.39 | *** join/#asterisk-dev lumasepa (~gestoip@193.145.124.30.local.ull.es) |
| 08:14.40 | *** join/#asterisk-dev doome_ (~doome@apn-185-10-125-97.vodafone.hu) |
| 08:17.14 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:22.46 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:22.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:17.02 | *** join/#asterisk-dev fr8nk87 (~fr8nk87@cable-86-56-5-21.cust.telecolumbus.net) |
| 10:01.56 | *** join/#asterisk-dev doome_ (~doome@82.150.48.146) |
| 12:46.29 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 12:57.51 | file | do you wanna build a snowmannnnnnnnn |
| 13:29.50 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:00.28 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-255-230-241.mci.googlefiber.net) |
| 14:09.34 | *** join/#asterisk-dev acidfoo_ (~acidfoo@modemcable002.114-70-69.static.videotron.ca) |
| 14:22.11 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:22.11 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:31.53 | file | woah cresl1n |
| 14:32.24 | cresl1n | file!!!! |
| 14:32.31 | file | WOAH CRESL1N |
| 14:34.27 | cresl1n | FILE!!!!! |
| 14:34.32 | file | oh, hi |
| 14:50.24 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-ufzpdnudpvysrinu) |
| 15:03.04 | cresl1n | rmudgett: !!!! |
| 15:04.50 | rmudgett | cresl1n: Nope. No one here by that name |
| 15:05.42 | *** join/#asterisk-dev fr8nk87 (~fr8nk87@cable-86-56-5-21.cust.telecolumbus.net) |
| 15:05.57 | cresl1n | :-) |
| 15:06.04 | cresl1n | Good morning Mr. rmudgett |
| 15:06.35 | *** join/#asterisk-dev oej (~oej@2001:6b0:7:1:e5e8:5d6b:464:a3e4) |
| 15:06.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:06.37 | rmudgett | 404 File not found |
| 15:06.49 | cresl1n | -ENOENT? |
| 15:07.04 | rmudgett | -ENOMEM |
| 15:07.12 | cresl1n | -EINVAL. |
| 15:08.14 | file | moo |
| 15:09.16 | cresl1n | moo who? |
| 15:16.26 | file | squirrel |
| 15:16.28 | file | gtjoseph, hi! |
| 15:16.56 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-tojnnntzpsrqlaax) |
| 15:20.55 | *** join/#asterisk-dev fornax (~fornax@85.183.43.221) |
| 15:23.33 | gtjoseph | good morning file! |
| 15:23.50 | file | gtjoseph, I am writing a BLOG POST about your pjproject bundling support! |
| 15:24.00 | file | I am hoping to coordinate it with the 13.8.0 release |
| 15:24.04 | gtjoseph | cool. thanks! |
| 15:24.40 | gtjoseph | on my list to update the wiki as well. |
| 15:24.53 | file | if I can get it out as part of the rc it may spur some people to try it so we can get additional feedback |
| 15:25.50 | gtjoseph | once the last set of patches get applied, i was going to ask for feedback on the asterisk-users mailing list as well |
| 15:30.54 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-sfrwvrsrgeznvjyl) |
| 15:30.54 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:32.24 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 15:36.05 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 15:36.05 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 16:11.53 | gtjoseph | rmudgett: i started by adding ast_strip to the locations in question then thought why not use the correct tokenizer. Do you really want me to go back to strsep and add ast_strip everyplace? |
| 16:14.52 | rmudgett | gtjoseph: Commas are the separator not spaces so yes. |
| 16:15.20 | rmudgett | Otherwise someone would only use spaces instead of the intended commas |
| 16:15.40 | gtjoseph | so? |
| 16:15.59 | gtjoseph | ok, back to ast_strip |
| 16:44.42 | *** join/#asterisk-dev oej (~oej@2001:6b0:7:1:f840:3d84:12bb:c2fa) |
| 16:44.42 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:44.48 | cresl1n | oej!!!!! |
| 16:51.04 | *** join/#asterisk-dev catacs (2585e119@gateway/web/freenode/ip.37.133.225.25) |
| 16:52.25 | catacs | Hi everyone. I want prepare a patch to send it to gerrit, but I am not sure how i must prepare the commits. |
| 16:52.46 | catacs | Should I put one unique commit ? |
| 16:53.57 | catacs | Or I can do mutiple commits (in all cases using the commit message policies https://wiki.asterisk.org/wiki/display/AST/Commit+Messages) |
| 16:54.54 | file | a commit should represent a single change, if you have multiple commits which are working on a change they should be squashed into one commit |
| 16:55.55 | catacs | I have implmented a new feature and for my local work I have made multiple commits |
| 16:57.01 | file | then you'd need to squash that to a single commit for review |
| 16:57.38 | catacs | My change cover the c file with the feature and a basic configuration for dependecies in build system. |
| 16:58.20 | catacs | Ok, Thank you. |
| 17:17.07 | gtjoseph | file: getting frequent "Connection timed out during banner exchange" with gerrit this morning. |
| 17:17.19 | file | Ack |
| 17:17.30 | file | I can kick it when I'm not standing in line |
| 17:17.55 | file | I may crontab a restart |
| 17:18.04 | gtjoseph | what irc client are you using when you're mobile BTW? |
| 17:21.09 | file | Tapchat |
| 17:21.10 | file | it sends me push notifications, which then go to my watch as well (I have a Pebble) |
| 17:21.22 | gtjoseph | ah, cool |
| 17:22.33 | file | gerrit being kicked |
| 17:23.17 | file | should come up in a min or so |
| 17:24.08 | file | and it's back |
| 17:49.13 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 17:51.03 | rmudgett | gtjoseph: You don't need to make ast_strip() null tolerant to fix the issue |
| 17:51.28 | rmudgett | That seems to be getting into scope creep. |
| 17:51.30 | gtjoseph | strsep returns nulls |
| 17:51.42 | gtjoseph | so it's either that or add even more code |
| 17:51.51 | gtjoseph | to each usage |
| 17:51.52 | rmudgett | That's because of how you are trying to use ast_strip |
| 17:52.38 | rmudgett | Most of the places you just need to add an ast_strip() before passing the string to ast_sip_location_retrieve_aor() |
| 17:53.00 | gtjoseph | nope |
| 17:53.06 | gtjoseph | ast_strip will segv |
| 17:53.27 | gtjoseph | oh, i gotcha |
| 17:54.11 | gtjoseph | but that means still adding more strips |
| 17:54.23 | rmudgett | Though me claiming scope creep is like calling the kettle black |
| 17:54.44 | gtjoseph | they should have been null tolerant anyway. |
| 17:55.31 | gtjoseph | your call. |
| 18:14.11 | *** join/#asterisk-dev gtj (~gtj@unaffiliated/gtj) |
| 18:15.33 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 18:19.43 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@unaffiliated/gtj) |
| 18:20.08 | gtjoseph_ | rmudgett: what would you like me to do? |
| 18:20.47 | gtjoseph_ | exit |
| 18:21.03 | rmudgett | I suppose do what you did. |
| 18:21.30 | gtjoseph_ | thank you. |
| 18:25.11 | rmudgett | gtjoseph_: Reviewed |
| 18:28.44 | gtjoseph_ | hates monday mornings |
| 18:34.40 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@unaffiliated/gtj) |
| 20:33.57 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 20:33.57 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:50.20 | acidfoo_ | do you think that between the if check: |
| 20:50.22 | acidfoo_ | https://github.com/asterisk/asterisk/blob/11/main/channel.c#L8053 |
| 20:50.37 | acidfoo_ | and the bridge() function being called: |
| 20:50.38 | acidfoo_ | https://github.com/asterisk/asterisk/blob/11/main/channel.c#L8065 |
| 20:50.48 | acidfoo_ | that ->bridge could become NULL ? |
| 21:06.40 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-wlkhbomftsllcwiu) |
| 21:06.40 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 21:26.14 | acidfoo_ | I have the feeling that someone else was unsure about it too |
| 21:26.16 | acidfoo_ | .bridge = ast_rtp_instance_bridge,/* XXX chan unlocked ? */ |
| 21:26.25 | acidfoo_ | https://raw.githubusercontent.com/asterisk/asterisk/11/channels/chan_sip.c |
| 21:43.44 | acidfoo_ | from what I can see, this function can bee called: |
| 21:43.44 | acidfoo_ | https://github.com/asterisk/asterisk/blob/11/main/features.c#L802 |
| 21:56.54 | acidfoo_ | boom! |
| 22:05.50 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 22:22.20 | *** join/#asterisk-dev fornax (~fornax@85.183.43.221) |
| 23:18.04 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 23:18.04 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 23:31.11 | gtjoseph_ | file: got a minute to take a look at something on res_pjsip_registrar? |
| 23:31.21 | file | yes, if I open another tab |
| 23:31.54 | gtjoseph_ | would you please open another tab and look at lines 661-671. :) |
| 23:33.00 | file | k |
| 23:33.05 | file | reads and looks confused |
| 23:33.12 | file | oh |
| 23:33.21 | gtjoseph_ | 2 issues... |
| 23:33.39 | gtjoseph_ | 1. why is that block 661-671 inside the loop. |
| 23:34.14 | gtjoseph_ | and 2. in identify_by_username we match by domain first and match exact on user last but... |
| 23:34.17 | file | because it's looking for an AOR which includes domain name, it could be done outside to optimize instead |
| 23:34.32 | gtjoseph_ | here we try exact first and domain last |
| 23:34.48 | file | yeah, domain should be done first as it's more specific |
| 23:34.58 | gtjoseph_ | ok good. |
| 23:35.06 | gtjoseph_ | that's what I thought |
| 23:38.18 | file | ugh, I had something rich in chocolate and sugar... it may have been a mistake |
| 23:38.38 | gtjoseph_ | that can NEVER be a mistake ! |
| 23:46.20 | gtjoseph_ | file, one more question... |
| 23:46.36 | file | sure, if you want to fork Asterisk and rewrite it in go - go ahead! |
| 23:47.14 | gtjoseph_ | in identify_by_name, we test domain, then domain alias but here we test alias OR domain. |
| 23:47.18 | gtjoseph_ | :):) |
| 23:47.33 | gtjoseph_ | i don't want to fork it. i want you guys to hire me. :) |
| 23:47.49 | file | I think it should be domain and then domain alias |
| 23:47.55 | gtjoseph_ | agreed again. |
| 23:54.08 | gtjoseph_ | final question... I'm thinking we test all aor_names for domain, then all for domain_alias, then all for just name instead of testing the first aor for domain, domain_alias, name, then the second for domain, domain_alias, name etc. |
| 23:54.24 | file | I'm fine with that |
| 23:54.33 | gtjoseph_ | perfect. |