| 02:53.44 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 04:34.18 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 06:30.57 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 10:49.40 | *** join/#asterisk-dev tzafrir (~tzafrir@95.35.174.93) |
| 10:49.40 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 14:11.50 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 15:34.31 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 18:01.51 | coreyfarrell | gtjoseph: what do you think for the filename of dialplan function management routines: custom_functions.c or pbx_functions.c? |
| 18:02.19 | gtjoseph | i'd go with pbx just to keep them together lexically |
| 18:03.23 | coreyfarrell | sounds good I'll rename it and get that on gerrit later. |
| 18:03.38 | gtjoseph | cool, |
| 18:07.12 | gtjoseph | file: what's the deal with jenkins? |
| 18:07.38 | gtjoseph | some weird stuff going on there. |
| 18:07.43 | file | gerrit likes to hang on git clone sometimes, or fail |
| 18:07.47 | file | causing a corrupted git clone in jenkins |
| 18:08.22 | file | secondly there is a specific test condition in a threadpool test which can occur where it will fail, it has not yet been fixed |
| 18:08.25 | gtjoseph | looks like one just ran but failed on test_threadpool |
| 18:08.39 | gtjoseph | :) |
| 18:09.02 | file | the test itself works fine but if the condition it tests for occurs at the last queued task then the test will prematurely end |
| 20:37.06 | gtjoseph | coreyfarrell: does it make sense to move the application related things into the same file as the functions? |
| 20:39.49 | gtjoseph | also, if we're going to have a few more of these maybe it's time for a pbx/ subdirectory. |
| 21:05.52 | coreyfarrell | gtjoseph: not sure what you mean by application related things |
| 21:06.15 | gtjoseph | the application cli functions |
| 21:07.50 | coreyfarrell | well I was thinking this latest review creates the file for dialplan functions including the CLI for the same. CLI for dialplan application's should stay with the dialplan applications code? |
| 21:08.31 | gtjoseph | makes sense. |
| 21:10.20 | gtjoseph | and now I see why you suggested custom_functions for the name. |
| 21:10.27 | coreyfarrell | if I remember right though I tried moving the dialplan applications management routines first and it was not as clean as the changes we've posted so far. |
| 21:10.39 | gtjoseph | i think you're right |
| 21:10.41 | coreyfarrell | gtjoseph: personally I like pbx_functions.c better |
| 21:10.55 | gtjoseph | cool. i was going to sugges function_support |
| 21:11.11 | gtjoseph | cool the way it is though. +1'd |
| 21:15.33 | gtjoseph | my new years resolution was to clean out my office and I just found a set of RedHat CDs from 1996. Guess I should clean out my office more often than every 20 years. |
| 21:19.36 | gtjoseph | I should probably chuck that dot-matrix print as well. |
| 21:22.14 | coreyfarrell | you should toss the MSDOS floppy disks while you are at it |
| 21:23.10 | gtjoseph | yeah. i have some 8" ones in storage. :) |
| 21:23.26 | gtjoseph | they were from a System/34 though. |
| 21:52.51 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 23:06.33 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 23:59.32 | *** join/#asterisk-dev Synthase__ (uid63346@gateway/web/irccloud.com/x-rsfrjqsmsxlztqew) |