| 00:00.40 | rmudgett | Creation of an object zero fills in the struct so any pointers are NULL. |
| 00:00.57 | gtjoseph | and? |
| 00:01.10 | rmudgett | When stringfields are initialized they all point to an empty string. "" |
| 00:01.31 | gtjoseph | ok that wasn't clear |
| 00:01.44 | rmudgett | There are places where status->aor and status->uri are used without checking for NULL |
| 00:01.49 | gtjoseph | there's only 1 that has to be done then... |
| 00:01.55 | rmudgett | Mostly those places seem to be ast_verb() |
| 00:02.07 | gtjoseph | in the contact_status allocator |
| 00:13.42 | rmudgett | gtjoseph: contact_status_alloc() is called by sorcery right |
| 00:14.08 | gtjoseph | yep |
| 00:14.56 | rmudgett | So in ast_res_pjsip_find_or_create_contact_status() updating status->uri would need to free the initial value |
| 00:15.38 | gtjoseph | the descructor does that |
| 00:15.49 | rmudgett | set by contact_status_alloc() |
| 00:15.52 | gtjoseph | unless i missed it |
| 00:16.01 | gtjoseph | correct |
| 00:18.17 | rmudgett | ast_res_pjsip_find_or_create_contact_status() calls ast_sorcery_alloc() calls contact_status_alloc() that sets status->aor and initializes status->uri to "" |
| 00:18.54 | rmudgett | ast_res_pjsip_find_or_create_contact_status() when it updates status->uri would need to free status->uri before strduping into it. |
| 00:18.57 | gtjoseph | and sets the destructor so aor and uri get freed |
| 00:19.21 | rmudgett | This is not about the destructor |
| 00:19.26 | gtjoseph | oh crap |
| 00:19.53 | gtjoseph | yep or we leak the empty strings |
| 00:20.04 | gtjoseph | ok, fixing |
| 00:22.08 | gtjoseph | given that the allocs are immeidately followed by the uri set, do i really need those empty strings? |
| 00:23.49 | gtjoseph | rmudgett: ^^ |
| 00:24.22 | rmudgett | maybe not |
| 00:24.49 | rmudgett | It depends upon if the sorcery object is instantiated by other locations |
| 00:25.15 | gtjoseph | it never is |
| 00:25.15 | rmudgett | It is trying to simulate stringfields since we cannot use them in 13 |
| 00:26.10 | gtjoseph | i know and i can add the frees but it seems to be overkill to free something that was allocated on the previous statement |
| 00:26.39 | gtjoseph | up to you |
| 00:27.53 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-tozoffxywkhdxlzh) |
| 00:29.39 | gtjoseph | rmudgett: ^^ make the call |
| 00:30.36 | rmudgett | Leave out the empty string dup |
| 00:31.01 | gtjoseph | ok |
| 06:00.32 | *** join/#asterisk-dev doome_ (~doome@77-234-67-26.pool.digikabel.hu) |
| 07:07.39 | *** join/#asterisk-dev goddva (~goddva@77.40.154.242) |
| 07:58.58 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:13.06 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:15.43 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:15.43 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:32.42 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:38.15 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 10:07.02 | *** join/#asterisk-dev oej (~oej@130.28.1.50) |
| 10:07.02 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:10.41 | *** join/#asterisk-dev doome_ (~doome@77-234-67-26.pool.digikabel.hu) |
| 11:18.57 | *** join/#asterisk-dev oej (~oej@130.28.1.50) |
| 11:18.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:08.01 | *** join/#asterisk-dev oej (~oej@130.28.1.50) |
| 13:08.03 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:34.55 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:04.27 | *** join/#asterisk-dev oej (~oej@130.28.1.50) |
| 14:04.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:22.54 | *** join/#asterisk-dev doome_ (~doome@77-234-67-26.pool.digikabel.hu) |
| 14:53.08 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vaxdxfifcoyndsvq) |
| 14:53.08 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:58.15 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-fobxygvqtyycyidc) |
| 15:03.28 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 15:03.35 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 15:20.25 | *** join/#asterisk-dev jozza (~chatzilla@BSN-77-186-224.static.siol.net) |
| 15:21.50 | jozza | hi, how can i compile a custom module from a debian distro. I downloaded asterisk-dev package, linux headers, but calling gcc on a source file throws many errors all the time |
| 15:29.47 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:31.27 | *** join/#asterisk-dev DavidHuebner (~hubie@ip-69-178-218-71.far.ideaone.net) |
| 15:38.58 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-fpxhbudeyltksoqg) |
| 15:38.58 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 15:38.58 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 15:38.58 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 15:38.58 | *** join/#asterisk-dev doome_ (~doome@77-234-67-26.pool.digikabel.hu) |
| 15:38.58 | *** join/#asterisk-dev jozza (~chatzilla@BSN-77-186-224.static.siol.net) |
| 15:38.58 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:38.58 | *** join/#asterisk-dev DavidHuebner (~hubie@ip-69-178-218-71.far.ideaone.net) |
| 15:38.58 | *** join/#asterisk-dev seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 15:38.58 | *** mode/#asterisk-dev [+oo tzafrir seanbright] by leguin.freenode.net |
| 15:39.30 | *** join/#asterisk-dev jrrose (jon@nat/digium/x-mdoroeziebeqbmzj) |
| 15:39.30 | *** join/#asterisk-dev ConSi (~consi@jest.pro) |
| 15:39.31 | *** join/#asterisk-dev Marquis42 (~mrbmw@d192-24-112-5.try.wideopenwest.com) |
| 15:39.31 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 15:39.31 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-mnwyggpzkcgtacfz) |
| 15:39.31 | *** join/#asterisk-dev Deeewayne (~dwayne@c-68-32-120-188.hsd1.al.comcast.net) |
| 15:39.31 | *** join/#asterisk-dev kasanop (~kasanop@ivanpoddubny.com) |
| 15:39.31 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-xajdrhwicrijgsmk) |
| 15:39.31 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-yckdmsnsowbisrxm) |
| 15:39.31 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-cmgpysoqpdruyvgf) |
| 15:39.31 | *** mode/#asterisk-dev [+oo malcolmd Deeewayne] by leguin.freenode.net |
| 15:40.56 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-255-230-241.mci.googlefiber.net) |
| 15:40.56 | *** join/#asterisk-dev russellb (~rustlebee@redhat/russellb) |
| 15:40.56 | *** mode/#asterisk-dev [+o russellb] by leguin.freenode.net |
| 15:41.14 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 15:41.14 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 15:41.14 | *** mode/#asterisk-dev [+o snuff-work] by leguin.freenode.net |
| 15:42.29 | *** join/#asterisk-dev stefan27 (~stefan27@212.247.4.149) |
| 15:44.18 | *** join/#asterisk-dev Gugge (gugge@92.246.2.105) |
| 15:44.18 | *** join/#asterisk-dev dan_j (sid21651@gateway/web/irccloud.com/x-jrtsgftgrefdkzuf) |
| 15:59.26 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-fobxygvqtyycyidc) |
| 15:59.26 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 15:59.26 | *** join/#asterisk-dev _longines (~longines@static.95.25.4.46.clients.your-server.de) |
| 15:59.26 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 15:59.26 | *** join/#asterisk-dev opticron (~opticron@75.76.201.152) |
| 15:59.26 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 15:59.26 | *** mode/#asterisk-dev [+oo jsmith opticron] by leguin.freenode.net |
| 16:34.40 | *** join/#asterisk-dev roramirez (~root@boxtub.com) |
| 16:34.40 | *** join/#asterisk-dev Jacke (jacke@valhalla.bofh.org) |
| 16:34.40 | *** join/#asterisk-dev revolve (~username@dmt.psybernetics.org.uk) |
| 16:34.40 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 16:34.40 | *** join/#asterisk-dev tompaw (U2FsdGVkX1@tompaw.xxx) |
| 16:34.40 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 16:34.40 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vaxdxfifcoyndsvq) |
| 16:34.40 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 16:34.41 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-fobxygvqtyycyidc) |
| 16:34.41 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 16:34.41 | *** join/#asterisk-dev _longines (~longines@static.95.25.4.46.clients.your-server.de) |
| 16:34.41 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 16:34.41 | *** join/#asterisk-dev opticron (~opticron@75.76.201.152) |
| 16:34.41 | *** mode/#asterisk-dev [+oooo newtonr leifmadsen jsmith opticron] by leguin.freenode.net |
| 16:34.41 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 16:35.08 | jozza | is it possible to compile asterisk module from a debian distro? I downloaded asterisk-dev package, linux headers, but calling gcc on a source file throws many errors. I included asterisk header files to gcc in numerous ways and positions |
| 16:46.26 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 16:46.28 | *** join/#asterisk-dev opticron (~opticron@75.76.201.152) |
| 16:46.28 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 16:46.28 | *** join/#asterisk-dev _longines (~longines@static.95.25.4.46.clients.your-server.de) |
| 16:46.28 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 16:46.28 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-fobxygvqtyycyidc) |
| 16:46.28 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 16:46.28 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vaxdxfifcoyndsvq) |
| 16:46.28 | *** mode/#asterisk-dev [+oooo opticron jsmith leifmadsen newtonr] by leguin.freenode.net |
| 16:46.29 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 16:46.29 | *** join/#asterisk-dev tompaw (U2FsdGVkX1@tompaw.xxx) |
| 16:46.29 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 16:46.29 | *** join/#asterisk-dev revolve (~username@dmt.psybernetics.org.uk) |
| 16:46.29 | *** join/#asterisk-dev Jacke (jacke@valhalla.bofh.org) |
| 16:46.29 | *** join/#asterisk-dev roramirez (~root@boxtub.com) |
| 17:01.57 | jrrose | @Jozza: I imagine that's going to depend on the module. |
| 17:02.51 | jrrose | Did it not come with any instructions? |
| 17:04.46 | jrrose | One thing that *might* make it a little easier is throwing it in the addons folder in your Asterisk source directory and trying to use Asterisk's make file to build it. |
| 17:04.49 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 17:04.49 | *** mode/#asterisk-dev [+o ChanServ] by leguin.freenode.net |
| 17:06.52 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-wxniizlmbhgffzof) |
| 17:07.08 | gtjoseph | hey file: i'm having a brain fart...how do we get debug messages from pjproject itself? |
| 17:07.35 | file | they get forwarded as debug log messages, and have a level attached |
| 17:07.39 | file | bump up your core debug and you'll see 'em |
| 17:07.54 | gtjoseph | yeah, i'm at 3 and not seeing them |
| 17:08.58 | gtjoseph | i wonder if i turned them off when i built pjproject |
| 17:24.21 | *** join/#asterisk-dev skrusty (~skrusty@168.63.14.171) |
| 17:31.28 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 17:42.14 | jozza | jrrose: thanks, it seems i didn't read the error correctly. ast_channel struct has changed in ast 11 since last time my module was compiled. |
| 17:44.49 | jozza | jrrose: no special flags or include paths to gcc were required to build my module, only dev headers installed |
| 18:53.58 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-sdiupkkgfwtmomtm) |
| 18:56.24 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 18:56.24 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 19:31.39 | *** join/#asterisk-dev sgriepentrog (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 20:01.26 | *** join/#asterisk-dev acidfoo- (18303355@gateway/web/cgi-irc/kiwiirc.com/ip.24.48.51.85) |
| 20:05.14 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-hzcwkweeuhnqliir) |
| 20:13.08 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-lddbqivpdayzfmwh) |
| 20:14.14 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-genbfmfyaoubsnub) |
| 20:25.39 | *** join/#asterisk-dev dan_j (sid21651@gateway/web/irccloud.com/x-lzylwrhszhqnqzhh) |
| 20:29.19 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-ewrjftewissbriyq) |
| 20:46.36 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 20:46.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:07.23 | rmudgett | file: Shouldn't https://issues.asterisk.org/jira/browse/ASTERISK-25480 be closed. The patch is merged to master but -1'ed for v13 |
| 21:08.26 | file | hrm, not yet |
| 21:08.27 | file | adds comment |
| 21:09.39 | file | moving right along |
| 21:43.54 | gtjoseph | so, what was the intention for contacts/contact_statuses and statsd? Even before my patch is't not right. The 'created' count gets decremented on reachable and there's no stats update when there's a delete |
| 21:54.43 | gtjoseph | Anyone in Huntsville know if mjordan's available? Could you ping him to join the channel for a quick statsd thing? |
| 21:56.31 | file | he's alive, I don't know if he's exactly available... |
| 21:56.59 | file | I have relayed your desire to communicate |
| 21:57.05 | gtjoseph | ok, i'll have to post to the list i guess. |
| 21:57.11 | gtjoseph | thanks |
| 21:59.15 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-ckhbwsfpofqspuxn) |
| 21:59.16 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 21:59.38 | mjordan | gtjoseph: hey man, apologies, I'm off site today hiding in a cubicle in a datacentre with a sign on the lavatory that says "beware of the jaguar" |
| 21:59.45 | mjordan | what's up? |
| 21:59.49 | gtjoseph | :) |
| 21:59.55 | gtjoseph | quick statsd question... |
| 22:00.02 | mjordan | Sure |
| 22:00.43 | gtjoseph | what was the intention? the lifecycle seems to be unknown+1, unknown-1,reachable+1 and nothing on delete |
| 22:01.14 | gtjoseph | this started with the id/hash thing |
| 22:01.46 | mjordan | Hm. |
| 22:01.52 | gtjoseph | i'm thinking of moving the lifecycle events to the contact and contact_status observers instead of being in the pjsip_options stuff |
| 22:02.23 | gtjoseph | that way we'll get consistent created+1, reachable+1, unreachable+1, removed+1 |
| 22:02.31 | mjordan | I'm not sure I ever looked at 'delete'. The intention was that you can look at a plot and see how many contacts are in each state. I do know that we cycle to 'unreachable' if the contact went offline |
| 22:02.51 | mjordan | i.e., when I tested it, with a qualified endpoint, I unplugged my phone and verified that it transitioned |
| 22:02.56 | gtjoseph | dynamic contcagts get deleted |
| 22:03.25 | mjordan | Hm. Static contacts aren't getting triggered? |
| 22:03.31 | gtjoseph | if you unregister cleanly though, nothing gets reported |
| 22:03.48 | gtjoseph | testing dynamic now |
| 22:03.53 | mjordan | Hm |
| 22:04.02 | mjordan | That is kind of funny, I didn't test an unregister |
| 22:04.16 | mjordan | Mostly what we've been seeing are weird network/other issues causing connectivity |
| 22:04.26 | mjordan | and tracing when a big spike of them go offline and come back is handy |
| 22:04.31 | mjordan | and graphs are kind of nice for that |
| 22:04.50 | mjordan | But an un-REGISTER should at least drop the Reachable count down by one |
| 22:05.33 | gtjoseph | agreed.. so for a dynamic contact that registers then disappears uncleanly i see unknown+1, unknown-1,reachable+1,reachable-1,unreachable+1 and nothing else |
| 22:05.52 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 22:06.00 | gtjoseph | I should see a followon removed after 30 seconds when the contact gets cleaned up. |
| 22:07.18 | gtjoseph | bigger question...was the intent to track simple transitions or actual lifecycle? |
| 22:08.03 | gtjoseph | on a state transition from created to reachable should it be created+1,reachable+1 or created+1,created-1,reachab;le+1 |
| 22:08.39 | mjordan | You should see created + 1, created - 1, reachable + 1 |
| 22:08.49 | mjordan | otherwise, the counts will run away and never go down |
| 22:09.06 | mjordan | the total sum of all states should equal the sum of all contacts |
| 22:09.31 | gtjoseph | well, it could have been created+1, reachable+1......... reachable-1,created-1 |
| 22:09.38 | mjordan | Hm. |
| 22:09.49 | mjordan | I would hope that we'd decrement the created once the reachable was +1'd |
| 22:10.06 | mjordan | but, honestly, so long as the count's are decremented at some point, it's not much of a concern |
| 22:10.10 | gtjoseph | ok, if that was the intent, then that's ok |
| 22:10.13 | mjordan | Created is kind of a wacky one |
| 22:10.21 | mjordan | as we're in the created state for a very short burst of time |
| 22:10.30 | mjordan | reachable/unreachable/unknown is a bit more useful |
| 22:11.03 | gtjoseph | ok, to keep it simple, we can do the simple accounting on state transition |
| 22:11.38 | gtjoseph | I'm going to do some cleanup there then |
| 22:12.05 | mjordan | awesome, thanks |
| 22:12.26 | gtjoseph | no worries. i also modified you hash patch and pushed it up |
| 22:12.31 | mjordan | :-) |
| 22:12.34 | mjordan | Thanks again |
| 22:12.40 | gtjoseph | :) |
| 22:12.43 | mjordan | I'm in sort of a strange state through tomorrow |
| 22:12.46 | gtjoseph | have fun in the datacentre |
| 22:12.55 | mjordan | Always a good time when you have to be on site :-) |
| 22:13.08 | file | mjordan, at least you aren't... FIREWALLED |
| 22:13.13 | mjordan | file: Truth! |
| 22:13.20 | file | sends email to have mjordan firewalled |
| 22:13.28 | gtjoseph | or FLUSHED |
| 22:13.43 | mjordan | iptables -F FL |
| 22:15.21 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 22:15.22 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:30.56 | gtjoseph | rmudgett: you're not going to complain if I use RAII_VAR in update_contact_status are you? :) |
| 23:34.01 | rmudgett | not too much :) |
| 23:50.20 | gtjoseph | i'll fix the blank line in the nest patch set. :) |
| 23:50.28 | gtjoseph | s/nest/next |
| 23:51.28 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-fobxygvqtyycyidc) |
| 23:53.31 | gtjoseph | rmudgett: the use of RAII_VAR in the master version of the patch isn't absolutely necessary but i wanted to keep the code as similar as possible so future cherry pciks apply cleanly |
| 23:55.25 | rmudgett | I know. I was getting ready to diff the patches on master and v13 to see if any other extraneous differences appeared. |
| 23:56.29 | gtjoseph | except for the string_field related stuff, they were the same although that was 2 revs ago. |