| 00:09.39 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-zqiyblgrvikpkzli) |
| 03:14.03 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 04:12.26 | *** join/#asterisk-dev fornax (~fornax@85.183.43.221) |
| 04:58.57 | *** join/#asterisk-dev fornax (~fornax@85.183.43.221) |
| 07:44.55 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:44.55 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:00.38 | *** join/#asterisk-dev lumasepa (~gestoip@193.145.124.30.local.ull.es) |
| 08:08.38 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:13.40 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 09:13.40 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 09:19.00 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 09:19.00 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:37.30 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:45.32 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 11:45.32 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:53.55 | seanbright | tzafrir: no |
| 11:54.35 | tzafrir | and now? |
| 11:54.41 | seanbright | yes. |
| 11:54.44 | seanbright | i am here. |
| 11:58.18 | seanbright | tzafrir: what can i do for you? |
| 12:00.23 | tzafrir | about the asterisk-opus patch |
| 12:00.41 | seanbright | ah |
| 12:00.44 | seanbright | PRs welcome |
| 12:00.45 | tzafrir | why does it need to be built-in? |
| 12:01.21 | seanbright | because of opus_samples |
| 12:01.34 | tzafrir | I tried it recently. Just removed almost everything becides codec_opus and the .h file |
| 12:01.40 | seanbright | opus is a "built-in" codec in asterisk, purely for passthrough |
| 12:02.09 | seanbright | there is a callback on struct ast_codec called 'samples_count' that is set to NULL in asterisk |
| 12:02.14 | seanbright | and it cannot be overridden externally |
| 12:02.24 | tzafrir | ah, that one |
| 12:02.35 | tzafrir | yeah. I did get an error about it |
| 12:02.47 | tzafrir | s/error/warnings/ |
| 12:03.20 | tzafrir | s/an // |
| 12:03.23 | seanbright | heh |
| 12:03.32 | seanbright | i understand. |
| 12:03.47 | seanbright | i honestly haven't touched that patch in months, but i've gotten a few PRs about it |
| 12:04.33 | seanbright | hopefully digium's position on opus will change at some point and then it can all be rolled in to asterisk and we can all move on to other things |
| 12:04.47 | seanbright | but i am not optimistic |
| 12:05.15 | tzafrir | anyway, some parts of it seems to have been merged in later 13.x . Try applying it now |
| 12:05.25 | seanbright | k |
| 12:05.26 | tzafrir | So the patch could be slightly reduced. |
| 12:05.29 | seanbright | one moment |
| 12:05.35 | tzafrir | Another slightly related issue: |
| 12:06.07 | tzafrir | there seems to be a new draft RFC suggesting ".opus" for ogg/opus |
| 12:06.10 | seanbright | https://github.com/seanbright/asterisk-opus/blob/asterisk-13.3/asterisk.patch |
| 12:06.20 | seanbright | you're talking about that patch? |
| 12:06.24 | tzafrir | Maybe add format_ogg_opus? |
| 12:06.41 | tzafrir | yes, that patch |
| 12:06.57 | seanbright | i don't see any conflict just at a quick glance, but i will try to apply it |
| 12:07.00 | seanbright | one moment |
| 12:07.20 | seanbright | format_ogg_opus would be fine, but the opusfile library transcodes |
| 12:07.53 | tzafrir | (it also makes it simpler to test the opus support, using file convert) |
| 12:07.59 | seanbright | opusfile (the library i have used in the past) does not give you "opus samples" it gives your PCM samples |
| 12:08.38 | seanbright | i haven't seen a way to extract the raw opus audio data, otherwise it could be included in vanilla asterisk |
| 12:09.47 | seanbright | tzafrir: just testing the patch i linked against the 13 branch in git and it applied cleanly |
| 12:09.50 | seanbright | brb |
| 12:10.24 | tzafrir | OK. Maybe I was using an older version of that patch |
| 12:17.15 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 12:17.15 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:28.56 | tzafrir | main/tcptls.c:785: undefined reference to `SSLv3_client_method' |
| 13:29.38 | tzafrir | OK. an update to openssl in Debian Testing finally dropped support to SSLv2 and SSLv3. |
| 13:40.32 | coreyfarrell | tzafrir: I don't see a way for the asterisk build system to define OPENSSL_NO_SSL2 or OPENSSL_NO_SSL3_METHOD. I'm guessing we need additional checks in configure.ac |
| 13:41.07 | tzafrir | doesn't openssl define those? |
| 13:42.44 | coreyfarrell | hmm I guess you are right about OPENSSL_NO_SSL2. I don't see anything in my openssl headers about NO_SSL3 though. |
| 13:44.59 | coreyfarrell | does your debian testing have those defines in the openssl headers? |
| 13:45.54 | tzafrir | defined here |
| 13:48.34 | coreyfarrell | if you have --enable-dev-mode you can check tcptls.i, verify both defines made it all the way. |
| 13:58.00 | coreyfarrell | tzafrir: I'm guessing you are running 1.8? this was fixed in 11+ - https://code.asterisk.org/code/changelog/asterisk?cs=78eb83d0a013cefea944e05d42d4b1c268a9b276 |
| 13:58.38 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:15.02 | *** join/#asterisk-dev Tim_Toady (~fuzzy@83.212.108.130) |
| 14:25.26 | tzafrir | coreyfarrell, I'm running 1.3.6. But it is indeed my error. tcptls.o was built vs. old openssl and now it failed to link with new openssl |
| 14:25.31 | tzafrir | Thanks |
| 15:09.13 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-pbziiagpayabmtxr) |
| 15:30.47 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-wvshdapooktvsusu) |
| 15:30.47 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:44.15 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-nztshxdfcdvccuwn) |
| 16:23.07 | tzafrir | Sanity check, just to make sure that this is my problem: |
| 16:23.55 | tzafrir | I'm getting many errors for "undefined symbols", and to resolve them I seem to need to order the module loading myself |
| 16:24.05 | tzafrir | with preload-s in modules.conf |
| 16:24.32 | tzafrir | This sounds like I'm doing something wrong and not something I should expect, right? |
| 16:27.02 | coreyfarrell | tzafrir: I can't speak for really old versions but I'm pretty sure the symbol error's during startup will cause the loader to retry those modules |
| 16:38.22 | tzafrir | Indeed that's the case. But I get a long series of warnings in the console, and I'd like to avoid them |
| 16:39.18 | tzafrir | I did need to preload res_pjsip.so . Otherwise asterisk crashes while trying to load res_pjsip_session.so |
| 16:46.18 | coreyfarrell | I thought those load priority issues were fixed in the current version, but I could be wrong. |
| 18:09.31 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 19:28.25 | *** join/#asterisk-dev superscrat (~asanders@173-21-89-217.client.mchsi.com) |
| 19:34.27 | *** join/#asterisk-dev Marquis42 (~mrbmw@d192-24-112-5.try.wideopenwest.com) |
| 19:45.33 | *** join/#asterisk-dev chadxz (Adium@nat/digium/x-ylemcsvsybolxfwq) |
| 19:48.23 | wdoekes | coreyfarrell: I can't get my build of asterisk 13 to start without unless I order modules.conf explicitly |
| 19:48.56 | wdoekes | recently tried with 13.6 |
| 19:51.40 | wdoekes | (I do use a modified debian build, so I might be seeing the same problems as tzafrir because of some debian change) |
| 20:12.42 | coreyfarrell | wdoekes: it must have been some other pjsip module load order issue I saw fixed |
| 20:53.53 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 20:53.53 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:31.36 | *** join/#asterisk-dev superscrat (~asanders@173-21-89-217.client.mchsi.com) |
| 21:55.56 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 23:57.28 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-pbziiagpayabmtxr) |