| 00:20.28 | *** join/#asterisk-dev roramirez (~rodrigo@pc-109-4-101-190.cm.vtr.net) |
| 01:38.30 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-31-144.baf.movistar.cl) |
| 01:39.05 | *** part/#asterisk-dev roramirez (~rodrigo@186-78-31-144.baf.movistar.cl) |
| 02:19.00 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 03:31.46 | *** join/#asterisk-dev babak (uid19622@gateway/web/irccloud.com/x-aepuyfqjmcvlgirb) |
| 04:24.55 | *** join/#asterisk-dev snuff-work (~blatus@14-203-74-253.tpgi.com.au) |
| 04:24.56 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 06:07.29 | *** join/#asterisk-dev wakko (~wakko@78.233.162.32) |
| 10:23.49 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 11:15.51 | *** join/#asterisk-dev pchero (~pchero@0x555140b5.adsl.cybercity.dk) |
| 14:29.52 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 14:38.30 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 14:38.30 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:49.35 | wakko | why is asterisk-dev list registration moderated ? |
| 15:14.34 | mjordan | spam. |
| 15:14.44 | mjordan | and not a small amount of spam. A lot of spam. |
| 15:14.51 | wakko | i see |
| 15:15.13 | mjordan | we've had multiple instances where an address decides to start sending unsolicited junk to list members. Moderation helps us narrow down which subscriber is doing it. |
| 15:15.35 | mjordan | and this is why we can't have nice things :-) |
| 15:17.19 | wakko | btw i pushed a gerrit review, and i did not receive any mail as the wiki says "git review : Note that this will automatically publish the change to the asterisk-dev mailing list!" |
| 15:23.09 | mjordan | ah |
| 15:23.26 | mjordan | I need to update the wiki page then. After some discussion, we moved all code reviews over to a separate mailing list |
| 15:23.32 | mjordan | people got tired of the e-mails :-) |
| 15:23.41 | mjordan | http://lists.digium.com/cgi-bin/mailman/listinfo/asterisk-code-review |
| 15:25.19 | mjordan | fixed |
| 17:05.00 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 17:39.10 | wakko | thanks a lot |
| 17:39.31 | wakko | i need to subscribe this one then :) |
| 17:50.01 | *** join/#asterisk-dev roramirez (~rodrigo@pc-109-4-101-190.cm.vtr.net) |
| 18:52.03 | coreyfarrell | gtjoseph: I've been working with vector's lately, one thing that would be nice is if the REMOVE operations took 'sorted' as a parameter instead of having sorted/unsorted variants.. AST_VECTOR_REMOVE(vec, idx, sorted). with a macro parameter 'sorted' being a const the if (sorted) statement in the macro should get optimized away (even with -O0). |
| 18:52.36 | gtjoseph | hmmm. |
| 18:53.03 | gtjoseph | i'll have to investigate |
| 18:53.24 | gtjoseph | that's how it was originally written so i'll have to see where they were used |
| 18:54.29 | coreyfarrell | if I'm right about the constant if statement being optimized away from macro's then it would have no impact on performance, and the _UNORDERED / _ORDERED variants could just call the main macro with the sorted param 0 or 1. |
| 18:54.56 | gtjoseph | yeah true. |
| 18:55.23 | gtjoseph | i've got time blocked this afternoon to look at vectors again |
| 18:55.30 | gtjoseph | i'll add that to the list |
| 18:55.31 | coreyfarrell | so I have code that uses vectors. it has a struct for it's data/settings, one of the fields is a sort_cb. |
| 18:57.11 | gtjoseph | yeah, sort was on the list as well. :) |
| 18:57.20 | coreyfarrell | so with 'if (settings->sort_cb) { REMOVE_ORDERED(); } else { REMOVE_UNORDERED(); }' both full macro's are compiled in my code, instead of just the conditional section. since my sorted param wouldn't be const it wouldn't optimize the 'if' away, but it would avoid duplicating most of the macro |
| 18:58.21 | gtjoseph | yeah, that's a good case for the single macro |
| 18:59.24 | coreyfarrell | cool, so anyways I'm not trying to force more on your plate.. I just knew you were already working on / planning to work on vector.h so I don't want to conflict with you :) |
| 19:00.10 | gtjoseph | nope. good timing |
| 19:00.27 | gtjoseph | i can get that done today |
| 19:01.56 | coreyfarrell | yeah I converted my api_registrar code from macro's to (mostly) C functions + a structure with settings/callbacks. still has some macro's to generate stub functions, but the code is MUCH more readable (nobody likes a 200 line macro). |
| 19:02.16 | gtjoseph | :) |
| 19:39.48 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-16-113.baf.movistar.cl) |
| 20:14.16 | *** part/#asterisk-dev roramirez (~rodrigo@186-78-16-113.baf.movistar.cl) |
| 21:07.57 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 21:07.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:29.45 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 21:29.45 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:47.17 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 22:08.37 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 22:08.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:10.17 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 22:24.19 | coreyfarrell | gtjoseph: I have to do dinner now, but I looked quickly at your new review. doesn't have to be part of this one but for me an AST_VECTOR_INSERT_SORTED would be more useful than AST_VECTOR_SORT. my vector will always be sorted because elements will be inserted/appended to the correct position. |
| 22:25.18 | coreyfarrell | anyways I'll be back in like an hour to do a complete review, thanks for working on this! |
| 22:26.16 | gtjoseph | no worries |
| 22:53.53 | gtjoseph | coreyfarrell: ping me when you're back. |
| 23:21.14 | coreyfarrell | gtjoseph: back briefly while I wait for the grill to warm |
| 23:21.28 | gtjoseph | grill? It's starting to snow here. :) |
| 23:22.16 | gtjoseph | just wanted to say wait for the next review revision before loking at it. the INSERT_SORTED macro will be there |
| 23:23.08 | coreyfarrell | awesome. oh so on that maybe it would be better to call it ADD_SORTED.. since it will append sometimes. dunno just a thought |
| 23:23.33 | gtjoseph | makes sense |
| 23:23.57 | coreyfarrell | and I could go for snow right about now, been 80-90 here the past few days |
| 23:25.28 | gtjoseph | Yikes! |
| 23:30.50 | coreyfarrell | and 40-50 at night. the temp swings in the spring here are annoying |