| 00:07.38 | *** join/#asterisk-dev roramirez (~rodrigo@186.78.16.196) |
| 00:08.05 | roramirez | Hello |
| 00:08.12 | auntie | hello :| |
| 00:09.11 | auntie | my build of asterisk testsuite is successfully running (and failing) most of the tests now :) |
| 00:09.51 | auntie | still hangs on the ami test... hrm. |
| 00:12.09 | roramirez | I think there is a small error, i dont know if is on doc or git server configuration. Because in the doc https://wiki.asterisk.org/wiki/display/AST/Commit+Messages say "Commit messages should be wrapped at 80 columns." but when i commited the server response "(W) c69ab13: too many commit message lines longer than 70 characters; manually wrap lines" |
| 00:12.22 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 00:12.22 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 00:13.16 | auntie | I've been writing 80 column lines; I hope it's the latter |
| 00:13.31 | auntie | although somehow 70 is nicer for emails... |
| 00:13.43 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:23.55 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:35.34 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-16-196.baf.movistar.cl) |
| 00:36.51 | roramirez | auntie: possibly did that on git server configuration |
| 01:27.16 | *** part/#asterisk-dev roramirez (~rodrigo@186-78-16-196.baf.movistar.cl) |
| 02:06.54 | auntie | woo I have 10/13 confbridge tests working, but the three that fail all fail with _reactor_timeout: Reactor timeout: '30' seconds |
| 02:07.17 | auntie | I suppose I'll live with that for now. maybe the timeout is too low |
| 05:10.26 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 05:22.13 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 05:22.13 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 05:27.58 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 06:19.30 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 06:19.30 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:59.26 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:744a:259f:b349:53b9) |
| 07:05.11 | *** join/#asterisk-dev oej (~oej@2a03:f0c0:1001:1000:bd15:2e87:64bc:efaa) |
| 07:05.12 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:27.20 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:00.36 | *** join/#asterisk-dev oej (~oej@2a03:f0c0:1001:1000:bd15:2e87:64bc:efaa) |
| 08:00.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:24.33 | *** join/#asterisk-dev oej (~oej@2a03:f0c0:1001:1000:bd15:2e87:64bc:efaa) |
| 09:24.33 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:36.51 | *** join/#asterisk-dev tuxd00d_ (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 11:11.04 | *** join/#asterisk-dev oej (~oej@2a03:f0c0:1001:1000:bd15:2e87:64bc:efaa) |
| 11:11.04 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:18.14 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 11:29.39 | *** join/#asterisk-dev tuxd00d_ (~tuxd00d@ip70-162-151-19.ph.ph.cox.net) |
| 11:59.39 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:20.02 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-jqfhhckftpbkovxq) |
| 12:20.19 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 13:09.04 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-shoislkujrsnoxmq) |
| 13:31.22 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-fsabciwmvbbyjlcd) |
| 13:31.22 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:33.01 | *** join/#asterisk-dev oej (~oej@2a03:f0c0:1001:1000:bd15:2e87:64bc:efaa) |
| 13:33.02 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:52.15 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-irqzlmdqjhjoobuy) |
| 13:52.15 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:10.34 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-iszvwicawcufhxsh) |
| 14:12.57 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:12.57 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:38.01 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:15.27 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-vbpyczqnrtgyfiek) |
| 15:15.27 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:23.55 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-snhbfkbgykvmqcrz) |
| 15:29.47 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 15:41.26 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-msfihvzcundzedpn) |
| 15:53.10 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 15:57.44 | Greenlight | Hey there! I submitted https://issues.asterisk.org/jira/browse/ASTERISK-25000 the other day regarding a deadlock that I've been getting. I'd tracked down where the deadlock was, but just not exactly what was causing it. I completely understand that resources are limited, but was hoping that someone who knows the code better and me would be able to have a glance over and maybe point me in |
| 15:57.44 | Greenlight | the right direction so I can look to create a patch. It's causing enormous pain to our business and I'd truly appriciate any help anyone can offer |
| 16:27.33 | mjordan | Greenlight: I'm not sure there's enough information there for someone to know why the lock in channel.c (line 2885) is blocking. Frankly, it's already grabbed that lock several times, so it is pretty odd. |
| 16:28.53 | mjordan | even more odd is that there isn't another thread that is locked on a mutex. |
| 16:30.30 | mjordan | Greenlight: can you reproduce the issue in a controlled environment? |
| 16:44.42 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-uphvepgsniiwuqoc) |
| 17:09.01 | *** join/#asterisk-dev roramirez (~rodrigo@190.54.225.167) |
| 17:21.47 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:3523:e92b:3ed0:4ba8) |
| 17:23.07 | Greenlight | Yes, that's what I found very odd -- no obvious other thread having the lock |
| 17:23.17 | Greenlight | And also, that it's *just* realeased that lock |
| 17:23.44 | Greenlight | I can't reproduce reliably... on production server under load it's occuring once a week or so |
| 17:24.21 | Greenlight | Could the channel hanging up somehow have disgarded it and left it locked? |
| 17:25.37 | Greenlight | I took 3 separate back traces a few minutes apart each, and all show that thread still locked at the same place, so I'm sure that's where it's deadlocked |
| 17:27.51 | Greenlight | I've taken the precaution of disabling CDR's as the section it's grabbing the lock in was related to them, but my concern is that the deadlock would just occur the previous time it tries to get the lock |
| 17:33.32 | mjordan | Greenlight: A 'core show locks' would be really helpful, but I wouldn't recommend that on a production system as busy as this one |
| 17:33.47 | mjordan | if there's any way to get it do trip on a test setup, that would help pinpoint who left a lock held and where |
| 17:33.59 | mjordan | note that means compiling with DEBUG_THREADS |
| 17:34.03 | Greenlight | I tried enabling DEBUG_THREADS |
| 17:34.14 | Greenlight | System died after 5 mins :( |
| 17:34.28 | Greenlight | I could barely use the shell to kill it |
| 17:34.35 | Greenlight | Load was like 240 |
| 17:38.08 | Greenlight | It's safe to assume we're in that ast_hangup as the channel has been marked as a zombie, presumably by it being hungup elsewhere |
| 17:38.28 | Greenlight | Or hmm |
| 17:42.12 | Greenlight | Why do we only try to hang it up if it's been marked as a zombie, wouldn't we want to get rid of it regardless |
| 18:26.52 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 18:41.01 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 19:28.40 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 19:44.43 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 19:52.38 | coreyfarrell | I saw someone else mention this, when I run 'git review' I get warning messages that the first line is >65 chars and other lines being >70. it would probably be good if we could fix that to only complain about >80 chars, or update the wiki / commit messages page. |
| 19:53.01 | gtjoseph | That was me. :) |
| 19:53.07 | gtjoseph | complaining that is. |
| 19:55.43 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 20:04.53 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-vbpyczqnrtgyfiek) |
| 20:10.36 | roramirez | coreyfarrell, yes, i am said thats , but i don't know what is the rule if is the doc or configuration git server. |
| 20:11.04 | roramirez | is doc or git server configuration? |
| 20:13.14 | roramirez | now is 70 character or 80 ? |
| 20:28.36 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 20:44.38 | coreyfarrell | roramirez: looks like the message is coming from gerrit. the wiki page about commit messages say limit lines to 80 chars, so I just do that and ignore the warning that says otherwise. |
| 20:45.07 | file | ignore warnings, LIVE LIFE! |
| 20:46.09 | leifmadsen | Gerrit prefers that first line be less than 80 chars, then have a blank line, followed by a more elaborate description (or bullet list or whatever) |
| 20:47.23 | coreyfarrell | leifmadsen: actually it complains about first line >65 char and other lines >70. at least gerrit.asterisk.org does. |
| 20:47.39 | leifmadsen | ah, might be just the way it is configured then |
| 20:53.39 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 20:53.56 | gtjoseph | i think this is because mjordan changed the hook |
| 20:54.02 | gtjoseph | it didn't use to |
| 21:00.13 | leifmadsen | that wiley mjordan |
| 21:34.52 | *** join/#asterisk-dev ZX81 (~Adium@186.73.87.90) |
| 21:47.58 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-190-191-71.ph.ph.cox.net) |
| 22:09.35 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 22:16.44 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-190-191-71.ph.ph.cox.net) |
| 22:23.48 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 22:23.48 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 22:33.07 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 22:37.39 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 22:49.20 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-iszvwicawcufhxsh) |
| 22:52.12 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |