| 00:11.23 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 00:59.01 | *** join/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 00:59.26 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:07.35 | *** part/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 01:30.44 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 02:08.57 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-18-119.baf.movistar.cl) |
| 02:09.02 | *** part/#asterisk-dev roramirez (~rodrigo@186-78-18-119.baf.movistar.cl) |
| 02:34.42 | *** join/#asterisk-dev leedm777 (~leedm777@50.81.28.152) |
| 04:29.48 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 04:29.48 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:17.50 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:17.50 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:13.22 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:13.22 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:40.48 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:cdc9:212:eed3:6abe) |
| 11:56.14 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 11:56.15 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:19.30 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 12:20.18 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-bjnycqxbxztrfsab) |
| 12:29.40 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 12:29.50 | *** part/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 12:31.50 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:09.25 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-glytuibheikmmfwt) |
| 13:44.43 | *** join/#asterisk-dev sgalarneau (sgalarneau@nat/digium/x-rfoylxgeklhadbul) |
| 13:50.16 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-pzxblqhrzekwbjdp) |
| 14:18.43 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:18.43 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:23.50 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-rraawhdskjtoycqu) |
| 14:30.35 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-zojcwbyembvfapjv) |
| 14:30.35 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:31.08 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-hupjnvnurengoynw) |
| 14:46.01 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 15:18.39 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-sndrksjubgeamknq) |
| 15:32.11 | gtjoseph | mjordan: my 13/master patches have to be merged in order. |
| 15:32.57 | gtjoseph | 43, 44 and 46,47 |
| 15:34.15 | mjordan | alas. I don't see a way to undo the "please merge this" |
| 15:35.05 | file | I'd like putnopvut's thoughts on the out of dialog send request stuff |
| 15:35.27 | gtjoseph | i'll add him |
| 15:35.28 | file | if he sees nothing, then we've only momentarily broken the world |
| 15:35.36 | putnopvut | I see everything |
| 15:35.38 | file | and on a Friday I'm *okay* with that |
| 15:38.00 | putnopvut | gtjoseph: I basically have a big "review George's stuff" task on my list today. |
| 15:38.18 | gtjoseph | :) Get to it then. |
| 15:47.52 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 15:47.52 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:57.42 | rmudgett | gtjoseph: alembic branches is unhappy on 13 |
| 15:57.51 | gtjoseph | not because of me |
| 15:57.55 | gtjoseph | i double checked |
| 15:58.08 | gtjoseph | bit i'll triple check :( |
| 15:58.33 | file | rmudgett is correct |
| 15:58.53 | file | alembic -c config.ini.sample branches |
| 15:58.54 | file | /usr/lib/python2.7/dist-packages/alembic/util.py:189: UserWarning: Revision 461d7d691209 referenced from 461d7d691209 -> a541e0b5e89 (head), add pjsip max_initial_qualify_time is not present |
| 16:00.02 | gtjoseph | did you checkout review 44 first? |
| 16:00.33 | file | hrm! |
| 16:00.51 | gtjoseph | for that series you have to review -d 43, review -x 44, review -x 45 |
| 16:01.01 | file | I did not |
| 16:01.28 | gtjoseph | yeah, that's the one I cherry picked from the UI and it didn't get the dependencies correct |
| 16:01.31 | rmudgett | I just did git pull on 13 and that's the warning I get. |
| 16:01.43 | file | so, it'll fix itself if the other thing goes in |
| 16:01.49 | gtjoseph | do a git log and see if you have the other patches |
| 16:02.01 | skrusty | the sympathy runs deep with you file ;p |
| 16:02.07 | file | skrusty, totally |
| 16:02.27 | gtjoseph | file, it should but i'll give it a try again and make sure |
| 16:04.00 | gtjoseph | file: just checked and it's file with the earlier patches applied. |
| 16:04.06 | gtjoseph | fiNe |
| 16:04.45 | rmudgett | no it's just file |
| 16:05.10 | file | is 100% file |
| 16:11.41 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-fqnngmxahkwnkkro) |
| 16:13.27 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 16:13.27 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:48.15 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 17:12.52 | mjordan | kharwell: your nemesis is now failing on 13 |
| 17:12.53 | mjordan | https://bamboo.asterisk.org/bamboo/browse/AST-ATSF1/latest |
| 17:15.10 | kharwell | mjordan: say it isn't so! |
| 17:15.56 | rmudgett | it isn't so |
| 17:16.10 | kharwell | rmudgett: you are right it isn't. that is another test! |
| 17:16.31 | rmudgett | lol |
| 17:17.55 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 17:17.55 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 17:20.07 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 17:20.07 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:20.11 | kharwell | mjordan: ^^^ that's a different test. should we create an issue to look into it? or you want me to check into it when I can? |
| 17:20.30 | mjordan | well, what's odd is that it failed on both agents with your change |
| 17:21.04 | mjordan | i.e., there don't appear to be any other changes. But you're right, it is different - I just saw the last name |
| 17:21.29 | mjordan | kharwell: I'll make a new issue |
| 17:21.59 | mjordan | I wonder if it is similar to the other test... |
| 17:22.04 | kharwell | the change I made that was just committed was only to the test-config.yaml itself for non_stasis_bridge_to_stasis_bridge. It shouldn't affect that test |
| 17:23.28 | mjordan | kharwell: yeah, looking back in the history it looks like there may be a few other related failures. |
| 17:24.33 | kharwell | mjordan: likely it is the same problem. The other test that was failing sometimes was not getting the stasisstart for Local/_attended@transfer too because bob was being hung up |
| 17:26.58 | kharwell | since that is expecting two events though a range feature may need to be added to the event count or more details need to be added to the event regex in order to match against two separate events |
| 17:29.39 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 17:29.39 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 17:54.02 | *** join/#asterisk-dev sgalarneau (sgalarneau@nat/digium/x-evndutiffgncyzyw) |
| 18:01.52 | seanbright | Your new password is: available at http://yooden.digium.api:8095/crowd/console/reset... |
| 18:02.19 | seanbright | unsuprisingly that domain does not resolve for me |
| 18:04.08 | file | yooden, that's a new one |
| 18:33.14 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-rraawhdskjtoycqu) |
| 18:46.22 | mjordan | seanbright: yeah... someone is trying to get that fixed. |
| 18:46.40 | mjordan | seanbright: if you replace that with crowd.asterisk.org/crowd/... - it should work. |
| 18:46.46 | mjordan | if not, let me know and I'll fix it |
| 18:56.24 | seanbright | well, i got my password changed (i think) |
| 18:56.28 | seanbright | but it still says invalid login |
| 18:56.40 | seanbright | i'm not doing anything but looking around, so it's not critical |
| 19:16.35 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:16.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:17.43 | *** join/#asterisk-dev sgalarneau (sgalarneau@nat/digium/x-rvsssjjbgemkflli) |
| 19:38.04 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 19:43.47 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 19:43.47 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:48.41 | mjordan | seanbright: hm. |
| 19:49.08 | mjordan | seanbright: let me know if you want me to reset it at some point. |
| 19:52.55 | seanbright | mjordan: you have more important things to do |
| 19:52.57 | seanbright | git all the things |
| 20:03.05 | gtjoseph | file, putnopvut: will you guys be able to get to those reviews today? |
| 20:03.19 | putnopvut | gtjoseph: yep |
| 20:03.29 | gtjoseph | thx |
| 20:03.44 | putnopvut | I can't comment for file since technically he's "off" today. |
| 20:03.54 | putnopvut | But that usually doesn't stop him from working |
| 20:04.21 | file | :P |
| 20:04.41 | file | I'll take a gander in a bit if they still exist |
| 20:14.31 | putnopvut | gtjoseph: are there any major differences between changes 43 and 46? |
| 20:14.52 | gtjoseph | exactly the same |
| 20:19.19 | putnopvut | Okay that's what I thought. |
| 20:21.06 | *** join/#asterisk-dev Corydon76 (~quassel@c-69-137-93-158.hsd1.tn.comcast.net) |
| 20:21.06 | *** mode/#asterisk-dev [+o Corydon76] by ChanServ |
| 20:23.36 | mjordan | egads, another merge conflict |
| 20:23.52 | mjordan | so, merge order should be 43/44 |
| 20:28.47 | mjordan | tentatively submits something |
| 20:32.15 | mjordan | gtjoseph: I rebased https://gerrit.asterisk.org/#/c/44 to fix the CHANGES conflict that I introduced due to the submit ordering |
| 20:32.21 | mjordan | since mark/josh +1'd it, I'm going to push it in |
| 20:32.26 | gtjoseph | cool |
| 20:32.51 | mjordan | and that fixed the flood gates |
| 20:33.07 | mjordan | yeah, the ability to actually fix problems you introduce as a result of being trigger happy on the submit button is nice |
| 20:33.10 | mjordan | sorry about that :-P |
| 20:33.28 | gtjoseph | no worries, how about doing the tests |
| 20:33.38 | gtjoseph | review 92 |
| 20:33.45 | mjordan | aye |
| 20:33.55 | mjordan | I need to get some IRC bots in here |
| 20:35.32 | mjordan | gtjoseph: only finding is the minversion |
| 20:36.02 | gtjoseph | oops, fixing now |
| 20:37.58 | gtjoseph | mjordan: fixed |
| 20:39.37 | gtjoseph | mjordan: once this one goes in, any other git/gerrit implementation stuff I can help with? |
| 20:46.23 | *** join/#asterisk-dev Demon_VoIP (~demon@ip253.net222.n37.ru) |
| 20:46.32 | putnopvut | I'm reviewing tests right now |
| 20:47.25 | putnopvut | Oh lol I started reviewing patchset 8 and mjordan had the exact same comments as me |
| 20:47.32 | putnopvut | About the version number on the tests being off. |
| 20:48.25 | Demon_VoIP | Hi. What Target Release Version of https://issues.asterisk.org/jira/browse/ASTERISK-24863 is? |
| 20:48.50 | putnopvut | mjordan: did you undo my commit message edit on change 92? |
| 20:49.24 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 20:50.28 | putnopvut | Oh, no you didn't. For some reason gerrit was shoing me patchset 6 instead of patchset 9. |
| 20:51.20 | Demon_VoIP | gtjoseph, In what release I can see the fixes https://issues.asterisk.org/jira/browse/ASTERISK-24863 ? |
| 20:51.55 | gtjoseph | It's targetted for 13.4. |
| 20:52.10 | gtjoseph | but if you pull from git you can get it now. |
| 20:52.54 | Demon_VoIP | gtjoseph, Thank you. I guess I'll wait |
| 23:45.16 | *** join/#asterisk-dev auntie (~auntieNeo@ec2-54-186-138-150.us-west-2.compute.amazonaws.com) |