| 00:40.24 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:48.55 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:17.57 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:47.08 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 02:27.55 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-sxgfnqarbdmisqba) |
| 02:27.55 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:28.03 | mjordan | branch history. |
| 02:29.07 | coreyfarrell | so I'm not sure if this is intentional, I get access denied when I try cloning a gerrit repo with ssh |
| 02:29.26 | coreyfarrell | I know you have more important things to work on now, just wanted to mention so you can check it out when you have more time |
| 02:31.22 | mjordan | er |
| 02:31.26 | mjordan | did you just do it? |
| 02:31.39 | mjordan | because I had to take the server down :-) |
| 02:31.46 | coreyfarrell | was a couple hours before you sent the email saying not to clone |
| 02:31.52 | mjordan | hm |
| 02:32.01 | mjordan | k, not sure then. I can take a look at the logs once I have it rebuilt |
| 02:32.03 | mjordan | it's getting close |
| 02:32.10 | coreyfarrell | looks like it was saying I didn't have access to the repo, like it recognized my SSH key |
| 02:32.38 | mjordan | ah |
| 02:32.50 | mjordan | you had three 'rs' in your name |
| 02:33.04 | mjordan | [2015-03-24 20:55:24,403 -0500] b792166a coreyfarrrell - AUTH FAILURE FROM xx.xxx.xxx.xxx user-not-found |
| 02:33.54 | coreyfarrell | doh |
| 02:34.33 | coreyfarrell | well now I get 'remote HEAD refers to nonexistent ref, unable to checkout.' but I assume that's what you were talking about taking the server down |
| 02:39.13 | mjordan | were you trying to pull testsuite? |
| 02:40.58 | coreyfarrell | yeah just now.. repotools is working though |
| 02:41.02 | mjordan | k |
| 02:41.15 | mjordan | that's ... interesting. |
| 02:42.44 | mjordan | brb |
| 02:47.22 | *** join/#asterisk-dev mjordan1 (mjordan@nat/digium/x-phlbdfsobdwnlsxm) |
| 02:47.23 | *** mode/#asterisk-dev [+o mjordan1] by ChanServ |
| 02:47.27 | mjordan1 | and back |
| 02:50.04 | mjordan1 | coreyfarrell: does doing a fresh clone of testsuite work now? |
| 02:50.41 | coreyfarrell | mjordan1: yup works now.. I assume this one is still going to become invalid? |
| 02:50.55 | mjordan1 | nope |
| 02:51.00 | mjordan1 | I got the history right this time |
| 02:51.12 | coreyfarrell | cool |
| 02:51.14 | mjordan1 | https://github.com/asterisk/testsuite |
| 02:52.53 | mjordan1 | I'll have to set up post-commit hooks to keep the mirrors on github and git.asterisk.org updated |
| 02:54.57 | coreyfarrell | so for asterisk what's going to happen to ASTERISK_FILE_VERSION() in all the sources? |
| 02:55.05 | mjordan1 | no idea |
| 02:55.22 | mjordan1 | but I'm sure that's going to be entertaining |
| 02:55.31 | mjordan1 | the Asterisk conversion is going to take a bit |
| 02:55.43 | mjordan1 | once we get the next batch of releases out, I want to do the port as soon as possible |
| 02:55.56 | mjordan1 | which gives us the next 6 weeks or so to iron out those kinds of details, along with all the build/release scripts |
| 02:59.56 | coreyfarrell | oh next batch of update releases.. sorry for a second I thought you meant after 14.0 |
| 03:00.14 | mjordan1 | heh |
| 03:00.26 | mjordan1 | we usually have about 6 weeks or so between release cycles |
| 03:00.31 | mjordan1 | so 13.4.0 |
| 03:00.40 | mjordan1 | the other question is: should we merge menuselect into 11? |
| 03:00.43 | mjordan1 | we did it for 13 |
| 03:01.01 | mjordan1 | the other wrinkle is what happens when we have a security vulnerability in 1.8/12 |
| 03:01.09 | mjordan1 | which means menuselect would need to be merged into those branches as well |
| 03:01.15 | coreyfarrell | the only reason we didn't for 11 is because we didn't want to break working copies |
| 03:01.26 | coreyfarrell | working copies are going to break with this migration, no choice |
| 03:01.51 | mjordan1 | true |
| 03:17.56 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 03:18.13 | coreyfarrell | I destroyed? |
| 03:18.36 | mjordan1 | huh? |
| 03:18.58 | coreyfarrell | I destroyed one of your reviews |
| 03:19.29 | mjordan1 | a poor attempt at humor |
| 03:19.53 | mjordan1 | you pointed out that I missed a lot of svn:ignore properties; now I get the chance to redo it and make it look like I looked at the subdirs |
| 03:20.42 | coreyfarrell | so that review I just posted for repotools, am I too early? |
| 03:22.37 | mjordan1 | we should be good |
| 03:23.10 | mjordan1 | the worst that happens is that we wait to merge it until Asterisk gets pulled in, but we can figure that out |
| 03:23.20 | mjordan1 | and I'm hoping to do that in the next two weeks |
| 03:23.27 | mjordan1 | since we should be making releases on Monday-ish |
| 03:24.00 | coreyfarrell | is the commit msg format going to stay the same for asterisk? I mean with the #close tags and Patches /Testers. |
| 03:32.30 | mjordan1 | so, the #close is used by fisheye (code.asterisk.org) |
| 03:32.37 | mjordan1 | so it remaining the same would be good |
| 03:32.54 | mjordan1 | but there are other ways we could close out issues, so it doesn't have to be that. |
| 03:33.00 | mjordan1 | (just less work) |
| 03:33.12 | mjordan1 | the other 'tags' are actually read by the digium_commits.py script |
| 03:33.21 | mjordan1 | and used to make release summaries and other such things |
| 03:33.29 | mjordan1 | their format could change, if we wanted to make them change |
| 03:34.28 | coreyfarrell | cool so the review I have for repotools could be applied at any time - it just makes it use the "new" #close tag and does REST lookup for license number of patches |
| 03:35.09 | mjordan1 | ooo, nice |
| 03:38.27 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 03:38.30 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 03:55.04 | *** part/#asterisk-dev mjordan1 (mjordan@nat/digium/x-phlbdfsobdwnlsxm) |
| 04:16.42 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 04:16.42 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 06:06.51 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.135.186) |
| 06:29.48 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:29.48 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:04.14 | oej | MOrning folks |
| 08:14.54 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 08:14.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:18.57 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:1834:1f16:78ba:8e78) |
| 08:41.31 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 10:40.03 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 10:40.04 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:59.06 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 10:59.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:11.47 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:30.00 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 12:56.21 | stefan27 | I created https://reviewboard.asterisk.org/r/4521/diff/ can anyone view it even though it's not published? |
| 12:56.35 | stefan27 | it belongs to https://issues.asterisk.org/jira/browse/ASTERISK-24832 |
| 12:57.48 | file | no, I can only see that it exists - no other information on it |
| 12:57.51 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 12:57.51 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:57.53 | file | and that might be because I'm an admin in it |
| 13:01.48 | stefan27 | I cant seem to set Reviewer |
| 13:01.54 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 13:02.07 | stefan27 | Reviewers * |
| 13:02.22 | stefan27 | it's required but empty, i cant seem to edit it? no pen symbol next to it like the other fields? |
| 13:02.38 | file | it can't be edited, and it shouldn't need to be |
| 13:02.45 | file | you do need a group of people though |
| 13:02.49 | file | er group OR people |
| 13:03.15 | stefan27 | aha i missed You can list specific individuals in the Reviewers field, or preferably you can just add "asterisk-dev" to the Groups field. Doing this will make sure others get notified of the new request. |
| 13:04.20 | stefan27 | https://reviewboard.asterisk.org/r/4521/ it's viewable? |
| 13:04.47 | stefan27 | the patch is kind of polluted, but this is the exact patch for which testing was done |
| 13:05.03 | file | yes, it is now viewable |
| 13:05.31 | stefan27 | ok Good - I haven't used these kind of tools before |
| 13:13.35 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-plsjmkgjhssgdafg) |
| 13:27.23 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:27.27 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:31.33 | oej | Afternoon |
| 13:32.05 | oej | Can we add something to coding guidelines: "The coder who doesn't add any doxygen or code comments on new code will be forced to wear a stupid hat at Astricon" |
| 13:36.21 | file | generally that's caught during code reviews these days, and the coding guidelines does specify how it should be |
| 13:45.21 | oej | Does it say "write 200 lines of code without any comments"? |
| 13:46.30 | file | no, but it details the format and such - I'd be fine with adding a comment saying about more commenting but it's not something that can be declared for all instances |
| 13:46.54 | oej | We shouldn't have to put it in the guidelines - it should be done anyway. |
| 13:47.19 | oej | No one is immortal. Code stays for a long time and other people will have to understand your stuff. |
| 13:48.15 | file | how much commenting is acceptable to one person differs from others, that's why I mentioned it being caught during code reviews - since fresh eyes bring out where logic should be documented for others |
| 13:48.53 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-gwhcjpluvdawjtuo) |
| 13:52.38 | file | ultimately I agree that more comments is good and newer code improves on that, but there's always room for improvement |
| 13:55.00 | oej | What I see in 11 doesn't improve. The old code have more comments⦠|
| 13:55.05 | oej | I hope it's better now. |
| 14:14.26 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-atcgwmywvqihujch) |
| 14:14.26 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:15.19 | file | a wild newtonr appears |
| 14:15.29 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:15.29 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:16.45 | newtonr | file, i'm a wild and crazy guy |
| 14:19.57 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-dhwbtljufqranbqa) |
| 14:23.38 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 14:23.38 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Asterisk 13.0.0 now released. Do the release dance! -=- Follow on Twitter at @AsteriskDev |
| 14:24.06 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-kahqfrumhwigoufr) |
| 14:24.06 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:24.15 | blitzrage | mjordan, YOU |
| 14:24.28 | newtonr | blitzrage, :D |
| 14:24.31 | file | mjordan, ARE |
| 14:24.48 | newtonr | mjordan, A SOFTWARE DEVELOPER |
| 14:24.57 | blitzrage | newtonr, lets not get crazy now |
| 14:25.09 | blitzrage | mjordan, is clearly just a manager now |
| 14:25.11 | blitzrage | :D |
| 14:25.16 | blitzrage | is so trolly today |
| 14:25.30 | newtonr | Actually, he is a director now! |
| 14:25.44 | blitzrage | finally caught up to me I guess |
| 14:25.47 | blitzrage | :D |
| 14:25.57 | blitzrage | actually I probably caught up to mjordan |
| 14:26.02 | Marquis42 | heh yeah |
| 14:26.03 | mjordan | my hair is pointy, and I do look at powerpoints |
| 14:26.07 | mjordan | so it's all over for me, I guess |
| 14:26.09 | blitzrage | lol |
| 14:26.14 | Marquis42 | mjordan: You're a perfect fit then! |
| 14:27.26 | oej | mjordan: Sad to hear. Soon it'll be sharepoint and you'll be gone forever. |
| 14:27.44 | file | ugh sharepoint |
| 14:27.54 | Marquis42 | vomits in his mouth a little |
| 14:28.03 | oej | Even good men get lost in the Microsoft djungle. |
| 14:28.55 | Marquis42 | May $deity have mercy on their souls. ;) |
| 14:29.34 | oej | $deity = Marwin, the depressed robot |
| 14:31.31 | oej | Arghh. Forgot to terminate with ";" |
| 14:32.07 | Marquis42 | Ah, Marvin. <3 Hitchhiker's Guide. :) |
| 14:32.21 | mjordan | oej: I used sharepoint once upon a time. I had blocked that particular memory, and now it is back :-( |
| 14:32.46 | oej | Feel free to blame Marwin. |
| 14:32.52 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 14:33.04 | oej | The brame the size of a universe, and he still can't understand Sharepoint. |
| 14:33.18 | Marquis42 | lol |
| 14:41.29 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-gbsfqcmfahnsgduv) |
| 14:46.51 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 14:46.52 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 14:46.53 | oej | mjordan: working on RTCP Feedback - Google REMB in 11. |
| 14:46.58 | oej | First time in 11 code base. Scary. |
| 14:54.36 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:07.04 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 15:15.09 | *** join/#asterisk-dev jamesc|2 (~kvirc@mail2.inetplc.com) |
| 15:38.58 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 15:38.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:07.34 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 16:12.33 | stefan27 | Oh I've never seen https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines before |
| 16:13.22 | stefan27 | what's wrong with C++ type (//) comments? just curious |
| 16:31.09 | blitzrage | they make baby Jesus cry |
| 16:46.34 | skrusty | :'( |
| 17:12.11 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:2593:a107:dd33:979d) |
| 18:00.05 | *** join/#asterisk-dev eremitah (~int@unaffiliated/eremitah) |
| 18:02.15 | *** join/#asterisk-dev danjenkins_ (anonymous@nat/digium/x-sacnzueedispksek) |
| 18:09.53 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 18:19.09 | *** join/#asterisk-dev superscrat (~asanders@173.17.133.2) |
| 18:29.20 | mjordan | stefan27: once upon a time, we compiled with a version of gcc that wouldn't have liked them. |
| 18:29.41 | mjordan | now, C++ comments showing up are out of line with the rest of the source |
| 18:29.54 | mjordan | when you're working in a large codebase with lots of authors, it is highly disruptive to have "unique styles" creep in |
| 18:30.10 | mjordan | we have enough of that to deal with already; the coding guidelines try to enforce some element of sanity |
| 18:41.15 | *** join/#asterisk-dev Demon_VoIP (~demon@ip253.net222.n37.ru) |
| 18:45.51 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:01.00 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:01.00 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:47.25 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:47.26 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:52.05 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-kahqfrumhwigoufr) |
| 20:13.34 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-svxdssroniopgkmw) |
| 20:13.34 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 20:43.48 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 21:09.28 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 21:24.08 | coreyfarrell | I have to get used to gerrit automatically publishing reviews :( |
| 21:24.29 | file | there's an option you can use to git review to have it post a draft, -D |
| 21:25.02 | coreyfarrell | hmm, I'll have to see if I can make that default on my system, thanks for the tip |
| 21:40.51 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 21:40.51 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:41.49 | coreyfarrell | ok that's weird, gerrit sent an email to me (and maybe elguero) before I published the draft |
| 21:45.25 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-yovgclytfqtftihm) |
| 21:45.25 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 21:56.20 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-feotllinynenienf) |
| 21:56.31 | mjordan | coreyfarrell: that is pretty weird. |
| 21:57.25 | coreyfarrell | yeah, I ran 'git review -D', then a couple minutes later I got an email which said it was sent to elguero.. a couple minutes later I actually published the draft |
| 23:10.01 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-feotllinynenienf) |