| 00:29.03 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 00:29.03 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:31.42 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 02:53.49 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 02:59.46 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 04:09.46 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:09.48 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 06:08.58 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.135.186) |
| 06:39.44 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:39.44 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:52.21 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 06:52.25 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 07:57.09 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 07:57.26 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 08:05.44 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6938:44cb:69ba:78da) |
| 08:12.52 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 08:12.52 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:13.34 | oej | Morning folks |
| 08:23.52 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:09.13 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:55.39 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 09:55.39 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:57.07 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 09:57.07 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:04.18 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 10:04.49 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 10:13.25 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 10:13.30 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 12:00.54 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 12:00.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:08.44 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:24.39 | *** join/#asterisk-dev Marquis42 (~mrbmw@d14-69-246-193.try.wideopenwest.com) |
| 12:27.47 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-66-28.user.veloxzone.com.br) |
| 12:50.46 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 12:50.49 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 12:52.56 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-drtsivjwvuqasdfl) |
| 13:16.04 | oej | hello folks |
| 13:22.35 | *** join/#asterisk-dev xytis (~xytis@5.20.223.100) |
| 13:26.53 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 13:35.21 | oej | file: Time for a brainstorm? |
| 13:35.28 | file | for? |
| 13:35.36 | oej | rtcp feedback stuff |
| 13:36.03 | oej | I am a bit lost on where to handle it in the myriad of data structures we ahve in rtp system |
| 13:36.04 | file | mjordan and putnopvut would be better fit for that, they've read that stuff recently |
| 13:36.13 | oej | Ok! |
| 13:36.17 | oej | mjordan: Ping |
| 13:36.29 | oej | mjordan: got a SIP REFER from file⦠:-) |
| 13:36.38 | file | he's not in here yet |
| 13:36.51 | oej | time zones. Gotta get rid of them. |
| 13:39.45 | file | he also wrote a long email to -dev awhile back about RTCP FB |
| 13:58.50 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-giskubscwtaubeta) |
| 14:00.31 | oej | I don't remember that. |
| 14:01.02 | file | http://lists.digium.com/pipermail/asterisk-dev/2014-December/071977.html there it is |
| 14:01.12 | oej | Thank you! |
| 14:01.25 | oej | Ok, that's NACK |
| 14:01.35 | oej | A different story that requires buffers and all kinds of stuff. |
| 14:01.51 | oej | I'm on a different track - the bandwidth feedback. |
| 14:02.05 | file | his response included generic feedback stuff |
| 14:02.08 | oej | In short either saying "give me more video" or "stop it, I can't swallow all of it" |
| 14:03.04 | file | sparking up the conversation on -dev would also be good since Nitesh monitors it and might have a comment too |
| 14:03.42 | oej | He's after a quite different thing. |
| 14:04.20 | oej | The problem I have in my code - that is underway - is to add a property to one stream but only for a certain codec |
| 14:04.20 | file | ultimately yes but there's still fundamentals and I'd hate to have him miss something that might be relevant |
| 14:04.55 | oej | I haven't got enough thought to compose email yet.. |
| 14:07.10 | file | can you clarify what you mean by "add a property to one stream" |
| 14:07.45 | oej | The google-remb attribute applies to one codec in a video stream. It's not a format property - should not be part of format/codec comparisions |
| 14:07.58 | oej | When using this codec in this particular stream we need to do this. |
| 14:08.11 | oej | If we switch to another codec we need to use the RTCP properties of that codec. |
| 14:08.21 | oej | I don't think we have that kind of structure today |
| 14:11.41 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-nwoocxrswtwgpsop) |
| 14:11.41 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:18.00 | file | I still don't understand what you mean, so I'm guessing no - what you want/need does not exist. |
| 14:18.26 | file | newtonr, do you plan on updating SAC phase 1 patch 2 outside connectivity? |
| 14:25.39 | oej | Ok, creating ugly hack right now. Need to get to testing. |
| 14:25.48 | oej | Thanks for the conversation, file! |
| 14:25.54 | file | cheers |
| 14:28.03 | newtonr | file, yeah I'm just slow as molasses lately. |
| 14:28.14 | file | k |
| 14:31.06 | anonymouz666 | oej: are you updating teapot with this? |
| 14:36.29 | oej | With what? |
| 14:36.33 | oej | The feedback stuff? |
| 14:36.38 | anonymouz666 | yes |
| 14:43.08 | oej | I don't think it belongs in the tea pot. |
| 14:43.14 | oej | Chocolate and tea doesn't mix. |
| 14:43.26 | oej | Joking, teapot needs to be at version 11 for this to be interesting. |
| 14:44.44 | anonymouz666 | ok, so tem REMB stuff is just a tool to implement an algorith on the client side to act accordingly |
| 14:45.04 | anonymouz666 | ? |
| 14:45.08 | anonymouz666 | (it was a question) |
| 14:45.37 | oej | This is for video - to adjust the bandwidth of the sender |
| 14:45.57 | oej | If asterisk notices packet loss we will tell the sender to back off, adjust the codec somehow to give a better experience. |
| 14:46.37 | oej | As asterisk doesn't ahve any video codecs we can't really handle it on our sending side. We could potentially send it over the bridge to the other party. |
| 14:47.51 | anonymouz666 | the client must understand then the feedback and slow down if necessary |
| 14:48.14 | oej | That's the idea. You negotiate this in the SDP |
| 14:48.21 | oej | So there's an agreement done. |
| 14:51.01 | oej | I am still not sure this is doable, but I'm tasked with giving it a try |
| 14:53.31 | oej | file: What's extended RTP properties? |
| 14:54.14 | file | they are a generic mechanism for informing an RTP engine about a setting without having to change the API substantially |
| 14:54.52 | oej | And the difference to a standard property is? |
| 14:55.35 | file | standard requires an API change in that it has to be defined, extended is completely arbitrary since it's just passing a name/value into the RTP engine |
| 14:55.59 | oej | There's no user of it in the source code⦠What's the story here? |
| 14:56.13 | oej | It must have been created for something |
| 14:56.17 | file | it was. |
| 14:56.30 | oej | Ouch |
| 14:57.11 | oej | Ok, won't touch that stuff. |
| 14:58.34 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hgjaamonbuktttbr) |
| 15:10.01 | oej | I don't see any usages of the standard properties either. This must be wrong. They're defined in rtp_engine.h |
| 15:10.38 | oej | ok, found them. Me bad. |
| 15:23.26 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 15:26.42 | *** join/#asterisk-dev jrose_atDigium (jrose_atDi@nat/digium/x-hqcpeippohjnuwvp) |
| 15:29.39 | jrose_atDigium | Taking a peek at https://reviewboard.asterisk.org/r/4510/ |
| 15:52.14 | oej | Ha! The next commit was from File. I knew it⦠:-) |
| 16:00.06 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 16:30.19 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-rprasnsifuftxdzn) |
| 17:17.23 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 17:17.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:18.31 | JunK-Y | hello! |
| 17:19.23 | jrose_atDigium | hey |
| 17:19.29 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-dnvmuikqavhkqroi) |
| 17:20.42 | JunK-Y | how are you? |
| 17:22.45 | jrose_atDigium | wellish |
| 17:23.49 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 17:23.49 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 17:28.40 | JunK-Y | yay! |
| 17:56.55 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 18:01.08 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 18:07.59 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 18:22.47 | *** join/#asterisk-dev y_ateya (~y_ateya@41.45.126.212) |
| 18:36.08 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 18:38.55 | justsomedood | I've run into a problem with the Asterisk Event Manager. When events are sent and the value is a string it doesn't escape the message control characters (\r\n) so when people send us callerid names that have a \r\n in it, it messes up programs that parse Event Manager output. I didn't see an obvious place that has a string replacement function, so I wrote one that will replace newline and carriage return with a "\r\n" instead. |
| 18:39.18 | justsomedood | Is there already a string replace I should be using, or is adding it ok? |
| 18:39.27 | justsomedood | I'm wanting to submit it as a patch later |
| 18:50.55 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 18:54.02 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-yfiqwtjgqaqdhzzr) |
| 18:54.49 | y_ateya | justdomedood: did ast_unescape_c do the job? |
| 18:57.12 | justsomedood | That's going the other way around right? |
| 19:07.29 | y_ateya | ah, you are right. I don't know escape function other than this. |
| 19:14.34 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:14.34 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:22.05 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-vdcognrormlclewt) |
| 19:27.24 | mjordan | justsomedood: I don't believe we do. An "ast_escape_c" would be appropriate in strings.h |
| 19:27.43 | justsomedood | k |
| 19:27.56 | *** part/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 19:29.05 | justsomedood | The string is longer than the original, so it returns a new buffer that it allocated so it would be expected that the caller frees the memory afterwards |
| 19:31.22 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:31.22 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:47.19 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-aikgifqwykgivtli) |
| 19:47.19 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 19:47.30 | mjordan | so.... |
| 19:47.36 | mjordan | any other testsuite tests need to be merged? |
| 19:48.35 | rmudgett | I just merged the rpid_immediate patches. |
| 19:49.03 | mjordan | I saw! |
| 19:49.12 | mjordan | you may have the dubious honor of being the last SVN merge :-) |
| 19:49.43 | file | nobody here but us unit tests |
| 19:51.31 | coreyfarrell | gtjoseph has r4388 that has been approved |
| 19:51.36 | malcolmd | ...unless seanbright shows up to claim the last revision number... ;) |
| 19:52.06 | mjordan | coreyfarrell: do you know if the patch went in for that test? |
| 19:52.44 | coreyfarrell | no idea, I just sorted open reviews by repository, saw that one is approved :) |
| 19:54.34 | mjordan | hm. |
| 19:54.47 | mjordan | since it had no findings on it, the diff should be pretty easy to re-generate for git. |
| 19:54.56 | mjordan | this is my current rationalization :-P |
| 19:55.52 | coreyfarrell | I agree.. if you're ready to pull the trigger go for it. patch -Np0 is pretty easy to run on a fresh git clone. |
| 19:56.45 | mjordan | SVN should be now read-only |
| 20:22.00 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 20:22.01 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:30.18 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 20:30.19 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:50.55 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 20:55.18 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 21:27.42 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-giskubscwtaubeta) |
| 21:49.52 | *** join/#asterisk-dev jvhester (~root@104.131.198.181) |
| 21:49.52 | *** join/#asterisk-dev blitzrage (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 21:49.52 | *** mode/#asterisk-dev [+o blitzrage] by sendak.freenode.net |
| 22:13.02 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-aikgifqwykgivtli) |
| 22:49.58 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:06.13 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-aobuojadmnhrmlmz) |