| 01:03.40 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:e6:43cc:4bdd:2d3e) |
| 02:57.54 | mjordan | oh snap |
| 02:58.02 | mjordan | file: you still around? |
| 03:32.42 | *** join/#asterisk-dev vlad_starkov (~vlad_star@91.206.59.50) |
| 03:40.56 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 03:41.00 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:54.51 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 06:43.20 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 06:43.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:53.34 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 06:53.39 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 07:22.05 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 07:59.50 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:e063:f01:4bc2:2002) |
| 08:16.06 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:16.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:54.01 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 08:54.01 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:22.52 | oej | Morning folks |
| 10:07.22 | skrusty | morning oej |
| 11:39.05 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 12:19.54 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-153-9.user.veloxzone.com.br) |
| 12:25.44 | *** join/#asterisk-dev reconwireless (uid10170@gateway/web/irccloud.com/x-qikpwuvbeyykkynn) |
| 12:41.28 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 12:41.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:29.55 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:16.38 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 14:17.13 | *** part/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 14:27.22 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 14:46.08 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-gzbtpffceklivyui) |
| 15:01.07 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-gaobuzhewsdssdsa) |
| 15:01.07 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:02.14 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:02.14 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:02.58 | *** part/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 15:07.20 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-zzeuettaveclgwok) |
| 15:07.54 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 15:07.54 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 15:12.22 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:12.22 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:14.35 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-iebavbtwqhxhplke) |
| 15:14.35 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:26.29 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-rilzyqyvkxozdnsl) |
| 15:27.41 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-rpivnossluixqorq) |
| 15:48.04 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:e063:f01:4bc2:2002) |
| 15:55.02 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-iebavbtwqhxhplke) |
| 16:17.20 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-mwemlpwfwemkhltv) |
| 16:17.20 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 16:17.27 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 16:17.27 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:20.59 | *** join/#asterisk-dev philippel (uid10480@gateway/web/irccloud.com/x-ncncnhobghavjhgv) |
| 16:53.52 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-mwemlpwfwemkhltv) |
| 17:30.34 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-ttvmzkkwlgbitnay) |
| 17:30.34 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 17:48.54 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-unwmxpmvcqjwqjmk) |
| 17:48.54 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 17:57.00 | *** join/#asterisk-dev spditner (~simon@23-91-147-223.cpe.pppoe.ca) |
| 17:57.54 | gtjoseph | If anyone's got some free time, editorial comments would be appreciated: https://wiki.asterisk.org/wiki/display/AST/PJSIP+Configuration+Wizard |
| 18:03.58 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 18:10.35 | leifmadsen | gtjoseph: reading through, but fyi in Confluence wrapping things in {{ }} will make it monospace type |
| 18:10.51 | leifmadsen | {{sip.conf}} for example |
| 18:10.57 | gtjoseph | cool, thanks for the edits. |
| 18:11.01 | leifmadsen | (I prefer to do that rather than us 'sip.conf' etc) |
| 18:11.22 | leifmadsen | there are lots more that could be updated, but it doesn't really add anything to the conversation, so instead I'm reading the page :) |
| 18:11.54 | gtjoseph | makes sense. I'll update the remainder. |
| 18:13.55 | leifmadsen | gtjoseph: so some softball questions :) |
| 18:14.06 | gtjoseph | yeah.... |
| 18:14.31 | leifmadsen | as this is most useful for people coming from sip.conf and this is intended to make this simpler, why aor/qualify_frequency rather than just qualify_frequency (or even just qualify) |
| 18:14.37 | *** join/#asterisk-dev cosmicwombat (sid10687@gateway/web/irccloud.com/x-doosusdcimshbwda) |
| 18:14.48 | leifmadsen | same with endpoint/context etc... vs just context |
| 18:14.54 | gtjoseph | a few reasons... |
| 18:15.49 | gtjoseph | first, the non prefixed options I have to write code for. The prefixed options are straight pass through. |
| 18:16.28 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-nckdybzmynzzxikc) |
| 18:16.43 | gtjoseph | second, i wanted to re-enforce what the options meant if you were going to define objects discretely |
| 18:17.32 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:e6:43cc:4bdd:2d3e) |
| 18:17.35 | gtjoseph | I.E. I didn't want confusion over 'qualify' in wizard vs 'qualify_frequency' in aor. |
| 18:17.38 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-gbchfnaikdvtxisn) |
| 18:18.05 | leifmadsen | makes sense, I was just curious if there was something that could make it "easier" for people to use those terms they are more familiar with |
| 18:18.18 | leifmadsen | I see now that the prefixed options are just things passed through unmodified |
| 18:18.45 | gtjoseph | yeah, i know. it was a trade off. the wizard doesn't mean you can not understand pjsip basics. |
| 18:19.10 | leifmadsen | gtjoseph: I agree and also have this weird disagreement about whether it would be confusing or not. I suspect people using the wizard will to some degree always use the wizard |
| 18:19.13 | leifmadsen | and maybe never look at the resulting output |
| 18:19.45 | *** part/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-rilzyqyvkxozdnsl) |
| 18:20.00 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-rilzyqyvkxozdnsl) |
| 18:20.03 | gtjoseph | quite possible but if they use the CLI at all, they'll see the native objects not wizards. |
| 18:20.11 | leifmadsen | yep, I think I'm in agreement. If anything, this wizard could be useful just to generate the initial examples for documentation :) |
| 18:21.26 | gtjoseph | to be clear though, the wizard doesn't generate a pjsip.conf config. it created the objects directly in asterisk. |
| 18:21.27 | leifmadsen | gtjoseph: for your examples, I would prefer to avoid using numbers as the peername |
| 18:21.50 | leifmadsen | maybe I'm just biased, but I don't believe in using numbers for peers... mac addresses or some other unique ident is my preferred |
| 18:21.59 | gtjoseph | i can change those. |
| 18:22.10 | gtjoseph | bob, alice, etc. |
| 18:22.14 | leifmadsen | perfect |
| 18:23.40 | leifmadsen | gtjoseph: for the wizard, does it just build the objects in memory, or can you use it (or does it work) to generate the pjsip.conf file? |
| 18:24.30 | gtjoseph | it doesn't build a conf file, only in memory. I could create a script easily enough though. |
| 18:24.33 | leifmadsen | gtjoseph: configuration reference has mix between default = and default: fyi |
| 18:24.42 | gtjoseph | will fix |
| 18:24.51 | leifmadsen | gtjoseph: I think something that output it from the wizard to a file would be incredibly useful |
| 18:25.03 | leifmadsen | some people might just use this to learn the new syntax and understand the objects |
| 18:25.07 | leifmadsen | including myself |
| 18:25.13 | gtjoseph | good point |
| 18:25.47 | leifmadsen | this is definitely a lower barrier to entry, but not everyone might want to be stuck with the wizard, as I suspect(?) that this isn't going to be realtime enabled? |
| 18:26.06 | leifmadsen | (I'm not sure if pjsip.conf is even realtime enabled either though) |
| 18:26.15 | gtjoseph | I could do a script or add a 'pjsip wizard export' CLI command. |
| 18:27.00 | gtjoseph | it is realtime enabled. you can use extconfig.conf to set it up. |
| 18:27.18 | gtjoseph | pjsip.conf is also realtime enabled via sorcery.conf |
| 18:27.19 | leifmadsen | static realtime or real realtime? :) |
| 18:27.23 | leifmadsen | ah neat |
| 18:27.26 | file | static realtime. |
| 18:27.31 | leifmadsen | makes sense |
| 18:27.33 | file | (his wizard is) |
| 18:27.43 | leifmadsen | sorcery.conf provides real realtime? |
| 18:27.46 | leifmadsen | dynamic* |
| 18:27.58 | leifmadsen | is essentially re-learning Asterisk lately |
| 18:28.13 | file | the sorcery API is pluggable, one of implemented wizards is a wrapper over realtime to allow any sorcery written part to use realtime |
| 18:29.16 | gtjoseph | yeah, the wizard itself isn't sorcery based but I can change that. |
| 18:32.30 | gtjoseph | leifmadsen: let me know when you done with your first pass and i'll make the suggested changes. |
| 18:32.33 | mjordan | leifmadsen: dogs, sleeping with cats |
| 18:32.37 | mjordan | leifmadsen: it's all different |
| 18:32.43 | mjordan | leifmadsen: mass hysteria |
| 18:34.02 | file | mjordan has sorta lost it - so mostly ignore him |
| 18:34.50 | leifmadsen | file: oh I actually have him muted |
| 18:34.58 | leifmadsen | so I didn't know he said anything until you mentioned something |
| 18:35.03 | leifmadsen | gtjoseph: done first pass |
| 18:35.13 | file | did he? |
| 18:35.18 | gtjoseph | cool. thanks for doing that. |
| 18:35.40 | leifmadsen | gtjoseph: np, I'm mostly procrastinating :) |
| 18:35.59 | leifmadsen | gtjoseph: the pjsip_wizard.conf is going to need a lot of really good documentation to explain what it is doing :) |
| 18:36.55 | gtjoseph | I've got comments and examples in the pjsip_conf.sample file but I was hooping the wiki would do most of the heavy lifting. |
| 18:37.04 | gtjoseph | pjsip_wizard.conf.sample |
| 18:37.45 | leifmadsen | makes sense to me |
| 18:37.51 | leifmadsen | I'd prefer to see stuff in the wiki anyways |
| 18:38.22 | gtjoseph | agreed. |
| 18:38.57 | mjordan | leifmadsen: ow |
| 18:39.35 | leifmadsen | mjordan: <3 :D |
| 18:41.29 | *** join/#asterisk-dev leedm777 (~leedm777@nat/digium/x-ihdncshrqpmbgwri) |
| 18:54.18 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-unwmxpmvcqjwqjmk) |
| 19:15.23 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-kbbzbkngxackklpd) |
| 19:15.23 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 19:21.31 | skrusty | evening all |
| 19:22.28 | file | g'evening |
| 19:32.30 | skrusty | dare i ask if you've had a look at the pull request yet for ari-examples? :) |
| 19:32.47 | skrusty | erm... mjordan even, not /me :/ |
| 19:33.07 | file | we're in a meeting |
| 19:34.16 | skrusty | ah, soz :) |
| 19:35.38 | file | puts skrusty on hold |
| 19:35.44 | skrusty | :) |
| 19:37.40 | file | I don't have res_musiconhold loaded though so you just hear nothing |
| 19:39.54 | skrusty | :[ |
| 21:13.00 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 22:17.18 | *** join/#asterisk-dev skrusty (~skrusty@168.63.14.171) |
| 22:23.43 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 22:26.43 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-mcwwjdzcuwghlzrb) |
| 22:26.43 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 22:31.21 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 22:56.48 | gtjoseph | putnopvut: my original patch for the outbound ref leak was decrementing the ref count in handle_registration_response. Is that what you're telling me to do? |
| 23:04.38 | putnopvut | gtjoseph: let me have a look |
| 23:05.02 | gtjoseph | thanks. i thought the original problem was straightforward. :) |
| 23:05.14 | gtjoseph | a +1 with no -1. |
| 23:06.23 | putnopvut | gtjoseph: My suggestion was replacing the call to cancel_registration() in handle_client_registration() with a decrement of the client_state refcount. |
| 23:06.50 | putnopvut | The cancel_registration() call is intended to decrement the refcount there, but it's essentially a no-op since the timer isn't in the pj_timer_heap at that point. |
| 23:07.04 | gtjoseph | Well, I could but that's a non-obvious fix. |
| 23:07.18 | gtjoseph | i'll try it though. |
| 23:07.35 | putnopvut | Honestly, cancel_registration() being used to decrement the stored refcount on the timer entry is non-obvious to begin with. |
| 23:07.43 | gtjoseph | :) |
| 23:10.18 | gtjoseph | actually, in handle _client_registration, i don't think you want to decrement at the start, |
| 23:10.33 | gtjoseph | but i'll test it |
| 23:32.51 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-mcwwjdzcuwghlzrb) |