| 00:10.11 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-iurncomvktgmubyp) |
| 01:34.06 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 01:55.14 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 01:58.14 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 01:58.14 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 03:23.41 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 03:23.41 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 04:03.57 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 04:15.28 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 05:25.23 | *** join/#asterisk-dev snuff-work (~blatus@203-219-29-182.tpgi.com.au) |
| 05:25.23 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 08:23.20 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:23.20 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:28.09 | *** join/#asterisk-dev skrusty (~skrusty@168.63.14.171) |
| 09:30.21 | *** join/#asterisk-dev seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 09:30.21 | *** mode/#asterisk-dev [+o seanbright] by ChanServ |
| 11:47.30 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 12:25.14 | *** join/#asterisk-dev wedhorn (~wedhorn@110-175-181-222.static.tpgi.com.au) |
| 12:26.36 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 12:26.36 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 12:26.36 | *** join/#asterisk-dev babak (uid19622@gateway/web/irccloud.com/x-ymsqubumiazeknoy) |
| 12:26.36 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-hqpuoicxqmxviydp) |
| 12:26.36 | *** join/#asterisk-dev tonyclewis (sid6025@gateway/web/irccloud.com/x-rfevlnxrjuctzwqx) |
| 12:26.36 | *** join/#asterisk-dev cosmicwombat (sid10687@gateway/web/irccloud.com/x-pnenigpqwfapewim) |
| 12:26.36 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-ikgwqqcktffytcfj) |
| 12:26.36 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-bfaxwiijjlyupgqm) |
| 12:26.36 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:437:1:862b:2bff:fead:2cce) |
| 12:26.37 | *** mode/#asterisk-dev [+oo tzafrir pabelanger] by sendak.freenode.net |
| 12:26.49 | *** join/#asterisk-dev snuff-work (~blatus@203-219-29-182.tpgi.com.au) |
| 12:26.49 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 12:26.49 | *** mode/#asterisk-dev [+o snuff-work] by sendak.freenode.net |
| 12:27.00 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 12:27.00 | *** join/#asterisk-dev mbowie (~mbowie@162.212.36.9) |
| 12:27.15 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 12:27.15 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:28.49 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 12:28.49 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-obhszwuepfyjtdnm) |
| 13:00.48 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:28.25 | *** join/#asterisk-dev leedm777 (~leedm777@nat/digium/x-wlmotxhkojdsnshg) |
| 13:33.02 | *** join/#asterisk-dev Marquis42 (~mrbmw@d14-69-246-193.try.wideopenwest.com) |
| 14:23.02 | *** join/#asterisk-dev sgalarneau (~sgalarnea@nat/digium/x-qexpfbuawnanfypr) |
| 14:33.12 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 15:05.55 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-nfgpzbasqafnrlcv) |
| 15:18.51 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-xbdougwrkkqwahiv) |
| 15:18.51 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:56.20 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 16:11.24 | gtjoseph | hey file: if you have a few minutes could you take a quick look at the qualify fixes in 4289 and 4290? |
| 16:12.04 | file | they are on my list |
| 16:12.16 | file | although there are other people |
| 16:13.33 | gtjoseph | yeah, but you're the only one online I can bug. :) |
| 16:43.43 | mjordan | adds them to the list |
| 16:50.35 | mjordan | gtjoseph: over to you :-) |
| 16:50.53 | gtjoseph | :) |
| 16:53.49 | gtjoseph | mjordan: i was just being future safe. Want me to discard 4289? |
| 16:58.41 | mjordan | I think your other review already solves it. |
| 16:58.52 | mjordan | I distrust the scheduler, so any time we are removing items multiple times, I get wary |
| 16:58.57 | mjordan | thar be dragons in that API |
| 16:59.09 | gtjoseph | gotcha i'll discard. |
| 17:05.41 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-wimcqkshjvfrshwr) |
| 17:08.32 | file | lunched |
| 17:43.48 | *** join/#asterisk-dev opticron (~opticron@75.76.148.219) |
| 17:43.48 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 17:49.30 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 18:33.40 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 18:37.34 | *** join/#asterisk-dev sgalarneau (~sgalarnea@nat/digium/x-txzvmgnrvxpplfzm) |
| 18:43.42 | gtjoseph | mjordan: can you give a ship it to r4290 if you're ok with it now. |
| 18:48.43 | mjordan | gtjoseph: actually, the finding I put on there was before I saw your other review |
| 18:48.56 | mjordan | the unschedule_qualify I was referring to is on line 477, in qualify_and_schedule |
| 18:49.04 | mjordan | we call unschedule_qualify on contact creation |
| 18:49.17 | gtjoseph | yeah, I dropped that review |
| 18:49.18 | mjordan | but we probably don't need to do that, if we've unilaterally purged out all of the contact qualifies on a reload |
| 18:49.25 | mjordan | no, that code exists in 13 now |
| 18:49.45 | gtjoseph | ah. now i get it |
| 18:50.22 | gtjoseph | i think that one needs to stay there if a dynamic contact unregisters |
| 18:50.32 | gtjoseph | we still need to unschedule |
| 18:50.58 | gtjoseph | i mena and re-registers |
| 18:51.00 | gtjoseph | mean |
| 18:51.16 | mjordan | Ah |
| 18:51.18 | mjordan | yup. |
| 18:51.52 | mjordan | shipped |
| 18:52.12 | gtjoseph | thanks |
| 19:01.09 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 19:01.09 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 19:03.58 | putnopvut | Bit of a vague question but has anyone else had trouble running the caller_refer_only and callee_refer_only PJSIP blind transfer tests? It appears that PJSUA is segfaulting when attempting to create a transport. If anyone has had this issue before and knows how to fix it, some help would be appreciated. |
| 19:04.13 | putnopvut | Things I've tried: Recompiling PJSIP, re-installing the PJSUA python library. |
| 19:04.51 | gtjoseph | i don't think it's been failing for me but I can test it right now. |
| 19:06.59 | putnopvut | I suspect it's a local problem since the CI build agents are running and passing the tests just fine. |
| 19:07.00 | gtjoseph | both mapped |
| 19:07.04 | gtjoseph | passed |
| 19:08.49 | file | putnopvut, I blame you |
| 19:13.30 | putnopvut | Trying the old "make uninstall" and "make realclean" in pjproject treatment now. |
| 19:17.29 | gtjoseph | i just noticed that sipp 3.4.1 is now required for some tests. When did that happen? |
| 19:17.30 | putnopvut | Nope! |
| 19:18.34 | putnopvut | gtjoseph: I'm not sure exactly. Unfortunately, looking at SIPp's site, it's difficult to see what's new in 3.4.1 exactly. |
| 19:18.46 | gtjoseph | hmmm |
| 19:23.46 | putnopvut | One thing that might help me out a little bit was if the segfault produced a core dump, but it's not. |
| 19:27.06 | putnopvut | Running the built PJSUA app works fine, so apparently it's a problem specifically with the python library. |
| 19:27.07 | putnopvut | HRM |
| 19:29.36 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:35.15 | putnopvut | Yay I figured it out. The _pjsua.c file in pjsip-apps/src/python was apparently out of date and not being re-built. touching that file made it get rebuilt and now the PJSUA python library is happy again. |
| 19:35.16 | putnopvut | yay |
| 19:37.31 | mjordan | silly build systems |
| 19:38.37 | mjordan | gtjoseph: I suspect, although I'm not sure, that itzangler's commit (https://github.com/itzangler) for a bug we found that a test needed was included in that release. |
| 19:39.11 | mjordan | but that's a bit of a wild guess :-P |
| 19:39.42 | gtjoseph | no worries. now i know why my test runs have been so clean. the tests that needed sipp > 3.3 weren't running. :) |
| 19:39.56 | gtjoseph | i'll update the wiki |
| 20:35.20 | *** join/#asterisk-dev sgalarneau (~sgalarnea@nat/digium/x-yxsupmmpwvvjgbbz) |
| 20:38.15 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 20:38.15 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:38.54 | gtjoseph | has anyone actually tried sipp 3.4.1? I get tons of testsuite failures that worked on 3.3 |
| 20:39.09 | gtjoseph | mostly around regexes |
| 20:44.37 | mjordan | Hrm. |
| 20:44.43 | mjordan | They had a bug in it that was fixed in the github repo that did htat |
| 20:44.45 | mjordan | er, that |
| 20:45.02 | gtjoseph | i'll look |
| 20:49.00 | gtjoseph | mjordan: where exactly do you guys pull sipp from? |
| 20:50.21 | mjordan | looks |
| 20:51.16 | mjordan | looks like from a tarball |
| 20:51.28 | gtjoseph | got a name |
| 20:51.30 | gtjoseph | ? |
| 20:51.48 | mjordan | sipp-3.4.1-tar.gz :-P |
| 20:52.00 | mjordan | I'm not sure where we got it from. I would imagine it was from a tagged release off of github |
| 20:52.05 | gtjoseph | yeah, that's what I've got |
| 20:52.15 | mjordan | I don't see a patch that we're appying |
| 20:52.19 | gtjoseph | do you happen to have your ./configure options handy? |
| 20:52.20 | mjordan | or applying even |
| 20:52.47 | mjordan | ./configure --with-pcap --with-openssl |
| 20:53.07 | gtjoseph | weird. that's what i'm using. |
| 20:54.31 | mjordan | yeah... I don't have anything about the tarball other than its name |
| 20:54.41 | gtjoseph | no worries |
| 20:55.31 | mjordan | yay git logs. We did upgrade to 3.4.1 because of a patch itzangler submitted to SIP. We went to that version back on May 1st |
| 20:58.24 | gtjoseph | i think i figured it out. i was using their git/master branch and even though the version is 3.4.1 it's apparently broken. the tarball works. |
| 21:16.38 | *** join/#asterisk-dev angler (~angler@pdpc/sponsor/digium/angler) |
| 21:18.03 | angler | gtjoseph, what issues were you having with SIPp? |
| 21:18.28 | gtjoseph | the version from git master was complaining about every regex match |
| 21:18.33 | file | woah it's angler |
| 21:25.16 | angler | gtjoseph, ah. It looks like there have been a good number of changes since v3.4.1 that the build agents use. |
| 21:25.48 | file | if regexes break then that's bad, not good |
| 21:25.56 | gtjoseph | gotcha. |
| 21:26.39 | angler | I see some regex references in commits since 3.4.1. No idea which caused it though. |
| 21:26.52 | gtjoseph | here's an example failure... Failed regexp match: looking in ' "foo" <sip:foo@65.102.211.9>;tag=9c8fa958-f763-44d2-b1d0-f95afb5ce74f', with regexp '"foo"\s+<sip:foo.*(;tag=.*)'. |
| 21:28.50 | gtjoseph | actually, not sure why it's looking at 65.102.211.9 but it passes with the 3.4.1 tarball. |
| 21:29.28 | gtjoseph | maybe it's something else that's changed. |
| 21:33.23 | angler | The already merged pull request #95 says it fixes issue #86. The issue states that regex was broken by some other previous commit.... Maybe it happened somewhere in there... |
| 22:46.51 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-xbdougwrkkqwahiv) |
| 23:29.18 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 23:41.37 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-nfgpzbasqafnrlcv) |