| 05:45.10 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 06:29.18 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 07:37.21 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:b022:6c94:959c:fd49) |
| 08:44.16 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 09:21.20 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 09:21.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:34.48 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:b1d2:44b2:743a:1108) |
| 11:38.22 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 12:09.11 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:33.21 | *** join/#asterisk-dev danjenkins_ (~dan@199.72.68.202) |
| 13:06.51 | *** join/#asterisk-dev danjenkins_ (~dan@nat/digium/x-mpbgwprkqncmlopl) |
| 13:17.51 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-aiuiuahtmdwlsogp) |
| 13:17.51 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:18.09 | *** join/#asterisk-dev danjenkins__ (~dan@nat/digium/x-acaqbusdruslnufq) |
| 13:59.52 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:59.52 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:00.20 | opticron | so, I'm trying to rewrite the parts of the pjsip_tx_data struct necessary to change the destination of a message, but I seem to be getting everything except what I need to actually change the destination |
| 14:00.20 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-xvjfrfyystjkfhyo) |
| 14:00.56 | opticron | I've tweaked the tp_info to be correct and it shows up correctly in the output of "pjsip set logger ..." |
| 14:01.08 | opticron | I've also set the request URI |
| 14:06.21 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-xkvjlfalztpmbppe) |
| 14:06.21 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:06.48 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:06.48 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:08.02 | file | opticron, when are you trying to change it? |
| 14:11.22 | opticron | hooking it in the nat module at PJSIP_MOD_PRIORITY_TSX_LAYER - 2 |
| 14:12.05 | file | ah - so in that case you need to change dest_info |
| 14:12.15 | file | that's post-resolution |
| 14:12.35 | opticron | ok, that's what I was looking into, but wanted to be sure before I dove into it |
| 14:13.13 | file | Disclaimer: Haven't made the stack do this before. |
| 14:16.09 | opticron | :) |
| 14:19.38 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-jabwyjjmasnchtgy) |
| 14:26.25 | opticron | ugh...getting a pjsip_transport_type_e from a pjsip_transport or pjsip_uri is annoying |
| 14:28.24 | file | from a pjsip_transport is easy - it's in the key I believe |
| 14:29.33 | opticron | ah, it's not the right value |
| 14:29.36 | opticron | err type |
| 14:30.23 | file | hum - you could use type_name to turn it into the enum |
| 14:30.44 | opticron | that's what I'm looking at doing |
| 14:30.58 | opticron | but there are TP variants for IPv4 vs IPv6 |
| 14:31.12 | file | I have faith in you! |
| 14:31.16 | opticron | wheee |
| 14:31.31 | file | wonders if you could put the transport on there without touching the rest |
| 14:32.59 | opticron | already tried |
| 14:33.04 | opticron | but possibly at upper levels |
| 14:33.07 | file | and doesn't the name include the family? |
| 14:33.09 | opticron | before it resolves |
| 14:42.53 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:43.44 | opticron | file, do you know where it resolves? I think I'm just going to push it a little above that |
| 14:43.57 | file | ummmm |
| 14:44.11 | opticron | not all the current hooks, just a new hook that I create |
| 14:44.29 | file | it's not resolved within the module layer, if I remember right from a weeks ago the act of sending is what triggers the resolution (be it sync or async) and then it goes through the layers |
| 14:44.46 | opticron | well crud |
| 14:44.52 | file | that's what I thought as well |
| 14:45.09 | file | it would be really nice if it were done like everything else |
| 14:45.42 | opticron | I have successfully written over the host and port, but the transport just seems to ignore what I set, so I guess I'll go dig for what I'm doing wrong |
| 14:47.44 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 14:59.45 | *** join/#asterisk-dev w9sh (~chatzilla@50-79-224-193-static.hfc.comcastbusiness.net) |
| 15:02.14 | *** join/#asterisk-dev w9sh (~chatzilla@50-79-224-193-static.hfc.comcastbusiness.net) |
| 15:03.14 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:5e0:9436:3921:c70e) |
| 15:04.13 | *** join/#asterisk-dev leifmadsen (~free-mads@asterisk/documenteur-extraordinaire/blitzrage) |
| 15:04.13 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 15:13.15 | gtjoseph | coreyfarrell: how about this: https://gist.github.com/gtjoseph/b3d429fe03cdd7e91d9f |
| 15:21.35 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 15:34.09 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 15:52.51 | *** join/#asterisk-dev puzzled (~patrick@84.105.37.42) |
| 15:53.05 | puzzled | hi |
| 15:53.41 | puzzled | is it already known that 11.13.0 does not compile against libsrtp-1.5.0? |
| 15:54.45 | jsmith | puzzled: Oh, did 1.5 actually get released? |
| 15:55.01 | puzzled | jsmith: yup during LinuxCon |
| 15:55.09 | jsmith | puzzled: Good to know :-) |
| 15:55.15 | puzzled | at least I was there, don't think it's related |
| 15:55.36 | puzzled | error: http://fpaste.org/142901/14135613/ |
| 16:06.14 | puzzled | pseudo patch which fixes the issue for me: http://fpaste.org/142905/41356194/ |
| 16:15.08 | mjordan | puzzled: awesome |
| 16:15.13 | mjordan | puzzled: please do open an issue, as it isn't known |
| 16:15.20 | mjordan | or wasn't. |
| 16:15.22 | mjordan | Now it is known. |
| 16:15.24 | mjordan | :-P |
| 16:15.27 | leifmadsen | :) |
| 16:15.46 | leifmadsen | also I think we found a bug that is open that was noted as being resolved with libsrtp 1.5 |
| 16:15.53 | puzzled | mjordan: will do |
| 16:16.36 | leifmadsen | ah this one: ASTERISK-16665 |
| 16:18.56 | mjordan | I always find it funny when someone asks for us to embed yet another project. Not that I disagree with Inaki... but... |
| 16:19.26 | leifmadsen | yea same |
| 16:19.36 | leifmadsen | embedding projects doesn't make any sense to me |
| 16:19.50 | leifmadsen | sounds like a distro problem :) |
| 16:19.55 | jsmith | leifmadsen: ARG! |
| 16:20.06 | leifmadsen | jsmith: I knew you were kicking around :) |
| 16:20.09 | jsmith | leifmadsen: Are you trying to make me pull out even more hair? |
| 16:20.12 | leifmadsen | (that's also why we build our own RPM packages and deploy from our own repo) |
| 16:20.17 | leifmadsen | jsmith: wait, you still have hair? |
| 16:20.18 | jsmith | doesn't have much hair left... |
| 16:20.29 | leifmadsen | I guess could be pulling your chest hair |
| 16:20.38 | leifmadsen | last resorts :D |
| 16:20.39 | jsmith | leifmadsen: Still have plenty of that :-/ |
| 16:20.42 | leifmadsen | haha |
| 16:20.56 | jsmith | leifmadsen: That's my reserve |
| 16:21.07 | leifmadsen | so far so good on the hair front on this side... |
| 16:31.30 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 16:33.41 | puzzled | mjordan: filed as https://issues.asterisk.org/jira/browse/ASTERISK-24436 |
| 16:33.52 | mjordan | puzzled: awesome, thanks |
| 17:06.09 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.33) |
| 17:12.27 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 17:12.27 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 17:57.08 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 18:26.18 | *** join/#asterisk-dev antiochIst (~taylorhaw@168.244.49.169) |
| 18:26.31 | *** join/#asterisk-dev danjenkins_ (~dan@nat/digium/x-sadusyamodoksmuw) |
| 18:28.25 | antiochIst | Hey guys, bit new here so appologies for any dumb questions. Im writting module to prevent SIP registration trolling. Any ideas on best way to hook into sip register function? |
| 18:30.37 | *** join/#asterisk-dev danjenkins__ (~dan@nat/digium/x-sphoyinbfciqtocn) |
| 18:54.33 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 19:59.51 | gtjoseph | coreyfarrell: ping |
| 20:05.37 | coreyfarrell | gtjoseph: pong |
| 20:06.01 | gtjoseph | hey...could you give a quick look at https://reviewboard.asterisk.org/r/4091/ |
| 20:06.26 | gtjoseph | I got rid of the AC_C_ macro |
| 20:09.04 | coreyfarrell | I'm not hugely against what you've done, but can I ask why you didn't use the AC_LANG_BOOL_COMPILE_TRY with ((char) -1) < 0 ? |
| 20:09.51 | coreyfarrell | I'm not sure if it's actually needed, but configure.ac does check for the existence of limits.h (and doesn't abort if not found). it looks like limits.h is unconditionally included in a couple sources, but asterisk/compat.h conditionally includes it |
| 20:10.09 | gtjoseph | It was the suggested portable alternative to to the macro |
| 20:15.24 | coreyfarrell | so like I said I'm not entirely against it, I don't know of any system that doesn't have limits.h, and from what I can see asterisk will fail to compile without it. one other question, any reason this is only being applied to 12+? |
| 20:16.05 | gtjoseph | I think it's just clearer to explicitly include limits.h. |
| 20:16.25 | gtjoseph | There's no code in pre-12 that needs it |
| 20:16.36 | gtjoseph | and it's unlikely there will be any |
| 20:17.03 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 20:17.27 | coreyfarrell | hmm that seems like something that's hard to know but I guess if someone runs into an issue in 11 then we can back-port |
| 20:18.10 | gtjoseph | I would have discovered it since I compile 11 for arm already. The only code in 12 that needs it is actually in res_statis_recording. |
| 20:18.49 | coreyfarrell | I hit ship it |
| 20:19.06 | gtjoseph | cool. thanks |
| 20:19.48 | coreyfarrell | I'd appreciate if you'd give a little time before committing so wdoekes has a chance to see your change incase he disagrees with me |
| 20:20.13 | gtjoseph | will do |
| 20:20.30 | gtjoseph | wdoekes: ^^ |
| 20:41.41 | jsmith | gtjoseph: I'm pushing updated pjproject RPMs to Koji to attempt to fix the ARM issue you reported |
| 20:41.49 | jsmith | gtjoseph: Are you able to test? |
| 20:41.55 | gtjoseph | any time |
| 20:42.14 | jsmith | gtjoseph: Any particular version of Fedora/RHEL you prefer to test with? |
| 20:42.21 | jsmith | gtjoseph: If so, I'll build that one in Koji first |
| 20:42.22 | gtjoseph | FC20 |
| 20:42.26 | jsmith | ACK |
| 20:42.40 | jsmith | Just as soon as rawhide finishes, F20 will be the next one :-) |
| 20:43.03 | gtjoseph | just ping me when ready |
| 20:44.10 | jsmith | gtjoseph: http://koji.fedoraproject.org/koji/taskinfo?taskID=7899641 |
| 20:44.12 | jsmith | It's building now |
| 20:51.56 | *** join/#asterisk-dev danjenkins_ (~dan@nat/digium/x-guwqkfjohjujrpww) |
| 20:52.26 | jsmith | gtjoseph: I'm going to have to go pick up my son after school. If you have a chance to test between now and Monday, please reply on that bugzilla ticket |
| 20:52.34 | gtjoseph | no problem |
| 20:52.38 | jsmith | gtjoseph: I'm not sure I've fixed it correctly, but hopefully it'll do the trick |
| 20:52.49 | gtjoseph | i'll let you know :) |
| 20:53.00 | jsmith | I don't pretend to like (or understand) that build system :-) |
| 20:53.22 | jsmith | It's a maze with lots of dark and twisty passages :-p |
| 20:53.28 | jsmith | runs off |
| 21:00.22 | *** join/#asterisk-dev danjenkins_ (~dan@nat/digium/x-srigeqpgjtinzapl) |
| 21:03.36 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:17.10 | coreyfarrell | will there be a security bulletin related to poodle? https://access.redhat.com/solutions/1232413 says you need to upgrade openssl and reconfigure ssl services to disable SSLv2/SSLv3. |
| 21:17.59 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 21:20.17 | coreyfarrell | also if anyone has a chance to look at reviews for testsuite REF_DEBUG processing: https://reviewboard.asterisk.org/r/4094/ and https://reviewboard.asterisk.org/r/4038/ |
| 21:27.08 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 21:27.08 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:31.53 | mjordan | coreyfarrell: it's a good idea to do something, although we waffled and then didn't get one out for heartbleed |
| 21:32.05 | mjordan | coreyfarrell: one that thing does bother me is res_xmpp's usage of SSL. |
| 21:32.19 | mjordan | coreyfarrell: I have to head out soon, but I'll take a closer look at it tonight |
| 21:32.28 | coreyfarrell | well heartbleed was simple... if you use SSL you needed to upgrade and replace your certs.. |
| 21:32.46 | coreyfarrell | this new bug is a little more difficult, mitigating requires reconfiguring any service that uses SSL |
| 21:33.46 | coreyfarrell | that is commonly available documents are good enough to tell people that they had to replace certificates after heartbleed and how to do so... for this issue it's different for every service that uses SSL |
| 22:11.27 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 23:10.37 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-xvjfrfyystjkfhyo) |