| 00:29.15 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 00:54.08 | mjordan | file: you around? |
| 00:54.24 | file | yes |
| 00:55.05 | mjordan | so, pondering format capabilities |
| 00:55.13 | mjordan | is there any reason why we don't segment out audio/video types? |
| 00:55.30 | mjordan | that is, why shouldn't a channel have both a set of audio capabilities, and a set of video capabilities? |
| 00:55.57 | file | a channel should have multiple format capabilities, each representing a stream - which carry a specific media type |
| 00:57.29 | file | but if you keep the constraint of 1 stream per type then separating them out would simplify things |
| 00:57.32 | mjordan | k. But a stream has a media type. And in general, we shouldn't be combining capabilities of audio & video |
| 00:57.45 | file | correct |
| 00:57.48 | mjordan | file: well, technically, each stream could have a capability |
| 00:57.55 | file | yes |
| 00:57.56 | mjordan | or share a capability, I suppose |
| 00:57.58 | mjordan | k. |
| 00:58.06 | file | the fact they are together is legacy |
| 00:58.14 | mjordan | yeah and messy |
| 00:58.23 | mjordan | hold on, dog hiding under chair and stuck |
| 00:58.34 | file | awww poor KB |
| 01:01.16 | mjordan | heh |
| 01:01.21 | mjordan | she's not terribly bright. |
| 01:01.40 | mjordan | so yeah. A lot of the mess that occurs with a single video stream is because we attempt to negotiate format capabilities thinking that they're audio |
| 01:01.43 | mjordan | and then we get confused and angry |
| 01:02.23 | file | yes |
| 01:12.07 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 01:12.12 | mjordan | hum hum hm. |
| 01:13.57 | mjordan | file: just as an initial baby step, how about having a 'stream' sub-struct on ast_channel, that had read/write formats and read/write raw formats? |
| 01:14.09 | mjordan | granted, it won't actually use the raw ones much for video :-P |
| 01:14.40 | mjordan | but since that's all internal on channel_internal_api, it's slightly less painful. The biggest pain would be having to specify which media stream you wanted the formats for when accessing the read/write formats |
| 01:15.10 | file | yes |
| 01:15.33 | mjordan | we actually could keep the existing API |
| 01:15.41 | mjordan | and just say that accessing the read/write means "audio" |
| 01:15.56 | mjordan | not sure there's a whole lot of channel drivers outside of SIP/PJSIP that bother with video |
| 01:16.12 | file | eeeeeeeeeks two |
| 01:16.17 | mjordan | ewwwwwwwwww |
| 01:16.21 | mjordan | welp. |
| 01:16.27 | mjordan | <_< |
| 01:16.29 | mjordan | >_> |
| 01:16.39 | file | SQUIRREL! |
| 01:16.43 | mjordan | !_! |
| 01:18.22 | mjordan | blech. Fixing all this is ... sucky. |
| 01:18.29 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 01:18.44 | mjordan | it's like CDR argghs all over again, only worse |
| 01:18.50 | file | yes. |
| 01:34.12 | mjordan | file: how did you envision format capabilities getting destroyed? They're currently calloc'd, but ast_format_cap_destroy was removed from the header |
| 01:39.22 | *** join/#asterisk-dev coreyf1513 (~cfarrell@2001:4830:117f:2:c01b:1111:7697:a826) |
| 02:29.11 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 03:29.59 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 04:24.52 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 08:16.09 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 08:18.49 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 08:51.27 | *** join/#asterisk-dev michael_work (~michael@bzq-112-168-31-118.red.bezeqint.net) |
| 09:01.30 | *** join/#asterisk-dev danjenkins (~dan@cpc4-folk2-2-0-cust105.1-2.cable.virginm.net) |
| 09:16.13 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 09:16.13 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:45.28 | vlad_starkov | Question: I just figured out that for some reason I'm banned to join #asterisk channel. Is there someone who can relax this ban and let me join the channel? Thanks. |
| 10:39.05 | *** join/#asterisk-dev danjenkins (~dan@188.29.164.134.threembb.co.uk) |
| 10:50.45 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 11:12.03 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 11:12.03 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 11:21.05 | file | mjordan, format capabilities are ao2 so you can use ao2_ref/ao2_cleanup - we can wrap those if we want |
| 11:26.54 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 11:40.56 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 11:47.02 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 11:51.05 | mjordan | file: I asked because ast_format_cap_alloc currently returns an ast_calloc'd structure |
| 11:51.23 | mjordan | so... you *could* ao2_cleanup that, but hilarity would ensue :-P |
| 11:51.37 | file | it would whine |
| 11:51.55 | mjordan | and leak an ao2 container |
| 11:51.56 | mjordan | psh |
| 11:52.03 | mjordan | but who needs those anyway |
| 11:52.20 | mjordan | if it's supposed to be ao2_alloc, no worries. Just wanted to make sure I understood the purpose |
| 11:54.11 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 11:58.16 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 12:12.49 | *** join/#asterisk-dev Marquis42 (~mrbmw@d149-67-95-208.try.wideopenwest.com) |
| 12:15.38 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 12:29.19 | file | mjordan, is res_corosync now going to become your baby? |
| 12:30.48 | mjordan | file: no |
| 12:30.56 | mjordan | :-) |
| 12:31.03 | mjordan | I just merely pushed it back to its previous state |
| 12:31.12 | mjordan | (Although: it wouldn't be hard to add presence state to it) |
| 12:31.19 | mjordan | (Or... other............ things. ) |
| 12:31.20 | file | mjordan, come now! it can become your child, like CDRs! |
| 12:31.28 | mjordan | file: I gave that one up for adoption. |
| 12:31.40 | mjordan | 4 sale. Cheap. |
| 12:31.41 | file | NEVER |
| 12:35.29 | Marquis42 | mjordan: I haven't looked at all, but do you know if res_jabber and/or res_xmpp got fixed up to work in the way res_corosync was? |
| 12:37.21 | mjordan | Marquis42: they were |
| 12:37.31 | Marquis42 | yay :) |
| 12:38.08 | mjordan | Marquis42: They were easier to port over to Stasis. res_corosync was tightly integrated to the event system's binary format, which we broke the hell out of |
| 12:38.19 | mjordan | not just a little breakage. A LOT. |
| 12:38.46 | Marquis42 | Ah, gotcha. Makes sense. Obviously it was transporting the binary format directly where jabber and xmpp weren't. |
| 12:38.51 | mjordan | yup |
| 12:39.14 | mjordan | The binary format was, in the end, easy to save. When we first were ripping through that portion of the code and pulling events from the binary format over to Stasis, it didn't seem like it would be |
| 12:39.26 | mjordan | shrugs |
| 12:39.57 | mjordan | (for the most part Stasis is "binary" as well , just different) |
| 12:39.59 | Marquis42 | I see. |
| 12:40.01 | Marquis42 | Right |
| 12:40.16 | file | mjordan, I suppose you could say that. |
| 12:40.27 | mjordan | file: It's all bytes in the end |
| 12:40.34 | file | aren't we all? |
| 12:40.38 | skrusty | :) |
| 12:41.13 | Marquis42 | We're all just another byte in the wall? |
| 12:41.57 | mjordan | Some of us may just be bits |
| 12:42.03 | Marquis42 | haha |
| 13:05.46 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 13:18.03 | leifmadsen | don't touch my bits! |
| 13:18.10 | leifmadsen | I NEED AN ADULT! |
| 13:57.25 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-rvhdlrwachhkohhc) |
| 13:58.28 | file | I could use a set of eyes on https://reviewboard.asterisk.org/r/3472/ and https://reviewboard.asterisk.org/r/3473/ my peeps |
| 14:03.00 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-vrdiudaargworawn) |
| 14:03.01 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:03.33 | opticron | yep, eyes are on them |
| 14:04.10 | file | merci |
| 14:08.22 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:12.43 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:12.44 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:35.37 | gtjoseph | mjordan: mind if i do a quick reviewless commit? When I committed my spinlock stuff I forgot a "spinlock_destroy" implementation. |
| 14:38.54 | *** join/#asterisk-dev otherwiseguy (~otherwise@99-46-2-71.lightspeed.mssnks.sbcglobal.net) |
| 14:40.42 | *** join/#asterisk-dev scouture (~scouture@unaffiliated/scouture) |
| 14:41.21 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-sehktpocmtfbrolx) |
| 14:51.34 | scouture | hey guys. i'd like to submit a patch to the reviewboard, and i was wondering if i needed anyone on the bugtracker to vouch for it, or if i could just go ahead and submit it. |
| 14:52.25 | scouture | it has to do with ASTERISK-18411, which is an issue with dynamic hints used as 'state_interface' for queue members. |
| 14:53.17 | file | provided you have a license agreement on file you can go ahead and submit it |
| 14:53.36 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-wtziuuejdixoaozf) |
| 14:53.37 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:56.26 | scouture | file: great, thanks |
| 15:01.12 | mjordan | gtjoseph: go for it |
| 15:01.50 | gtjoseph | thx |
| 15:19.34 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 16:43.27 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 16:45.25 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:54.09 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-joaxidgczpuxllqg) |
| 17:43.34 | *** join/#asterisk-dev otherwis_ (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 18:17.11 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:20.48 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.153.51) |
| 19:30.45 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 19:30.46 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 19:37.01 | *** join/#asterisk-dev Zoran034 (~zoran@109-93-161-74.dynamic.isp.telekom.rs) |
| 19:37.38 | Zoran034 | hello |
| 19:37.47 | Zoran034 | i'm glad that here |
| 19:38.09 | Zoran034 | is there anybody who programming Asterisk AMI with Qt |
| 19:51.02 | *** join/#asterisk-dev danjenkins (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 20:16.32 | *** join/#asterisk-dev danjenkins_ (~dan@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 20:26.24 | *** join/#asterisk-dev otherwis_ (~otherwise@23-255-171-52.mci.googlefiber.net) |
| 20:40.54 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 20:40.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:32.58 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 22:38.50 | *** join/#asterisk-dev coreyf1513 (~cfarrell@2001:4830:117f:2:c01b:1111:7697:a826) |
| 23:01.39 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-rvhdlrwachhkohhc) |