| 01:38.10 | *** join/#asterisk-dev willwh (~willwh@unaffiliated/willskills) |
| 05:59.49 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 05:59.49 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:20.50 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 09:10.17 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 09:20.47 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 09:20.47 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:47.05 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 12:22.03 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 12:27.39 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:24.02 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-ejqriabxkjuvaejo) |
| 13:24.02 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:35.07 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-vlvdrwtfwnwaxdui) |
| 13:48.30 | mjordan | I hate optional API. |
| 13:49.01 | file | mjordan, yessssssssss |
| 13:49.05 | mjordan | file: are you able to load res_monitor on trunk? |
| 13:49.37 | file | uhhhhh no |
| 13:49.50 | mjordan | k, at least it's consistent across my machine, yours, and the build agents |
| 13:50.19 | mjordan | Hm. |
| 13:50.43 | mjordan | wonders if func_periodic_hook should have the global symbols flag |
| 13:51.09 | file | methinks yes |
| 13:58.58 | file | achoo. |
| 14:05.17 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:8409:ed45:809b:3984) |
| 14:11.25 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:11.25 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:19.28 | mjordan | russellb: ping |
| 14:19.39 | russellb | mjordan: pong |
| 14:22.32 | russellb | http://blogs.gnome.org/markmc/2014/02/20/naked-pings/ :-p |
| 14:23.10 | file | russellb, ping ping ping |
| 14:23.26 | leifmadsen | file: put it away |
| 14:27.38 | mjordan | blah. Silly releasing distracted me. |
| 14:27.45 | mjordan | so, yeah. Does res_monitor load for you on trunk? |
| 14:30.12 | *** join/#asterisk-dev anonymouz666 (~anonymouz@187.76.181.102) |
| 14:32.42 | russellb | looks like i broke it. i'll deal with it. sorry. |
| 14:33.23 | pabelanger | .dealwithit |
| 14:34.18 | mjordan | russellb: no worries |
| 14:35.22 | russellb | tested mixmonitor, not monitor |
| 14:35.26 | russellb | oh well |
| 14:35.32 | mjordan | I totally didn't even notice it until I looked at a log on a build agent |
| 14:35.38 | mjordan | since we have no tests for monitor, nothing caught it |
| 14:35.44 | mjordan | (because monitor is silly and dumb) |
| 14:36.09 | mjordan | also: OPTIONAL API. Neither optional nor an API. Discuss amongst yourselves. |
| 14:36.26 | russellb | make mixmonitor able to not mix, can drop it i think |
| 14:36.35 | mjordan | pretty sure it can do that |
| 14:36.39 | mjordan | looks |
| 14:36.40 | russellb | well then |
| 14:36.54 | russellb | if so, write an app that just converts args to mixmonitor :) |
| 14:37.24 | mjordan | yup, that's the 'r' and 't' option. Alas, 11 only |
| 14:37.45 | mjordan | it would be nice to rip Monitor out completely in trunk. |
| 14:37.50 | file | heck to the yes |
| 14:37.55 | russellb | right |
| 14:38.02 | russellb | ideally would have a shim for backwards compat though |
| 14:38.04 | russellb | is what i was saying |
| 14:38.06 | mjordan | yup |
| 14:38.11 | mjordan | no reason to not do that |
| 14:38.18 | russellb | sounds like work |
| 14:38.21 | russellb | but not much work at least |
| 14:38.21 | mjordan | ew |
| 14:38.24 | mjordan | work |
| 14:38.26 | mjordan | I don't do that |
| 14:38.27 | russellb | ikr |
| 14:39.45 | Marquis42 | I've got a patch that does most of the work there, although it assumes bidirectional monitoring since it was originally written for 1.8. But porting to trunk and adding support for one-sided monitoring shouldn't be hard. |
| 14:39.53 | *** join/#asterisk-dev otherwiseguy (~otherwise@99-46-2-71.lightspeed.mssnks.sbcglobal.net) |
| 14:41.51 | mjordan | ASTERISK-23657 |
| 14:42.36 | Marquis42 | mwahahahaha :) |
| 14:42.45 | russellb | wtf @ this res_monitor error |
| 14:42.54 | mjordan | russellb: I know, right? |
| 14:43.11 | mjordan | I threw the global symbol flag in func_periodic_hook as well, and my joy was less than full |
| 14:43.13 | russellb | mixmonitor loads fine |
| 14:43.29 | russellb | mjordan: right, thought that was it |
| 14:43.35 | russellb | i didn't add stuff to funcs/func_periodic_hook.exports |
| 14:43.44 | mjordan | russellb: you may have to make beep.h not optional api-ish |
| 14:43.44 | russellb | and looks like it should be in main/asterisk.dynamics maybe |
| 14:43.47 | russellb | but that doesn't fix it |
| 14:44.11 | russellb | mjordan: if it's not optional, then monitor/mixmonitor will hard require it right? that's not ideal |
| 14:44.27 | russellb | but why does mixmonitor load and monitor doesn't ... annoying |
| 14:46.02 | russellb | rages out loud while figuring it out |
| 14:50.55 | leifmadsen | I'm not opposed to res_monitor going away |
| 14:51.01 | leifmadsen | in case my opinion matters :) |
| 14:52.09 | file | leifmadsen, who are you? |
| 14:52.13 | russellb | i'm tempted to do that instead of fixing this bug |
| 14:53.02 | leifmadsen | russellb: I think Marquis42 did some of this work already to be honest |
| 14:53.08 | leifmadsen | maybe he can provide you the patch :) |
| 14:53.14 | file | he did, he already mentioned it up there ^^^ |
| 14:53.15 | russellb | yeah he said that a few minutes ago |
| 14:53.23 | leifmadsen | I'm confirming what he stated |
| 14:53.30 | leifmadsen | my work here is done |
| 14:53.31 | Marquis42 | russellb: If you want to and have time before I would, I can forward you the patch. |
| 14:53.45 | russellb | maybe. |
| 14:53.54 | leifmadsen | otherwise Marquis42 is going to do it :) |
| 14:53.58 | leifmadsen | since he already had most of the work done |
| 14:54.17 | Marquis42 | Indeed I will, eventually. :) Probably not this week, though, if you're anxious to make it happen sooner. |
| 14:54.38 | russellb | OH |
| 14:54.41 | russellb | i bet i know what it is. |
| 15:00.39 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:01.54 | russellb | mjordan: give that a shot |
| 15:02.17 | russellb | well, after i properly commit |
| 15:02.24 | russellb | forgot to propset_txt |
| 15:03.01 | file | he has temporarily ceased to exist |
| 15:03.14 | russellb | oic |
| 15:03.48 | file | a speaker from NASA is talking about the Space Launch System they are working on at Redstone |
| 15:04.03 | leifmadsen | sounds like minecraft and KSP |
| 15:04.14 | russellb | woot |
| 15:04.17 | russellb | well anyway, committed |
| 15:04.18 | russellb | works on my bos |
| 15:04.21 | russellb | box |
| 15:04.23 | russellb | must mean it's perfect |
| 15:05.15 | file | I will TEST |
| 15:09.54 | file | confirmed |
| 15:20.44 | *** join/#asterisk-dev otherwis_ (~otherwise@172.56.10.0) |
| 16:07.59 | *** join/#asterisk-dev otherwis_ (~otherwise@99-46-2-71.lightspeed.mssnks.sbcglobal.net) |
| 16:08.48 | *** join/#asterisk-dev datachomper (~russ@nat/digium/x-mzzrpkgeovglmufd) |
| 16:13.10 | *** join/#asterisk-dev otherwiseguy (~otherwise@172.56.10.0) |
| 16:32.18 | *** join/#asterisk-dev datachomper (~russ@nat/digium/x-zjewavjrwlikxaon) |
| 16:55.27 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 17:08.23 | mjordan | sorry, mjordan was out and then mjordan made releases and now mjordan is going to yes yet another meeting but mjordan believes russellb fixed the issue. Thanks :-) |
| 17:14.55 | russellb | yay |
| 17:36.33 | *** join/#asterisk-dev puzzled (~patrick@puzzled.xs4all.nl) |
| 17:36.37 | puzzled | hi |
| 17:37.25 | puzzled | when creating a "New Review Request" I need to provide at least one reviewer or group. What do enter there? |
| 17:37.39 | file | asterisk-dev for group |
| 17:38.12 | puzzled | file: thanks |
| 17:38.59 | mjordan | puzzled: https://wiki.asterisk.org/wiki/display/AST/Code+Review |
| 17:39.28 | puzzled | mjordan: thanks |
| 17:49.05 | puzzled | iirc I should paste it in here too so: https://reviewboard.asterisk.org/r/3474/ |
| 18:03.30 | *** join/#asterisk-dev danjenkins_ (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 18:19.07 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-hwvqksxiskwrpueu) |
| 18:19.07 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 18:29.48 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 18:29.48 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:42.05 | coreyf1513 | russellb: maybe the optional api problem is caused by res_monitor exporting global symbols itself where app_monitor doesn't? |
| 18:42.25 | russellb | yeah that's what i figured |
| 18:42.35 | russellb | i didn't dig long enough to figure out exactly what was going on though |
| 18:42.45 | russellb | that's the main diff between the 2 modules though |
| 18:43.10 | russellb | also seemed odd that app_mixmonitor worked though |
| 18:43.19 | russellb | since func_periodic_hook wasn't set up to export symbols |
| 18:43.35 | russellb | but *shrug* |
| 18:43.45 | coreyf1513 | no, I mean since app_mixmonitor doesn't export globals, nothing forced it to resolve all symbols at dlopen time |
| 18:43.58 | russellb | oh |
| 18:44.05 | russellb | meaning it would have broken if it ran? |
| 18:44.12 | russellb | swears he tested mixmonitor |
| 18:44.22 | russellb | but maybe i didn't re-test after converting it to the optional_api junk? |
| 18:44.45 | coreyf1513 | I'm thinking if res_monitor didn't export globals it might have worked |
| 18:55.18 | *** join/#asterisk-dev dwayne (~dwayne@c-71-207-208-112.hsd1.al.comcast.net) |
| 19:12.23 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 19:38.35 | gtjoseph | hey file: if you've got a minute this afternoon can you do a final once-over on https://reviewboard.asterisk.org/r/3405/ |
| 19:39.04 | file | already there, in a half unconscious state |
| 19:39.36 | gtjoseph | glass half empty, eh? |
| 19:39.47 | file | tacos. |
| 19:40.48 | file | go for it. |
| 19:41.04 | gtjoseph | cool, thanks! |
| 19:50.45 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 19:50.45 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:58.59 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 22:11.47 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 22:12.42 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-vlvdrwtfwnwaxdui) |
| 22:29.51 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 23:50.08 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 23:54.31 | *** join/#asterisk-dev bsutton (~chatzilla@203-206-183-204.perm.iinet.net.au) |
| 23:54.48 | *** join/#asterisk-dev roderickm (~roderickm@99-124-89-102.lightspeed.dctral.sbcglobal.net) |
| 23:55.10 | bsutton | I'm looking for some advice on submitting enhancements to asterisk |
| 23:55.42 | bsutton | We have developed three queue related enhancements under asterisk 1.4 and are looking to port this to asterisk 11 or 12 |
| 23:56.19 | bsutton | The enhancements are: global queue priorities, priority escalation and an 'extended' wrap which is terminated via a manager api call. |
| 23:58.10 | bsutton | I would guess that 11 is closed to feature enhancements but I want to check that the community will accept enhancements to 12 |
| 23:58.31 | bsutton | can anyone confirm that the community will accept enhancements to 11 and/or 12? |
| 23:58.49 | WIMPy | That would probably have tobe for 13. |
| 23:59.11 | bsutton | really I was hoping not. |
| 23:59.33 | bsutton | when you say 'probably' what exactly do you mean? |