| 00:21.43 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 01:25.18 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 03:25.59 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 06:01.53 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 06:21.35 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 06:21.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:57.58 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 07:24.09 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 07:54.43 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 07:54.43 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:01.32 | oej | Hello folks |
| 08:23.03 | *** join/#asterisk-dev Oggu (0596c716@gateway/web/freenode/ip.5.150.199.22) |
| 08:28.40 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:35.09 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 09:17.25 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:fcdb:5627:f4f1:da3b) |
| 09:54.22 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 09:58.48 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 10:46.51 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 10:46.51 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:34.35 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 11:45.06 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 11:59.16 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:18.02 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 12:24.39 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 12:50.34 | jsmith | Greetings all |
| 13:01.45 | seanbright | o/ |
| 13:17.05 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 13:27.19 | rustlebee | \o |
| 13:29.00 | seanbright | .dance |
| 13:29.03 | seanbright | heh |
| 13:30.16 | rustlebee | <("<) ^("^) (^")^ (>")> |
| 13:31.43 | seanbright | perfect |
| 13:32.13 | rustlebee | glad i could contribute something today |
| 13:32.57 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:f460:f622:d628:a5f3) |
| 13:50.17 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-dopwczxxgnjwjzrz) |
| 13:50.17 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:07.28 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-qoyxucmzhyzncmwx) |
| 14:20.41 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-htvwyiecmybetrpo) |
| 14:21.28 | *** join/#asterisk-dev Fwny (~potato@192-0-250-120.cpe.teksavvy.com) |
| 14:24.09 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-tchizuejhbujxknx) |
| 14:34.50 | *** join/#asterisk-dev vlad_starkov (~vlad_star@nat.canmos.ru) |
| 14:37.28 | *** join/#asterisk-dev vlad_starkov (~vlad_star@nat.canmos.ru) |
| 14:38.07 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@nat.canmos.ru) |
| 14:39.11 | *** join/#asterisk-dev vlad_st__ (~vlad_star@109.188.125.109) |
| 14:44.10 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-hsurnswnrwsjldqw) |
| 15:04.43 | seanbright | is this safe for 12: |
| 15:04.44 | seanbright | http://paste.ubuntu.com/7131015/ |
| 15:14.41 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 15:17.24 | seanbright | UGH |
| 15:18.49 | seanbright | i break builds. |
| 15:30.48 | seanbright | and aelparse is why we can't have nice things. |
| 15:31.56 | Marquis42 | heh |
| 15:31.59 | Marquis42 | What's wrong with aelparse? |
| 15:33.06 | seanbright | well... it's a long story |
| 15:33.26 | seanbright | in ael.flex i changed an ast_log(LOG_NOTICE... to an ast_debug(1, ... |
| 15:33.34 | seanbright | well ast_debug references AST_MODULE |
| 15:33.42 | seanbright | which works fine for res/ael/* |
| 15:33.48 | seanbright | but fails miserably for utils/aelparse.c |
| 15:33.56 | seanbright | because there ain't no AST_MODULE there |
| 15:34.20 | Marquis42 | Well there's your problem. :P |
| 15:43.47 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:43.58 | Qwell | Can we kill AEL? |
| 15:46.56 | seanbright | i use it |
| 15:46.59 | seanbright | so no |
| 15:47.13 | seanbright | anyone against me adding a call to sed in the utils Makefile? |
| 15:47.14 | seanbright | no? |
| 15:47.16 | seanbright | ok great. |
| 16:19.42 | oej | sed rocks. |
| 16:21.53 | rustlebee | seanbright: utils/ has been a disaster for a while because of the lack of ability to use any asterisk code as a library |
| 16:22.25 | rustlebee | there's a ton of stuff we did in asterisk that in retrospect, would have been super useful independent libraries |
| 16:22.28 | rustlebee | live and learn |
| 16:28.00 | seanbright | indeed. |
| 16:35.11 | *** join/#asterisk-dev Jacke (~jacke@iam.ss7.pl) |
| 16:45.17 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 16:45.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:56.13 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.109) |
| 17:21.36 | tm1000 | newtonr: hey you around |
| 17:21.52 | newtonr | tm1000, some say so |
| 17:22.01 | tm1000 | newtonr: is Scott in the office today? |
| 17:26.59 | newtonr | tm1000, which one? Griepentrog? |
| 17:27.07 | tm1000 | yes |
| 17:27.20 | newtonr | tm1000, i think he is working remotely, i'll ping him |
| 17:34.48 | newtonr | tm1000, He is not responding at this moment. Do you have his E-mail ? |
| 17:41.45 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.109) |
| 17:58.54 | tm1000 | newtonr: yeah ill email him :-) |
| 18:12.30 | opticron | jrose_atDigium, continuing the conversation about the change in behavior for bridge subscriptions referenced in https://reviewboard.asterisk.org/r/3361/ |
| 18:13.34 | opticron | I don't see how the additional subscription could fail to be torn down unless the after bridge callbacks got removed from the channel (which were added in res/stasis/control.c) |
| 18:13.40 | jrose_atDigium | opticron: The behavior I was noticing was as follows - if the channel in a stasis app is added to the bridge, the subscription to the bridge is added to the application. From there, if you attempt to use ARI to delete the subscription to the bridge from the application once, the subscription lingers. The second time, the subscription is removed. If the channel is removed from the bridge, the subscription also lingers unle |
| 18:13.40 | jrose_atDigium | ss you deliberately delete the subscription afterwards. |
| 18:13.57 | jrose_atDigium | I'll check to see if the after bridge callback is being ran or not. |
| 18:18.32 | jrose_atDigium | Yeah, the callback is being raised. |
| 18:18.43 | jrose_atDigium | It calls into unsubscribe. |
| 18:18.56 | jrose_atDigium | When it does, the forwards->interested value is 2, so the subscription stays alive. |
| 18:19.05 | opticron | :/ |
| 18:19.08 | jrose_atDigium | because it drops down to 1 instead of 0. |
| 18:19.27 | jrose_atDigium | So somewhere, the forwards->interested value was bumped twice. |
| 18:19.35 | opticron | what about the subscription created in the stasis loop in res_stasis.c? |
| 18:19.50 | opticron | there are two automatic subscriptions created |
| 18:20.23 | opticron | one begins before the bridge is created and ends right as the channel exits the bridge (the one I recently added) |
| 18:21.11 | opticron | the other is managed in the stasis app loop and gets added while the channel is already in the bridge and removed a bit after the channel exits the bridge |
| 18:21.19 | jrose_atDigium | Looking into it |
| 18:21.48 | jrose_atDigium | The other subscription doesn't appear to make it into unsubscribe. |
| 18:22.12 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-olzxrkdvncuxdcfw) |
| 18:22.33 | opticron | odd |
| 18:22.34 | jrose_atDigium | As in, when the channel is removed, unsubscribe is only called once and only by the after bridge callback. |
| 18:27.55 | jrose_atDigium | It looks to me like the only real reason for an application to drop that extra subscription to the bridge is if the channel it is controlling either enters a new bridge or it stops controlling that channel. |
| 18:28.04 | jrose_atDigium | opticron: ^ |
| 18:28.14 | opticron | ooooh |
| 18:28.16 | opticron | looks |
| 18:29.18 | jrose_atDigium | Actually... scratch that, looks like the subscription lingers even if the channel enters a new bridge. Rats. |
| 18:29.26 | file | weird... |
| 18:36.59 | jrose_atDigium | *snort* I think I see what the issue is |
| 18:37.25 | jrose_atDigium | every pass of the main control loop in stasis_app_exec initializes bridge to NULL |
| 18:37.51 | jrose_atDigium | Then as long as the ast_check_hangup_locked check passes, it then sets last_bridge to bridge... |
| 18:37.59 | jrose_atDigium | so last_bridge is always set to NULL immediately. |
| 18:38.05 | jrose_atDigium | in every pass of the loop. |
| 18:40.04 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-fumeievppmbbxwib) |
| 18:41.19 | jrose_atDigium | opticron: Yep, moving the initialization of bridge to the beginning of the function fixed the problem. |
| 18:41.46 | jrose_atDigium | And if I had to guess... that'll make the test pass without mjordan's changes. |
| 18:42.03 | jrose_atDigium | fortunately I don't actually... have to guess. I can just run the test. |
| 18:42.38 | jrose_atDigium | oh wait |
| 18:42.44 | jrose_atDigium | I forgot the other obvious thing... |
| 18:42.58 | jrose_atDigium | unsubscribing manually still only reduces the interested count by 1. |
| 18:43.02 | jrose_atDigium | So it doesn't fix the test. |
| 18:43.23 | jrose_atDigium | Iiiin any event, it fixes the legitimate problem that was uncovered. |
| 18:43.49 | jrose_atDigium | I'll have a patch up on reviewboard in a moment. |
| 18:44.18 | opticron | hooray! |
| 19:04.13 | jrose_atDigium | opticron: https://reviewboard.asterisk.org/r/3380/ |
| 19:04.13 | jrose_atDigium | So this does make me think of another question... |
| 19:04.13 | jrose_atDigium | and that's whether or not automatically created subscriptions should be allowed to be deleted by ARI? |
| 19:05.55 | opticron | proooobably not is my opinion |
| 19:06.12 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 19:06.24 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 19:06.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:06.53 | opticron | as that's one of the comments in mjordan's review to fix the subscribe-bridge test |
| 19:11.43 | jrose_atDigium | I'll add a comment to mjordan's review then. It looks like he might have thought this was somehow safeguarded when in reality it was just two subscriptions. |
| 19:20.55 | seanbright | who is the resident sorcery expert when file isn't around? |
| 19:21.08 | file | what's the question? |
| 19:21.12 | seanbright | oh hi |
| 19:21.35 | file | if it's about realtime + sorcery then jrose_atDigium wrote the page on it, quite literally |
| 19:21.42 | file | and putnopvut has wrestled with it recently |
| 19:22.02 | jrose_atDigium | That hardly makes me an expert. |
| 19:22.05 | seanbright | ok, well here is what i am trying to accomplish |
| 19:22.30 | seanbright | jrose_atDigium: i am following your wiki page |
| 19:22.44 | seanbright | but i want pjsip.conf to be consulted/searched before realtime |
| 19:23.28 | jrose_atDigium | I haven't actually dealt with using both pjsip.conf and realtime at the same time unfortunately. |
| 19:23.43 | seanbright | k |
| 19:23.48 | jrose_atDigium | I'm not sure if there is a way to set a preferred order or not. |
| 19:23.58 | jrose_atDigium | Or even if both can be consulted in the same configuration. |
| 19:24.03 | file | they can be. |
| 19:24.18 | file | endpoint=config,pjsip.conf,criteria=type=endpoint |
| 19:24.37 | file | seanbright, add that to your sorcery.conf after the endpoint=realtime line |
| 19:24.43 | file | or rather, before |
| 19:24.47 | seanbright | roger |
| 19:24.56 | file | same goes for the other types - just change the line accordingly |
| 19:25.05 | file | and yes this should be documented but isn't cause I suck |
| 19:25.26 | jrose_atDigium | There you go. The real expert on sorcery + anything remains the person who wrote sorcery. AKA the sorcerer |
| 19:25.47 | file | wizard hierarchy! |
| 19:25.51 | file | grand wizard! |
| 19:25.57 | jrose_atDigium | you don't want to go there file |
| 19:28.11 | seanbright | it sorta works |
| 19:28.17 | seanbright | duplicates the endpoint for some reason |
| 19:28.28 | seanbright | http://paste.ubuntu.com/7132289/ |
| 19:28.52 | file | duplicates? |
| 19:29.39 | seanbright | yeah |
| 19:29.47 | seanbright | pjsip show endpoints shows the same endpoint twice |
| 19:29.59 | file | they aren't in both are they? |
| 19:30.09 | seanbright | they are not |
| 19:30.14 | file | weirddddddd |
| 19:30.51 | seanbright | pjsip.conf -> http://paste.ubuntu.com/7132296/ |
| 19:31.11 | file | yeah that's all fine |
| 19:31.34 | seanbright | i'm doing autoload = yes |
| 19:31.39 | seanbright | maybe there is something loading that shouldn't? |
| 19:31.52 | file | shouldn't do that even if there was |
| 19:32.30 | file | I have no explanation, unless recent sorcery changes or caused a regression |
| 19:33.45 | gtjoseph | file: seanbright not related to this is it? https://reviewboard.asterisk.org/r/3326/ |
| 19:34.02 | file | ah |
| 19:34.52 | seanbright | mayhaps |
| 19:34.56 | seanbright | let me take a gander |
| 19:37.36 | seanbright | yup. putnopvut's patch fixed it. |
| 19:39.02 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 19:41.04 | seanbright | thanks gtjoseph |
| 19:41.23 | gtjoseph | no problem |
| 19:41.37 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.159.253) |
| 20:06.12 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 20:09.36 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-cwhbegvhhbnvekjq) |
| 20:09.45 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 20:10.35 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 20:23.09 | seanbright | file: any way to invalid a sorcery cache? |
| 20:23.12 | seanbright | invalidate* |
| 20:23.51 | file | not currently - eventually I'd expect time based invalidation and manual invalidation to come into existence |
| 20:24.58 | seanbright | well, i've gotten it down to 6 queries to authenticate a dynamic realtime endpoint |
| 20:25.04 | seanbright | it was 7 with chan_sip |
| 20:25.06 | seanbright | so that's a win |
| 20:27.04 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 20:47.03 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 20:50.38 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 20:51.37 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 21:00.01 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 21:32.43 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 21:35.16 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 21:43.27 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 21:56.41 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-mmvgwonebqnusvtd) |
| 22:06.02 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 22:41.45 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-htvwyiecmybetrpo) |
| 23:18.16 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 23:25.30 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-bxphcfoyizzwjiyp) |