| 00:21.58 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 01:22.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 02:22.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 03:22.25 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 04:22.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 05:22.18 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 05:28.31 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 06:00.03 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 06:22.19 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 06:25.05 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 06:25.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:22.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 07:27.56 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 07:29.11 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 07:29.12 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:55.58 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:17.32 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6d04:7a25:2cf0:e2bb) |
| 08:22.17 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 08:25.18 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 08:25.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:32.07 | oej | Morning folks! |
| 08:33.24 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:45.48 | skrusty | morning all |
| 08:46.00 | skrusty | nice to see the ari bridge audio queue issue being picked up! |
| 08:46.19 | skrusty | looking forwards to that being resolved |
| 09:16.27 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:ac9c:1330:d156:8052) |
| 09:22.19 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 09:37.54 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 09:37.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 10:07.48 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 10:18.25 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 10:22.19 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 11:22.21 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 11:54.46 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 12:07.11 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 12:18.56 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:22.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 12:37.02 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 12:38.11 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 12:38.11 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 12:56.29 | file | skrusty, there you go... you can now specify that you want DTMF events when creating a bridge! ^_^ |
| 12:59.55 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 13:01.45 | *** join/#asterisk-dev Devon_ (~Devon_@63.214.236.169) |
| 13:07.50 | sgriepentrog | coreyf1513: do you want me to post your patch to rb or did you want to do so yourself? |
| 13:10.02 | skrusty | file: yay! :) |
| 13:10.16 | skrusty | feels all warm anf fluffy inside |
| 13:18.45 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 13:38.04 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:38.04 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 13:57.16 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 14:21.02 | *** join/#asterisk-dev mjordan (~matt@nat/digium/x-rzsfxogoyibzowlm) |
| 14:21.02 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:26.37 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-mhosbmkmhodvvwjf) |
| 14:40.37 | *** join/#asterisk-dev vlad_starkov (~vlad_star@nat.canmos.ru) |
| 14:46.31 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-jfcfvemnoxpntuhn) |
| 14:48.07 | *** join/#asterisk-dev vlad_starkov (~vlad_star@nat.canmos.ru) |
| 14:48.59 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@nat.canmos.ru) |
| 15:41.36 | *** join/#asterisk-dev otherwiseguy (~otherwise@99-46-2-71.lightspeed.mssnks.sbcglobal.net) |
| 16:32.31 | *** join/#asterisk-dev vlad_starkov (~vlad_star@nat.canmos.ru) |
| 16:41.08 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 16:41.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:20.45 | coreyf1513 | sgriepentrog: I'll post it in a few minutes |
| 17:31.05 | sgriepentrog | ko |
| 18:22.12 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 18:26.41 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 19:04.37 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 19:04.37 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:34.34 | *** join/#asterisk-dev otherwiseguy (~otherwise@99-46-2-71.lightspeed.mssnks.sbcglobal.net) |
| 20:17.30 | leifmadsen | if one was going to add a call to ast_manager_event() in app_mixmonitor.c, I'm thinking it should go into stop_mixmonitor_exec() (I want to create a StopMixMonitor event). I'm unsure if I should put this above or below the ast_channel_unlock(chan) ? |
| 20:21.10 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 20:26.45 | pabelanger | under? Since you don't want to lock held while you do AMI stuff? |
| 20:26.51 | pabelanger | Note, I did not look at code |
| 20:26.55 | pabelanger | or am I an expert |
| 20:29.05 | leifmadsen | yea, my gut told me under as well... but who knows |
| 20:30.01 | leifmadsen | guess I'll try it out :) |
| 20:32.23 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 20:33.53 | coreyf1513 | leifmadsen: in trunk the only call to ast_manager_event() is from main/channel.c:__ast_change_name_nolink - this is run with chan is locked |
| 20:35.16 | leifmadsen | coreyf1513: uhhh... that can't be true :) |
| 20:35.22 | leifmadsen | coreyf1513: I see several of them in the apps/ dir |
| 20:35.51 | *** join/#asterisk-dev Marquis42 (~mrbmw@c-98-224-144-181.hsd1.mi.comcast.net) |
| 20:37.52 | coreyf1513 | leifmadsen: I just did a grep of all *.c and *.h in trunk for 'ast_manager_event\s*(', it's showing the define and the use in channel.c |
| 20:38.17 | leifmadsen | maybe it was renamed in trunk |
| 20:38.23 | leifmadsen | I'm working on 1.8 (and it's called the same in 12) |
| 20:38.38 | leifmadsen | don't grep with a space |
| 20:38.44 | leifmadsen | ast_manager_event(chan, EVENT_FLAG_CALL, "MixMonitorStop", |
| 20:38.48 | leifmadsen | would be an example |
| 20:39.05 | coreyf1513 | leifmadsen: I know \s* is 0 or more spaces, I added it to make sure I didn't miss anything when I saw only 1 |
| 20:39.13 | leifmadsen | ah |
| 20:39.18 | leifmadsen | I suck at regex |
| 20:39.49 | file | yeah it doesn't quite exist like that in trunk anymore as everything is stasis |
| 20:39.53 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.159.253) |
| 20:40.14 | coreyf1513 | odd that one use got left behind |
| 20:41.32 | leifmadsen | file: makes sense |
| 20:41.36 | leifmadsen | coreyf1513: no, that is one I built |
| 20:41.49 | leifmadsen | like I said, I'm modifying 1.8 |
| 20:45.16 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip24-251-34-116.ph.ph.cox.net) |
| 20:49.58 | coreyf1513 | leifmadsen: in any case I think chan should be unlocked after running ast_manager_event. ast_manager_event isn't consistently called with the channel locked, but it does access (read) the channel without locking |
| 20:50.33 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 20:50.35 | leifmadsen | coreyf1513: thanks! |
| 20:50.37 | leifmadsen | before lock it is |
| 20:50.40 | leifmadsen | errr |
| 20:50.43 | leifmadsen | before unlock it is. |
| 20:50.44 | coreyf1513 | so cases where it's called while chan is unlocked are thread safety bugs |
| 20:50.53 | coreyf1513 | err probably bugs I should say |
| 20:54.58 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 20:54.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:00.08 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:21.46 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 21:50.55 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 21:50.55 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:57.10 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 21:58.10 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 22:27.25 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 22:44.46 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-mhosbmkmhodvvwjf) |
| 22:52.29 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 23:27.19 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 23:32.16 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |