| 00:23.20 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 00:48.18 | *** join/#asterisk-dev jmls1 (~julian@77.107.171.82) |
| 00:51.42 | *** join/#asterisk-dev moy (~moy@70.25.53.39) |
| 00:52.22 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 00:52.53 | *** join/#asterisk-dev spditner (~simon@206.248.134.68) |
| 00:53.32 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c01::f03c:91ff:fe70:fce6) |
| 00:56.43 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:43e:3501:3e97:eff:fe14:ef66) |
| 00:58.17 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c01::f03c:91ff:fe70:fce6) |
| 01:19.23 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:43e:3501:3e97:eff:fe14:ef66) |
| 01:19.34 | *** join/#asterisk-dev moy (~moy@UNVLON55-1176057127.sdsl.bell.ca) |
| 01:31.18 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c01::f03c:91ff:fe70:fce6) |
| 01:31.22 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 01:46.59 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:43e:3501:2677:3ff:fe8f:2730) |
| 02:05.54 | *** join/#asterisk-dev spditner (~simon@206-248-134-68.dsl.teksavvy.com) |
| 02:05.58 | spditner | why might ast_tvnow() be returning times that are incrementing by 80ms between calls instead of 20ms? |
| 02:07.34 | spditner | sorry, not ast_tvnow, I meant calc_txstamp() in res_rtp_asterisk.c |
| 02:08.21 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c01::f03c:91ff:fe70:fce6) |
| 02:12.43 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 02:28.21 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 02:58.32 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 03:12.48 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 03:28.51 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 04:12.49 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 04:29.24 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 05:29.17 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 06:04.48 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 06:04.48 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:29.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 06:44.27 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 07:17.37 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 07:20.16 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c00::f03c:91ff:fe6e:6894) |
| 07:29.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 07:35.07 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 08:24.06 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:24.47 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:29.17 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 08:57.11 | *** join/#asterisk-dev jeffd1830 (~jeffd@63-155-160-253.eugn.qwest.net) |
| 09:23.25 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 09:28.59 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 09:28.59 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:29.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 10:13.15 | *** join/#asterisk-dev skrusty (~skrusty@168.63.14.171) |
| 10:29.18 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 10:48.28 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 10:57.17 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 10:57.17 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:05.51 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-tdbflwdkwbncqtnm) |
| 11:29.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 11:31.10 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 11:36.05 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 11:38.19 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 11:42.20 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:e002:6450:20f7:aebb) |
| 12:06.55 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 12:06.55 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:22.32 | *** join/#asterisk-dev snuff-work (~snuffy@210.8.167.13) |
| 12:22.32 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 12:29.20 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 12:38.34 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 12:56.03 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:58.25 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-cndfeqgqwaiuxtau) |
| 13:08.55 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 13:08.55 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 13:16.39 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-vhcaugcvgowpevzy) |
| 13:18.45 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 13:26.36 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 13:26.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:29.21 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:29.21 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 13:47.41 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 13:57.41 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 13:57.41 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:01.30 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-zlbdbtxqybkrmuje) |
| 14:02.56 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-kukdnsmxczrnwdsj) |
| 14:02.57 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:09.11 | *** join/#asterisk-dev mjordan (~matt@nat/digium/x-kyvwchamqvtfvuvb) |
| 14:09.11 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:10.36 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 14:11.46 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:43e:3501:2677:3ff:fe8f:2730) |
| 14:19.13 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 14:33.25 | *** join/#asterisk-dev dfighter (~someone@arcemu/staff/dfighter) |
| 14:37.16 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-eslxsojfneveuakf) |
| 14:48.02 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 15:04.54 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:dd35:9c4f:f38b:878e) |
| 15:05.22 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginmedia.com) |
| 16:28.24 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 16:28.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:18.36 | *** join/#asterisk-dev otherwiseguy (~otherwise@99.46.2.71) |
| 17:26.34 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 17:45.56 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 17:49.52 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 17:57.47 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6004:4f5c:ad43:e572) |
| 18:04.14 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:60e7:8842:1529:68b2) |
| 18:10.28 | *** join/#asterisk-dev Ta^3 (~tacvbo@187.188.107.19) |
| 18:23.31 | file | sgriepentrog, are you going to use an ao2 global for format interfaces container? |
| 18:25.45 | sgriepentrog | Once I understand how to - unless there is an issue with that. Wanted to eliminate the ptr issue. |
| 18:27.08 | sgriepentrog | You have a suggestion? |
| 18:28.04 | file | my problem with such things is that while having a clean shutdown is a nice goal the ripples and repercussions this is having my concerned that we are sacrificing performance (albeit the whole format interfaces container is a performance sink to begin with right now) for something that most people wouldn't care about |
| 18:28.15 | file | er have me concerned |
| 18:29.05 | sgriepentrog | q: is this issue going to be affected by your work on formats? |
| 18:30.17 | file | sorta |
| 18:30.26 | file | the container will just not get used as much |
| 18:30.43 | file | for most people it'll only be hit a few times at startup |
| 18:30.54 | sgriepentrog | and q2: do you think we should go ahead with the patch as is and see if it helps prevent crashes? |
| 18:31.56 | file | if that is our only other option then yes, or revert the original cleanup change |
| 18:32.35 | file | I have a feeling, though, if more changes like this are done we'll run into the same thing |
| 18:32.38 | sgriepentrog | Because if your changes are going to also minimize this possibility, then any more significant work on this issue should be avoided. |
| 18:33.23 | sgriepentrog | Okay, I'll reup the review - do you want to throw a quick comment on it and then we can throw it in if there are no other objections? |
| 18:33.32 | file | sure |
| 18:36.18 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 18:36.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:13.33 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip24-251-34-116.ph.ph.cox.net) |
| 19:28.35 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-nogpytoqhgypqbyt) |
| 19:37.29 | *** part/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 19:43.42 | gtjoseph | just came back from lunch and had to google "happy eyeballs" |
| 19:44.51 | file | huh, the SIP RFC is up at the top in Bing |
| 19:49.38 | *** join/#asterisk-dev dfighter (~someone@arcemu/staff/dfighter) |
| 19:50.38 | jsmith | gtjoseph: Did you google "happy earballs" as well? |
| 19:51.08 | gtjoseph | HA! |
| 19:51.44 | jrose_atDigium | I feel like... if I googled that I might stumble into some decidedly NSFW content. |
| 20:04.14 | pabelanger | jrose_atDigium, roll the dice! |
| 20:04.24 | pabelanger | you can always close your office door |
| 20:05.48 | coreyf1513 | sgriepentrog: file: so I'm not sure I understand, what is the plan for format interfaces container? |
| 20:06.51 | *** join/#asterisk-dev dfighter (~someone@arcemu/staff/dfighter) |
| 20:09.13 | sgriepentrog | At the moment, I'm getting different suggestions from different individuals. There is a clear "best" way of resolving the issue, but it could result in performance degradation. I may still explore that, if I can prove the performance penalty is negligible. |
| 20:10.46 | sgriepentrog | Everbody's input is valid, and I think I finally understand the options. So I'm leaving this open for comments for a while longer as we still don't have consensus and I'm hoping to have some time to explore the performance issue. |
| 20:35.56 | coreyf1513 | sgriepentrog: I just did a couple valgrind tests against latest branches/11 (core stop gracefully, core stop now, and 'killall asterisk'). core stop gracefully left 445k allocated at exit (mostly dlopen). both core stop now and 'killall asterisk' left 7.5MB allocated. |
| 20:36.21 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:43e:3501:2677:3ff:fe8f:2730) |
| 20:40.38 | sgriepentrog | Yes, I realize the interest in getting leaks resolved - and I want to do that if it a) doesn't keep me from getting other work done, b) doesn't significantly affect performance. What I haven't done yet is set up a good way of testing overall cpu performance under extensive real-world like loading, which would make such questions of how much is that going to affect performance easy to determine. |
| 20:41.21 | coreyf1513 | sgriepentrog: this is why I don't understand the concern about leaking 1 more ao2 container during non-graceful shutdown. core stop gracefully won't call format_attr_shutdown until all channels are stopped. |
| 20:42.03 | sgriepentrog | So your suggestion is to remove the container cleanup? |
| 20:42.17 | coreyf1513 | sgriepentrog: just when we have active channels |
| 20:46.01 | sgriepentrog | That check really feels wrong to me... as Mark pointed out, having no channels doesn't seem like a valid condition for having no used interfaces. |
| 20:46.18 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 20:46.19 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:49.25 | coreyf1513 | I understand but that is the reality, every active channel hits that interface many times per second. the other idea I had was to backport ast_register_cleanup, and switch format_attr_cleanup to use that |
| 20:50.42 | sgriepentrog | I would welcome another approach - let the reviewers decide if it passes muster. In the meantime, I'm getting quite the education in Asterisk internals... |
| 20:51.28 | mjordan | Hm. ast_register_cleanup would not be a huge back port. |
| 20:53.08 | coreyf1513 | mjordan: I considered it in the past and it's trivially small. |
| 21:00.20 | mjordan | if we think that going that route would be best overall, then I'd go for it. |
| 21:00.37 | mjordan | I'm hesitant about the ao2 global container. It's technically correct, but this is one of those areas that just gets slammed |
| 21:00.54 | mjordan | technically correct won't buy us much forgiveness when people's performance drops 20% |
| 21:00.56 | mjordan | :-P |
| 21:02.51 | file | DESTROY |
| 21:06.23 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:18.46 | *** join/#asterisk-dev serafie1 (~erin@nat/digium/x-oqbotzzuxbgykkrv) |
| 21:30.15 | file | I've decided not to fight the past. |
| 21:30.29 | mjordan | Fight the future yo. |
| 21:30.58 | file | mjordan, fight pollution! |
| 21:53.00 | file | I have a goal of not working this weekend. |
| 21:54.36 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip24-251-34-116.ph.ph.cox.net) |
| 21:55.38 | Qwell | file: good luck with that |
| 21:55.52 | file | Qwell, hush you |
| 22:09.54 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 22:10.10 | mjordan | file: btw. did we have a thought on what do with the failing tests due to the multihomed module? |
| 22:14.18 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-zlbdbtxqybkrmuje) |
| 22:19.38 | file | mjordan, yes - add the ability to mark stuff as not being subject to multihomed |
| 22:21.09 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-vuxfrvifgcvbenea) |
| 22:21.27 | mjordan | We're probably going to need to do that sooner rather than later - do you want an issue for it, or do you want to clean up the patch that you had and push it up? |
| 22:21.56 | file | I've committed fixes for other stuff that was quick (thus reducing the number of failures by 70%) |
| 22:22.14 | file | I have not yet tackled that specifically |
| 22:22.28 | mjordan | kk |
| 22:22.49 | file | if you desire to create an issue I encourage you to do so, but would suggest making the description a haiku for amusement |
| 22:28.43 | *** part/#asterisk-dev mjordan (~matt@nat/digium/x-kyvwchamqvtfvuvb) |
| 22:55.26 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.41.82.191) |
| 23:45.42 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 23:46.47 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c00::f03c:91ff:fe6e:6894) |
| 23:47.30 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip24-251-34-116.ph.ph.cox.net) |