| 00:19.51 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 00:19.51 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 00:39.08 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 00:39.08 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 00:48.43 | *** join/#asterisk-dev tzafrir (~tzafrir@50-194-236-81-static.hfc.comcastbusiness.net) |
| 00:48.43 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 00:51.33 | *** join/#asterisk-dev suneye (~atcmmi@119.139.62.67) |
| 01:13.51 | *** join/#asterisk-dev atcmmi (~atcmmi@116.7.103.170) |
| 01:17.39 | *** join/#asterisk-dev suneye (~atcmmi@119.139.62.67) |
| 01:57.36 | *** join/#asterisk-dev atcmmi (~atcmmi@116.7.103.170) |
| 02:09.36 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 02:23.21 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 02:23.46 | *** part/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 03:59.54 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 04:31.11 | *** join/#asterisk-dev oron (~oron_lapt@192.115.25.214) |
| 07:42.58 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6861:b930:3b57:18b7) |
| 07:54.19 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.239.220.131) |
| 07:56.01 | *** join/#asterisk-dev kesselklopfer79 (~kesselklo@astaro.starface.de) |
| 08:02.29 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@195.239.220.131) |
| 08:11.02 | *** join/#asterisk-dev ivan` (~ivan@unaffiliated/ivan/x-000001) |
| 08:51.49 | *** join/#asterisk-dev coreyf1513 (~cfarrell@24-177-3-55.dhcp.nwtn.ct.charter.com) |
| 09:36.27 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6861:b930:3b57:18b7) |
| 09:43.51 | *** join/#asterisk-dev dpeloquin (uid13057@gateway/web/irccloud.com/x-qqibcuhbrrscdaqz) |
| 09:57.52 | *** join/#asterisk-dev tzafrir (~tzafrir@50-194-236-81-static.hfc.comcastbusiness.net) |
| 09:57.52 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:06.20 | *** join/#asterisk-dev fish9370 (~Miranda@psy.iptelefon.su) |
| 11:09.41 | fish9370 | hello, who know what is SOME_PRIME in astmm.c ? why 563? |
| 11:28.04 | tzafrir | fish9370, a very simplistic hashing: put numbers into buckets. 563 is the number of buckets |
| 11:28.23 | tzafrir | More buckets: more memory required but lower chance of a collision |
| 11:29.28 | tzafrir | It was increased recently (r376791) to 1567 |
| 11:29.40 | fish9370 | tzafrir, yes, but why 563? |
| 11:32.12 | fish9370 | tzafrir, why prime? |
| 11:33.28 | tzafrir | a prime: to reduce the chance of coliding with an existing pattern (say, of increasing in steps of 10) which would skip most of the buckets |
| 11:38.51 | fish9370 | it's associated with memory alignment? |
| 11:41.11 | fish9370 | tzafrir, thanks |
| 11:41.38 | tzafrir | fish9370, memory alignment: no |
| 11:43.19 | fish9370 | than i don't understand, |
| 11:45.31 | fish9370 | we calculate hash from memory ptr, which we receive from malloc |
| 11:47.18 | tzafrir | Never tried it on ARM, actually |
| 11:48.15 | tzafrir | hmm... never mind |
| 11:49.00 | tzafrir | so, right. Memory alignment is one such pattern. But think of sizes of structs |
| 11:50.41 | fish9370 | where you take this algorithms? |
| 11:51.48 | fish9370 | for me SOME_PRIME it's magic |
| 11:54.16 | fish9370 | and where you use ast_region.cache? |
| 12:00.45 | *** join/#asterisk-dev protocoldoug (~doug@unaffiliated/protocoldoug) |
| 12:05.20 | opticron | fish9370, the number of buckets should be prime for a hash table implementation because there could be a flaw in the hashing algorithm that would otherwise cause many buckets to go unused. choosing a large-ish prime prevents this by ensuring any such flaws are offset from each other when assigning into the buckets |
| 12:07.09 | opticron | by "flaw", I mean what tzafrir said, a hashing algorithm could prefer numbers on some interval and if that interval was a factor of the number of buckets, the hash implementation would be significantly less efficient |
| 12:07.38 | opticron | beyond this explanation, you should read about how to implement a hash table |
| 12:09.08 | fish9370 | opticron, why you don't use a better hash function for hash, like djb2 algorithm? |
| 12:10.41 | fish9370 | i understand it's memory debug, but... |
| 12:14.28 | tzafrir | fish9370, it's a very cheap function. If it's good enough, why use a more expensive one? |
| 12:14.36 | tzafrir | (if. I have no data on that) |
| 12:15.54 | fish9370 | i'm confused SOME_PRIME only ) |
| 12:16.10 | *** join/#asterisk-dev leifmadsen (~lmadsen@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:16.10 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:20.59 | opticron | fish9370, also, you have no guarantee that all hash functions used with this implementation will be of high quality |
| 12:22.55 | opticron | "high quality" being entirely subjective |
| 12:23.50 | fish9370 | i think, it's you need primarily, when it's need ) |
| 12:24.38 | fish9370 | opticron, ok, thanks for comments |
| 12:38.00 | *** join/#asterisk-dev leifmadsen (~lmadsen@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:38.00 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:39.56 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 12:39.56 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 12:58.58 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 12:58.58 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 12:59.08 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 13:01.03 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 13:05.55 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-cbnowvllcmuadwhl) |
| 13:06.44 | *** join/#asterisk-dev Marquis42 (~mrbmw@c-98-224-144-181.hsd1.mi.comcast.net) |
| 13:22.21 | *** join/#asterisk-dev tzafrir (~tzafrir@63.133.202.2) |
| 13:22.21 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:37.12 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:37.12 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 13:37.39 | sruffell | leifmadsen: https://github.com/sruffell/dahdi-linux/blob/wip/build_tools/dkms-helper |
| 13:38.50 | *** join/#asterisk-dev mjordan (~mjordan@63.133.202.2) |
| 13:38.50 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:51.16 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-69-214.user.veloxzone.com.br) |
| 13:54.20 | leifmadsen | sruffell: thanks |
| 14:02.12 | *** join/#asterisk-dev mjordan (~mjordan@63.133.202.2) |
| 14:02.12 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:51.02 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 15:19.13 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 15:19.13 | *** mode/#asterisk-dev [+o jsmith] by ChanServ |
| 15:30.10 | *** join/#asterisk-dev vlad_starkov (~vlad_star@77.50.56.157) |
| 15:36.00 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 16:01.57 | opticron | wdoekes, ping ASTERISK-22459 |
| 16:22.55 | *** part/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 16:26.42 | *** join/#asterisk-dev Pullphinger (~Pullphing@12.40.23.68) |
| 16:27.40 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 16:27.40 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 16:46.10 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 16:57.02 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:434:5101:2677:3ff:fe8f:2730) |
| 17:05.56 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 17:18.54 | *** join/#asterisk-dev tzafrir (~tzafrir@63.133.202.2) |
| 17:18.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 17:31.00 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-luxnoquergtpgvvw) |
| 17:38.52 | *** join/#asterisk-dev newtonr (~newtonr@63.133.202.2) |
| 17:38.52 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 17:49.31 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:434:5101:3e97:eff:fe14:ef66) |
| 17:50.36 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 17:55.53 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 18:05.58 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 18:25.51 | *** join/#asterisk-dev leifmadsen (~lmadsen@asterisk/documenteur-extraordinaire/blitzrage) |
| 18:25.51 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 18:27.58 | *** join/#asterisk-dev danjenkins (~danjenkin@63.133.202.2) |
| 18:38.04 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 18:40.09 | *** join/#asterisk-dev zigg (~matt@unaffiliated/zigg) |
| 19:26.17 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 19:26.17 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 20:04.02 | *** join/#asterisk-dev otherwiseguy (~otherwise@cpe-69-23-116-90.kc.res.rr.com) |
| 20:46.38 | wdoekes | opticron: re: ASTERISK-22459. what do you want me to say? feel free to commit or close the ticket. |
| 20:53.30 | *** join/#asterisk-dev sgriepentrog (~androirc@63.133.202.2) |
| 20:55.31 | opticron | wdoekes, alright, I can commit it |
| 20:55.37 | opticron | just poking to see if you wanted to |
| 20:56.55 | *** join/#asterisk-dev serafie1 (~erin@nat/digium/x-otjnjldwawvgmewa) |
| 20:59.21 | wdoekes | I didn't read a definitive "ship it" there |
| 20:59.58 | wdoekes | but you apparently did. so go ahead, I don't have the time right now |
| 21:15.16 | wdoekes | (alternatively, you can yell ship it in the issue, and I'll deal with it later this week ;) ) |
| 21:16.24 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 21:16.24 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 21:25.36 | *** join/#asterisk-dev snuff-work (~snuffy@210.8.167.13) |
| 21:25.36 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:08.32 | *** join/#asterisk-dev otherwiseguy (~otherwise@2605:a601:434:5101:2677:3ff:fe8f:2730) |
| 22:14.12 | opticron | wdoekes, I'll take care of it :) |
| 22:30.15 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 22:42.12 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |