| 00:52.51 | snuff-work | mm.. is there a reason that when u turn on debug logging via an asterisk -r session u don't see any debug msgs? |
| 00:53.33 | wedhorn | Seems to be an issue with reading the commit messages. I made a reference to reviewboard and it closed the review (see http://svnview.digium.com/svn/asterisk?view=revision&revision=377991) |
| 01:16.35 | snuff-work | wedhorn: u bother adding other smaller g722's / s7 / s14 ? |
| 01:17.16 | wedhorn | nope |
| 01:17.41 | wedhorn | thought it was better to just commit as I'm having a hard time finding spare minutes to do some testing |
| 01:18.15 | snuff-work | atm i'm just tryin to make pickup return a call any call.. before worrying about making the phone handle the rest properly ;) |
| 01:18.47 | wedhorn | okay, what was the function called? |
| 01:18.55 | snuff-work | when i see a channel finally being 'got' much rejoycing shalt occur |
| 01:18.55 | wedhorn | to pickup |
| 01:19.06 | snuff-work | its literally just called 'ast_pickup |
| 01:19.15 | snuff-work | its in main/features.c |
| 01:19.35 | snuff-work | it seems straight forward.. i think part of my prob is its not spanning channel techs |
| 01:19.47 | snuff-work | but i have a solution for that.. dont span :) |
| 01:19.54 | snuff-work | got another phone in the office on my * |
| 01:19.57 | snuff-work | using sccp |
| 01:20.58 | wedhorn | ast_pickup_call? |
| 01:21.03 | snuff-work | yep |
| 01:21.26 | snuff-work | basically i have a func similar to chan_sip.. which makes thread to take call |
| 01:21.38 | snuff-work | aka ripped straight from chan_sip.. |
| 01:21.45 | snuff-work | i think i'm just getting muddled :) |
| 01:23.04 | wedhorn | do you need a thread? |
| 01:23.54 | snuff-work | i have no clue if i truly need it.. just figured chan_sip would be 'best practice' for it |
| 01:26.22 | wedhorn | looking at the function it looks like you need to create an empty channel, pass it to the function, and then connect the now non empty channel (the one you created) |
| 01:26.51 | wedhorn | basically, I'd grab a copy of SOFTKEY_REDIAL in handle_soft_key_event_message |
| 01:27.39 | wedhorn | change SKINNY_OUTGOING to SKINNY_INCOMING (but should work without it) |
| 01:28.28 | wedhorn | change "dialandactivatesub(sub, l->lastnumberdialed);" to "setsubstate(sub, SUBSTATE_CONNECTED);" |
| 01:29.26 | wedhorn | oh, and call "ast_pickup_call(c)" before the setsubstate (could be handy ;) |
| 01:31.04 | wedhorn | now, as to how to but stuff in a group, no idea |
| 01:31.24 | snuff-work | i think i know that part |
| 01:49.41 | snuff-work | yey |
| 01:50.21 | snuff-work | wedhorn: it worked |
| 01:50.42 | wedhorn | cool |
| 01:50.47 | wedhorn | time for a beer or three |
| 01:51.29 | snuff-work | http://pastebin.ca/2293345 |
| 01:52.07 | snuff-work | i made call from sip client to a dialplan that had sccp phones.. it then stole call ok.. |
| 01:52.58 | wedhorn | it's 200 lines of packets, I think I'll just take your word that it worked |
| 01:53.04 | snuff-work | heh |
| 01:53.27 | snuff-work | follow only from 100 |
| 01:53.39 | wedhorn | try turning off packet and turn on sub |
| 01:53.52 | wedhorn | sub tells you more of what's going on internally |
| 01:54.02 | wedhorn | skinny debug -packet +sub |
| 01:54.16 | wedhorn | and your tab completion can't handle that ;) |
| 01:54.24 | snuff-work | i know.. |
| 01:55.34 | snuff-work | http://pastebin.ca/2293348 |
| 01:56.18 | snuff-work | probably only care from line 50 |
| 01:56.28 | snuff-work | that's where i'm actually dialling |
| 01:58.23 | wedhorn | you still starting another thread? |
| 01:59.13 | snuff-work | yes cause i was impatient... would have meant i had to find my other 4 refs to my func n comment it all out to stop compile bitching :) |
| 01:59.37 | snuff-work | i can test with a raw 'ast_pickup' now |
| 02:00.12 | wedhorn | okay, would be worth also testing picking up from a ringing SIP phone |
| 02:00.25 | snuff-work | i am going to try that in a sec |
| 02:00.34 | wedhorn | Should work the same |
| 02:00.58 | WIMPy | snuff-work: You wanted the locks for the dial/switch thing? |
| 02:01.15 | wedhorn | snuff-work: For info, all your skinny patches are now committed |
| 02:01.16 | snuff-work | it failed to get it.. |
| 02:01.28 | snuff-work | i'm in #ast-commits i noticed :) |
| 02:01.47 | wedhorn | Any feedback, like no channel in group? |
| 02:01.48 | snuff-work | i think i recall there is a 'limitation' around pickups |
| 02:02.17 | snuff-work | [2012-12-14 13:00:43] WARNING[20444]: chan_skinny.c:7038 skinny_pickup_thread: leaving skinny-pickup-thread |
| 02:02.17 | snuff-work | [2012-12-14 13:00:43] WARNING[20218]: chan_skinny.c:1923 find_subchannel_by_reference: Could not find any lines that contained a subchannel with reference '9' on device 'xxxx' |
| 02:02.25 | snuff-work | [2012-12-14 13:00:43] ERROR[20218]: chan_skinny.c:6290 handle_open_receive_channel_ack_message: Open Receive Channel Failure - can't find sub for 9 |
| 02:03.01 | wedhorn | that's different, it seems it can't find the sub it created |
| 02:03.24 | snuff-work | i think that's because pickup didn't find anything |
| 02:03.28 | wedhorn | does the device still work, make/receive calls properly |
| 02:03.35 | wedhorn | maybe |
| 02:03.48 | snuff-work | because it won't return a valid chan |
| 02:04.04 | snuff-work | will return our 1/2 empty 1 we made to give to it |
| 02:05.03 | wedhorn | no, the one you send is a full chan |
| 02:05.20 | wedhorn | and I don't see anything that hangs it up is ast_pickup_call |
| 02:05.28 | wedhorn | so it should still be valid |
| 02:05.39 | snuff-work | mm.. well there is no channel to connect to |
| 02:05.47 | snuff-work | [2012-12-14 13:00:43] DEBUG[20444] features.c: pickup attempt by Skinny/5000@xxxx |
| 02:05.55 | snuff-work | [2012-12-14 13:00:43] DEBUG[20444] features.c: No call pickup possible... for Skinny/5000@xxxxx |
| 02:07.07 | snuff-work | WIMPy: i dont myself particularly want it.. but i'm sure if u posted the core show locks etc / bt of the live lock with an issue it may help :) |
| 02:08.23 | WIMPy | The question is to what extent. The core dialing thing is rather flawed. Not just chan_skinny. |
| 02:09.40 | snuff-work | well i still have open issue about the newer pattern matching.. doesn't respect hierarchy.. aka reg expressions trump normal extens |
| 02:10.01 | snuff-work | but i an't going near pattern matching :) |
| 02:10.51 | WIMPy | Yesterday I wanted to do some experiemts to find out more about caller ID handling. But instead I battled with dialing. When using the SIP phone I ended up with a new call for each entered digit. |
| 02:11.13 | snuff-work | uh.. sounds like overlap dialing or something |
| 02:11.27 | WIMPy | Yes. Last time I tried the new extension matching made things a lot worse. |
| 02:11.34 | WIMPy | Yes. |
| 02:11.41 | snuff-work | rather than 'enbloc' - aka all digits sent @ once |
| 02:12.56 | WIMPy | I even tried the worst I sound so far was sip to sip. It can be made to work using the Incomplete application, but that's only good as a proof of concept. You have to dial really slow for it to work. |
| 02:13.15 | WIMPy | But then I have to dial slowly anyway because of dundi. |
| 02:14.20 | WIMPy | So dialing is a huge issue for me. |
| 02:14.22 | snuff-work | ah.. i don't use dundi/e164.. to scared :) |
| 02:15.15 | WIMPy | Well, the enum switch doesn't exist any more so there's one thing less to be scared of. |
| 02:15.25 | WIMPy | I would have liked to use it, however. |
| 02:15.51 | snuff-work | i think stealing a channel of diff tech is frowned :) |
| 02:16.20 | WIMPy | Why? |
| 02:17.16 | snuff-work | something to do with channel masq i'd guess |
| 02:17.54 | WIMPy | Not that unlikely for a pickup to be from another channeltype. |
| 02:19.00 | wedhorn | I can't see why. A call could be ringing at two different techs and if you pickup the similar tech it'll still stop ringing on the other tech |
| 02:19.10 | wedhorn | anyway I've got to disappear for a while |
| 02:19.19 | snuff-work | np thanks for ur help wedhorn.. :) |
| 02:19.44 | WIMPy | Just like any normally accepted call. |
| 02:39.15 | snuff-work | mm.. a skin to skin call was able to be picked up by a sip |
| 03:36.08 | snuff-work | mm i think it will work.. figured out another issue.. just my config was bung.. aka typo |
| 03:41.53 | *** join/#asterisk-dev rmeyerriecks (~rmeyerrie@nat/digium/x-yxxtjmcsgqopffrs) |
| 03:47.08 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-etdsgoapxgownquu) |
| 04:24.48 | *** join/#asterisk-dev Qwell (~north@pdpc/sponsor/digium/Qwell) |
| 04:24.48 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 04:25.08 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-pjodtmubxsasrcvw) |
| 04:58.55 | snuff-work | wedhorn: it does work just fine.. |
| 04:59.17 | wedhorn | of course it does, unlike my commits today :( |
| 04:59.36 | snuff-work | checking for any other 'unknown msgs' |
| 04:59.48 | snuff-work | that may generate when stealing call |
| 05:00.10 | wedhorn | from the grabber or grabbee? |
| 05:00.31 | snuff-work | either |
| 05:01.00 | wedhorn | but you've no idea what tech the grabbee is |
| 05:01.05 | snuff-work | any1 with a softphone suggestion.. i have tried 'linphone' and that is crash every 4 calls |
| 05:01.22 | snuff-work | i'm just lookin @ skinny packets |
| 05:01.57 | snuff-work | dont care about the 'other side' as they should handle it |
| 05:02.11 | wedhorn | I'd be more worried about the substate stuff. you really shouldn't be doing anything new with the packets except 1 |
| 05:03.28 | snuff-work | mm so only msg 49 and 154 |
| 05:03.40 | wedhorn | eg, if you find an issue with putting the other device onhook (which is done with setsubstate(ONHOOK) we've some serious issues |
| 05:03.56 | snuff-work | the skinny device it steals from seems fine |
| 05:04.02 | wedhorn | 49 and 154 from memory are some new calling directory thingy, i think |
| 05:06.42 | snuff-work | mm |
| 05:06.53 | wedhorn | later ... |
| 05:06.59 | snuff-work | see ya.. |
| 05:07.15 | wedhorn | I meant ponder those packets later ... |
| 05:07.21 | snuff-work | most likely give u a patch to look @ later today |
| 05:07.24 | snuff-work | oh :) |
| 05:07.45 | snuff-work | if 'wireshark' can't decode the skinny packet its not worth worrying about :D |
| 05:07.51 | wedhorn | I vaguely remember you sent me a pcap with some of them in there and I was just scratching my head as to what to do with all the details in it |
| 05:08.09 | wedhorn | from memory they're really long with lots of call info |
| 05:11.18 | snuff-work | now i shall see how well we match ccm for 'stealing' |
| 05:15.53 | wedhorn | you mean the packets sent/received? |
| 05:15.58 | snuff-work | yep |
| 05:16.16 | wedhorn | I wouldn't rely on that too much |
| 05:16.47 | wedhorn | Much of the stuff in asterisk is built to work with multiple devices and firmware |
| 05:17.04 | wedhorn | ccm probably does different stuff based on model and firmware |
| 05:17.11 | wedhorn | we don't unless it is required |
| 05:17.18 | snuff-work | mm.. |
| 05:17.31 | snuff-work | i shall post the pickup stuff now |
| 05:18.18 | wedhorn | okay, if you give me a quick tut (or link) on setting up groups, I can test |
| 05:19.09 | snuff-work | real easy.. add to ur lines -> callgroup=1 and pickupgroup=1 |
| 05:19.37 | snuff-work | restart skinny.. then make a call from 1 to another and hit the pickup button :) |
| 05:19.44 | wedhorn | okay, seems fairly easy |
| 05:19.49 | snuff-work | yep :) |
| 05:19.56 | wedhorn | similar for sip I'm guessing |
| 05:20.01 | snuff-work | the same |
| 05:33.30 | wedhorn | snuff-work: now for you next trick you'll have to have a go at directed pickup |
| 05:34.22 | snuff-work | heh |
| 05:35.41 | snuff-work | directed pickup might even be easier.. |
| 05:36.05 | wedhorn | yeah, maybe, but it looks like you'll need to run it through the dialplan |
| 05:36.31 | snuff-work | http://pastebin.ca/2293389 |
| 05:37.09 | snuff-work | i enabled extra keys.. could prob turn em off |
| 05:37.37 | snuff-work | but real fun will be when we 'mask off' buttons u can't use.. for future use :) |
| 05:37.57 | wedhorn | yeah I noticed, and you've still got it in a thread |
| 05:38.09 | snuff-work | yep.. u can ditch that bit n try.. |
| 05:38.26 | snuff-work | but i haven't yet |
| 05:39.36 | snuff-work | the hangup cause.. lines 94/96 could be replaced with somethin u use within skinny more often as it was copy n past from sip |
| 05:40.15 | snuff-work | then u can ditch the causes.h include |
| 05:40.53 | snuff-work | oops.. i missed removing 1 thing from ur other patch :) |
| 05:41.07 | wedhorn | yeah, saw that |
| 05:41.48 | wedhorn | if your code is working, it looks like that ast_pickup_call blocks which mean it will need to be threaded |
| 05:41.49 | snuff-work | was on phone talking to colleague about another script |
| 05:42.30 | snuff-work | hard to be recalling script contents from a month ago and also editing a patch file |
| 06:05.58 | wedhorn | seems it doesn't block, does masquerade swap chans? |
| 06:13.40 | wedhorn | snuff-work: an abbreviated version - http://pastebin.ca/2293396 |
| 06:14.14 | snuff-work | k |
| 06:14.31 | wedhorn | seems to work, but I see some issues with bad magic, guessing it's to do with the forced unref'ing, given ref'ing's on my "todo" list |
| 06:14.49 | *** join/#asterisk-dev seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 06:14.49 | *** mode/#asterisk-dev [+o seanbright] by ChanServ |
| 06:16.25 | snuff-work | mm |
| 06:19.48 | *** join/#asterisk-dev marv (~Adium@c-50-130-4-242.hsd1.al.comcast.net) |
| 06:24.38 | wedhorn | maybe just get rid of the unref, its complaining about the object already been destroyed |
| 06:27.11 | snuff-work | yes u can.. |
| 06:27.27 | snuff-work | in the 'threaded' part u took out.. it does an initial ref |
| 06:27.50 | snuff-work | so u shouldn't need an unref |
| 06:27.53 | wedhorn | ah, okay makes sens |
| 06:27.55 | wedhorn | e |
| 06:29.37 | wedhorn | back in it goes |
| 06:32.59 | snuff-work | it blew up ? |
| 06:34.12 | wedhorn | nope, put the ref in the beginning and its all hunky dory |
| 06:36.15 | wedhorn | slight revisions (including where ref/unref go) http://pastebin.ca/2293398 |
| 06:36.57 | snuff-work | looks good |
| 06:36.58 | snuff-work | :) |
| 06:37.09 | wedhorn | no apparent errors either picking up a call or trying to pickup when call doesn't exist |
| 06:37.19 | snuff-work | yer i didn't notice any |
| 06:44.20 | wedhorn | just pondering, should probably add back the hangup cause seeing as it could go to other techs |
| 06:44.43 | snuff-work | shouldn't hurt |
| 06:44.59 | snuff-work | chan_sip does.. chan_mgcp doesn't.. |
| 06:45.06 | snuff-work | i haven't looked over all chans |
| 06:46.50 | wedhorn | if mgcp doesn't may as well leave it out (we'll just put hangup causes on that todo list - maybe ast47 will get it ;) |
| 06:48.34 | wedhorn | you want to put it up for review, or I'm happy to. Suggest without hangup cause and comment that it can be added if wanted |
| 06:51.45 | snuff-work | mm.. can't wait for my bksp key to work fully :) |
| 06:52.25 | wedhorn | you mean without a patch? |
| 06:52.29 | snuff-work | 3/4 of pickup was u suggesting how to make it work |
| 06:53.05 | snuff-work | my ver atm doesn't have the additional bksp patch.. since its now in ur dial fixes |
| 06:53.14 | snuff-work | and i've been lazy |
| 06:54.07 | wedhorn | just run the two diffs. They should patch over each other easy enough |
| 06:54.24 | snuff-work | it does i just haven't re-run it with the later version |
| 06:55.06 | wedhorn | ok, I'll post it to reviewboard so you have to nice and easy diff's to apply |
| 06:58.30 | snuff-work | i think we may as well add 1 extra thing since we have pickup.. is the 'named' version of pickup/callgroups |
| 06:59.00 | snuff-work | i can do that :) |
| 06:59.38 | wedhorn | bugger, I was just about to submit the review |
| 06:59.52 | snuff-work | submit.. all good |
| 07:00.49 | wedhorn | here it comes |
| 07:18.21 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 07:21.49 | snuff-work | mm.. next patch named groups.. lil more work to do.. |
| 07:21.56 | snuff-work | will do it over w/end |
| 07:22.05 | snuff-work | have good evening wedhorn :) |
| 07:22.29 | wedhorn | well on my way ;) but what's groups? |
| 07:23.33 | snuff-work | call/pickup were only ints.. now they can also be strings.. aka more user friendly :) |
| 07:24.18 | snuff-work | *gone to train* |
| 07:24.22 | wedhorn | ah, okay, patch on a patch, cool. Have a good weekend, I'll be around if you want someone to bounce ideas off |
| 07:55.04 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 08:39.01 | *** join/#asterisk-dev x1user (~chatzilla@212.36.13.6) |
| 08:58.17 | *** join/#asterisk-dev Tim_Toady (~fuzzy@194.50.55.200) |
| 09:22.10 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 11:27.54 | *** join/#asterisk-dev caio1982 (~caio1982@189.125.242.3) |
| 11:29.29 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 11:35.51 | *** join/#asterisk-dev Marquis42 (~bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 11:53.48 | x1user | I got write("exec SetCDRUserField PrePaid"); in old *.agi php script, how to convert this to work with the new Set(CDR(userfield)=Value) ? |
| 12:20.04 | *** join/#asterisk-dev blitzrage (~lmadsen@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:20.05 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 12:59.33 | *** join/#asterisk-dev bombev (~bombev@PPPoE-Static-40-132.UnicsBG.Net) |
| 13:55.41 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-eawvqksaqakhjxiz) |
| 14:09.08 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 14:09.08 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 14:28.32 | *** join/#asterisk-dev leedm777 (~leedm777@nat/digium/x-qhwpvknjislujnra) |
| 15:01.11 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 15:35.36 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:35.36 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:54.28 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:54.28 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:59.12 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 15:59.12 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 17:26.23 | jsmith | pabelanger: You around? |
| 17:27.07 | pabelanger | jsmith: ohai |
| 17:27.18 | jsmith | pabelanger: Did you see the private message? |
| 17:27.30 | jsmith | tries to slip pabelanger an Asterisk patch under the table |
| 17:27.37 | pabelanger | jsmith: Oh, no |
| 17:27.42 | pabelanger | pm again :) |
| 18:43.58 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:43.58 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:57.01 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 18:57.03 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 19:46.00 | *** join/#asterisk-dev Tim_Toady (~fuzzy@host-89-242-82-150.as13285.net) |
| 21:05.11 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 21:05.14 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 23:22.30 | *** join/#asterisk-dev sezuan (bouncer@irc.scheff32.de) |
| 23:53.30 | *** join/#asterisk-dev sezuan (bouncer@irc.scheff32.de) |