| 00:11.12 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 02:06.42 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@bzq-218-155-146.cablep.bezeqint.net) |
| 02:06.42 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 05:25.18 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 06:18.49 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 07:31.09 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 07:52.36 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 08:00.37 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 08:00.37 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 08:00.37 | *** join/#asterisk-dev blitzrage (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 08:00.37 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 09:01.06 | bombev | hi all |
| 09:05.39 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:3d11:bd45:72ac:b3e7) |
| 10:20.16 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 10:20.16 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 12:17.16 | *** join/#asterisk-dev caio1982 (~caio1982@189.125.242.3) |
| 12:26.40 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:26.40 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:30.10 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-58-4.user.veloxzone.com.br) |
| 12:45.22 | *** join/#asterisk-dev Tim_Toady (~moi@178.128.20.156.dsl.dyn.forthnet.gr) |
| 12:50.44 | *** join/#asterisk-dev Marquis42 (~bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 13:23.24 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:23.24 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:25.24 | *** join/#asterisk-dev acidfu (~inetrio.c@75-119-246-157.dsl.teksavvy.com) |
| 13:30.52 | *** join/#asterisk-dev blitzrage (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:30.52 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 13:55.47 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-fuutwdhiqqczqagx) |
| 13:58.25 | *** join/#asterisk-dev italorossi (~italoross@189.124.196.68) |
| 14:29.39 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-lcntfencyzbmzjop) |
| 14:36.06 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 14:36.06 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 15:19.00 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 15:19.00 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 15:22.43 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:22.43 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:34.48 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 15:34.48 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 15:55.23 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:55.23 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 16:15.43 | *** join/#asterisk-dev jkroon (~jkroon@dsl-244-30-18.telkomadsl.co.za) |
| 16:17.21 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-58-4.user.veloxzone.com.br) |
| 16:18.24 | jkroon | hi all, i'm trying to figure out a patch for https://issues.asterisk.org/jira/browse/ASTERISK-20754, however, it seems that ast_rtp_instance_get_chan is returning NULL for the rtp instance for which the rtcp is being sent/received ... |
| 16:18.30 | jkroon | any ideas/suggestions? |
| 16:19.57 | jkroon | hmm, running a grep through the source tree it seems there are no users of that function ... other than me now. |
| 16:20.27 | file | This will only return a channel while in a local or remote bridge. |
| 16:21.26 | *** join/#asterisk-dev spditner (~simon@206-248-134-127.dsl.teksavvy.com) |
| 16:21.59 | jkroon | file, looking at main/rtp_engine.c it looks like it will *never* return a channel. |
| 16:22.07 | jkroon | instance->chan is only ever used once. but i'm still looking. |
| 16:22.27 | file | that's because it isn't referenced by instance |
| 16:22.30 | file | instance0 and instance1 |
| 16:22.36 | spditner | Before I run off and rewrite dialplan -- what's the best practice for recording the original dialed extension into the cdr's? The user field? As I'm using gosubs, and so I get a lot of s, s-noanswer and such. |
| 16:23.48 | jkroon | ok, so rtp isn't associated with a channel? |
| 16:24.06 | file | not really, no |
| 16:24.22 | jkroon | how the heck is that achieved? |
| 16:24.32 | jkroon | surely rtp is set up as a result of some channel? |
| 16:24.40 | file | the channel driver is a user of the RTP engine API |
| 16:25.16 | jkroon | eg, call comes in on SIP/102-1234 ... which then (as a result of the channel driver) sets up a RTP stream, so when the channel gets torn down, so will the RTP stream ... |
| 16:25.28 | file | yes, all done in chan_sip |
| 16:26.04 | jkroon | ok, so "only return a channel while in a local or remote bridge" - what's the implications of that? |
| 16:26.41 | file | that will return NULL if bridged to non-RTP or if something prevented it from native bridging (different codecs, call recording, spying) |
| 16:26.42 | jkroon | i'd really, really like to be able to associate the rtcp info from asterisk with a channel |
| 16:27.04 | jkroon | is there a reason/motivation for doing it that way? |
| 16:27.38 | jkroon | surely just because the "consumer" is a local application, or an IAX/2 or DAHDI channel for that matter, doesn't mean we're not interested in the RTCP info? |
| 16:28.58 | jkroon | and no, even when setting up a SIP <-> SIP call I still get null from ast_rtp_instance_get_chan |
| 16:29.11 | file | there are many different conditions that will prevent native bridging |
| 16:29.54 | jkroon | native bridging being defined as? |
| 16:30.07 | file | the RTP core being given two channels and accessing the details for each directly |
| 16:30.22 | file | allowing a reinvite to occur or a packet forwarding operation |
| 16:30.58 | jkroon | ok, so the only time the rtp instance won't return null is when we won't be receiving rtcp anyway? |
| 16:32.13 | jkroon | just doesn't make sense to me why we shouldn't be able to associate a channel with the rtp stream |
| 16:33.18 | file | it's never been needed enough to have an ability to do it |
| 16:33.36 | file | at least, outside the scope of bridging |
| 16:34.04 | jkroon | ok, so it's more a matter of not needed than not wanted/doesn't make sense? |
| 16:34.20 | file | as long as it wasn't a requirement, then fine |
| 16:34.57 | jkroon | ok, would it make sense for me to attempt a patch to whenever an rtp_intance is created get the chan pointer set up? |
| 16:35.24 | file | no, you can't do that... has to be settable at any time |
| 16:36.21 | *** join/#asterisk-dev dms (~dms@75.76.106.90) |
| 16:36.21 | *** mode/#asterisk-dev [+o dms] by ChanServ |
| 16:36.32 | jkroon | ok, so add a function to be able to set it? |
| 16:36.37 | file | yes |
| 16:37.07 | jkroon | so in the case of chan_sip directly after calling ast_rtp_instance_new call ast_rtp_instance_set_chan(instance, channel) (for example) ? |
| 16:37.17 | file | yes |
| 16:37.29 | jkroon | ok, then that is the approach I'll take, thanks for the input. |
| 16:38.45 | jkroon | this is what the get_chan function says: Get the channel that is associated with an RTP instance while in a bridge |
| 16:38.55 | jkroon | adding the code as suggested above will change that. |
| 16:39.09 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:39.09 | jkroon | basically just removing the "while in a bridge" portion. |
| 16:39.13 | jkroon | acceptable? |
| 16:41.43 | file | seems like it, but I guarantee nothing until code review |
| 16:42.37 | jkroon | not asking for guarantees - just looking for some input. and it's much appreciated. |
| 16:42.59 | file | yuo yuo |
| 16:43.02 | file | erm yup yup |
| 16:46.12 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:46.18 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:48.22 | file | is pkiefer present in here? |
| 16:54.06 | jkroon | file, ok, turns out that that strategy may not be quite possible either ... |
| 16:54.28 | jkroon | the rtp_instance is associated from a sip_pvt structure, not an ast_channel |
| 16:54.38 | file | correct |
| 16:54.46 | file | the sip_pvt knows the ast_channel |
| 16:56.11 | jkroon | file, ah ok awesome. i'll recheck, didn't see it in the struct but i must've missed it. |
| 16:57.38 | jkroon | ->owner ... thanks |
| 16:57.52 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 16:57.52 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 17:02.46 | opticron | hmm....I think pkiefer's patch needed to go into 11 as well |
| 17:03.16 | file | opticron, already commented on the issue |
| 17:03.22 | opticron | ah |
| 17:47.41 | *** join/#asterisk-dev blitzrage (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 17:47.41 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 17:58.56 | jkroon | file, got a patch, but it doesn't seem to work. |
| 17:59.33 | jkroon | very wierd ... seems the sip_pvt->owner value is NULL at the time when I call the set_chan function ... |
| 18:42.44 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:42.44 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 19:09.01 | *** join/#asterisk-dev italorossi (~italoross@189.124.196.68) |
| 19:41.10 | *** join/#asterisk-dev spditner (~simon@206-248-134-234.dsl.teksavvy.com) |
| 19:47.17 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 19:47.17 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 20:27.23 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 20:27.23 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 23:02.08 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 23:02.11 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 23:33.27 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 23:33.27 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |