| 00:50.25 | *** join/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 00:50.25 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:24.02 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-pdnstokjirvuahni) |
| 01:24.02 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:51.53 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 02:55.52 | WIMPy | Yes. That's what I asked about some time ago. The cannel variables don;t exist before there's a match in the dialplan. |
| 03:14.03 | Corydon76-home | WIMPy: so then the next question is, is that intended behavior? |
| 03:14.40 | WIMPy | I was told that there's no (easy) way to change it. |
| 03:15.24 | WIMPy | The channel itself isn't set up at that stage so it can't carry any variables. |
| 03:15.31 | WIMPy | That's when dialing. |
| 03:15.32 | Corydon76-home | Ah... |
| 03:15.55 | WIMPy | If you use it later on in the dialplan with WaitExten or DISA that's another story. |
| 03:17.31 | WIMPy | It would be really handy if it worked, but I don't think that's anywhere near any agenda. |
| 03:20.14 | WIMPy | switches in particular and dialing in general are a bit of an issue anyway :-( |
| 03:20.24 | *** join/#asterisk-dev snuff-work (~snuffy@210.8.167.13) |
| 03:20.24 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 03:25.13 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 03:25.13 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 07:49.38 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 08:43.45 | *** join/#asterisk-dev attila_lendvai (~attila_le@unaffiliated/attila-lendvai/x-3126965) |
| 08:46.18 | attila_lendvai | hi! so, I'm delving into that feature to syntax check a dialplan without trying to apply it... and due to our setup instead of a command like "dialplan check", I need a standalone executable (main server wants to check before remote managed server receives the dialplan). so, I'm looking at the makefiles, and trying to find a good place to add a new target and a new main.c that does some argparsing and calls the dialpla |
| 08:46.27 | attila_lendvai | any guidance is appreciated |
| 08:46.41 | attila_lendvai | I'm working on the 11.0.0 tag checkout |
| 08:48.18 | attila_lendvai | my current plan is to add a check_dialplan.c with its own main() and add a new target to main/Makefile, but I badly miss a bird's eye view on the asterisk sources, so it may be a bad idea... |
| 08:53.31 | attila_lendvai | hrm, I guess a new command line argument makes more sense |
| 08:53.38 | attila_lendvai | instead of a separate main() |
| 09:12.07 | wdoekes | attila_lendvai: look at how aelparse and friends are made (see Utilities in make menuconfig) |
| 09:14.16 | attila_lendvai | wdoekes: what do you think about a new cli command instead of a new argv parameter? "dialplan check [optional filename]" |
| 09:14.50 | wdoekes | I wouldn't like it, since I build my dialplans somewhere where I don't have a running asterisk |
| 09:15.55 | attila_lendvai | looks into aelparse |
| 09:18.19 | wdoekes | (make sure you don't use utils/extconf.c though like aelparse does. ASTERISK-15350) |
| 09:23.12 | attila_lendvai | wdoekes: utils/extconf.c is needed for the more advanced features of aelparse, namely also printing which variables are set, not only parsing errors? (saying all this with a very shallow understanding of the internals of asterisk) |
| 09:24.02 | wdoekes | I'm saying that the stuff in extconf.c is old, and possibly not correct |
| 09:25.40 | attila_lendvai | why is ael parsing factored out into res/ while ast_expr2.y and friends are in main/ ? is this a TODO, or is there something more fundamental difference? |
| 09:26.47 | wdoekes | because ael is optional? |
| 09:28.38 | wdoekes | I do worry that you may need to include way more than needed (e.g. full fledged module loading) into your dialplan_check binary |
| 09:29.05 | attila_lendvai | what I worry about is that it's not a couple of hours hack as I expected... :) |
| 09:30.00 | wdoekes | attila_lendvai: an alternative is creating a custom parser (in a scripting language of choice) |
| 09:30.02 | attila_lendvai | I thought that I just call a function and present the warnings somewhere... that's why I'm leaning towards a "dialplan check" cli command, because that sounds reasonable within a few hours starting from zero |
| 09:30.44 | wdoekes | that downside of the custom parser is that it won't get updated. the upside is that it can be more feature-rich, like checking functions/applications |
| 09:30.48 | attila_lendvai | wdoekes: that will go out of sync... then I'd write a regex quick hack instead in the jsp server |
| 09:31.37 | attila_lendvai | is eyeing handle_cli_dialplan_reload |
| 09:32.36 | attila_lendvai | more specifically pbx_load_config in pbx_config.c |
| 09:32.43 | wdoekes | like I mentioned earlier: the dialplan will go case sensitive in the future.. that could require a feature-rich dialplan_check |
| 09:34.24 | wdoekes | I guess you should do whatever time permits you ;) |
| 09:34.48 | attila_lendvai | wdoekes: do you know by any chance whether there's a factored out load_dialplan and apply_dialplan in the codebase? staring at pbx_load_config it's not obvious, but it looks like there's none |
| 09:35.39 | wdoekes | if there was another one, we'd have duplicate code |
| 09:37.05 | attila_lendvai | I mean the config gets applied to the internal state as it's being loaded, as opposed to loading it into an AST or something, and then in a separate operation assigning that AST to the pbx state |
| 09:39.12 | attila_lendvai | ...because if the two operations are not separate already, then what I want to do is way much harder. |
| 10:09.18 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 10:15.47 | *** join/#asterisk-dev caio1982 (~caio1982@189.125.242.3) |
| 11:16.18 | WIMPy | Why don't you start a new instance and do it via commandline parameter, just as many other applications do? |
| 11:24.58 | attila_lendvai | and what if I don't make any changes to the source, but rather use the -C command to specify a generated config file, and then try to start asterisk. can multiple instances of asterisk run if the dirs are all generated/isolated in asterisk.conf? |
| 11:26.21 | WIMPy | Seems to be the obvious way to me. |
| 11:27.21 | WIMPy | I'd go and just try to find a way of preventing it from actually starting. But That might be not that easy. |
| 11:28.45 | attila_lendvai | well, the obvious way to me would be calling a function directly in the functionally written asterisk codebase from the web server, with one parameter which is either a filename or a big string containing the dialplan... but that's a different discussion... :) |
| 11:30.56 | *** join/#asterisk-dev italorossi (~textual@189.124.196.68) |
| 11:39.17 | attila_lendvai | (the issue is that it's threaded (web server), and that a live asterisk is already running on our server) |
| 11:51.51 | *** join/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 11:51.51 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:00.38 | *** part/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 12:11.54 | *** join/#asterisk-dev w9sh (~chatzilla@64.238.96.125) |
| 12:15.41 | *** join/#asterisk-dev italorossi (~textual@189.124.196.68) |
| 12:29.29 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 12:29.30 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 13:00.26 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-wzlyvccodykdisen) |
| 13:10.27 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 13:10.27 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 13:15.37 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 13:22.10 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-tmwnjqhfeiahixku) |
| 13:22.10 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:56.08 | *** join/#asterisk-dev latv (~latv@109.238.244.73) |
| 14:07.26 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:07.26 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:26.21 | *** part/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 14:39.42 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:39.43 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:59.45 | rmeyerriecks | blah |
| 15:00.01 | file | rmeyerriecks, bleh |
| 15:00.58 | *** join/#asterisk-dev leedm777 (~Adium@nat/digium/x-xqgtijiwmavfbwap) |
| 15:01.25 | rmeyerriecks | file: ? |
| 15:01.45 | file | just responding to your blah! |
| 15:01.56 | rmeyerriecks | oh, haha |
| 15:02.01 | rmeyerriecks | didn't realize I typed that |
| 15:02.54 | Qwell | rmeyerriecks: rough morning? O.o |
| 15:03.33 | rmeyerriecks | Qwell: do mornings exist that aren't rough? |
| 15:03.44 | Qwell | touche |
| 15:23.18 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 15:24.16 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 15:40.06 | file | hello, I'm looking for Molly... I've looked everywhere and I can't seem to find Molly |
| 15:41.10 | WIMPy | Have you tried asking Cedric Gervais? |
| 15:41.17 | leedm777 | file: that's funny. she was just here looking for you. she went that way. |
| 15:41.24 | file | ooh |
| 15:41.29 | leedm777 | points |
| 15:42.58 | WIMPy | retries here: |
| 15:43.07 | WIMPy | While speaking of ConfBridge... I noticed that the enter and leave sounds are played after the corresponding announcement. That doesn't seem to make sense. Does anyone know if that is intended |
| 15:43.12 | WIMPy | behaviour or a bug? |
| 15:43.16 | Qwell | file: I may know a guy. |
| 15:43.26 | mjordan | WIMPy: what version of 10? |
| 15:43.41 | WIMPy | TRUNK |
| 15:43.44 | mjordan | hm |
| 15:43.55 | mjordan | well, a lot of stuff just got 'tweaked' |
| 15:44.03 | mjordan | otherwiseguy: you in here too? :-) |
| 15:44.39 | mjordan | nuts, he isn't |
| 15:45.22 | mjordan | WIMPy: I'll take a look. In the user profiles, were you using waitmarked or marked users? |
| 15:45.46 | WIMPy | Neither |
| 15:46.05 | mjordan | kk |
| 15:46.16 | mjordan | hooray for simpler scenarios :-) |
| 15:46.44 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 15:46.48 | otherwiseguy | somebody called? |
| 15:49.03 | leifmadsen | mjordan: ^^^ |
| 15:49.12 | mjordan | WIMPy: looks intended to me |
| 15:49.23 | mjordan | otherwiseguy: (10:43:07 AM) WIMPy: While speaking of ConfBridge... I noticed that the enter and leave sounds are played after the corresponding announcement. That doesn't seem to make sense. Does anyone know if that is intended |
| 15:50.06 | mjordan | otherwiseguy: pretty sure that's how its always been, and your state-ification patch didn't change that |
| 15:50.29 | WIMPy | I think the sounds only make sense as an intro to the announcement. |
| 15:50.46 | otherwiseguy | I intended to make as few change to behavior as possible. So basically, if that is how it used to be then it was intended to remain the same by me. I can't speak to the original author's intent. |
| 15:51.12 | WIMPy | There seems to be little pint in playing a sound that says someone has jeft after you've just been told so. |
| 15:52.01 | mjordan | join to me, makes sense: you announce that they're joining, play the join sound |
| 15:52.15 | mjordan | leaving is currently: you announce that they left, then play the leave sound |
| 15:52.20 | WIMPy | Not to me. Same reason. |
| 15:52.22 | mjordan | it could be argued that the reverse order is appropriate |
| 15:52.24 | mjordan | hm |
| 15:52.37 | WIMPy | It would make sense before, however so you know there's an announcement comming. |
| 15:53.00 | mjordan | WIMPy: this feels a bit more in the land of opinion :-) I wouldn't turn away a patch that reversed the order, but I have a sneaky suspicion that we'll get someone who prefers the other order |
| 15:53.15 | file | yes. |
| 15:53.34 | WIMPy | Possibly. That's why I asked if it's intended. |
| 15:54.23 | mjordan | WIMPy: I'm going to go with yes, it was intended - but probably because the author picked a route and went with it. |
| 15:56.58 | WIMPy | Also the announcements block each other where it doesn't make sense. |
| 15:57.55 | mjordan | WIMPy: how so? |
| 15:57.58 | WIMPy | If the 2nd user joins, first MOH on the conference is stopped, then the 2nd user heras the user count and after that he will be announced to the conference. Would be nice if that happened in paralle |
| 15:58.03 | WIMPy | parallel. |
| 16:00.29 | mjordan | hm. That's really due to the threading model in place on ConfBridge. It wouldn't be impossible to make those happen in parallel, but it'd be very, very tricky to get the synchronization correct. Simply dropping the channel joining into another thread isn't possible, because - in general (at least for non-join playbacks, but possibly also at that point) - they're technically owned by the bridging layer, and you need to give them back |
| 16:02.05 | WIMPy | For what I planned I have to do the announcements manually anyway. Maybe that will be a workaround for the timing thing as well. |
| 16:02.47 | mjordan | maybe - for long announcements especially, it would be nice to have them played to both the channel and the bridge at the same time, then resynch the two (carefully) back together |
| 16:03.10 | file | easier said... than done |
| 16:03.14 | mjordan | file: agreed |
| 16:06.44 | otherwiseguy | mjordan: did you notice how file properly used the word "than"? :-p |
| 16:06.47 | otherwiseguy | runs and hides |
| 16:06.51 | *** join/#asterisk-dev IceMan82 (~chatzilla@67.48.122.234) |
| 16:06.54 | file | :D |
| 16:08.18 | mjordan | hey now |
| 16:08.22 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-ulrdjcpiesxykpsf) |
| 16:08.28 | mjordan | you have to admit I've been better than I was in the past |
| 16:08.31 | mjordan | ^^^^ (SEE!!!) |
| 16:08.48 | Qwell | then* |
| 16:09.31 | mjordan | Comparison (present me versus past me) |
| 16:13.20 | *** join/#asterisk-dev Gugge (gugge@kriminel.dk) |
| 19:21.16 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@66-232-81-197.ctcweb.net) |
| 19:58.54 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 19:58.57 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 20:25.19 | *** join/#asterisk-dev rmeyerriecks (~rmeyerrie@nat/digium/x-wjjsrfppcxpxpsuh) |
| 22:06.46 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-gfhzsxsxvekdghqi) |
| 22:09.09 | *** join/#asterisk-dev otherwiseguy (~otherwise@63.92.246.169) |
| 22:19.01 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-tmwnjqhfeiahixku) |
| 22:21.43 | *** join/#asterisk-dev JunK-Y (~junky@pdpc/supporter/active/junk-y) |