| 00:00.42 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 00:00.43 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 00:23.03 | *** join/#asterisk-dev wudles (~wudles@gateway.secureinstrument.com) |
| 01:08.43 | *** join/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 01:08.43 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:16.01 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 02:40.17 | *** part/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 04:25.26 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 04:25.27 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 05:31.44 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 05:31.45 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:08.00 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 06:08.02 | schmidts | good morning |
| 06:35.10 | oej | Morning folks! |
| 06:36.01 | Maxus2 | Morning! |
| 07:05.52 | oej | So what do you think the Asterisk project should focus on for version 12? |
| 07:06.33 | Maxus2 | RTCP stats would be nice for us, for iax. if thats possible? |
| 07:19.58 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:fdb5:efda:fed8:29af) |
| 07:22.22 | schmidts | oej CSTA ;) |
| 07:22.46 | oej | Ouch |
| 07:22.46 | schmidts | or atleast UACSTA |
| 07:23.04 | oej | Yes, I would like to get my RTCP code in there. |
| 07:23.35 | Maxus2 | :) |
| 07:24.06 | schmidts | oej +1 |
| 07:25.22 | oej | In fact I have tons of stuff that should be in there. |
| 07:25.30 | oej | But I have to start with getting it inside my 1.8 tree |
| 07:26.40 | *** join/#asterisk-dev dwayne (~dwayne@c-76-29-230-45.hsd1.al.comcast.net) |
| 07:34.31 | oej | I think we should make 12 a community release. Focus on all the stuff that is in the bug tracker and branches. |
| 07:34.50 | Maxus2 | that sounds good. |
| 07:34.55 | schmidts | good idea |
| 07:42.46 | *** join/#asterisk-dev oej_ (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 07:42.47 | *** mode/#asterisk-dev [+o oej_] by ChanServ |
| 07:45.13 | latv | oej: i'd like to "book" number for AST_FORMAT_AMRNB in format.h :) |
| 07:46.38 | *** join/#asterisk-dev RiceCracker (~RiceCrack@59.152.236.158) |
| 07:55.50 | oej | Those should be dynamic. But it's easy to add in pass-through mode. Just provide a patch that add the proper fields to RTP and format.h. |
| 08:19.57 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 10:06.54 | WIMPy | oej: I'm still missing a channel state 'disconnected' so that we can some time get tones/announcements working propperly. |
| 10:07.42 | WIMPy | And while adding that I think another one for voicemail would also be nice for channels that are 'up' but still should be considered for pickup. |
| 11:18.06 | *** join/#asterisk-dev mjordan (~mjordan@user-24-214-136-35.knology.net) |
| 11:18.06 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 11:21.20 | oej | What's the difference between "down" and "disconnected" - is disconnected up but not bridged? |
| 11:22.08 | WIMPy | same as early media, but after instead of before the call. |
| 11:32.02 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 11:32.02 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 11:36.18 | oej | After the call you have no media channel. |
| 11:37.42 | WIMPy | Exactely. That's the issue. |
| 11:37.59 | oej | SO how would a new state help? |
| 11:38.13 | oej | You can already keep the incoming channel up, but that's up, after a bridge ends. |
| 11:38.24 | WIMPy | That is used iextensively in telephony. |
| 11:38.47 | WIMPy | Yes, but you can't signal a call has ended and keep the channl open. |
| 11:56.00 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 11:56.00 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 12:51.53 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-mghfaiswtmimcdkn) |
| 13:07.36 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-daiezgpnmftfdtsd) |
| 13:07.36 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:09.00 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 13:09.00 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 13:41.47 | *** join/#asterisk-dev malcolmd_ (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 13:41.47 | *** mode/#asterisk-dev [+o malcolmd_] by ChanServ |
| 13:42.47 | *** join/#asterisk-dev malcolmd_ (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 13:42.47 | *** mode/#asterisk-dev [+o malcolmd_] by ChanServ |
| 13:51.23 | *** join/#asterisk-dev caio1982 (~caio1982@189.125.242.3) |
| 14:06.48 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:06.48 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:29.33 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 14:33.43 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 14:56.09 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 14:56.10 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 14:57.16 | oej | mjordan: Online? |
| 14:57.42 | mjordan | oej: yup, but about to pop into a meeting. Can I ping you in about 30 min? |
| 14:58.10 | oej | Yep, should work. Have an architecture discussion I would like to involve you in! :-) |
| 14:58.17 | oej | THanks. |
| 14:58.40 | oej | So boring to discuss only with me, myself and possibly I. |
| 14:59.59 | leifmadsen | oej: aren't those discussions usually preferred on the mailing list for history purposes and other interaction with the community? |
| 15:05.19 | *** join/#asterisk-dev italorossi (~textual@189.124.163.167) |
| 15:10.24 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 15:14.58 | *** join/#asterisk-dev marv (~Adium@173-14-206-193-huntsville.hfc.comcastbusiness.net) |
| 15:21.17 | file | raises eyebrow |
| 15:21.41 | oej | I want a realtime discussion now, Leif. |
| 15:22.01 | oej | Whatever comes out of it will be discussed later on lists and in my code. |
| 15:22.15 | oej | There is a reason why we have the IRC channel :-) |
| 15:43.01 | mjordan | oej: ping - sorry, my 30 min meeting turned into a 45 :-) |
| 15:43.21 | oej | No problem. My brain is working slowly so I did not realize :-) |
| 15:43.31 | oej | You have a few minutes? |
| 15:43.37 | mjordan | yup |
| 15:44.07 | oej | Ok, so I'm doing this noise generation stuff. |
| 15:44.34 | oej | Basically, we receive a signal from the incoming RTP stream that "I'm not going to send you anything for a while, so please generate sound with this level" |
| 15:44.46 | oej | (which is where I automatically start playing ABba music). |
| 15:44.53 | mjordan | excellent choice |
| 15:45.00 | oej | To apply this to Asterisk, we have a design issue. |
| 15:45.13 | oej | I am leaning towards sending a control frame, which is actually done now. |
| 15:45.35 | oej | On the other end, I make a decision on what to do - send a CNG if it can be done (SDP neg) or generate noise. |
| 15:45.56 | oej | The question is how to do that. |
| 15:46.11 | oej | Idea: |
| 15:46.32 | oej | I could add a call in the tech_pvt interface to check if the channel has support for CNG. If not, I'll generate noise in the core. |
| 15:46.41 | mjordan | ast_rtp_read could return the control frame asking for the noise |
| 15:46.52 | oej | If the PVT (like the SIP channel would have) wants to get the control frame, we could handle it in the channel. |
| 15:47.18 | oej | I think it does by ways of another function that handles the CNG frame and sends a control frame. |
| 15:47.25 | oej | But we don't do anything. |
| 15:47.43 | mjordan | oej: yup |
| 15:47.45 | oej | I want to generate noise when the tech doesn't support it or let the tech decide what to do |
| 15:48.08 | mjordan | oej: if ast_rtp_read returned a control frame as the ast_frame that it returned, the channel driver would receive it first |
| 15:48.09 | oej | If the tech can forward a CNG across the channel, it should. If not the tech should turn on noise generation. |
| 15:48.26 | file | mjordan, other side. |
| 15:48.28 | oej | And the channel driver can forward it to the core |
| 15:48.33 | mjordan | file: nuts |
| 15:48.40 | oej | The other side of the bridge needs to make the decision. |
| 15:48.48 | mjordan | gotchya |
| 15:49.19 | mjordan | oej: in that case it sounds like the appropriate answer is to pass the control frame onto the channel and have it handled by the channel technologies, as you suggested |
| 15:49.22 | oej | So I think a change to the tech_pvt that indicates if a channel can handle cng would be a good thing. If that doesn't exist, the core will just play out noise |
| 15:49.45 | oej | I do have a noise generator I found in the bug tracker :-) |
| 15:49.49 | file | I'd use a channel flag to indicate support or not, and a frame hook to intercept and decide so the core doesn't have to be modified |
| 15:50.02 | mjordan | oej: does it need a change to the tech_pvt, or can it just be handled by the indicate callback? |
| 15:50.12 | file | but that's just me. |
| 15:50.22 | mjordan | frame hook would be good |
| 15:50.24 | oej | file: But if the pvt doesn't support CN, the core has to step in |
| 15:50.48 | oej | It's not up to the channel, it's a property of the PVT |
| 15:50.53 | oej | sorry the tech |
| 15:50.55 | oej | Or? |
| 15:51.32 | file | oej, a frame hook allows you to hook into the path of control frames - you can look at the channel to determine if that specific channel has support for CNG (negotiated in the SDP in the case of SIP), if not you can then stop the control frame from proceeding and execute other logic to start CNG |
| 15:51.38 | oej | Ah you mean that the other end channel could have a flag to indicate and the core can make a decision based on that. It works too. Then we don't have to change the tech_pvt interface |
| 15:52.24 | oej | I need a permanent frame hook then. I thought frame hooks was temporary things based on an added feature. |
| 15:52.53 | file | they don't have to be - but my point is expanding the ever growing core read and write code isn't needed |
| 15:53.12 | file | or adding code explicitly there |
| 15:54.07 | oej | So I'll write a frame hook in channel.c or somewhere that is always added to catch AST_FRAME_CNG and decide what to do. Ok, that's doable. |
| 15:54.18 | file | or have it in a separate nicely contained file |
| 15:54.22 | file | with all the logic |
| 15:54.35 | oej | A lot of it is in res_rtp_asterisk.c |
| 15:54.55 | oej | the channel generator I've added alongside the silence generator, they kind of belong together. Yin and Yang. |
| 15:55.06 | oej | s/channel/noise/ |
| 15:55.37 | oej | Thanks for the feedback guys! No for the second topic: |
| 15:55.45 | oej | This is all the receiving side. |
| 15:55.58 | oej | If I want to send CNG, I need a silence detector. |
| 15:56.13 | oej | This can be applied on a channel based on configuration somehow. |
| 15:56.21 | oej | Do we have one? |
| 15:56.30 | file | yes. |
| 15:56.39 | file | the DSP code can detect silence |
| 15:56.47 | oej | Is that what we use in voicemail? |
| 15:56.50 | mjordan | oej: bridging code should use that |
| 15:56.52 | file | it's used everywhere |
| 15:56.52 | oej | Was looking for that |
| 15:56.55 | mjordan | bridginge API |
| 15:57.02 | mjordan | s/bridginge/bridging/ |
| 15:57.06 | file | the cost being you transcode to signed linear |
| 15:58.05 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:58.05 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:58.14 | oej | Right now I have the noise generator and a module named res_noise that has an application called whitenoise() for generating noise. Would it be a good thing to review that part separately and get it in, then go ahead and start with the receiving side as a separate thing? |
| 15:58.39 | oej | I like small pieces. Easier to review and commit. |
| 15:58.47 | file | the more self contained parts that are up for review the easier |
| 15:58.56 | oej | Ok, agree then. |
| 15:59.09 | oej | If we can get this to work, we can save bandwidth like crazy for all asterisk users. |
| 15:59.16 | oej | It will be a BIG thing. |
| 15:59.18 | file | WELL, at the cost of CPU |
| 15:59.25 | file | if you are doing silence detection. |
| 15:59.59 | oej | In most countries, CPU is cheap and we have a lot of idling cores. Bandwidth is very expensive in some parts of the world. Not here though. |
| 16:01.05 | mjordan | oej: agreed that its hugely useful. This isn't the first time someone has looked for CNG :-) |
| 16:01.41 | file | it's a trade off and certainly worthwhile for some |
| 16:03.30 | leifmadsen | does that mean we can get rid of that NOTICE about comfort noise support not being implemented? :) |
| 16:03.45 | oej | It's going away! |
| 16:04.35 | oej | My Asterisk is negotiating CN properly, but doesn't actually play out noise yet. Now I now how to get it done! Thanks all. I will certainly have more questions later. |
| 16:04.56 | file | The answer is open. |
| 16:08.14 | oej | And open is the answer. |
| 16:08.28 | oej | Time for dinner in this time zone. |
| 16:10.31 | leifmadsen | I need lunch |
| 16:20.26 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 16:20.26 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 16:39.31 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:40.56 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 16:40.56 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:26.08 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 17:26.08 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:27.17 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 17:27.17 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:44.12 | *** join/#asterisk-dev bweschke (~bweschke@209.196.192.8) |
| 18:40.53 | *** join/#asterisk-dev snuff-home (~snuffy@203-219-29-182.tpgi.com.au) |
| 18:40.53 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 18:58.38 | *** join/#asterisk-dev droemel (~droemel@p4FCADC39.dip.t-dialin.net) |
| 19:22.16 | *** join/#asterisk-dev droemel (~droemel@p4FCADC39.dip.t-dialin.net) |
| 19:29.59 | *** join/#asterisk-dev bweschke (~bweschke@209.196.192.8) |
| 19:35.35 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 19:35.35 | *** mode/#asterisk-dev [+o ChanServ] by pratchett.freenode.net |
| 19:43.35 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 19:43.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:24.05 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 20:48.05 | acidfoo | astricon is soon \o/ |
| 20:59.00 | newtonr | very soon |
| 21:01.21 | acidfoo | the weather look nice in atlanta, way better than quebec ;) |
| 21:06.41 | newtonr | yeah i'm hoping its a good drive |
| 21:06.55 | newtonr | i'll be driving 4 hours or so from Huntsville to Atlanta |
| 21:07.01 | newtonr | shouldn't be bad at all |
| 21:09.54 | opticron | 3.5 if you drive like I do |
| 21:10.44 | file | notes to not go with opticron |
| 21:11.20 | opticron | nah, I'm relatively safe, ~8mph over the speed limit and only on major highways |
| 21:17.38 | pabelanger | 21 hour drive here |
| 21:23.27 | newtonr | pabelanger: i can't do drives that long. i start i see Cthulu |
| 21:23.45 | leifmadsen | newtonr: pffft that's nothing :) |
| 21:23.53 | leifmadsen | oh ya, wha pabelanger said |
| 21:23.55 | leifmadsen | lolz |
| 21:24.07 | leifmadsen | try being in a car with pabelanger for 21 hrs... that'll make you drink! |
| 21:24.08 | leifmadsen | :D |
| 21:24.18 | leifmadsen | will be stopping at a Five Guys at least once |
| 21:24.29 | pabelanger | leifmadsen, hellz ya |
| 21:24.46 | newtonr | longest i've driven was 14 hours, resulted in a cop pulling me over for "evading the police by switching drivers" |
| 21:25.34 | newtonr | my wife and i switched towards the end, just as an undercover (that we never spotted) was about to pull us over |
| 21:25.37 | newtonr | it was weird |
| 21:25.49 | leifmadsen | indeed |
| 21:26.00 | leifmadsen | first time I met pabelanger, we drove 14 hrs to AstriCon in Washington |
| 21:26.51 | pabelanger | indeed |
| 21:59.53 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 22:03.37 | *** join/#asterisk-dev droemel (~droemel@p4FCADC39.dip.t-dialin.net) |
| 22:20.02 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 22:20.02 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 22:50.10 | Maxus2 | Hi people, stupid question where do i sign up to submit code to the review board? |
| 22:52.41 | mjordan | Maxus2: not a stupid question. In general, review board access is granted to people who are actively working on patches. Do you have a JIRA issue with your patch on it? |
| 22:53.29 | Maxus2 | mjordan, naar i have a cdr_curl module to submit for review |
| 22:53.43 | Maxus2 | so no patches, unless that is a patch? |
| 22:53.57 | mjordan | Maxus2: Please open a JIRA issue first, sign a license contributor agreement if you haven't already, and attach the patch to the JIRA issue |
| 22:53.58 | Maxus2 | i assumes a patch is a bug fix? where as this is new code and is self contained |
| 22:54.06 | mjordan | no |
| 22:54.07 | Maxus2 | Ahh okay! |
| 22:54.14 | mjordan | patch in this case is something that changes Asterisk :-) |
| 22:54.18 | Maxus2 | that clears it up a bit |
| 22:54.31 | Maxus2 | thanks for that, will do. |
| 22:54.33 | leifmadsen | you can use something like 'svn diff' if you've been making changes in your checked out repo |
| 22:54.44 | Maxus2 | naar its all in one file |
| 22:54.51 | Maxus2 | doesn't chang anything else |
| 22:54.56 | leifmadsen | ah gotcha |
| 22:54.58 | Maxus2 | its more about having the code reviewed |
| 22:55.11 | leifmadsen | yep, just attached to the issue tracker in a new issue per mjordan |
| 22:55.16 | mjordan | Maxus2: one thing that helps the process a lot is to make sure it follows the coding guidelines |
| 22:55.20 | Maxus2 | ive don only very small amounts of c previously |
| 22:55.41 | Maxus2 | where can i find the guidelines? |
| 22:55.50 | mjordan | https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines |
| 22:55.58 | Maxus2 | thanks will review |
| 22:57.16 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-daiezgpnmftfdtsd) |
| 23:00.55 | Maxus2 | Im confused, the coding guidelines say everything should be tab indented, but when i look at any other existing asterisk file its tab indented? |
| 23:01.11 | Maxus2 | sorry guidelines say everything should be space indented |
| 23:01.57 | Maxus2 | so tabs or spaces? |
| 23:08.48 | *** join/#asterisk-dev bweschke (~bweschke@c-68-44-59-234.hsd1.pa.comcast.net) |
| 23:11.58 | *** join/#asterisk-dev tzafrir (~tzafrir@212.179.75.202) |
| 23:11.58 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |