| 00:27.51 | *** join/#asterisk-dev mvanbaak_ (~michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 00:27.53 | *** mode/#asterisk-dev [+o mvanbaak_] by ChanServ |
| 00:28.09 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 00:28.09 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:02.01 | *** join/#asterisk-dev Velluto (~stephen@dhcp-0-13-c4-f4-76-22.cpe.quickclic.net) |
| 01:02.20 | *** part/#asterisk-dev Velluto (~stephen@dhcp-0-13-c4-f4-76-22.cpe.quickclic.net) |
| 01:26.19 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 01:26.19 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:51.09 | *** join/#asterisk-dev wudles (~wudles@gateway.secureinstrument.com) |
| 02:56.39 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 02:56.39 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 03:09.10 | *** part/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 03:17.25 | *** join/#asterisk-dev KNERD (~KNERD@129.113.48.16) |
| 03:21.17 | *** join/#asterisk-dev bklang (~bklang@c-71-56-236-35.hsd1.co.comcast.net) |
| 03:46.36 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 03:59.11 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 03:59.12 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 07:46.06 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:46.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:30.00 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 09:03.50 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 10:55.10 | *** join/#asterisk-dev jamicque (~jamicque@80.50.125.74) |
| 10:56.38 | jamicque | Hi I have a question about https://issues.asterisk.org/jira/browse/ASTERISK-19465. I'm trying to make proper condition in add_rpid funcion checking if RPID or PAI heaer exist - if (!ast_strlen_zero(sip_get_header(req, "P-Asserted-Identity"))) |
| 10:57.27 | jamicque | If condition is true I'm trying to remove the header I was trying to use sip_removeheader funcion but I have some doubts if it is the right way |
| 10:57.40 | jamicque | Can anyone give his opinion on that? |
| 11:35.52 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:35.53 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:47.08 | *** join/#asterisk-dev mjordan (~mjordan@user-24-96-15-44.knology.net) |
| 11:47.08 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:03.36 | *** join/#asterisk-dev mjordan (~mjordan@user-24-96-15-44.knology.net) |
| 12:03.36 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:38.58 | *** join/#asterisk-dev chazzam (~chazz@50-81-150-34.client.mchsi.com) |
| 12:50.46 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-lzmjzuvgatamamhq) |
| 12:50.46 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:26.02 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 13:26.03 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 13:30.10 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-bfvnzhooiydwakmi) |
| 13:33.48 | jamicque | <jamicque> Hi I have a question about https://issues.asterisk.org/jira/browse/ASTERISK-19465. I'm trying to make proper condition in add_rpid funcion checking if RPID or PAI heaer exist - if (!ast_strlen_zero(sip_get_header(req, "P-Asserted-Identity"))) |
| 13:33.49 | jamicque | If condition is true I'm trying to remove the header I was trying to use sip_removeheader funcion but I have some doubts if it is the right way |
| 13:33.49 | jamicque | Can anyone give his opinion on that? |
| 13:37.48 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-145-151.user.veloxzone.com.br) |
| 14:00.43 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 14:00.43 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 14:04.43 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:04.46 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:08.21 | acidfoo | .erm, why is this url private? (im logged in) https://issues.asterisk.org/jira/browse/AST-894 |
| 14:08.50 | acidfoo | it says 'permission violation' :| |
| 14:10.23 | leifmadsen | acidfoo: because it's used for internal development tracking at Digium |
| 14:10.30 | acidfoo | ok |
| 14:10.37 | leifmadsen | mostly development resource planning and allocation |
| 14:10.50 | leifmadsen | it's just a copy of the public issue, and all work is done on the public side |
| 14:11.28 | acidfoo | i see ;) |
| 14:11.31 | acidfoo | thank you |
| 14:14.02 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:14.03 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:23.50 | acidfoo | poke opticron |
| 14:25.34 | acidfoo | opticron, did you know that there was a remote crash attack possible before fixed this ? https://reviewboard.asterisk.org/r/1994/diff/ |
| 14:25.44 | acidfoo | before you* |
| 14:26.39 | opticron | in that a voicemail user can possibly cause a crash intentionally? |
| 14:26.45 | acidfoo | yup |
| 14:27.00 | opticron | I thought that might be a possibilty, but I was never able to produce it myself |
| 14:27.12 | acidfoo | Im able, I was able to submit an issue, but I saw this |
| 14:27.29 | acidfoo | I was about* |
| 14:28.06 | opticron | yeah, the mix of code in there was pretty bad |
| 14:28.09 | acidfoo | so now I need to restart my test to see if you patch fixed all what I was able to attack ;P |
| 14:28.16 | opticron | :D |
| 14:28.57 | acidfoo | opticron, you leave an urgent message, then you log into your voicemail, then you wait (you press nothing), meanwhile you let an urgent and a normal message |
| 14:29.16 | acidfoo | then in your voicemail menu you press 1, you delete the urgent message, so it close the urgent mailbox, than switch to the normal mail box |
| 14:29.18 | acidfoo | then you press # |
| 14:29.21 | acidfoo | and boom |
| 14:29.31 | opticron | nice |
| 14:29.47 | acidfoo | and it was freeing twice in the close_mailbox |
| 14:29.49 | acidfoo | in the out: |
| 14:29.53 | acidfoo | but you changed that ;) |
| 14:30.02 | opticron | there are already a couple of issues open about this, one being ASTERISK-19923 |
| 14:30.08 | opticron | yeah |
| 14:30.21 | opticron | not only freeing, indexing into freed memory |
| 14:30.29 | acidfoo | yeah |
| 14:30.49 | opticron | Bad Things(TM) |
| 14:31.14 | acidfoo | good |
| 14:31.17 | acidfoo | that you fixed it |
| 14:32.00 | acidfoo | I'll recheck if on my side it doesn't crash anymore in all case I saw |
| 14:32.09 | opticron | cool, thanks |
| 14:33.04 | opticron | if you can reproduce anything after that patch, I would very much appreciate valgrind output |
| 14:33.15 | opticron | since some of the other issues seem to be unable to get that |
| 14:35.24 | acidfoo | good |
| 14:43.06 | acidfoo | opticron, since this is a security issue, do you know if a new version of asterisk will be out in the next day ? or it will come with the next normal release as a fix |
| 14:45.02 | mjordan | acidfoo: no, it won't be out in the next day |
| 14:45.19 | mjordan | acidfoo: we do not have conclusive evidence that this patch fixes the root cause of this issue |
| 14:45.50 | acidfoo | mjordan, if you create me an account with a voicemail I can show you :P |
| 14:45.51 | mjordan | it will be, at a minimum however, a regression release. Most likely, based on this conversation, it will also be a security release. |
| 14:46.28 | acidfoo | ok cool, anyway meanwhile I'll apply the patch on the asterisk we run |
| 14:47.10 | mjordan | acidfoo: not doubting you, but I don't want to release a security release or a regression release and not fix the root cause of the problem. Once we're sure the patch fixes it, some form of release will definitely happen |
| 14:47.34 | acidfoo | I agree |
| 15:04.52 | *** join/#asterisk-dev bklang (~bklang@c-71-56-236-35.hsd1.co.comcast.net) |
| 15:19.12 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 15:50.55 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 15:53.06 | *** join/#asterisk-dev moy (~moy@UNVLON55-1176057127.sdsl.bell.ca) |
| 16:01.31 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:254c:50b1:34dd:6ea3) |
| 16:05.37 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:54.49 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 16:54.49 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 17:20.27 | mjordan | opticron: putnopvut: have we set up an IMAP voicemail test system for the patch on 1994? |
| 17:24.40 | putnopvut | No, I know of no IMAP voicemail test system. IMAP testing has always been done on local developer boxes. |
| 17:25.10 | mjordan | putnopvut: heh, that's pretty much what I meant |
| 17:25.34 | mjordan | I'll start bouncing voicemail against a gmail account after lunch. Didn't want to set it up if y'all were already looking at it |
| 17:26.32 | putnopvut | Well, opticron may have something set up, but I don't know for certain. |
| 17:28.44 | opticron | I don't |
| 18:00.22 | kpfleming | file: do you plan to move the CELT and SILK SDP stuff into format modules too? |
| 18:00.52 | file | kpfleming: oui - it won't take long |
| 18:00.57 | kpfleming | cool |
| 18:06.48 | leifmadsen | doooooooooo eeeeeeeeeeet |
| 18:07.08 | file | H.264 FIRST! |
| 18:11.51 | opticron | file is fixing ALL OF THE THINGS |
| 18:12.05 | file | except chan_skinny and CDRs |
| 18:12.17 | Qwell | so, masquerades?! |
| 18:12.24 | kpfleming | what if we merge chan_skinny and chan_ooh323? |
| 18:12.42 | file | kpfleming, good idea! |
| 18:13.01 | file | Qwell, DONE! |
| 18:13.51 | leifmadsen | make it so number one |
| 18:53.29 | mjordan | acidfoo: ping |
| 18:53.40 | acidfoo | pong |
| 18:54.26 | mjordan | do you mind shooting an e-mail to security@asterisk.org with a description of the voicemail crash and steps to reproduce it? |
| 18:54.58 | mjordan | I want to make sure that I'm reproducing it correctly and that - regardless of the corruption issues - the patch fixes it |
| 18:55.33 | acidfoo | no problem, I'll describe the two ways I found to crash it |
| 18:55.48 | mjordan | thanks |
| 18:57.00 | acidfoo | I should press 'send' in the next hour, If nothing urgent arrive here |
| 18:57.12 | mjordan | ok :-) |
| 18:58.47 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 18:58.47 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 19:17.08 | *** join/#asterisk-dev bklang (~bklang@c-71-56-236-35.hsd1.co.comcast.net) |
| 19:40.38 | mjordan | opticron: ping |
| 19:41.33 | opticron | mjordan, pong |
| 19:42.32 | mjordan | in your latest patch you check dh_arraysize before deleting vms->heard/deleted. Is there a reason to not check if heard or deleted is NULL? |
| 19:43.20 | opticron | not particularly |
| 19:43.29 | opticron | the way it's written, either of those checks is valid |
| 19:44.09 | opticron | I guess checking heard/deleted makes a little more sense |
| 19:57.03 | *** join/#asterisk-dev GameGamer43 (users.5533@gateway/web/irccloud.com/x-mfqdapzaywgadfhr) |
| 20:04.31 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 20:11.47 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 20:16.59 | acidfoo | mjordan, sent |
| 20:18.07 | acidfoo | it's time to go home now, if there is something unclear, you can reply to the email, I'll answer tomorrow morning |
| 21:15.07 | *** join/#asterisk-dev acidfu (~nib@76-10-164-217.dsl.teksavvy.com) |
| 21:15.16 | acidfu | home sweet home |
| 21:20.04 | *** join/#asterisk-dev Tim_Toady (~fuzzy@188.4.95.15.dsl.dyn.forthnet.gr) |
| 21:47.49 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 21:47.49 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 21:59.10 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-lzmjzuvgatamamhq) |
| 22:49.14 | *** join/#asterisk-dev acidfu (~nib@206.167.132.211) |
| 23:00.22 | *** join/#asterisk-dev bklang (~bklang@c-71-56-236-35.hsd1.co.comcast.net) |
| 23:00.40 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 23:00.41 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 23:42.08 | *** join/#asterisk-dev Velluto (~stephen@dhcp-0-13-c4-f4-76-22.cpe.quickclic.net) |
| 23:42.50 | Velluto | Hi Everyone, I was just wondering if someone would be help me debug an error I'm receiving with CDR & odbc ? |
| 23:43.36 | leifmadsen | ~ask |
| 23:43.36 | infobot | Questions in the channel should be specific, informative, complete, concise, and on-topic. Don't ask if you can ask a question first. Don't ask if a person is there; just ask what you intended to ask them. Better questions more frequently yield better answers. We are all here voluntarily or against our will. |
| 23:45.01 | Velluto | i'm receiving an error "CDR direct execute failed" using cdr_odbc with freetds to a MS SQL Server - is there a quick way I could determine what is causing this error? |
| 23:45.29 | Velluto | the ODBC driver I'm using is also being used to handle Realtime, and that is working correctly. |
| 23:47.39 | Velluto | I have tried to use cdr_alternative_odbc - and that logs the call correctly. I say call, because after that Realtime quits on me and no peers are able to be called. |
| 23:53.07 | Velluto | i'm using Asterisk 10.5 (yum) with FreeTDS 0.82, SQL Server 2008 R2 |
| 23:58.45 | Velluto | any help would be greatly appreciated! |