| 00:40.33 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@bzq-218-155-148.cablep.bezeqint.net) |
| 00:40.33 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 00:42.52 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 01:10.33 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 04:35.33 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 04:35.34 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 05:05.57 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 05:05.57 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 05:55.36 | *** join/#asterisk-dev oej (~olle@86.183.216.87.static.jazztel.es) |
| 05:55.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:04.03 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 06:04.03 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 06:19.50 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 06:45.38 | *** join/#asterisk-dev oej (~olle@86.183.216.87.static.jazztel.es) |
| 06:45.39 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:23.56 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 07:23.58 | schmidts | good morning |
| 07:36.48 | schmidts | please help me out with a question i have found about state_notify_build_xml. I can see in the code that the dialed extension has to be the same extension as the hint points too and not only the device but this makes not much sense to me. |
| 07:39.00 | schmidts | ok maybe the problem even starts earlier |
| 07:43.09 | schmidts | why do i have to search for exten@context of the hint and not directly use the device which matches on this hint? |
| 07:43.29 | schmidts | for this find_channel callback it would be much better to use the ringing device not the exten@context of the hitn |
| 07:43.33 | schmidts | s/hitn/hint/ |
| 08:20.41 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 08:33.40 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 08:33.46 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 09:39.07 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:30d4:833c:8b4b:f20f) |
| 10:37.06 | *** join/#asterisk-dev tomdm (~tomdm@78-23-54-51.access.telenet.be) |
| 11:07.43 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:07.44 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:15.48 | *** join/#asterisk-dev Marquis42 (~bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 12:58.51 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 12:58.52 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 13:13.32 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-ipltsolauixvxdoy) |
| 13:13.46 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:27.24 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:27.24 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:30.14 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-vimipmbtsmjtofff) |
| 13:35.56 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-arycjostakhnoyyj) |
| 13:45.49 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 13:45.49 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 13:57.04 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 13:57.05 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 14:24.35 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:24.36 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:26.04 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:26.05 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:26.44 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:26.44 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:27.13 | *** join/#asterisk-dev GameGamer43 (users.5533@gateway/web/irccloud.com/x-vaezdilfqqkuxnha) |
| 14:58.31 | *** join/#asterisk-dev angler (~angler@pdpc/sponsor/digium/angler) |
| 15:10.16 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:34.30 | *** join/#asterisk-dev kanelbullar2 (~kanelbull@83.240.200.90) |
| 17:33.35 | *** join/#asterisk-dev Tim_Toady (~fuzzy@130.43.28.109.dsl.dyn.forthnet.gr) |
| 17:48.26 | *** join/#asterisk-dev luka12345 (~luka12345@unaffiliated/luka12345) |
| 18:24.07 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 18:24.07 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 19:34.23 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@bzq-218-155-145.cablep.bezeqint.net) |
| 19:34.23 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 19:43.01 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@bzq-218-155-170.cablep.bezeqint.net) |
| 19:43.02 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 20:15.58 | *** join/#asterisk-dev oej (~olle@86.183.216.87.static.jazztel.es) |
| 20:15.59 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:23.40 | rgagnon | awful quiet here today... |
| 20:23.55 | rgagnon | opticron: I updated the code per your comments on rb1947 https://reviewboard.asterisk.org/r/1947/ |
| 20:50.04 | opticron | rgagnon, one last comment on the reiew |
| 20:50.09 | opticron | *review |
| 20:50.14 | opticron | otherwise, it's good to go |
| 20:54.21 | opticron | assuming you don't have commit access (didn't see you on the list), I'll get that in tonight or tomorrow |
| 20:57.31 | rgagnon | kthx |
| 21:00.04 | rgagnon | opticron... I thought about the semicolons you commented about... I left them off to avoid having to also look for instances where the header would contain semicolon+space+tag |
| 21:00.18 | *** join/#asterisk-dev wedhorn (~wedhorn@123-243-209-34.static.tpgi.com.au) |
| 21:01.17 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 21:01.17 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 21:01.35 | opticron | hmmm |
| 21:02.08 | rgagnon | I dont see any instances in my live data, but did notice in other parts of chan-sip that tags are sometimes hunted using an optional space |
| 21:02.53 | rgagnon | worst-case: I could add all 6 conditions but it seems like overkill |
| 21:03.17 | opticron | I was looking at the gettag code that gets the "tag" parameter from the To and From headers |
| 21:03.25 | opticron | it doesn't seem to account for spaces there |
| 21:06.41 | opticron | I don't see any examples of parameters with preceeding spaces in the SIP RFC, but that's not definitive |
| 21:07.39 | rgagnon | I agree that the RFCs and drafts don't allow for spaces, but I've seen asterisk parsing code that checks for it... probably due to a rogue UAC of some sort.... trying to locate the example I saw |
| 21:08.12 | opticron | I see one example in the contact header |
| 21:08.22 | opticron | not in asterisk code |
| 21:08.34 | opticron | but in the RFC, hadn't searched far enough |
| 21:09.53 | opticron | there really needs to be a function for generalized parameter retreival... |
| 21:11.14 | rgagnon | oh well... i can't locate the code I saw... I'll just add the semi's |
| 21:11.35 | rgagnon | if some server sends "; oli=" they are out of luck :-) |
| 21:14.54 | rgagnon | ahh... found it... find_sdp() shows it when looking for boundary= |
| 21:15.14 | rgagnon | but it could be the only insance |
| 21:15.22 | rgagnon | instance* |
| 21:21.16 | opticron | that's the only instance I can easily find in chan_sip |
| 21:21.46 | opticron | there may be another instance or two that are more programmatic |
| 21:23.45 | rgagnon | code updated. For an expired draft, it sure passes through our switch a lot. a portion of our business requires proper billing of payphone originated calls, so we have to watch for it |
| 21:25.25 | rgagnon | although I haven't seen it appear as cpc, nor in the p-asserted-identity header yet... maybe this is one potential standard where everyone will just put the tag in one place? |
| 21:25.48 | rgagnon | (there I go again dreaming that programmers implement a standard standardly :-)) |
| 21:31.32 | opticron | yeah, good luck with that :) |
| 21:52.31 | *** join/#asterisk-dev wedhorn (~wedhorn@123-243-209-34.static.tpgi.com.au) |
| 21:52.31 | *** join/#asterisk-dev snuff-home (~snuffy@203-219-29-182.tpgi.com.au) |
| 21:52.31 | *** join/#asterisk-dev snuff-work (~snuffy@210.9.82.197) |
| 21:52.31 | *** mode/#asterisk-dev [+oo snuff-home snuff-work] by kornbluth.freenode.net |
| 21:58.51 | *** join/#asterisk-dev snuff-work (~snuffy@210.9.82.197) |
| 21:58.51 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:08.57 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 22:20.50 | *** join/#asterisk-dev Corydon76-home (gold@c-69-137-80-31.hsd1.tn.comcast.net) |
| 22:20.50 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 22:32.09 | *** join/#asterisk-dev aimka (~aimka@unaffiliated/aimka) |
| 22:37.18 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.23.116.90) |
| 22:37.57 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-ipltsolauixvxdoy) |
| 23:14.56 | *** join/#asterisk-dev Tim_toady (~fuzzy@130.43.28.109.dsl.dyn.forthnet.gr) |