| 01:39.45 | *** join/#asterisk-dev otherwiseguy (~textual@69.76.221.79) |
| 02:16.53 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@mail.redfish-solutions.com) |
| 05:18.03 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@mail.redfish-solutions.com) |
| 07:47.25 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 07:47.33 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 07:53.07 | *** join/#asterisk-dev lftsy (~lftsy@194.38.160.113) |
| 09:47.37 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:bdb9:af66:ccc0:c91b) |
| 09:53.48 | *** join/#asterisk-dev ccesario (~ccesario@189.29.54.144) |
| 10:26.01 | *** join/#asterisk-dev tamiel (~tamiel@85-171-171-179.rev.numericable.fr) |
| 12:17.51 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 12:17.51 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:21.24 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:21.24 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 12:35.38 | *** join/#asterisk-dev moy (~moy@173.239.155.74) |
| 12:50.21 | *** part/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 13:15.15 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:15.15 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:30.47 | *** join/#asterisk-dev DarkRift (~dark@unaffiliated/darkrift) |
| 13:37.01 | *** join/#asterisk-dev gokulnath (~gokulnath@115.111.177.122) |
| 13:47.26 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189.25.117.41) |
| 14:05.22 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-eeytfguggbsnwvuh) |
| 14:07.20 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-xvvmriybcuimqfta) |
| 14:07.33 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:16.32 | *** part/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 14:43.40 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 15:03.28 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189.25.104.126) |
| 15:08.27 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:08.27 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:28.49 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:28.49 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:44.36 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 15:44.37 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:58.00 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-bnacqvjbidaqqrsq) |
| 16:09.51 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:33.21 | kpfleming | it's so exciting when a new developer posts on the list about something they've hacked into an old release, when the feature they need already exists in a newer release |
| 16:37.59 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189.25.138.70) |
| 16:41.19 | leifmadsen | kpfleming: efficiency at its best |
| 16:48.20 | mjordan | on the other hand, framehooks for the win |
| 16:57.51 | mjordan | putnopvut: oh right, that's your name |
| 16:57.53 | mjordan | duh |
| 16:58.00 | putnopvut | yerp |
| 16:58.16 | mjordan | anyway, tested out the blind transfer patch - fixed the outright failures, but there's still an odd behavior that occurs |
| 16:58.23 | putnopvut | whazzat? |
| 16:58.52 | mjordan | it looks like the bridge never actually gets destroyed when the 'h' extension is still present |
| 16:59.08 | mjordan | (still present => exists at all) |
| 17:00.04 | putnopvut | Which test, specifically? |
| 17:00.28 | mjordan | the ones I just put up on reviewboard - https://reviewboard.asterisk.org/r/1686/ |
| 17:01.01 | mjordan | modified the blind transfer test I originally wrote to reproduce the issue to test out more of what you discovered |
| 17:01.12 | *** join/#asterisk-dev jeffg (~jeffg@pdpc/supporter/professional/jeffg) |
| 17:01.59 | mjordan | the only one that actually hangs up as you would expect with the 'h' extension present in the dialplan is callee_with_reinvite - so Phone A initiates the transfer and is nice enough to put Phone B on hold first |
| 17:03.04 | putnopvut | wow that's weird. Does that behavior exist without the h extension? |
| 17:06.08 | putnopvut | mjordan: also, what branch were you testing on? 1.8? |
| 17:13.37 | putnopvut | Wait, "callee_with_reinvite" is the one where phone B initiates the transfer, not A. |
| 17:19.35 | putnopvut | mjordan: I just ran the four scenarios manually against 1.8 with my patch, and all bridges were established and torn down just fine. When you have some time, I'd like to see your suspicious test results. |
| 17:20.08 | putnopvut | That was badly worded. The test results aren't suspicious, they make the scenario seem suspicious. |
| 17:32.01 | mjordan | putnopvut: did any of the tests take substantially longer then 20s to finish? |
| 17:32.59 | putnopvut | When I say manually, I mean I used phones. I didn't use the test cases you wrote. |
| 17:33.04 | mjordan | gotchya |
| 17:33.20 | putnopvut | mjordan: mind if I drop by for a sec? |
| 17:33.25 | mjordan | I'm in |
| 17:58.26 | putnopvut | mjordan: I just ran tests with phones again and did a core stop gracefully after hanging up the calls. Asterisk closed instantly. |
| 17:59.47 | mjordan | weird. |
| 18:19.09 | *** join/#asterisk-dev jeffg (~jeffg@pdpc/supporter/professional/jeffg) |
| 19:17.26 | kpfleming | jrose_atDigium: your commit message in 352093 should have referenced that the patch was authored by a community member, even if you had to get it ready for commit |
| 20:08.42 | kpfleming | patcehs going in, bugs getting fixed. |
| 20:08.50 | kpfleming | s/patcehs/patches/ |
| 20:53.43 | kpfleming | tzafrir_laptop: the 'libasteriskssl' branch now includes SONAME versioning of the installed library |
| 21:05.00 | *** join/#asterisk-dev ccesario (~ccesario@189-46-93-199.dsl.telesp.net.br) |
| 21:29.02 | mjordan | putnopvut: did some additional tweaking, found out that the BYE wasn't being sent because pjsua was getting killed faster then I thought - so the problem was with the test |
| 21:29.29 | mjordan | (oddly enough, one of them did seem to work consistently however - which is some strange timing) |
| 21:34.36 | jrose_atDigium | kpfleming: Normally in that case I just link the patch, but that time the issue itself didn't have a patch associated with it so I just linked the review. I don't think we have a special tag set aside for authorship otherwise, so I just appended to the log message to include the fact that Sergio wrote the patch in the multiline description section. |
| 21:35.00 | kpfleming | jrose_atDigium: ok, thanks |
| 21:35.48 | *** join/#asterisk-dev mvanbaak (~michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 21:35.48 | *** mode/#asterisk-dev [+o mvanbaak] by ChanServ |
| 22:02.06 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-jhjhgnceuylthrei) |
| 22:11.53 | putnopvut | mjordan: okay, good to know. |
| 22:39.25 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-zslxruxygpcujawu) |
| 22:55.23 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-fzuoobbpsmwcgbxu) |
| 23:12.32 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-xvvmriybcuimqfta) |
| 23:31.28 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@bzq-218-155-148.cablep.bezeqint.net) |
| 23:31.28 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 23:34.31 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 23:34.31 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 23:47.35 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 23:47.36 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |