| 00:44.48 | *** join/#asterisk-dev moy (~moy@173.239.155.74) |
| 02:15.52 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 02:15.52 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:49.42 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 02:49.42 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 03:36.20 | *** join/#asterisk-dev ccesario (~ccesario@187.17.166.162) |
| 05:04.49 | *** join/#asterisk-dev irroot (~gregory@196-215-57-31.dynamic.isadsl.co.za) |
| 05:05.17 | irroot | morning folks |
| 05:06.35 | WIMPy | Moin irroot |
| 05:07.14 | irroot | yeah about right time to start working again :P post holidays and all hope you all had good one |
| 05:07.40 | WIMPy | Holiday? What's that? |
| 05:08.06 | irroot | difference between been at office and home but not related to work |
| 05:08.20 | irroot | infact not been in office is more productive |
| 05:09.04 | WIMPy | That's the good thing about home office, but how do you define holiday in that situation? |
| 05:09.42 | irroot | ah based on if you dressed for going out or not |
| 05:09.53 | irroot | or dressed at all :P |
| 05:10.11 | WIMPy | That's an interesting one. |
| 07:35.03 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 07:37.11 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 07:37.12 | schmidts | good morning |
| 07:47.16 | *** join/#asterisk-dev wdoekes2 (~walter@wjd.osso.nl) |
| 07:48.47 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 07:48.47 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 07:48.58 | schmidts | good night leifmadsen ;) |
| 07:51.55 | wdoekes2 | morning |
| 08:04.57 | *** join/#asterisk-dev lftsy (~lftsy@194.38.160.113) |
| 08:19.57 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 08:19.58 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 08:31.57 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 08:44.27 | irroot | wdoekes2 morning |
| 08:44.44 | irroot | schmidts yo yo |
| 08:46.25 | schmidts | morning irroot |
| 09:45.08 | schmidts | can someone describe me why this is equal : *start == '"' when start beginns with a "+" like "+431234" |
| 09:49.56 | *** join/#asterisk-dev moneer (~moneer@109.74.39.198) |
| 09:49.57 | wdoekes2 | it isn't.. assuming we're talking C here |
| 09:50.20 | *** part/#asterisk-dev moneer (~moneer@109.74.39.198) |
| 09:55.44 | *** join/#asterisk-dev kaii (~kh@ciphron.de) |
| 09:58.45 | schmidts | wdoekes2 functino get_pai in chan_sip.c |
| 10:01.17 | wdoekes2 | I'm betting *start contains '"' as first char.. like: P-Asserted-Identity: "+123" <abc@def> |
| 10:01.46 | schmidts | yes |
| 10:02.10 | wdoekes2 | what is the problem? |
| 10:02.58 | schmidts | my problem is i get a PAI header like this: P-Asserted-Identity: +43599442440 <sip:+43599442440@sipmgc but get_pai drop out in the part where it wants to find the second " but there is none |
| 10:03.06 | schmidts | atleast there isnt even the first one ;) |
| 10:04.03 | wdoekes2 | I'm thinking it drops out here if (*start != '<') |
| 10:04.34 | schmidts | no it goes into the if (*start == '"') but then exit in the if (!end) |
| 10:06.07 | wdoekes2 | impossible.. either your lines are off (chan_sip.c editing after compile) or *start really IS '"' |
| 10:06.39 | schmidts | wdoekes2 give me a second i will show you |
| 10:09.35 | schmidts | sorry yes you are right |
| 10:09.49 | schmidts | i checked the wrong line number |
| 10:10.11 | wdoekes2 | you're right that the code is wrong though |
| 10:10.27 | schmidts | thats what i meant |
| 10:10.30 | wdoekes2 | pretty sure that it should do the normal useraddr parsing |
| 10:10.49 | schmidts | IMHO a display name doesnt have to had ", right? |
| 10:10.55 | wdoekes2 | from reqresp_parser |
| 10:11.38 | wdoekes2 | correct.. " is only needed if the name-bit contains space or " or < ... |
| 10:12.16 | wdoekes2 | (exact rules are in the abnf of course) |
| 10:12.39 | schmidts | i am just checking 10 and trunk and it looks like the code is the same in there |
| 10:13.11 | wdoekes2 | PAssertedID-value = name-addr / addr-spec |
| 10:14.29 | schmidts | its just like normal sip |
| 10:18.54 | schmidts | hmm it looks like channels/sip/regresp_parser is completly missing in doxygen |
| 10:23.00 | schmidts | ok i change this get_pai function to use the reqresp_parser functions like get_calleridname |
| 10:27.49 | schmidts | btw is this even valid: char *cid_num = ""; |
| 10:27.49 | schmidts | ? |
| 10:28.23 | schmidts | atleast it doesnt generate a compiler warning but i have never seen something like this ;) |
| 10:32.53 | *** join/#asterisk-dev ccesario (~ccesario@189.29.54.144) |
| 10:46.20 | wdoekes2 | schmidts: technically it's wrong, since "" should alloc a 1-byte ("\0") string in R/O mem |
| 10:47.12 | wdoekes2 | so it should be a const char |
| 10:48.13 | wdoekes2 | there are cases when this goes boom (there was an instance in func_curl where the ast_uri_decode was called on such a string, and writing (inline copying) the final (only) NUL caused a segfault |
| 10:48.59 | schmidts | wdoekes2 i have allready finished changing this function using the reqresp_parser functions and then i will also change this to NULL |
| 10:49.15 | schmidts | imho checking if this pointer is NULL will also not work when initialised with "" |
| 11:01.58 | *** join/#asterisk-dev ccesario (~ccesario@189.29.54.144) |
| 11:36.20 | *** join/#asterisk-dev Netgeeks (~chris@173.11.68.156) |
| 11:39.09 | *** join/#asterisk-dev micols (~t@rlogin.dk) |
| 11:39.44 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 11:39.44 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 11:41.11 | *** join/#asterisk-dev tzanger (tzanger@wallace.mixdown.ca) |
| 11:45.06 | *** join/#asterisk-dev merbanan (~benjamin@c-94-255-221-5.cust.bredband2.com) |
| 11:57.01 | schmidts | wdoekes2 https://reviewboard.asterisk.org/r/1673/ |
| 12:02.45 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 12:02.45 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:19.03 | wdoekes2 | schmidts: reviewed |
| 12:20.33 | schmidts | thanks ;) |
| 12:29.26 | schmidts | wdoekes2 imho get_name_and_number gets a const char * for the header and copy it before changing anything |
| 12:29.38 | schmidts | the get_in_brackets(pai) works cause pai is unchanged |
| 12:30.48 | schmidts | do you know whats in the sip rfc for anonymous does it have to be anonymous@anonymous.invalid or only anonymous before the @ or only the domain? |
| 12:31.42 | schmidts | ha nothing of this :D |
| 12:32.11 | wdoekes2 | ah.. you're right that get_name_and_number does a copy.. but then you have a memory leak instead ;) |
| 12:32.35 | schmidts | cool |
| 12:32.36 | schmidts | ;) |
| 12:32.50 | wdoekes2 | you'll need to free cid_num and cid_name |
| 12:33.00 | schmidts | allready doing this |
| 12:33.46 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:33.46 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 12:35.51 | schmidts | ok that was the easy part |
| 12:36.06 | schmidts | the question is how asterisk normally handles the anonymous thing |
| 12:37.27 | wdoekes2 | I wouldn't bother too much with that right now.. leave it for a different patch |
| 12:37.32 | schmidts | ok ;) |
| 12:47.52 | schmidts | wdoekes2 updated ;) |
| 12:49.10 | *** join/#asterisk-dev merbanan (~benjamin@c-94-255-221-5.cust.bredband2.com) |
| 13:38.00 | wdoekes2 | schmidts: "cid_name could be NULL but not the cid_num." => ... !strcasecmp(p->cid_name, cid_name) ... |
| 13:41.29 | schmidts | thanks, forget about it ;) |
| 13:43.53 | wdoekes2 | and I really don't like how ugly the if's have gotten around the ast_free. I prefer to see only one pair of ast_free's in the whole function. could be done by adding a few temp variables (is_anonymous and is_the_same) and checking those multiple times |
| 13:45.26 | wdoekes2 | (sorry for being a pain ;)) |
| 13:45.29 | *** join/#asterisk-dev tamiel (~tamiel@85-171-171-179.rev.numericable.fr) |
| 13:48.38 | *** join/#asterisk-dev b3nt_pin (~b3ntpin@142.162.36.51) |
| 13:51.07 | schmidts | is it safe to use ast_free on a NULL pointer, i didnt remember what we have said about this, IMHO yes |
| 13:51.20 | wdoekes2 | yes |
| 13:58.51 | schmidts | hmm finding the right way to check for cid_name != NULL isnt as easy as i thought ;) |
| 14:02.30 | schmidts | my problem with this is, if there is no name set in the PAI header should we replace the cid_name or should we just use the name from the from header |
| 14:03.22 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-pdpofgzzlhtpgssi) |
| 14:03.22 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:05.15 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-hfgsvmuqtxltlchu) |
| 14:11.36 | schmidts | wdoekes2 once again ;) |
| 14:15.48 | schmidts | cya all tomorrow ;) |
| 14:18.06 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 14:31.52 | *** join/#asterisk-dev joshaidan (~brianj@S0106001c1023e838.tb.shawcable.net) |
| 15:18.43 | pabelanger | Hmm, are 'all blind transfers' really broken in 1.8.9.0-rc1? |
| 15:20.35 | mjordan | pabelanger: not that I've been able to reproduce. We're waiting on pcaps. |
| 15:21.54 | *** join/#asterisk-dev bklang (~bklang@2001:470:8:5de:225:ff:fe49:f8cd) |
| 15:26.08 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:26.08 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:47.11 | *** join/#asterisk-dev irroot (~gregory@197.109.13.197) |
| 15:52.39 | *** join/#asterisk-dev otherwiseguy (~otherwise@nat/digium/x-xvkyfekhwsetwhss) |
| 16:15.45 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 16:15.45 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 16:18.32 | *** join/#asterisk-dev w9sh (~chatzilla@64-238-96-125.corp.cbeyond.net) |
| 16:25.03 | *** join/#asterisk-dev irroot (~gregory@197.169.187.99) |
| 16:27.50 | tzanger | kpfleming: I hear you are an excellent cook |
| 16:28.22 | kpfleming | tzanger: that is the story that is going around, yes. |
| 16:28.43 | tzanger | what started this rumour? |
| 16:28.55 | kpfleming | my cooking, i suspect |
| 16:30.41 | tzanger | droll, Mr. Fleming, very droll. |
| 16:31.30 | file | kpfleming did not make cookies though |
| 16:31.48 | kpfleming | no. i considering doing it this morning, but did not. |
| 16:32.04 | tzanger | oh that's right, file's stateside |
| 16:32.29 | tzanger | meanwhile someone back in Canadia is rearranging his house |
| 16:32.55 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:33.02 | file | yes |
| 16:33.17 | file | https://twitter.com/#!/Tux889/status/158660307517046784/photo/1 |
| 16:33.30 | file | my desk is on the left. |
| 16:38.01 | *** join/#asterisk-dev angler (~angler@pdpc/sponsor/digium/angler) |
| 16:46.20 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 16:46.20 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 16:50.57 | *** join/#asterisk-dev malcolmd_ (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 16:50.57 | *** mode/#asterisk-dev [+o malcolmd_] by ChanServ |
| 17:00.00 | *** join/#asterisk-dev irroot (~gregory@197.170.152.70) |
| 17:02.47 | *** part/#asterisk-dev irroot (~gregory@197.170.152.70) |
| 17:31.54 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 17:31.57 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 17:36.57 | seanbright | commit asterisk 351287 |
| 17:37.16 | seanbright | well... bot is dead, but that's a new feature going into a release branch |
| 17:37.32 | kpfleming | the RTP probation thing? |
| 17:37.39 | seanbright | correct |
| 17:37.59 | kpfleming | it's not really new, it's a reimplementation of what we already had, except now it actually works as users expect it to work. |
| 17:38.20 | file | it's just less dumb |
| 17:38.44 | mjordan | (but still dumb, mind you) |
| 17:39.09 | kpfleming | it's as dumb as the RFCs mandate it needs to be |
| 17:39.24 | seanbright | i see |
| 17:39.30 | seanbright | certainly looks new to me |
| 17:39.33 | seanbright | but what do i know |
| 17:39.57 | kpfleming | no, we already had 'learning' mode for strictrtp, it just wasn't implemented well and broke media in various transfer and directmedia scenarios |
| 17:40.09 | seanbright | gotcha |
| 18:21.39 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:21.39 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:50.08 | *** join/#asterisk-dev irroot (~gregory@197.174.135.33) |
| 18:55.00 | *** part/#asterisk-dev irroot (~gregory@197.174.135.33) |
| 19:04.12 | *** join/#asterisk-dev malcolmd_ (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 19:04.12 | *** mode/#asterisk-dev [+o malcolmd_] by ChanServ |
| 19:19.30 | JunK-Y | wdoekes2: any more concerns with https://reviewboard.asterisk.org/r/1651/ ? |
| 19:46.24 | wdoekes2 | let's see |
| 20:13.07 | wdoekes2 | JunK-Y: there you go |
| 20:14.30 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 20:15.13 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 20:15.14 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 20:37.50 | JunK-Y | wdoekes2: i'll fix them 2nite. |
| 20:38.23 | JunK-Y | as soon all this will be commited, i'll start working on another patch to fix many more things. |
| 21:16.42 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 21:43.49 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 21:43.49 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Tier 4 support is in #2,000 |
| 23:17.09 | *** join/#asterisk-dev joshaidan (~brianj@S010600095bfe15df.tb.shawcable.net) |
| 23:20.02 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-pdpofgzzlhtpgssi) |
| 23:23.18 | *** part/#asterisk-dev joshaidan (~brianj@S010600095bfe15df.tb.shawcable.net) |
| 23:31.35 | *** join/#asterisk-dev joshaidan (~brianj@S010600095bfe15df.tb.shawcable.net) |
| 23:46.34 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 23:46.34 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |