| 00:13.33 | alecdavis | how long you around fo? |
| 00:17.26 | alecdavis | Im just wondering about wctdm_init_ring_generator_mode, should i call spin_lock_irqsave(&wc->reglock, flags); and restore around wctdm_set_ring_generator_mode? |
| 00:19.28 | sruffell | I should be around for another couple of hoursâ¦. |
| 00:20.07 | sruffell | andâ¦yes, you'll need to make sure that the lock is held when you call wctdm_setreg_intr, since you don't want to stomp on another CPU which may be queueing a command to the cmd list. |
| 00:20.16 | sruffell | alsoâ¦.is it safe to skip the wait_access call? |
| 00:27.59 | alecdavis | re wait_access, i'm having trouble with that too. |
| 00:28.54 | alecdavis | If we need to wait, in the ISR context, it's bad, right? hence your thoughts on getting this misc stuff out of the ISR |
| 00:30.06 | sruffell | yes..that's what I was thinking. The patch I had intended to whip up was to push your new function out to the system global workqueue (assuming it's called infrequently) |
| 00:30.30 | sruffell | then all the reset of the isr_misc stays put |
| 00:30.41 | sruffell | is that something you still would be interested in seeing? |
| 00:30.51 | sruffell | s/reset/rest/ |
| 00:33.43 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@208.88.9.51) |
| 00:41.04 | alecdavis | it's only called, when settign messages on or off, and from what I'm seeing each onhook. |
| 00:41.05 | alecdavis | so not very often. |
| 00:41.08 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@174-23-33-109.slkc.qwest.net) |
| 00:41.25 | sruffell | okâ¦making patchâ¦. |
| 00:43.53 | alecdavis | module reload, 7 seconds. |
| 00:44.08 | sruffell | â¦and before? :) |
| 00:51.13 | alecdavis | 19 seconds. just timed trunk. |
| 00:52.03 | sruffell | have you thought how you're going to spend all those extra seconds of life? |
| 00:52.26 | sruffell | I'm going boldâ¦I'm just going to try and move all the isr_misc out of the interrupt handlerâ¦.and see if anything breaks. |
| 00:53.07 | alecdavis | ohh, 9 seconds, timing by watch, not counting in head. |
| 00:53.44 | sruffell | hmmâ¦.only 2 seconds better? |
| 00:54.10 | alecdavis | no, the 7 seconds was an estimate. |
| 00:54.25 | alecdavis | 19/9 both timed with a watch. |
| 00:54.46 | sruffell | that's about what I would expectâ¦you're on a TDM800 right? |
| 00:54.53 | alecdavis | yep. |
| 00:55.02 | sruffell | TDM800 about twice as fastâ¦.6 times faster on the 2400 |
| 01:00.00 | alecdavis | where to spend many more seconds of my life, working on the BMS (battery management system) for electric bikes. Awesome stuff. |
| 01:00.02 | alecdavis | http://www.astara.co.nz/Astara/Electric_motorcycle_project.html |
| 01:00.45 | sruffell | oh wowâ¦do you have one of those? |
| 01:02.01 | alecdavis | no. But, oneday I'll get to ride it. I work with the company that builds them |
| 01:15.10 | sruffell | hmmâ¦.it's not happy... |
| 01:19.14 | alecdavis | always the way. |
| 01:26.12 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@174-23-33-109.slkc.qwest.net) |
| 01:39.09 | alecdavis | what's this: fxs->idletxhookstate |= SLIC_LF_OPPENDING | SLIC_LF_REVMASK; |
| 01:39.27 | alecdavis | ^^ shouldn't have OPPENDING, surely? |
| 01:43.05 | sruffell | I think that OPPENDING is used as a sort of lock.... |
| 01:43.16 | sruffell | it's not actually written out. |
| 01:44.37 | sruffell | wellâ¦I guess you know that, looking at: http://svn.asterisk.org/view/dahdi?view=revision&revision=9063 |
| 01:45.20 | alecdavis | i wondered, if it was me that put it in. |
| 01:45.24 | alecdavis | oops. |
| 01:47.55 | alecdavis | ah, I sort of remember that. |
| 01:47.55 | sruffell | http://svn.asterisk.org/view/dahdi?view=revision&revision=7117 is when that went in specifically..so you're off the hook (parden the pun) |
| 01:55.00 | alecdavis | it was already there. doug changed 0x10 to SLIC_LF_OPPENDING |
| 02:18.18 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@174-23-33-109.slkc.qwest.net) |
| 02:21.09 | sruffell | okâ¦what I was seeing was a problem introduced in one of the other commits on my for-trunk branch. So the branch you have checked out won't "grow" latency correctlyâ¦it'll just hard underrun instead. |
| 02:22.26 | sruffell | in http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=commitdiff;h=05c22bf89d I had "if (1 == dl->count); " there shouldn't be a semicolon at the end of that line. :( |
| 02:26.30 | alecdavis | changed it now. |
| 02:29.52 | sruffell | okâ¦you should be able to add my change with 'curl "http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=patch;h=58525374e22" | git am' |
| 02:30.03 | sruffell | ahhâ¦no git... |
| 02:30.24 | sruffell | curl "http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=patch;h=58525374e22" | patch -p1 |
| 02:30.28 | sruffell | that'll do it |
| 02:31.08 | sruffell | (you can also look at in in webview: http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=commitdiff;h=58525374e2) |
| 02:31.55 | sruffell | there's some other cleanup workâ¦but I'd be interested to know if that still works for you. |
| 02:33.12 | alecdavis | if I had curl. installing now |
| 02:34.38 | alecdavis | 4 out of 9 hunks FAILED -- saving rejects to file drivers/dahdi/wctdm24xxp/base.c.rej |
| 02:35.06 | alecdavis | was this suposed to be applied your clean team checkout |
| 02:35.10 | sruffell | huhâ¦that's just on top of your version 6 |
| 02:35.53 | sruffell | You can see what I applied it on looking at the http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=shortlog;h=refs/heads/neon_vmwi2 |
| 02:36.59 | alecdavis | ah, I've change the wctdm_proslic_setreg_indirect_intr(wc, mod, 20, reg20) to wc,md,Friendlyname,reg20 |
| 02:41.19 | alecdavis | installing.... |
| 02:48.38 | *** join/#asterisk-dev alecdavis (~sivad@202-78-149-14.cable.telstraclear.net) |
| 02:49.45 | alecdavis | umm. that wasn't good. went off hook, got dial tone. went onhook, and died. not sure if seg fault as monitor was blank. |
| 02:50.42 | sruffell | hmmâ¦alrightâ¦.then I'll need to spend some quality time with that. I think it's probably worth the time to get all that code out of the interrupt handlerâ¦which will have the nice side effect of making your issue with the indirect regs moot... |
| 02:50.56 | sruffell | I just load tested itâ¦didn't pass any calls over the channels, which I'll do. |
| 02:53.40 | sruffell | and with that, I'm out of here and I'll talk to you later. |
| 03:18.21 | *** join/#asterisk-dev alecdavis (~sivad@202-78-149-14.cable.telstraclear.net) |
| 04:00.38 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 04:00.38 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 05:53.36 | *** join/#asterisk-dev Qwell (~north@pdpc/sponsor/digium/Qwell) |
| 05:53.36 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 08:40.58 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 11:06.01 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:06.01 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 14:40.08 | *** join/#asterisk-dev luckman212 (~irc@pool-173-77-253-141.nycmny.fios.verizon.net) |
| 15:00.20 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 15:00.20 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 18:35.13 | *** join/#asterisk-dev moy (~moy@CPE003048b11058-CM00222d6b4d65.cpe.net.cable.rogers.com) |
| 19:25.28 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 19:25.28 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 19:27.09 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 19:27.09 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 20:16.03 | *** join/#asterisk-dev JunK-Y (~junky@pdpc/supporter/active/junk-y) |
| 21:17.14 | seanbright | jrose use irc? |
| 21:23.19 | Freeaqingme | what softphone can be used best for debugging? |
| 21:23.25 | Freeaqingme | (on linux) |
| 21:41.44 | tzafrir_laptop | Freeaqingme, I prefer twinkle |
| 21:43.20 | Freeaqingme | hmm, I'm the wrong channel I see. Tnx though, that's what I'd just started |
| 22:22.16 | *** join/#asterisk-dev elguero (~miguel323@17.140.211.66.inaddr.G4.NET) |
| 22:37.23 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@pool-71-111-114-150.ptldor.dsl-w.verizon.net) |
| 23:03.20 | Kobaz | Freeaqingme: twinkle |
| 23:07.47 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 23:07.47 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 23:17.50 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 23:17.51 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |