| 01:14.27 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 01:14.27 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 01:48.13 | *** join/#asterisk-dev mog (~mog@c-68-62-169-225.hsd1.al.comcast.net) |
| 01:48.13 | *** mode/#asterisk-dev [+o mog] by ChanServ |
| 01:48.14 | *** join/#asterisk-dev bbryant (~brett@c-76-26-221-79.hsd1.sc.comcast.net) |
| 01:48.14 | *** mode/#asterisk-dev [+o bbryant] by ChanServ |
| 02:22.54 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 03:05.49 | *** join/#asterisk-dev bbryant (~brett@c-76-26-221-79.hsd1.sc.comcast.net) |
| 03:05.50 | *** mode/#asterisk-dev [+o bbryant] by ChanServ |
| 03:11.31 | *** part/#asterisk-dev alecdavis (~alec@210.48.127.227) |
| 03:40.50 | *** join/#asterisk-dev micols (~mio@rlogin.dk) |
| 03:56.10 | *** join/#asterisk-dev eugeneoden (~goden@99-62-173-58.lightspeed.austtx.sbcglobal.net) |
| 04:57.39 | *** join/#asterisk-dev ybit2 (~quassel@unaffiliated/ybit) |
| 05:55.16 | *** join/#asterisk-dev ssh-add (~schmidts@lmlo.sil.at) |
| 05:55.19 | ssh-add | good morning |
| 05:55.27 | *** join/#asterisk-dev lftsy (~lftsy@install.deckpoint.ch) |
| 06:05.18 | *** join/#asterisk-dev jdoe (jdoe@665.be) |
| 06:41.54 | *** join/#asterisk-dev hehol (~hehol@buero-gw.dortmund.loca.net) |
| 07:28.20 | ssh-add | i have a question about issue 18112 |
| 07:28.22 | MuffinMan | [new] [Asterisk] Applications/app_macro 0018112: [patch] Report what extension called a failed macro reported by prado https://issues.asterisk.org/view.php?id=18112 |
| 07:28.40 | ssh-add | the patch looks ok for me but i am not sure if i should add it to trunk. |
| 07:28.48 | ssh-add | how decide this? |
| 07:37.31 | ssh-add | s/how/who/ |
| 07:58.57 | wdoekes2 | ssh-add: be patient, schmidts said he would talk to the other devs |
| 07:59.44 | wdoekes2 | oh.. that would be you |
| 07:59.55 | wdoekes2 | lol :) |
| 08:16.40 | ssh-add | :D |
| 08:17.26 | schmidts | ;) |
| 08:17.48 | schmidts | maybe i should watch what i type in which window |
| 08:27.07 | schmidts | has anyone tried to move hints from an rwlist to an ao2 container? |
| 08:33.13 | schmidts | and also state callbacks |
| 08:50.38 | *** join/#asterisk-dev CoderForLife (~Miranda@cpe-174-103-152-61.cinci.res.rr.com) |
| 08:52.13 | schmidts | cause even in trunk its just slow ;) |
| 08:53.25 | schmidts | handle_statechange needs 1533 usec LINE: 4278 |
| 08:53.25 | schmidts | handle_statechange needs 1534 usec LINE: 4278 |
| 08:53.25 | schmidts | handle_statechange needs 1030 usec LINE: 4278 |
| 08:53.25 | schmidts | handle_statechange needs 743 usec LINE: 4278 |
| 08:53.30 | schmidts | just some examples what i mean |
| 09:14.32 | *** join/#asterisk-dev jmls (~Julian@host217-36-208-155.in-addr.btopenworld.com) |
| 09:46.37 | *** join/#asterisk-dev grEvenX (~even@apb9hb.ip.ssc.net) |
| 10:06.21 | snuff-home | schmidts: i guess.. ppl aren't expected to have 100's of hints :) |
| 11:24.37 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:24.38 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:29.22 | snuff-home | mornin kp |
| 11:34.59 | *** join/#asterisk-dev rrb3942 (~rbullock@208.34.105.161) |
| 11:50.09 | *** join/#asterisk-dev Marquis42 (~bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 11:54.29 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 11:54.29 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 11:56.53 | schmidts | snuff-home i know this but i have it :D 1300 hints with > 1700 subscribes on it |
| 12:16.27 | *** join/#asterisk-dev Dovid (Dovid@ool-4355e297.dyn.optonline.net) |
| 12:33.34 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 12:33.34 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- IAX2 is now RFC 5456. -=- AstriDevCon 2010, October 29, sign up here: http://bit.ly/astridevcon2010 |
| 12:52.33 | *** join/#asterisk-dev bklang (~bklang@tesla.alkaloid.net) |
| 12:54.59 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 12:54.59 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 13:02.09 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 13:17.34 | schmidts | just a short question, why is the DEFAULT_TRANS_TIMEOUT allways set to -1? |
| 13:23.32 | schmidts | ok got it ;) |
| 13:46.09 | Corydon76-home | schmidts: I think if you did the conversion of hints to a hashed container, it would be most welcome |
| 13:53.41 | *** join/#asterisk-dev crowbar7 (~JKLOBUCAR@12.2.84.2) |
| 13:57.25 | *** join/#asterisk-dev Deeewayne (~dwayne@75-150-14-49-Atlanta.hfc.comcastbusiness.net) |
| 13:57.25 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 14:14.12 | schmidts | is this kind of code acceptable in the coding guidelines? |
| 14:14.14 | schmidts | sip_scheddestroy(p, (expires_ms > ((p->timer_t1 != 0) ? p->timer_t1 : global_t1) * 64) ? DEFAULT_TRANS_TIMEOUT : (expires_ms - EXPIRY_GUARD_MIN)); |
| 14:17.02 | Corydon76-home | The coding guidelines don't specifically address that, so yes, although given that it will take somebody several minutes to read that and understand the full implications, I'd suggest that it be avoided |
| 14:18.25 | schmidts | i will split this up to make it better to read ;) |
| 14:18.59 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 14:18.59 | Corydon76-home | Generally, it's more difficult to read when you include a ternary operator in the conditional of another ternary operator |
| 14:19.13 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 14:19.38 | Corydon76-home | Most of our compound ternary statements include additional conditionals only in the 3rd argument of the ternary operator |
| 14:23.43 | schmidts | i know i wouldnt catch this for myself if i havent wrote this |
| 14:25.56 | schmidts | this looks better: |
| 14:25.56 | schmidts | <PROTECTED> |
| 14:25.57 | schmidts | <PROTECTED> |
| 14:25.57 | schmidts | <PROTECTED> |
| 14:26.58 | schmidts | more or less :D |
| 14:27.27 | schmidts | http://pastebin.com/S4i1hDQx |
| 14:28.27 | kpfleming | actually, with the complexity of those conditionals, they should either be on separate lines, or they could even be separate clauses of the if statement (even though they have the same resulting action) |
| 14:29.22 | kpfleming | and put a space between 'if' and '('... it is not a function call :-) |
| 14:29.32 | schmidts | sorry missed this ;) |
| 14:29.46 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:29.46 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:32.04 | schmidts | http://pastebin.com/YZuHAcM2 |
| 14:32.11 | schmidts | like this ^^ |
| 14:33.02 | kpfleming | schmidts: indeed, much easier to read and understand |
| 14:33.42 | schmidts | thats true! |
| 14:37.36 | schmidts | this solves issue 18119 am i supposed to put this into svn? |
| 14:37.37 | MuffinMan | [new] [Asterisk] Channels/chan_sip/Registration 0018119: Reregistration with small (20 sec) Expiry fails reported by fabled https://issues.asterisk.org/view.php?id=18119 |
| 14:40.15 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 14:47.15 | wdoekes2 | (schmidts: personally I would've gone with a temporary variable even, so you get only one sip_scheddestroy() call after the if... after all: you're not considering whether you want to destroy, you're only considering which timeout you need) |
| 14:59.34 | schmidts | wdoekes2 you are right, looks even better like this |
| 14:59.55 | schmidts | http://pastebin.com/L3uPzf8v |
| 15:01.04 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 15:01.04 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 15:18.02 | *** join/#asterisk-dev guilhermebr (~Guilherme@189.63.40.18) |
| 15:27.02 | *** join/#asterisk-dev marv (~timr@24.214.206.254) |
| 15:29.47 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:29.47 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 18:11.36 | *** join/#asterisk-dev bbryant (~brett@c-76-26-221-79.hsd1.sc.comcast.net) |
| 18:11.36 | *** mode/#asterisk-dev [+o bbryant] by ChanServ |
| 19:34.50 | *** join/#asterisk-dev JunK-Y (~junky@64.15.77.94) |
| 19:37.48 | JunK-Y | howdy |
| 19:48.45 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 19:58.54 | *** join/#asterisk-dev erinspice (~erin@207.98.195.107) |
| 20:00.44 | *** join/#asterisk-dev miguel3239 (~miguel323@ns1.nashuacs.com) |
| 20:16.39 | *** join/#asterisk-dev bbryant (~brett@c-76-26-221-79.hsd1.sc.comcast.net) |
| 20:16.39 | *** mode/#asterisk-dev [+o bbryant] by ChanServ |
| 20:46.56 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 21:10.45 | *** join/#asterisk-dev erinspice (~erin@207.98.195.107) |
| 22:06.04 | *** join/#asterisk-dev snuff-work (~aaa@210.9.82.197) |
| 22:06.04 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:44.56 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 23:36.02 | *** join/#asterisk-dev CoderForLife (~Miranda@cpe-174-103-152-61.cinci.res.rr.com) |