| 00:02.57 | *** join/#asterisk-dev jpeeler (~jpeeler@asterisk/digium-software-dev/jpeeler) |
| 00:02.57 | *** mode/#asterisk-dev [+o jpeeler] by ChanServ |
| 00:05.47 | *** part/#asterisk-dev jpeeler (~jpeeler@asterisk/digium-software-dev/jpeeler) |
| 01:54.04 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 01:54.04 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 06:30.25 | jmls | Corydon76-dig: hey, that's what I was trying to do. I thought that frame->data contained the "sound", so I replaced it with all zeros |
| 06:30.59 | jmls | or so I thought. I suspect that I did a lot more damage inadvertently |
| 06:32.39 | *** join/#asterisk-dev snuff-work (~aaa@210.9.82.197) |
| 06:32.39 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 07:22.56 | *** join/#asterisk-dev mog (~mog@c-68-62-169-225.hsd1.al.comcast.net) |
| 07:22.56 | *** mode/#asterisk-dev [+o mog] by ChanServ |
| 07:31.48 | Corydon76-dig | jmls: yes, but you should replace it by overwriting it with zeroes, not by allocating a completely separate buffer |
| 07:38.33 | jmls | Hi Corydon76-dig. I thought that I should save the contents of frame->data, replace it with a buffer containing zeros, transmit the frame and then restore the contents of frame->data |
| 07:39.18 | jmls | as an aside, could this be the cause of my crashes I've been reporting over the last couple of weeks ? |
| 07:39.20 | Corydon76-dig | Why are you restoring the frame after transmission? |
| 07:39.37 | *** join/#asterisk-dev mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |
| 07:39.38 | jmls | because I was under the impression that the frame would be used elsewhere |
| 07:39.53 | Corydon76-dig | Generally not |
| 07:40.08 | jmls | "generally" scares me ;) |
| 07:40.21 | Corydon76-dig | Where exactly are you altering the frame? |
| 07:41.03 | Corydon76-dig | inside a manipulate audiohook? |
| 07:41.52 | jmls | audiohook.c, in ast_audiohook_write_frame |
| 07:42.07 | Corydon76-dig | Okay, there should be no reason for you to alter that file at all |
| 07:42.22 | Corydon76-dig | If you want to install a manipulate audiohook, do it there |
| 07:43.06 | Corydon76-dig | i.e. you install a manipulate audiohook on a particular channel, then your routine gets called for each frame passing through that channel |
| 07:43.29 | jmls | this is a "backport" for my mutemixmonitor |
| 07:43.57 | Corydon76-dig | See func_speex for an example of how to create such a manipulate audiohook |
| 07:44.35 | Corydon76-dig | How is it a mixmonitor at all, if you're silencing frames? |
| 07:45.02 | jmls | remember, I need to mute the part of the recording when the agent is taking credit card numbers over the phone |
| 07:45.17 | Corydon76-dig | and btw, mixmonitor is doing at the spy stage, which happens before manipulation |
| 07:45.21 | jmls | all other parts of the conversation must be recorded |
| 07:45.43 | Corydon76-dig | Ah |
| 07:46.13 | Corydon76-dig | How do you determine what part of the conversation that is? |
| 07:46.29 | Corydon76-dig | Feature code? |
| 07:46.37 | jmls | the application sends an AMI command when the agent tabs into a credit card number field |
| 07:46.47 | Corydon76-dig | Ah |
| 07:47.50 | Corydon76-dig | Let me think about that. I'm about to head to bed, and I have a graduation to attend tomorrow |
| 07:48.01 | jmls | the manager command finds the mixmonitor audiohook, and sets a flag to mute or unmute |
| 07:48.08 | jmls | attend ? You graduating ? |
| 07:48.28 | Corydon76-dig | A friend is graduating HS |
| 07:48.33 | jmls | ah. |
| 07:49.01 | jmls | btw - a "proper" version of this was comitted to trunk |
| 07:49.44 | Corydon76-dig | Oh? |
| 07:49.44 | jmls | 1.4 didn't have the functions that I used in trunk |
| 07:49.44 | Corydon76-dig | In that same source file? |
| 07:49.44 | jmls | audiohook.c, yes |
| 07:49.58 | jmls | and frame.c iirc |
| 07:50.10 | jmls | app_mixmonitor.c as well :) |
| 07:50.49 | Corydon76-dig | Right. Note that for the implementation in trunk, no alloca is used, just a memset |
| 07:51.25 | Corydon76-dig | No worries that the frame needs to be somehow restored |
| 07:51.40 | jmls | ok, that makes things a lot simpler :) |
| 07:52.06 | jmls | just memset frame->data to 0 ? |
| 07:52.18 | jmls | will leave you alone to get some zzzz's |
| 07:52.37 | Corydon76-dig | Yes, just make sure that the size is correct |
| 07:53.02 | jmls | frame->datalen |
| 07:53.20 | Corydon76-dig | Right |
| 07:53.24 | jmls | woot! |
| 07:53.26 | jmls | ;) |
| 07:54.17 | jmls | <PROTECTED> |
| 07:59.24 | *** join/#asterisk-dev angler (~angler@pdpc/sponsor/digium/angler) |
| 08:47.48 | *** join/#asterisk-dev renshen (~renshen4@host40-246-dynamic.19-79-r.retail.telecomitalia.it) |
| 09:09.19 | *** join/#asterisk-dev ChannelZ (~bobm@burner.com) |
| 09:11.31 | *** join/#asterisk-dev hehol (~Adium@ip-78-94-0-76.unitymediagroup.de) |
| 09:39.58 | jmls | any C coders out there not in zzzzzzz territory ? |
| 09:40.14 | jmls | mvanbaak: I know that you are in my timezone ... you can't hide .... |
| 09:41.09 | jmls | just wanting to check that memset(frame->data, 0, frame->datalen) would zero the frame data, not the frame data pointer ;) |
| 10:20.31 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 10:20.31 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 10:21.42 | snuff-home | jmls yes.. void *memset(void *s, int c, size_t n); |
| 10:22.03 | snuff-home | s = pointer, c = data, n = size |
| 10:35.45 | jmls | snuff-home: thanks |
| 10:36.05 | jmls | gotta run. school fun day beckons :( |
| 12:03.30 | *** join/#asterisk-dev hehol (~hehol@buero-gw.dortmund.loca.net) |
| 13:20.04 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 13:20.04 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:14.12 | *** join/#asterisk-dev Corydon76-dig (four@c-69-137-80-31.hsd1.tn.comcast.net) |
| 15:14.12 | *** mode/#asterisk-dev [+o Corydon76-dig] by ChanServ |
| 15:24.35 | *** join/#asterisk-dev puzzled (~patrick@puzzled.xs4all.nl) |
| 15:49.10 | tzafrir_laptop | hmmm.... is libpri 1.4.11 ABI-compatible to libpri 1.4.10.2 ? |
| 15:49.19 | tzafrir_laptop | Or should the SONAME be bumped? |
| 16:05.31 | *** join/#asterisk-dev Deeewayne (~dwayne@75-150-14-49-Atlanta.hfc.comcastbusiness.net) |
| 16:05.31 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 16:22.46 | tzafrir_laptop | hmm... ok. seems to at least able to load with asterisk 1.6.2 |
| 16:48.35 | *** join/#asterisk-dev Dovid (~annon@213.8.121.90) |
| 17:21.34 | *** join/#asterisk-dev diegomad (~mad@190.158.77.2) |
| 17:24.17 | *** join/#asterisk-dev akshayb (~akshay@089-101-190066.ntlworld.ie) |
| 18:51.41 | *** join/#asterisk-dev Netgeeks (~chris@173.11.68.155) |
| 19:04.27 | *** join/#asterisk-dev puzzled (~patrick@puzzled.xs4all.nl) |
| 19:06.40 | *** part/#asterisk-dev ChannelZ (~bobm@burner.com) |
| 19:37.43 | *** join/#asterisk-dev akshayb (~akshay@089-101-190066.ntlworld.ie) |
| 20:30.52 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 20:30.52 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 20:48.30 | *** join/#asterisk-dev alecdavis (~alec@210.48.127.227) |
| 21:49.48 | *** join/#asterisk-dev akshayb (~akshay@089-101-190070.ntlworld.ie) |
| 22:27.42 | *** join/#asterisk-dev mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |
| 22:33.05 | *** join/#asterisk-dev diegomad (~mad@190.158.77.2) |