| 00:57.00 | *** join/#asterisk-dev dseeb_ (~Adium@CPE-58-169-79-6.lns1.bat.bigpond.net.au) |
| 01:34.14 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 01:34.14 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 01:49.38 | *** join/#asterisk-dev dseeb_ (~Adium@CPE-58-169-79-6.lns1.bat.bigpond.net.au) |
| 02:14.34 | *** join/#asterisk-dev diegomad (mad@186.81.138.29) |
| 03:13.42 | *** join/#asterisk-dev Deeewayne (~dwayne@206.61.30.131) |
| 03:13.42 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 03:37.53 | *** part/#asterisk-dev dseeb_ (~Adium@CPE-58-169-79-6.lns1.bat.bigpond.net.au) |
| 05:51.57 | *** join/#asterisk-dev nickw (~nickw@c-76-111-107-117.hsd1.md.comcast.net) |
| 06:04.44 | *** join/#asterisk-dev nickw (~nickw@c-76-111-107-117.hsd1.md.comcast.net) |
| 07:06.28 | *** join/#asterisk-dev hehol (~hehol@buero-gw.dortmund.loca.net) |
| 07:14.36 | *** join/#asterisk-dev tamiel (~tamiel@213.30.183.226) |
| 07:37.40 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 09:03.17 | *** join/#asterisk-dev micols (~mio@rlogin.dk) |
| 09:53.05 | *** join/#asterisk-dev kerframil (~kerframil@gentoo/user/kerframil) |
| 09:55.47 | *** join/#asterisk-dev micols (~mio@rlogin.dk) |
| 10:19.34 | *** join/#asterisk-dev mvanbaak_ (~michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 10:19.34 | *** mode/#asterisk-dev [+o mvanbaak_] by ChanServ |
| 10:19.43 | *** join/#asterisk-dev brookshire (mbrooks@hijacked.us) |
| 10:31.59 | *** join/#asterisk-dev nickw (~nickw@c-76-111-107-117.hsd1.md.comcast.net) |
| 10:45.19 | *** join/#asterisk-dev pabelanger (~pabelange@yoda.kanatek.com) |
| 11:23.27 | *** join/#asterisk-dev eliel (~eliels@201.234.94.226) |
| 11:23.27 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 11:32.27 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 11:32.27 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 11:43.10 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:43.10 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 12:46.08 | *** join/#asterisk-dev TheDavidFactor (~chatzilla@c-68-34-116-180.hsd1.md.comcast.net) |
| 13:18.16 | pabelanger | morning |
| 13:19.59 | frawd | hello |
| 13:30.12 | *** join/#asterisk-dev akshayb (~b49531e2@gateway/web/freenode/x-vgvyxahbqwbhtknt) |
| 13:30.30 | *** join/#asterisk-dev Deeewayne (~dwayne@75-150-14-49-Atlanta.hfc.comcastbusiness.net) |
| 13:30.30 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 13:35.12 | *** join/#asterisk-dev moy (~chatzilla@bas1-unionville55-1177733627.dsl.bell.ca) |
| 13:40.04 | *** join/#asterisk-dev codefreeze-lap (~murf@mail.parsetree.com) |
| 13:40.04 | *** mode/#asterisk-dev [+o codefreeze-lap] by ChanServ |
| 13:40.42 | leifmadsen | morning all |
| 13:41.09 | *** join/#asterisk-dev caio1982 (~caio1982@CAcert-br/caio1982) |
| 13:41.19 | *** join/#asterisk-dev Pazzo (~ugelt@reserved-225136.rol.raiffeisen.net) |
| 13:44.15 | snuff-home | ello leifmadsen |
| 13:44.24 | pabelanger | salutes leifmadsen |
| 13:45.36 | leifmadsen | greetings and salutations! |
| 13:48.20 | pabelanger | heh, we don't have 'minute' recorded anywhere in the prompts. |
| 13:48.27 | pabelanger | only minutes |
| 13:48.40 | snuff-home | i thought it was already raised |
| 13:48.46 | snuff-home | as a issue? |
| 13:48.50 | pabelanger | yar |
| 13:48.58 | pabelanger | just surprise to see that. |
| 13:49.07 | leifmadsen | huh... crappy |
| 13:53.44 | pabelanger | I've been thinking for a while about submitting a patch to clean up the sounds structure, but havn't got around to it. |
| 13:55.07 | snuff-home | there was discussion about sounds and folders a while ago on the -dev list |
| 13:55.11 | snuff-home | goes to bed.. |
| 13:55.13 | snuff-home | :) |
| 13:55.30 | pabelanger | snuff-home: ya, might restart it. night man |
| 13:55.45 | *** join/#asterisk-dev hugorebelo (~hugo@p5B2770D4.dip.t-dialin.net) |
| 13:55.48 | leifmadsen | well I just did a sounds release yesterday :) I did a bunch of cleaning up, but patches welcome to do further cleanup! |
| 13:56.58 | pabelanger | leifmadsen: ya, seen that. Triggered my brain. Let me brain dump it into an email, and see what people think, before going down the path. |
| 13:57.17 | leifmadsen | sounds good |
| 14:11.29 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:11.29 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:14.04 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:14.04 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:18.25 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 14:18.25 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 14:24.37 | *** join/#asterisk-dev jtodd (qv6w0wydcm@asterisk/community-director-and-tie-dye-shirt-lover/jtodd) |
| 14:24.37 | *** mode/#asterisk-dev [+o jtodd] by ChanServ |
| 14:35.50 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 14:44.17 | *** join/#asterisk-dev jpeeler (~jpeeler@asterisk/digium-software-dev/jpeeler) |
| 14:44.17 | *** mode/#asterisk-dev [+o jpeeler] by ChanServ |
| 14:49.35 | *** join/#asterisk-dev gelo (~gelo@mx01.quobis.com) |
| 14:50.06 | gelo | hello |
| 14:50.12 | gelo | is asterisk supposed to be able to transfer a call if it doesn't have the two legs of the transfer, like in sip transfer acting as ua? |
| 14:53.24 | gelo | i mean, is asterisk rfc5589 compliant? |
| 15:00.39 | *** join/#asterisk-dev marv (~timr@24.214.206.254) |
| 15:02.17 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:02.17 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:04.36 | pabelanger | putnopvut: ping |
| 15:05.15 | putnopvut | pabelanger: pong |
| 15:06.49 | pabelanger | To answer your question about adding the 3 lines, was done to stop gcc from complaining about undeclared functions. |
| 15:08.02 | pabelanger | Do you suggest something different? |
| 15:13.04 | putnopvut | I suspect that the reason for this is that you put the handler for the CLI command above the definitions of those structs. If you place the handler below where the structs are declared, that would do the trick. |
| 15:13.24 | putnopvut | But honestly, I was just asking why you did it more than anything. |
| 15:15.01 | Qwell | in time/test_time.c, does anybody see a need for the usage of mkdtemp? It seems like it could skip using a dir, and just go with a mkstemp for tzfile. The issue is that mkdtemp is new in POSIX.1-2008 |
| 15:15.38 | russellb | Corydon76-dig should be back this afternoon, he'd be best to answer |
| 15:15.54 | *** join/#asterisk-dev Greek-Boy (~Greek-B0y@80.231.70.250) |
| 15:16.58 | pabelanger | putnopvut: correct. I can move the code for next patch. |
| 15:17.14 | *** join/#asterisk-dev rrb3942 (~rbullock@208.34.105.161) |
| 15:18.16 | *** join/#asterisk-dev atis_work (~atis_work@193.238.212.171) |
| 15:26.20 | *** part/#asterisk-dev gelo (~gelo@mx01.quobis.com) |
| 15:31.16 | pabelanger | putnopvut: Sorry if a lame question, but do I check the buffer first before calling ast_free(manager_channelvars)? IE: if (manager_channelvars) ast_free(manager_channelvars)? |
| 15:31.45 | putnopvut | pabelanger: That's not necessary. calling ast_free on a NULL pointer is perfectly safe. |
| 15:32.01 | pabelanger | putnopvut: Ok. Thanks. |
| 15:44.20 | *** join/#asterisk-dev jeffg (~jeffg@pdpc/supporter/professional/jeffg) |
| 16:18.28 | *** join/#asterisk-dev Fairman (~Fairman@c-24-23-61-12.hsd1.ca.comcast.net) |
| 16:18.45 | *** part/#asterisk-dev Fairman (~Fairman@c-24-23-61-12.hsd1.ca.comcast.net) |
| 16:23.42 | *** join/#asterisk-dev Rem| (~remi@209.191.13.247) |
| 16:28.13 | *** join/#asterisk-dev hehol (~hehol@buero-gw.dortmund.loca.net) |
| 16:29.01 | kpfleming | question for the esteemed assemblage here: related to the T.38 fax gateway proposal i sent to the dev list yesterday and klaus darilion's response this morning... just how horrific would it be if the fax detection and gateway stuff was wrapped up in a channel driver that worked like chan_local? |
| 16:29.35 | jsmith | blinks... |
| 16:30.08 | jsmith | Seems like it would work, for *outbound* calls... How would you propose it might work for *inbound* calls, or am I missing something obvious? |
| 16:30.42 | kpfleming | i have not really thought it through very much... just a musing on the way to the office this morning |
| 16:32.53 | russellb | omfg please no more proxy channels |
| 16:33.02 | russellb | chan_local is a disaster and a nightmare to maintain |
| 16:33.12 | russellb | plzkthxbyew |
| 16:34.57 | Qwell | but then we could do chan_sip>chan_t38gateway>chan_local>app_queue>chan_local>chan_agent>chan_sip! |
| 16:35.30 | leifmadsen | doesn't that require chan_h323? |
| 16:37.49 | leifmadsen | hmmm... I'm getting errors when running ./runtests.py against 1.6.2.6. One of the errors I'm getting is: Failed to open CDR file '/usr/src/asterisk-testing/1.6.2.6/testsuite/tests/iax-call-basic/tmp//ast2/var/log/asterisk/cdr-csv/Master.csv' |
| 16:38.34 | leifmadsen | iax-call-basic, manager-action-events-response, and originate-cdr-dispostion fail. The rest prior to those seem to pass though. Perhaps I'm missing some dependencies? |
| 16:38.54 | leifmadsen | (the purpose of getting this working is so I can document how to setup a testsuite system so people can write their own tests) |
| 17:02.13 | *** join/#asterisk-dev CoderForLife (~Miranda@cpe-174-101-155-51.cinci.res.rr.com) |
| 17:17.27 | *** join/#asterisk-dev atis_work (~atis_work@193.238.212.171) |
| 17:20.08 | Corydon76-dig | Qwell: propose how you're going to create a symlink "safely" by using mkstemp |
| 17:25.38 | *** join/#asterisk-dev philipp64 (~kvirc@mail.redfish-solutions.com) |
| 17:26.26 | philipp64 | are changes on reviewboard supposed to automatically kick stuff out via email? because the emails that I am getting are sporadic. |
| 17:28.40 | Corydon76-dig | Check your spam filter |
| 17:28.49 | philipp64 | already did that. |
| 17:29.17 | Corydon76-dig | Are you talking about -dev list or direct? |
| 17:29.31 | philipp64 | both. |
| 17:29.53 | Corydon76-dig | For -dev list, if the poster isn't subscribed to the list, the emails won't reach there |
| 17:30.53 | philipp64 | I'm on the -dev list... and I whitelisted 76.164.171.226 since it doesn't seem to have rDNS. |
| 17:31.49 | philipp64 | do we need a bug # to go with reviewboard entry 629 before it can be committed? |
| 17:32.20 | Corydon76-dig | Yes |
| 17:32.20 | philipp64 | this is a fix that Nick posted, that makes sip_pvt.relatedpeer point back to the sip_peer for INVITEs. |
| 17:32.58 | philipp64 | I tested his fix, and marked it 'ship it'. I think putnopvut already reviewed it... |
| 17:33.37 | Corydon76-dig | If it doesn't have a bug number, then you would need to prevail on somebody with commit who isn't employed by Digium to commit it |
| 17:33.58 | Corydon76-dig | or a Digium person after hours |
| 17:37.36 | philipp64 | sounds easier to open a bug #. |
| 17:39.40 | leifmadsen | at which point it will be prioritized and potentially assigned to a Digium developer at some point in the future |
| 17:42.26 | philipp64 | where do I sign up for the fast track? |
| 17:44.08 | philipp64 | well, the fix has been posted on reviewboard and reviewed by two other people beside the author. |
| 17:44.17 | philipp64 | I think it's been tested by 3 including the author. |
| 17:45.39 | philipp64 | putnopvut: ping? |
| 17:49.05 | philipp64 | leifmadsen: 17040 was tested, reviewed, and good to go... but Nick wrote a patch in reviewboard #629 and it occurred to me that this patch would simplify my own fix immensely, so I leveraged it. |
| 17:49.31 | philipp64 | the disadvantage to that, however, being that I have to get out of line and go to the back of the queue all over again... |
| 17:50.00 | philipp64 | since #629 needs to be reviewed and committed before #565 can go in. |
| 17:50.30 | philipp64 | MuffinMan: is there an Mnnnnn equivalent for reviewboard entries? |
| 17:51.02 | philipp64 | well, I guess Mark isn't around. |
| 17:52.48 | leifmadsen | R629 |
| 17:52.52 | MuffinMan | [R629] Extend pvt->relatedpeer support to INVITES in chan_sip.c [Pending] Submitted by Nick_Lewis => https://reviewboard.asterisk.org/r/629/ |
| 17:57.57 | *** join/#asterisk-dev CunningPike (~CunningPi@204.239.8.157) |
| 18:03.02 | *** join/#asterisk-dev akshayb (~b49531e9@gateway/web/freenode/x-xlohsbuvbxlyrqhl) |
| 18:09.32 | putnopvut | philipp64: pong, I just got back from a nice walk |
| 18:10.11 | philipp64 | walks are good. |
| 18:10.35 | philipp64 | did you get a chance to peek at reviewboard 629? I think Nick penciled you in as "people". |
| 18:11.15 | putnopvut | I haven't yet, sorry. I'm planning to commit the review request you put up (can't remember the number) this afternoon though. |
| 18:11.48 | philipp64 | ah... that's the thing. 629 is really handy, not the least because it makes 565 (mine) trivial. |
| 18:12.06 | philipp64 | so I rewrote my fix assuming that his would make it in. |
| 18:12.23 | putnopvut | Well, I do need to get some code reviews in today, so I'll do 629 within the next hour. |
| 18:12.28 | leifmadsen | i.e. 629 is a child of 565 :) |
| 18:12.41 | putnopvut | 565 is too young to be having children! |
| 18:12.58 | putnopvut | review board numbers are gradually approaching a good credit score. |
| 18:13.51 | philipp64 | what sort of machine does reviewboard run on, because it's really slow... (maybe it's got some chokepoint?) |
| 18:15.05 | kpfleming | it's a virtual machine on a Xen host |
| 18:15.12 | kpfleming | that also hosts issues.asterisk.org, which is a pig |
| 18:17.51 | *** join/#asterisk-dev atis_work (~atis_work@193.238.212.171) |
| 18:20.37 | philipp64 | ah... that explains it. clicking on "view diff" takes about 12 seconds... |
| 18:21.48 | kpfleming | it's a dual dual-core Opteron machine with 16GB of RAM... so it's no slouch. mantis is just a CPU hog. |
| 18:23.00 | Qwell | Corydon76-dig: don't know. have a better suggestion for how to make it compile on Solaris (or things that don't yet conform to POSIX-1.2008)? |
| 18:32.47 | philipp64 | is there a particular way to diagnose the message: [Apr 28 12:21:04] ERROR[4949]: astobj2.c:110 INTERNAL_OBJ: user_data is NULL |
| 18:33.04 | philipp64 | and figure out what's causing it? not getting a calling stack, so... |
| 18:36.13 | *** join/#asterisk-dev moy (~chatzilla@bas1-unionville55-1177733627.dsl.bell.ca) |
| 18:39.52 | *** join/#asterisk-dev moy (~chatzilla@bas1-unionville55-1177733627.dsl.bell.ca) |
| 18:49.22 | *** join/#asterisk-dev caio1982 (~caio1982@CAcert-br/caio1982) |
| 19:17.44 | *** join/#asterisk-dev atis_work (~atis_work@193.238.212.171) |
| 19:45.52 | pabelanger | r616 |
| 19:45.58 | MuffinMan | [R616] Dynamiclly generate asterisk.conf (new script) [Pending] Submitted by pabelanger => https://reviewboard.asterisk.org/r/616/ |
| 19:46.32 | pabelanger | A gentle reminder, looking for additional feedback or 'ship it'. |
| 19:56.23 | *** join/#asterisk-dev slawek (~slawek@chello089072183060.chello.pl) |
| 20:00.01 | slawek | Hi all, |
| 20:00.01 | slawek | I have a question about audiohooks. I have 2 machines with asterisk connected by fxo/fxs. On both a i have |
| 20:00.01 | slawek | install sip softphones. I have wrote a dialplan function that does something like this (in audiohook callback): |
| 20:00.02 | slawek | if (frame->frametype == AST_FRAME_VOICE) { |
| 20:00.04 | slawek | if (direction == AST_AUDIOHOOK_DIRECTION_WRITE) |
| 20:00.06 | slawek | { |
| 20:00.08 | slawek | int count; |
| 20:00.10 | slawek | short *fdata = frame->data.ptr; |
| 20:00.12 | slawek | int value = 17000; |
| 20:00.14 | slawek | for(count = 0; count < frame->samples; ++count) |
| 20:00.16 | slawek | { |
| 20:00.18 | slawek | fdata[count] = value; |
| 20:00.19 | *** mode/#asterisk-dev [+q slawek!*@*] by Corydon76-dig |
| 20:00.25 | pabelanger | lol, my eyes |
| 20:00.31 | Corydon76-dig | Use pastebin |
| 20:01.04 | *** mode/#asterisk-dev [-q slawek!*@*] by Corydon76-dig |
| 20:01.20 | Corydon76-dig | ~pb |
| 20:01.21 | infobot | [~pb] A "pastebin" is a web-based service where you should paste anything over 3 lines so you don't flood the channel. Here are links to a few : http://www.pastebin.com , http://pastebin.ca , http://channels.debian.net/paste , http://paste.lisp.org , http://bin.cakephp.org/ , http://asterisk.pastey.net/ , or install pastebinit with yum or aptitude. |
| 20:02.40 | slawek | Ok i have pasted it here: http://pastebin.com/TL1ghSh0 |
| 20:05.22 | Corydon76-dig | It's possible that the frame is getting smoothed between processes. What you should care about is whether the data (in SLIN) is the same or not |
| 20:07.28 | slawek | how can i access that data (It's my first code i have writen in asterisk) and can i change it? My goal was to send some text over the pstn |
| 20:10.15 | slawek | SLIN = Signed Linear Audio? |
| 20:10.33 | kpfleming | yes |
| 20:10.40 | kpfleming | but you can't send raw SLIN data over FXO/FXS |
| 20:10.52 | kpfleming | it will be converted to G.711 (either ulaw or alaw) on the way |
| 20:15.12 | *** join/#asterisk-dev diegomad (~mad@190.146.200.120) |
| 20:18.03 | slawek | so how should I try to insert some text into the samples and read it on the other machine? |
| 20:18.17 | kpfleming | over FXO/FXS? it's not really possible |
| 20:18.48 | Qwell | So, on systems without an `install` program, autoconf will set INSTALL to "./install-sh -c". when trying to use it from a subdir, it doesn't work because of the relative paths. would it be too hackish to just replace it in Makefile, like: ifeq($(INSTALL),./install-sh -c) ? |
| 20:18.49 | jsmith | FSK for the win! |
| 20:19.27 | kpfleming | Qwell: just prefix the path with $(ASTTOPDIR) |
| 20:19.34 | Qwell | one thing I *can* do, is set AC_CONFIG_AUX_DIR in configure.ac to `pwd`, but that seems kinda bad, since you'd have /path/to/foo/ in makeopts. |
| 20:19.44 | Corydon76-dig | You could try using TDD |
| 20:19.45 | kpfleming | oh, i see the problem |
| 20:19.47 | Qwell | kpfleming: you can't do that in all cases |
| 20:20.12 | kpfleming | i think setting AUX_DIR should be fine |
| 20:20.25 | Qwell | that means that if you ever move your src tree, you'd have to re-run configure |
| 20:20.30 | kpfleming | you already have to |
| 20:20.34 | Qwell | do you? |
| 20:20.41 | kpfleming | all the dependency files have paths in them too |
| 20:20.46 | Qwell | ahh |
| 20:20.54 | Qwell | well then. that's easy |
| 20:21.16 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 20:21.30 | Qwell | checking for a BSD-compatible install... /usr/src/asterisk/trunk/install-sh -c |
| 20:23.46 | slawek | kpfleming: why is it impossible to send for example 101010 as voice data and read that on the other machine? |
| 20:23.58 | kpfleming | i already explained it |
| 20:24.14 | kpfleming | the PSTN does not carry signed linear audio, and FXO/FXS don't carry digital audio |
| 20:24.33 | kpfleming | so even if you generated a G.711 ulaw bit pattern and fed it to the FXO port, it would not be decoded as the same bits on the FXS port |
| 20:25.09 | kpfleming | or at least you couldn't guarantee it would be... it might work some times |
| 20:25.12 | jsmith | Right... you'd *could* encode it as audio (using something like FSK), but it's slow and ugly |
| 20:25.19 | kpfleming | correct |
| 20:25.30 | kpfleming | or V.34, which is fast but incredibly hard |
| 20:28.00 | jsmith | Yeah... Even a guy like me can (almost) understand how FSK works... V.34 makes my brain hurt |
| 20:28.18 | *** join/#asterisk-dev alecdavis (~alec@202.36.76.21) |
| 20:30.46 | Corydon76-dig | slawek: this is also why I suggested TDD |
| 20:31.29 | slawek | tdd? |
| 20:31.49 | Corydon76-dig | Sending text over audio lines is precisely what TDD was designed to do |
| 20:32.19 | Corydon76-dig | It's a teletype for the deaf |
| 20:32.34 | slawek | TDD = Time-Division Duplex? |
| 20:33.05 | Corydon76-dig | Telecommunications Device for the Deaf |
| 20:33.33 | Corydon76-dig | http://en.wikipedia.org/wiki/Telecommunications_device_for_the_deaf |
| 20:37.37 | alecdavis | M17037 |
| 20:37.40 | MuffinMan | [ready for testing] [Asterisk] Core/General 0017037: [patch] internal_ao2_ref fails to check if null returned from INTERNAL_OBJ reported by alecdavis https://issues.asterisk.org/view.php?id=17037 |
| 20:42.18 | alecdavis | corydon76-dig: getting close with 17037. Asterisk didn't segfault :) but very soon after 'bad magic number' system was totally unusable, disk thrashing, unable to login. Better not test on a production box thats remote. |
| 20:51.54 | *** part/#asterisk-dev Rem| (~remi@209.191.13.247) |
| 20:53.10 | Corydon76-dig | alecdavis: I saw. Are you making independent progress? |
| 21:12.59 | alecdavis | corydon76-dig: sorry no, just helping out testing, in the small amount of time I had available. |
| 21:13.58 | russellb | The_Boy_Wonder: you didn't address the try/except thing |
| 21:14.11 | The_Boy_Wonder | russellb: did you see my comment |
| 21:14.21 | russellb | looks for it |
| 21:14.21 | The_Boy_Wonder | i didn't put it under yours |
| 21:14.29 | The_Boy_Wonder | i meant to but i did it wrong |
| 21:14.48 | russellb | oh there it is |
| 21:14.49 | russellb | one sec |
| 21:15.37 | The_Boy_Wonder | let me know if that makes sense |
| 21:16.29 | russellb | I understand what you're trying, but did you test it? |
| 21:16.35 | The_Boy_Wonder | nope |
| 21:16.37 | russellb | tsk tsk |
| 21:16.40 | russellb | i don't think that will work |
| 21:17.16 | The_Boy_Wonder | ok, i'll try and test it |
| 21:17.19 | russellb | k |
| 21:17.35 | kpfleming | testing of the unit test with unit test testers |
| 21:18.16 | russellb | you have to test the tests or the tests don't test |
| 21:32.22 | *** join/#asterisk-dev TheDavidFactor (~chatzilla@c-68-34-116-180.hsd1.md.comcast.net) |
| 21:36.52 | The_Boy_Wonder | russellb: updated with your suggestion |
| 21:37.50 | russellb | k, but I'm still concerned that it doesn't actually validate what you wanted to validate |
| 21:37.57 | russellb | (that Asterisk doesn't still have it open) |
| 22:01.16 | philipp64 | M17037 |
| 22:01.18 | MuffinMan | [ready for testing] [Asterisk] Core/General 0017037: [patch] internal_ao2_ref fails to check if null returned from INTERNAL_OBJ reported by alecdavis https://issues.asterisk.org/view.php?id=17037 |
| 22:03.56 | *** join/#asterisk-dev SDP (~spasetti@ip24-250-30-94.ri.ri.cox.net) |
| 22:10.49 | *** part/#asterisk-dev SDP (~spasetti@ip24-250-30-94.ri.ri.cox.net) |
| 22:17.15 | *** join/#asterisk-dev philipp64 (~chatzilla@mail.redfish-solutions.com) |
| 22:19.46 | *** join/#asterisk-dev codefreeze-lap (~murf@72.21.67.40) |
| 22:19.46 | *** mode/#asterisk-dev [+o codefreeze-lap] by ChanServ |
| 22:20.44 | philipp64 | putnopvut: no "ship it!" on R629 ? |
| 22:21.04 | philipp64 | oh, bugger... he's gone. |
| 22:21.26 | putnopvut | I'm here |
| 22:21.27 | philipp64 | well, from what I can tell, it didn't sound like he had any reason to hold it back... |
| 22:21.53 | philipp64 | ah... my IRC client (chatzilla) does some weird things when people are marked "away"... |
| 22:22.13 | putnopvut | interesting. I shouldn't be marked away right now. |
| 22:22.20 | philipp64 | so is it "blessed" or just not vetoed? |
| 22:22.23 | putnopvut | Unless my inactivity caused me to be marked that way automatically. |
| 22:22.44 | putnopvut | philipp64: essentially. The code itself is fine, but I just don't feel like committing it actually ... DOES anything though. |
| 22:23.10 | philipp64 | well, it enables other fixes. |
| 22:23.15 | philipp64 | so who can commit it? |
| 22:24.05 | philipp64 | or more importantly, who might commit it? |
| 22:24.30 | putnopvut | It's a matter of whether it should be. I understand what you're saying about how it can enable other things to be done. My opinion is to at least begin some of the other improvements. |
| 22:24.33 | *** join/#asterisk-dev akshayb (~b49531e2@gateway/web/freenode/x-akjtnzodgdfzromv) |
| 22:24.40 | putnopvut | Maybe I'm alone on the matter though. |
| 22:25.05 | putnopvut | Hi akshayb! |
| 22:25.35 | philipp64 | putnovput: given the glacial pace of getting reviews (and commits) for things that might need improvement, I'm not highly motivated to put energy into anything that's not strictly a showstopper for me. |
| 22:25.39 | philipp64 | the ROI is a bit low. |
| 22:26.22 | philipp64 | that's not a criticism of you... just of the process in general. |
| 22:26.29 | akshayb | hi putnopvut |
| 22:27.10 | akshayb | putnopvut : I finished reading astobj2.h |
| 22:27.12 | akshayb | I guess, have got a good grasp of the header file |
| 22:27.22 | putnopvut | akshayb: Great! |
| 22:27.51 | philipp64 | M17238 for instance is a trivial fix, but no one has reviewed it. |
| 22:28.44 | putnopvut | M17238 |
| 22:28.46 | MuffinMan | [ready for review] [Asterisk] Channels/chan_sip/General 0017238: [patch] Improve usability of logging information for misconfigured contexts reported by pprindeville https://issues.asterisk.org/view.php?id=17238 |
| 22:34.05 | *** join/#asterisk-dev lmsteffan (~lmsteffan@reef.ac-noumea.nc) |
| 22:40.00 | *** join/#asterisk-dev bklang (~bklang@tesla.alkaloid.net) |
| 22:40.01 | leifmadsen | philipp64: you realize how many issues are being handled by developers on a daily basis right? |
| 22:40.45 | Corydon76-dig | Not many, but the ones that we are tend to be exceptionally difficult |
| 22:41.30 | Corydon76-dig | If you want to trade, I'd be happy on any given day |
| 22:42.49 | Corydon76-dig | If you can track down the problem in issue 17000, I'll be happy to look at your 'trivial' issues. |
| 22:42.53 | Corydon76-dig | M17000 |
| 22:42.55 | MuffinMan | [acknowledged] [Asterisk] Applications/app_confbridge 0017000: [regression] Segfault when hanging up phone after launching app_confbridge on Solaris 10 x86 reported by rmcgilvr https://issues.asterisk.org/view.php?id=17000 |
| 22:57.59 | philipp64 | Corydon76-dig: are all the extension pattern matching issues resolved? because I'm seeing something strange in 1.6.2.6 |
| 22:58.46 | *** part/#asterisk-dev akshayb (~b49531e2@gateway/web/freenode/x-akjtnzodgdfzromv) |
| 22:59.36 | philipp64 | this is what I mean: http://pastebin.com/SkgUc22t |
| 23:00.28 | philipp64 | the extension pattern _fn-. isn't matching fn-CONGESTION |
| 23:03.51 | *** join/#asterisk-dev akshayb (~b49531e2@gateway/web/freenode/x-akjtnzodgdfzromv) |
| 23:25.31 | Corydon76-dig | philipp64: I have no idea |
| 23:25.55 | Corydon76-dig | but dashes in general are ignored in patterns |
| 23:26.48 | Corydon76-dig | This is to allow the pattern _NXX-NXX-XXXX |
| 23:27.20 | Corydon76-dig | Makes it easier for humans to parse the config and verify that there isn't an extra X in the pattern |
| 23:44.30 | *** join/#asterisk-dev bklang (~bklang@tesla.alkaloid.net) |