| 00:13.24 | seanbright | the bit near the end is incorrect |
| 00:14.05 | seanbright | if ((match & CMP_STOP) || (multi_container == NULL)) { |
| 00:14.19 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-147.cablep.bezeqint.net) |
| 00:14.19 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 00:14.21 | seanbright | that is wrong somehow. just not sure why :-) (line 734) |
| 02:18.09 | *** join/#asterisk-dev JunK-Y (n=junky@modemcable206.69-20-96.mc.videotron.ca) |
| 03:41.51 | *** join/#asterisk-dev ticoit (n=ticoit@201.191.151.155) |
| 04:22.49 | *** join/#asterisk-dev xpot-mobile (n=xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 05:45.52 | *** join/#asterisk-dev denon (n=denon@synapse.subneural.net) |
| 07:50.12 | *** join/#asterisk-dev tzafrir (n=tzafrir@bzq-218-155-145.cablep.bezeqint.net) |
| 07:50.12 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:23.19 | *** join/#asterisk-dev mpe (n=mpe@0x4dd624b2.adsl.cybercity.dk) |
| 08:30.43 | *** join/#asterisk-dev |Cybex| (n=John@atwork-21.r-212.178.82.atwork.nl) |
| 09:10.12 | *** join/#asterisk-dev erotavlas_turbo (n=erotavla@host253-126-dynamic.1-87-r.retail.telecomitalia.it) |
| 09:10.48 | erotavlas_turbo | @hi all |
| 09:50.24 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 09:50.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:54.36 | mvanbaak | mogguh olle |
| 09:55.09 | mvanbaak | how is you and the rest of the family ? |
| 09:55.14 | oej | Morning Mvanbaak |
| 09:55.15 | oej | Just fine |
| 09:55.26 | oej | And you and Nancy in this cold weather? |
| 09:55.45 | mvanbaak | great. cosy around the central heating :) |
| 09:55.57 | mvanbaak | it's -9C here |
| 09:56.10 | mvanbaak | I'm not build for this weather |
| 09:56.25 | snuff-home | its mvanbaak :P |
| 09:57.05 | oej | Who's built for this weather? |
| 09:57.24 | snuff-home | calculates that it was 44C hotter here than ur -9 ;) |
| 10:06.05 | oej | Ouch... |
| 10:06.28 | oej | My brother just returned from Katmandu. Almost 40 degrees difference in a few flights. |
| 10:06.34 | oej | He's going to freeze to death. |
| 10:07.57 | snuff-home | heh my cousin had it just as bad.. was over here in 25-30C.. back to denmark around 31st.. all came down with colds |
| 10:08.16 | *** join/#asterisk-dev tzafrir (n=tzafrir@bzq-218-155-170.cablep.bezeqint.net) |
| 10:08.16 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 10:40.26 | *** join/#asterisk-dev ArtemMakhutov (n=ArtemMak@ip-95-223-6-41.unitymediagroup.de) |
| 14:37.45 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-147.cablep.bezeqint.net) |
| 14:37.45 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 15:05.42 | *** join/#asterisk-dev kpfleming (n=kpflemin@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:05.42 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:21.13 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-170.cablep.bezeqint.net) |
| 15:21.13 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 15:45.45 | *** join/#asterisk-dev ticoit (n=ticoit@201.191.151.155) |
| 15:52.57 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 15:52.57 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:13.57 | *** join/#asterisk-dev mnt_real (n=sinan@bas12-montrealak-1167974851.dsl.bell.ca) |
| 16:20.10 | *** join/#asterisk-dev MikeJ (n=MikeJ@freeswitch/developer/mikej) |
| 16:27.21 | *** join/#asterisk-dev mpe (n=mpe@91.100.62.73.generic-hostname.arrownet.dk) |
| 16:28.45 | *** join/#asterisk-dev dlynes (n=dlynes@bas6-hamilton14-1167992947.dsl.bell.ca) |
| 16:28.47 | dlynes | M16175 |
| 16:28.49 | MuffinMan | [closed] [Asterisk] Channels/chan_sip/CodecHandling 0016175: Revision 202007 Introduces Deadlock reported by paul-tg https://issues.asterisk.org/view.php?id=16175 |
| 17:10.13 | seanbright | Corydon76-dig: ping |
| 17:10.20 | Corydon76-dig | pong |
| 17:11.50 | seanbright | http://pastebin.ca/1744285 |
| 17:12.45 | seanbright | M16564 |
| 17:12.47 | MuffinMan | [acknowledged] [Asterisk] Core/Configuration 0016564: "config reload" doesn't work correctly reported by pj https://issues.asterisk.org/view.php?id=16564 |
| 17:12.52 | seanbright | that patch fixes that particular issue |
| 17:15.03 | seanbright | just wanted to know if it looked sane to you |
| 17:15.12 | Corydon76-dig | That seems strange... |
| 17:15.30 | seanbright | the issue is the check for multi_container |
| 17:15.56 | Corydon76-dig | Ah, I see... |
| 17:15.57 | seanbright | because it is possible to hit that bit of code having passed OBJ_NODATA |
| 17:16.15 | seanbright | so there shouldn't be a container |
| 17:16.17 | Corydon76-dig | Right. Excellent work |
| 17:16.32 | seanbright | thanks for taking a look. |
| 17:16.46 | *** join/#asterisk-dev |Cybex| (n=John@atwork-21.r-212.178.82.atwork.nl) |
| 17:18.38 | Corydon76-dig | I wonder... can you just remove the second condition entirely? |
| 17:19.17 | Corydon76-dig | No, nevermind |
| 17:20.17 | seanbright | we could probably split it into multiple functions for clarity |
| 17:23.16 | Corydon76-dig | I think this behavior would be an excellent candidate for creating a test to verify behavior |
| 17:23.33 | Corydon76-dig | for every single condition |
| 17:24.00 | Corydon76-dig | because the interaction is particular and complex |
| 17:24.50 | seanbright | agreed. and the more i think about it... the multi_container == NULL part can be removed i think |
| 17:25.16 | seanbright | was that what you meant before? or did you mean everything about the CMP_STOP check? |
| 17:25.25 | seanbright | s/about/after/ |
| 17:26.23 | Corydon76-dig | Make the tests first, then you can experiment |
| 17:26.56 | Corydon76-dig | Instead of trying to wrap your head around the logic, you can be absolutely sure that a change doesn't affect the logic |
| 17:27.03 | seanbright | true |
| 17:30.24 | Corydon76-dig | In light of a test, it's easier to determine why a particular case doesn't work than it is to predict that all cases will work |
| 18:17.04 | *** join/#asterisk-dev Deeewayne (n=dwayne@75.76.254.162) |
| 18:17.04 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 18:54.53 | *** join/#asterisk-dev MikeJ (n=MikeJ@freeswitch/developer/mikej) |
| 19:05.11 | *** join/#asterisk-dev MikeJ_ (n=MikeJ@freeswitch/developer/mikej) |
| 19:18.07 | seanbright | so if i want VERBOSE messages to get logged to the /var/log/full even when i have 'core set verbose 0' on the CLI, how would i do that? |
| 19:18.10 | seanbright | with 1.6.1 |
| 19:53.26 | *** part/#asterisk-dev MikeJ (n=MikeJ@freeswitch/developer/mikej) |
| 20:52.39 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-146.cablep.bezeqint.net) |
| 20:52.39 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 21:14.04 | *** join/#asterisk-dev TheDavidFactor-H (n=chatzill@nc-71-0-16-133.dhcp.embarqhsd.net) |
| 22:47.34 | *** join/#asterisk-dev mpe_ (n=mpe@0x4dd624b2.adsl.cybercity.dk) |
| 23:09.36 | *** join/#asterisk-dev sgimeno (n=santiago@226.Red-80-33-64.staticIP.rima-tde.net) |
| 23:40.53 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 23:40.53 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 23:46.06 | *** join/#asterisk-dev tzafrir (n=tzafrir@212.179.75.202) |
| 23:46.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |