| 00:04.03 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-148.cablep.bezeqint.net) |
| 00:04.03 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 00:08.54 | Corydon76-dig | russellb: on this document, do you want me to trace down the stuff in BSD-contributed code? It's rather dense. |
| 00:10.00 | russellb | I suppose we have to since we include it in our tree :-( |
| 00:10.06 | Corydon76-dig | especially the db1 code |
| 00:10.45 | russellb | yeah ... it's scary in there |
| 00:11.03 | Corydon76-dig | Actually, only the db1 code is left. I already looked through editline code |
| 00:11.16 | russellb | doesn't have to be done tonight |
| 00:11.22 | Corydon76-dig | Okay |
| 00:11.38 | russellb | maybe it will be easier when starting fresh tomorrow |
| 00:12.15 | russellb | thanks for working on it |
| 00:12.15 | Corydon76-dig | Riiiiiiight... |
| 00:12.21 | Corydon76-dig | yw |
| 00:13.23 | Corydon76-dig | In fact, I've gone through everything except the lines marked "unable to verify" |
| 00:13.59 | Corydon76-dig | which is shorthand for... "WTF? I can't read this!" |
| 00:13.59 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 00:14.03 | russellb | lol |
| 00:14.06 | russellb | :-) |
| 00:14.21 | russellb | our response can be "we can't read it either" |
| 00:14.25 | russellb | (kidding) |
| 00:15.08 | Corydon76-dig | How about 'Unable to verify'? |
| 00:15.23 | russellb | heh, I don't think we can say that, unfortunately |
| 00:15.31 | russellb | however, more time, I can give :-p |
| 00:15.58 | Corydon76-dig | Can you give anti-psychotic medications afterwards, too? |
| 00:16.31 | Corydon76-dig | ;-) |
| 00:17.00 | russellb | how about ... a weekend off! |
| 00:17.10 | russellb | and ... a trip to CA |
| 00:17.10 | russellb | heh |
| 00:17.44 | Corydon76-dig | Heh |
| 00:33.43 | *** join/#asterisk-dev naikrovek (n=jjohnson@unaffiliated/naikrovek) |
| 00:53.30 | *** join/#asterisk-dev denon (i=denon@sassinak.net) |
| 01:17.27 | *** join/#asterisk-dev snuff-work (n=aaa@203.19.141.34) |
| 01:17.27 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 01:29.09 | *** join/#asterisk-dev Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 01:29.09 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 02:00.08 | seanbright | user question... |
| 02:00.19 | russellb | user answer! |
| 02:00.25 | seanbright | in sip.conf: |
| 02:00.30 | seanbright | [sean@something.com] |
| 02:00.33 | seanbright | type=friend... |
| 02:00.35 | seanbright | etc, etc. |
| 02:00.47 | seanbright | should that work? |
| 02:00.49 | seanbright | :) |
| 02:03.47 | seanbright | or do i need to do [sean%40something.com] |
| 02:05.09 | russellb | i don't think I have ever tried |
| 02:05.44 | seanbright | could you try real quick and let me know? kthx |
| 02:05.46 | seanbright | jk |
| 03:10.29 | Corydon76-dig | atis_work: Thank you ever so much for that valgrind output |
| 03:13.27 | *** join/#asterisk-dev The_Boy_Wonder (n=davidvos@asterisk/batman-developer/dvossel) |
| 03:13.27 | *** join/#asterisk-dev denon (i=denon@sassinak.net) |
| 03:13.27 | *** join/#asterisk-dev naikrovek (n=jjohnson@unaffiliated/naikrovek) |
| 03:13.27 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 03:13.27 | *** join/#asterisk-dev janinge (i=j@ninge.net) |
| 03:13.28 | *** join/#asterisk-dev ApOgEE (i=apogee@elite.bshellz.net) [NETSPLIT VICTIM] |
| 03:13.28 | *** join/#asterisk-dev MikeBalsam (n=michael@syria.uc.org) |
| 03:13.28 | *** join/#asterisk-dev xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 03:13.28 | *** join/#asterisk-dev kaii (n=kai@ciphron.de) [NETSPLIT VICTIM] |
| 03:13.28 | *** join/#asterisk-dev file (n=file@asterisk/developer-and-muffin-lover/file) |
| 03:13.28 | *** join/#asterisk-dev russellb (n=russellb@asterisk/digium-open-source-team-lead/russellb) |
| 03:13.28 | *** join/#asterisk-dev snuff-home (n=snuffy@203-219-29-182-bri-ts6-2600.tpgi.com.au) [NETSPLIT VICTIM] |
| 03:13.28 | *** mode/#asterisk-dev [+oooo The_Boy_Wonder file russellb snuff-home] by irc.freenode.net |
| 03:13.28 | *** join/#asterisk-dev Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 03:13.28 | *** join/#asterisk-dev ricko73 (n=dhartman@wilug/newlug/ricko73) |
| 03:13.28 | *** join/#asterisk-dev Damin (n=damin@nucleus.nacs.net) |
| 03:13.28 | *** join/#asterisk-dev jsmith-teaching (n=jsmith@asterisk/training-and-documentation-guru/jsmith) |
| 03:13.28 | *** join/#asterisk-dev mnicholson (n=mnichols@nat/digium/x-bnbwwkrzpnjhwcxt) |
| 03:13.28 | *** join/#asterisk-dev angler (n=angler@pdpc/sponsor/digium/angler) |
| 03:13.28 | *** join/#asterisk-dev jamesh1 (n=jhenders@xob.neospire.net) |
| 03:13.28 | *** mode/#asterisk-dev [+oo Qwell jsmith-teaching] by irc.freenode.net |
| 03:13.34 | Corydon76-dig | atis_work: Thank you ever so much for that valgrind output |
| 03:13.39 | Corydon76-dig | atis_work: Amazingly, it was a one-line fix |
| 03:14.06 | *** join/#asterisk-dev xpot-mobile (n=james@67.40.99.145) |
| 03:22.01 | *** join/#asterisk-dev snuff-work (n=aaa@203.19.141.34) |
| 03:22.01 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 03:43.27 | *** join/#asterisk-dev xpot-mobile (n=james@67.40.99.145) |
| 04:14.10 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 04:14.10 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 04:59.39 | *** join/#asterisk-dev fiddur (n=fiddur@192.121.104.118) |
| 05:21.28 | *** join/#asterisk-dev xpot-mobile (n=james@67.40.99.145) |
| 06:06.13 | *** join/#asterisk-dev Iamnach0 (i=Iamnacho@ip98-186-180-143.ks.ks.cox.net) |
| 06:48.20 | *** join/#asterisk-dev infobot (i=ibot@rikers.org) |
| 06:48.20 | *** topic/#asterisk-dev is Topic for #asterisk-dev is: Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- AstriCon Discount Code: ac09digi |
| 07:16.31 | *** join/#asterisk-dev |Cybex| (n=John@atwork-26.r-212.178.82.atwork.nl) |
| 07:20.37 | *** join/#asterisk-dev obnauticus (n=obnautic@about/windows/regular/obnauticus) |
| 07:23.42 | *** join/#asterisk-dev tamiel (n=tamiel@213.30.183.226) |
| 07:30.33 | *** join/#asterisk-dev snuff-home (n=snuffy@203-219-29-182-bri-ts6-2600.tpgi.com.au) |
| 07:30.33 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 10:55.25 | *** join/#asterisk-dev Victor_Yure (n=victor@unaffiliated/victoryure/x-837844) |
| 11:21.01 | atis_work | Corydon76-dig: you're welcome. apparently "killall -6 asterisk" made valgrind to stop and write summary |
| 11:21.37 | atis_work | Corydon76-dig: now i have "memory show summary" and "memory show allocations" working, however the issue is not gone yet |
| 11:22.17 | atis_work | Corydon76-dig: it seems that messages got posted to logmsgs faster than logger thread write them |
| 11:23.25 | atis_work | I have in mind some hashing in ast_log and check for repeating messages, so that they are logged " message repeats 1212312 times" |
| 11:35.25 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-218-155-170.cablep.bezeqint.net) |
| 11:35.25 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 11:37.40 | atis_work | should i use __thread to create thread variable, or there's something different in asterisk? |
| 11:43.36 | *** join/#asterisk-dev kpfleming (n=kpflemin@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:43.36 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:45.51 | atis_work | kpfleming: maybe you can help me with thread-local variables? |
| 11:46.05 | kpfleming | i suppose it is possible |
| 11:46.42 | atis_work | i suspect that logger thread is not dealing with all the messages comming in, so i want to add some thread-local variables to check for duplicate messages in ast_log |
| 11:47.16 | atis_work | so far i've found __thread to declare TLV's, but i don't see that anywhere in asterisk source |
| 11:48.26 | *** join/#asterisk-dev blargman_ (n=blarg@12.234.16.130) |
| 11:49.38 | atis_work | kpfleming: so, i just want to add few variables to each thread, keeping previous log message and usage count |
| 11:51.01 | kpfleming | we don't use __thread |
| 11:51.03 | kpfleming | although you can |
| 11:51.33 | kpfleming | but it can only be used for ints and simple variables, or a struct, but not for pointers to dynamically allocated stuff because there's no way to free them |
| 11:51.58 | kpfleming | so you could declare __thread char lastmsg[4096]; and that would be fine |
| 11:53.27 | atis_work | oh, thanks :) |
| 11:53.47 | atis_work | aah, i should probably declare globally in logger.c, right? |
| 11:56.18 | atis_work | hmm, what's the purpose of AST_THREADSTORAGE(verbose_buf) and log_buf? |
| 12:01.01 | kpfleming | those are for using pthread_key-based thread local storage, which we use because it allows for destructors to be called when the thread is destroyed |
| 12:02.16 | atis_work | i suspected that, but what's strange that they seem to be some kind of buffer, which is never filled |
| 12:02.24 | kpfleming | they are used quite heavily |
| 12:02.31 | kpfleming | those are the buffers used for formatting messages for output |
| 12:03.16 | atis_work | i found just two usages of them - one in declaration, and another is get |
| 12:03.21 | kpfleming | correct |
| 12:03.35 | kpfleming | and the get returns a pointer to the buffer, which is then used for formatting the message to be output |
| 12:03.47 | atis_work | aah, gotcha |
| 12:04.06 | kpfleming | that method keeps us from having to either dynamically allocate a buffer (and free it) every time there is a message to be output, or allocating a large buffer on the stack |
| 12:04.12 | atis_work | so there's no malloc/free every time |
| 12:04.29 | kpfleming | and no fixed size buffer either |
| 12:04.51 | atis_work | thanks for teaching me C :) |
| 12:04.58 | kpfleming | well, this isn't really C |
| 12:05.05 | kpfleming | it's POSIX Threading |
| 12:05.13 | atis_work | better :) |
| 12:05.35 | kpfleming | we use that technique a lot in various modules |
| 12:18.56 | *** join/#asterisk-dev caio1982 (i=caio1982@CAcert-br/caio1982) |
| 12:24.28 | *** join/#asterisk-dev jeffg (n=jeffg@pdpc/supporter/active/jeffg) |
| 12:35.40 | *** join/#asterisk-dev ccesario (n=ccesario@189-19-6-236.dsl.telesp.net.br) |
| 12:37.29 | *** join/#asterisk-dev Iamnacho (i=Iamnacho@ip98-186-180-143.ks.ks.cox.net) |
| 12:42.30 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:42.30 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:58.58 | *** join/#asterisk-dev msetim (n=setim@189.4.48.141) |
| 14:05.09 | *** join/#asterisk-dev putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 14:05.09 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:17.09 | *** join/#asterisk-dev anonymouz666 (n=anonymou@187.28.37.118) |
| 14:18.58 | *** join/#asterisk-dev Deeewayne (n=dwayne@75.76.254.162) |
| 14:18.58 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 14:25.05 | *** join/#asterisk-dev sruffell (n=sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:25.05 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:26.58 | *** join/#asterisk-dev xpot-mobile (n=james@67.40.99.145) |
| 14:30.08 | *** join/#asterisk-dev jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) |
| 14:30.08 | *** mode/#asterisk-dev [+o jpeeler] by ChanServ |
| 14:37.44 | *** join/#asterisk-dev puzzled (n=foobar@puzzled.xs4all.nl) |
| 14:41.52 | *** join/#asterisk-dev moy (n=moy@74.12.135.147) |
| 15:00.54 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 15:26.01 | *** join/#asterisk-dev kpfleming (n=kpflemin@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:26.01 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:30.07 | *** join/#asterisk-dev |Cybex| (n=John@80.100.126.176) |
| 15:33.35 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 15:50.53 | *** join/#asterisk-dev steliosk (n=Stelios@84.254.2.107) |
| 15:55.05 | *** join/#asterisk-dev _ys (n=Miranda@236-070.nat.mns.ru) |
| 15:55.38 | *** join/#asterisk-dev jtodd (i=m5reave7@asterisk/community-director-and-tie-dye-shirt-lover/jtodd) |
| 15:55.38 | *** mode/#asterisk-dev [+o jtodd] by ChanServ |
| 16:04.07 | *** join/#asterisk-dev JimDickenson (n=dickenso@c-98-232-185-121.hsd1.or.comcast.net) |
| 16:26.37 | moy | I'm working with a guy testing M15175, using ast_dsp_process() on calls with p->digital set does not sound good and in fact is breaking the v.110 bit stream, is there any reason to not by-pass completely ast_dsp_process on chan_dahdi when p->digital is set? |
| 16:29.34 | kpfleming | nope, that sounds completely reasonably |
| 16:32.12 | moy | thanks |
| 16:42.15 | atis_work | Corydon76-dig: ping |
| 16:43.42 | Corydon76-dig | pong |
| 16:44.04 | atis_work | your patch for func_lock still crashes my box |
| 16:44.17 | Corydon76-dig | Hrm |
| 16:44.23 | Corydon76-dig | What about the memory leak? |
| 16:44.49 | Corydon76-dig | atis_work: try the branch |
| 16:45.10 | atis_work | i wrote small addition to func_log, because after your fix i saw logger.c eating a lot of allocations in "memory show summary" |
| 16:45.23 | atis_work | Corydon76-dig: which branch? |
| 16:45.28 | Corydon76-dig | 1.6.1 |
| 16:45.58 | atis_work | Corydon76-dig: i'm testing on r221922 which was latest tomorrow morning |
| 16:46.02 | atis_work | GMT+2 |
| 16:46.11 | Corydon76-dig | tomorrow morning? |
| 16:46.15 | atis_work | damn |
| 16:46.19 | atis_work | it's friday evening here |
| 16:46.22 | atis_work | heh |
| 16:47.08 | atis_work | I have exactly the same backtrace as the last one i posted on issue |
| 16:47.22 | Corydon76-dig | That sentence construction was a little wonky |
| 16:47.54 | atis_work | s/tomorrow/today/ |
| 16:48.42 | atis_work | so, i would suggest reverting changes to func_lock until the issue is solved |
| 16:49.25 | *** join/#asterisk-dev errotan (n=errotan@5403E720.catv.pool.telekom.hu) |
| 16:50.14 | Corydon76-dig | atis_work: you still have the core on that? |
| 16:50.14 | atis_work | the patch that i posted on that issue does the job for me, so that one is not urgent, i can live with my dirty patch |
| 16:50.14 | atis_work | yes |
| 16:50.15 | Corydon76-dig | p *c |
| 16:50.42 | atis_work | $1 = {hash_fn = 0x2aaabb6098c0 <null_hash_cb>, cmp_fn = 0x2aaabb6098d1 <null_cmp_cb>, n_buckets = 7, elements = 0, version = 2, buckets = 0x2aaad00952b0} |
| 16:50.53 | atis_work | that's the new one |
| 16:51.04 | atis_work | or you mean, the old core from backtrace? |
| 16:51.21 | Corydon76-dig | Oh, wait, I think I see what's wrong |
| 16:53.35 | Corydon76-dig | Easy fix |
| 16:53.42 | atis_work | is ready to test |
| 16:54.04 | Corydon76-dig | Committed, run that |
| 16:56.22 | russellb | we should probably modify astobj2.c to abs() the hash result |
| 16:57.14 | Corydon76-dig | Yeah, I was just thinking that |
| 16:58.04 | russellb | changing the hash prototype probably isn't worth the API breakage |
| 17:00.52 | seanbright | more likely to get collisions now though |
| 17:01.15 | seanbright | but i'm not sure that is really a problem. |
| 17:02.38 | Corydon76-dig | seanbright: no, not really. If you're any more likely to get a collision now, it would have corrupted memory before |
| 17:06.56 | seanbright | do all of the hash functions we use return negative numbers? or just yours? |
| 17:07.31 | Corydon76-dig | Well, according to the API, they could have, even if they didn't |
| 17:07.49 | seanbright | so just yours then? |
| 17:08.17 | seanbright | seems like it would have been a bigger problem if they all were doing that. |
| 17:11.16 | Corydon76-dig | seanbright: I haven't performed an exhaustive search, so I'm not going to guess |
| 17:11.55 | seanbright | eh... the answer is pretty obvious :) |
| 17:16.36 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 17:16.41 | atis_work | Corydon76-dig: it seems to be working |
| 17:17.55 | *** join/#asterisk-dev hugorebelo (n=hugorebe@200.171.132.124) |
| 17:23.54 | atis_work | could anybody help me categorize this coredump? http://pastebin.ca/1589690 |
| 17:24.22 | seanbright | "bad" |
| 17:24.47 | atis_work | seanbright: no such category in mantis |
| 17:24.53 | seanbright | drat |
| 18:09.01 | Corydon76-dig | atis_work: p *frame |
| 18:16.37 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 18:27.08 | *** join/#asterisk-dev CunningPike (n=CunningP@204.239.8.157) |
| 18:40.31 | *** join/#asterisk-dev gardo (n=gardo@121.97.192.96) |
| 19:06.30 | *** join/#asterisk-dev jetsnoc (n=brian@72.22.242.66) |
| 19:12.20 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 19:12.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:21.38 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 19:21.38 | *** join/#asterisk-dev gardo (n=gardo@121.97.192.96) |
| 19:21.38 | *** join/#asterisk-dev _ys (n=Miranda@236-070.nat.mns.ru) [NETSPLIT VICTIM] |
| 19:21.38 | *** join/#asterisk-dev moy (n=moy@74.12.135.147) |
| 19:21.38 | *** join/#asterisk-dev putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 19:21.38 | *** join/#asterisk-dev snuff-home (n=snuffy@203-219-29-182-bri-ts6-2600.tpgi.com.au) [NETSPLIT VICTIM] |
| 19:21.38 | *** join/#asterisk-dev The_Boy_Wonder (n=davidvos@asterisk/batman-developer/dvossel) |
| 19:21.38 | *** mode/#asterisk-dev [+oooo oej putnopvut snuff-home The_Boy_Wonder] by irc.freenode.net |
| 19:21.38 | *** join/#asterisk-dev janinge (i=j@ninge.net) |
| 19:21.38 | *** join/#asterisk-dev ApOgEE (i=apogee@elite.bshellz.net) [NETSPLIT VICTIM] |
| 19:21.38 | *** join/#asterisk-dev xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 19:21.38 | *** join/#asterisk-dev kaii (n=kai@ciphron.de) [NETSPLIT VICTIM] |
| 19:21.38 | *** join/#asterisk-dev file (n=file@asterisk/developer-and-muffin-lover/file) |
| 19:21.38 | *** join/#asterisk-dev russellb (n=russellb@asterisk/digium-open-source-team-lead/russellb) |
| 19:21.38 | *** join/#asterisk-dev Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 19:21.38 | *** join/#asterisk-dev ricko73 (n=dhartman@wilug/newlug/ricko73) |
| 19:21.38 | *** join/#asterisk-dev Damin (n=damin@nucleus.nacs.net) |
| 19:21.38 | *** join/#asterisk-dev jsmith-teaching (n=jsmith@asterisk/training-and-documentation-guru/jsmith) |
| 19:21.38 | *** mode/#asterisk-dev [+oooo file russellb Qwell jsmith-teaching] by irc.freenode.net |
| 19:21.38 | *** join/#asterisk-dev mnicholson (n=mnichols@nat/digium/x-bnbwwkrzpnjhwcxt) |
| 19:21.38 | *** join/#asterisk-dev angler (n=angler@pdpc/sponsor/digium/angler) |
| 19:21.38 | *** join/#asterisk-dev jamesh1 (n=jhenders@xob.neospire.net) |
| 19:34.21 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 20:08.48 | *** join/#asterisk-dev Iamnach0 (i=Iamnacho@ip98-186-180-143.ks.ks.cox.net) |
| 21:34.07 | *** join/#asterisk-dev infobot (i=ibot@rikers.org) |
| 21:34.07 | *** topic/#asterisk-dev is Topic for #asterisk-dev is: Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- AstriCon Discount Code: ac09digi |
| 21:49.36 | *** join/#asterisk-dev jeffg (n=jeffg@pdpc/supporter/active/jeffg) |
| 21:51.07 | *** join/#asterisk-dev tamiel (n=tamiel@85-170-152-243.rev.numericable.fr) |
| 22:01.46 | *** join/#asterisk-dev obnauticus (n=obnautic@about/windows/regular/obnauticus) |
| 22:02.52 | *** join/#asterisk-dev JunK-Y (n=junky@modemcable206.69-20-96.mc.videotron.ca) |
| 23:51.47 | *** join/#asterisk-dev mbranca (n=matteo@2001:1418:130:0:21e:8cff:fe51:5b05) [NETSPLIT VICTIM] |
| 23:51.47 | *** join/#asterisk-dev Praise (n=Fat@unaffiliated/praise) [NETSPLIT VICTIM] |