| 00:01.12 | *** join/#asterisk-dev Mackes (n=root@cpe-76-180-236-119.buffalo.res.rr.com) |
| 02:00.36 | snuff-work | callguy: with ur patch to 11080.. if p == NULL then there isn't a lock to be freed |
| 02:15.13 | *** join/#asterisk-dev grimsy (n=chatzill@203-206-220-214.perm.iinet.net.au) |
| 02:32.45 | *** join/#asterisk-dev moy (n=moyhu@189.169.50.222) |
| 02:35.18 | *** join/#asterisk-dev enst (n=enst@60.28.119.64) |
| 03:00.42 | *** part/#asterisk-dev Mackes (n=root@cpe-76-180-236-119.buffalo.res.rr.com) |
| 03:33.08 | *** join/#asterisk-dev mitcheloc (n=mitchel@adsl-68-120-227-239.dsl.irvnca.pacbell.net) |
| 04:08.55 | *** join/#asterisk-dev ctooley (n=ctooley@doc-72-47-33-80.maryville.mo.cebridge.net) |
| 04:13.28 | *** join/#asterisk-dev mitcheloc (n=mitchel@adsl-68-120-227-239.dsl.irvnca.pacbell.net) |
| 04:14.01 | *** join/#asterisk-dev Netgeeks-laptop (n=chris@204.11.231.198.static.etheric.net) |
| 04:18.06 | *** join/#asterisk-dev Laureano (n=chatzill@OL30-199.fibertel.com.ar) |
| 04:41.17 | moy | __ast_alloc_region() seems to have a bug. After malloc() failure is not returning and trying to use the "reg" pointer, am I missing something? |
| 04:49.48 | *** join/#asterisk-dev CunningPike (n=CunningP@S010600095b33697f.vc.shawcable.net) |
| 05:04.09 | *** join/#asterisk-dev enst (n=enst@60.28.119.64) |
| 05:16.13 | De_Mon | exten => s,n,Dial(Local/support@queue-support2||G(s^pickup)) |
| 05:16.14 | De_Mon | exten => support,1,Queue(queue-2|t|||1800) ; timeout after 30min |
| 05:17.42 | De_Mon | The calling party hears the queue's hold music, but after 5min the dial is ended with Dialstatus CANCEL. I'm in the middle of re-testing with just those two lines right now to confirm... |
| 05:21.52 | De_Mon | well crap. I thought I had it this time... |
| 05:43.09 | *** join/#asterisk-dev enst (n=enst@60.28.119.64) |
| 05:44.54 | snuff-work | gotta hate that De_Mon |
| 05:44.55 | snuff-work | ;) |
| 05:50.20 | snuff-work | mm looks interesting moy.. u'd think it would return after failure |
| 05:50.21 | De_Mon | I think I've got it this time, I never Answered() and my softphone said "Calling..." and probably gave up while it was in the queue |
| 05:51.18 | moy | snuff-work: yup, otherwise will segfault when using reg->something |
| 05:51.22 | De_Mon | It's slightly strange that Im using Dial to join the queue and then split the agent that answers and the caller and drop them into a conf so the calling party is 'ringing' the entire time they are in the queue. |
| 05:51.51 | De_Mon | getting to that 5min mark soon, cross your snuff |
| 05:53.02 | snuff-work | yer.. when it tries to set 'fence' it would die |
| 05:53.49 | snuff-work | assigning ptr to reg->data may fail.. but setting fence would |
| 05:54.08 | snuff-work | no i'm wrong |
| 05:54.44 | snuff-work | ah whatever.. its 'bad' tm |
| 05:56.12 | moy | will fail at first ast_copy_string(reg->file....), won't it ?? |
| 05:58.17 | snuff-work | oh true |
| 05:58.26 | snuff-work | i skipped over then |
| 05:58.40 | snuff-work | wait no.. |
| 06:00.45 | moy | no? why? what do you have in mind? |
| 06:02.23 | snuff-work | nevermind.. my head isn't in it today ;( |
| 06:05.02 | moy | :p I know how it is ... I have had a loooong day as well |
| 07:17.35 | *** join/#asterisk-dev pnlarsson (n=pnlarsso@c83-248-96-159.bredband.comhem.se) |
| 07:35.24 | *** join/#asterisk-dev oej (n=olle@soll4-125.cust.blixtvik.net) |
| 07:35.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:32.18 | *** join/#asterisk-dev tzafrir (n=tzafrir@62.90.10.53) |
| 08:32.18 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:33.38 | oej | morning folks |
| 08:45.58 | *** join/#asterisk-dev tzafrir (n=tzafrir@62.90.10.53) |
| 08:45.58 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:51.14 | *** join/#asterisk-dev agx (n=AGX@host63-216-static.34-88-b.business.telecomitalia.it) |
| 09:27.02 | *** join/#asterisk-dev osas (n=nnnnnnno@i216-58-54-200.cybersurf.com) |
| 09:28.20 | *** join/#asterisk-dev _ys (n=yuri@236-069.nat.mns.ru) |
| 09:28.55 | *** join/#asterisk-dev qdk (n=qdk@85.235.253.139) |
| 09:45.09 | *** join/#asterisk-dev Iamnach0 (i=Iamnacho@ip68-103-153-140.ks.ok.cox.net) |
| 10:25.27 | snuff-home | mm oej.. moy mentioned somethin earlier.. |
| 10:25.51 | snuff-home | in main/astmm.c |
| 10:25.54 | snuff-home | [14:41] <moy> __ast_alloc_region() seems to have a bug. After malloc() failure is not returning and trying to use the "reg" pointer, am I missing something? |
| 10:32.23 | oej | Need to discuss that with Russell, the king of malloc and alloc and calloc's |
| 10:35.09 | sergee | oej: sorry, forgot to test patch after removing duplicating code, that was a little bit conceitedly, excuse me please. |
| 10:42.20 | oej | sergee: No problem, I fixed it :-) |
| 10:42.25 | oej | sergee: Thanks for the patch! |
| 10:45.59 | sergee | oej: thank you for your time :) |
| 10:46.19 | oej | np |
| 11:19.19 | *** join/#asterisk-dev _ys (i=ys@91.151.196.254) |
| 12:12.58 | *** join/#asterisk-dev DarkRift (i=dark@bas10-montreal02-1177584064.dsl.bell.ca) |
| 12:19.33 | snuff-home | codefreeze: ping ? |
| 12:36.39 | oej | He's propably sleeping at this time |
| 12:36.54 | oej | Americans are lazy people, sleeping into late afternoon |
| 12:44.53 | *** join/#asterisk-dev michael-i (n=michael-@Lc371.l.pppool.de) |
| 12:47.38 | snuff-home | mm.. maybe.. it was little wishful thinking on my part :) |
| 12:47.47 | snuff-home | i'm only 16 hrs ahead |
| 12:51.31 | oej | :-) |
| 12:51.39 | oej | Gott get some lunch... Later. |
| 12:52.07 | snuff-home | bye oej |
| 13:19.23 | *** join/#asterisk-dev blitzrage (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:19.23 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 13:42.23 | *** join/#asterisk-dev puzzled (n=patrick@puzzled.xs4all.nl) |
| 13:42.44 | puzzled | hi |
| 13:42.54 | snuff-home | hello puzzled |
| 13:46.32 | jmls | hi guys |
| 13:46.56 | jmls | what's the difference between pbx_builtin_setvar_helper and pbx_builtin_setvar ? |
| 13:47.24 | jmls | I'm looking at app_queue.c and the differences between trunk and 1.4 |
| 13:47.40 | *** join/#asterisk-dev Laureano (n=Laureano@200.59.172.38) |
| 13:47.44 | jmls | trunk uses pbx_builtin_setvar, but locks the queue before and after |
| 13:47.58 | jmls | 1.4 uses pbx_builtin_setvar_helper but does not lock the queue |
| 13:50.01 | Corydon76-dig | pbx_builtin_setvar takes an argument in the form channel,"name=value". _helper takes the name and value as separate arguments |
| 13:54.56 | jmls | why does one lock the queue and not the other ? |
| 14:06.01 | *** join/#asterisk-dev CunningPike (n=arodgers@S010600095b33697f.vc.shawcable.net) |
| 14:10.14 | *** join/#asterisk-dev ctooley (n=ctooley@doc-72-47-33-80.maryville.mo.cebridge.net) |
| 14:31.51 | jmls | I'm just trying to figure out if there is a problem in 1.4, or some unrequired lock in trunk, or neither ;) |
| 14:40.20 | *** join/#asterisk-dev zerohalo (n=zeroHalo@pool-71-255-162-167.bstnma.east.verizon.net) |
| 14:42.51 | *** join/#asterisk-dev yannj_fr (n=yannj_fr@APuteaux-152-1-61-178.w82-120.abo.wanadoo.fr) |
| 14:45.22 | *** join/#asterisk-dev eliel (n=eliel@200.59.172.38) |
| 14:55.20 | *** join/#asterisk-dev CunningPike (n=arodgers@204.239.8.149) |
| 14:55.38 | codefreeze | snuff-home: yes? BTW; been up since 5:30; breakfast, scripture with family, dropped off Amber at school (12 miles away), shower, etc. and this lazy american finally spotted your summons! |
| 15:00.36 | *** join/#asterisk-dev CunningPike (n=arodgers@204.239.8.149) |
| 15:10.45 | eliel | M11256 |
| 15:10.46 | MuffinMan | [new] [Asterisk] Core/ManagerInterface 0011256: [patch] Deadlock in find_session(unsigned long ident) reported by ys http://bugs.digium.com/view.php?id=11256 |
| 15:11.12 | eliel | Hello, I have been looking manager.c code and it looks confusing the locks |
| 15:12.03 | eliel | on the same function: process_message() you lock the mansession "s" while doing a astman_send_error(), and sometimes you don't |
| 15:15.38 | *** join/#asterisk-dev anthm (n=anthm@CPE-72-131-113-50.wi.res.rr.com) |
| 15:15.38 | *** mode/#asterisk-dev [+o anthm] by ChanServ |
| 15:33.13 | oej | codefreeze: My apologies for my accusations. But you weren't up at 5.30 my time :-) |
| 15:35.31 | codefreeze | oej: no insult taken. The real question is: had I even gone to bed by 5.30 your time....? hmmmm! It's too early in the morning for such calculations... |
| 15:35.46 | oej | yeah, let's forget all about it... |
| 15:35.59 | oej | I'm flying over to the lazy norwegians, that's at least a bit closer to the USA |
| 15:41.35 | *** join/#asterisk-dev IgorG (i=FeedomPa@host-90-188-188-119.pppoe.omsknet.ru) |
| 15:56.48 | *** join/#asterisk-dev russellb (i=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 15:56.48 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 16:07.40 | *** join/#asterisk-dev jcmoore (n=jcmoore@unaffiliated/tgrman) |
| 16:23.18 | *** join/#asterisk-dev qdk (n=qdk@0x573fe57e.bynqu2.broadband.tele.dk) |
| 16:30.21 | *** join/#asterisk-dev outtolunc (n=me@adsl-66-218-53-172.dslextreme.com) |
| 16:32.57 | Juggie | anyone ever see this problem, i call into an * box, audio plays fine, i press a dtmf, audio dies, but it still shows playing on the * console, i press another dtmf, * sees it, but still no audio on my side, this is over a zaptel pri |
| 16:33.24 | Juggie | tried a new card, same issue. |
| 16:39.38 | outtolunc | like its waiting for another digit on an extension logic ? |
| 16:40.36 | outtolunc | does it ever timeout? if so that would be the case |
| 16:43.10 | Juggie | no, its playing files on the console but the remote end doesnt hear them |
| 16:43.56 | outtolunc | using playback or some other method like queue/etc moh |
| 16:44.23 | Juggie | using Background |
| 16:44.49 | Juggie | its a 4span t1 card, it worked before, i dunno what changed to be honest i dont manage asterisk anymore i've just been asked to help |
| 16:44.53 | outtolunc | make sure 'a' extension exists for that read |
| 16:45.03 | outtolunc | like a 1, |
| 16:46.00 | *** join/#asterisk-dev anthm (n=anthm@CPE-72-131-113-50.wi.res.rr.com) |
| 16:46.00 | *** mode/#asterisk-dev [+o anthm] by ChanServ |
| 16:46.46 | outtolunc | point being the embedded 'read' in backrgound is waiting for 'valid' input |
| 16:48.43 | Juggie | outtolunc, its all in agi |
| 16:49.00 | Juggie | the same script works fine on every other server. |
| 16:49.23 | Juggie | its either a bug or an odd configuration glitch |
| 16:49.39 | outtolunc | just trying to help |
| 16:50.09 | Juggie | sorry, dont mean to belittle you, but its not something simple like the dialplan.. i wish it was :) |
| 16:52.55 | outtolunc | yeah silly me, i just use exec-read and get_variable because of that type of issue |
| 16:53.59 | Juggie | nah its something weird, a call via sip works fine, and of course the agi script works fine on all other boxes.. audio is not being transfered over the pri after the first dtmf |
| 16:56.21 | outtolunc | i am sure i will see it soon as we will be turning up the inbound side on ours within 2 weeks |
| 16:59.22 | De_Mon | :( I don't go to bed early enough to read scripture in the morning |
| 17:05.53 | Juggie | yes. |
| 17:05.56 | Juggie | doesnt show anything of use |
| 17:06.01 | Juggie | not that i see anyway. |
| 17:08.48 | outtolunc | well with debug mode you would hopefully see the recv and possibly the error/cause why it goes dumb |
| 17:09.13 | outtolunc | if you can get me that debug info i'll take a peek at it |
| 17:09.49 | Juggie | just upgraded the lib pri to 1.4.2 and did a clean rebuild of it all |
| 17:09.53 | Juggie | we'll see if that makes a difference |
| 17:10.18 | outtolunc | k |
| 17:13.31 | jmls | anyone here who wpulde care to help me out with a question on app_queue.c ? |
| 17:13.50 | Juggie | hrmf... nope. |
| 17:14.11 | jmls | ;) |
| 17:16.36 | Corydon76-vcch | I think you need to ask in #asterisk |
| 17:17.07 | putnopvut | jmls: possibly... |
| 17:17.17 | jmls | Corydon76-vcch: it is a developer question - regarding why locks are set or not on a queue |
| 17:17.40 | *** join/#asterisk-dev blitzrage (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 17:17.40 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 17:17.44 | Juggie | grrr |
| 17:17.46 | jmls | putnopvut: before setting a channel variable, app_queue.c 1.4 uses pbx_builtin_setvar_helper but does not lock the queue |
| 17:18.03 | jmls | trunk uses pbx_builtin_setvar, but locks the queue before and unlocks it after |
| 17:18.10 | jmls | I was wondering why ... |
| 17:18.49 | putnopvut | Is this in all cases where a variable is set, or in specific instances? |
| 17:18.56 | Corydon76-vcch | Why ask why? Drink Bud Dry. |
| 17:19.07 | Qwell | s/Drink/Try/ |
| 17:19.18 | *** join/#asterisk-dev fakhir (n=fakhir@unaffiliated/fakhir) |
| 17:19.19 | putnopvut | Does Bud Dry even exist anymore? |
| 17:19.35 | Corydon76-vcch | No idea |
| 17:19.39 | Qwell | they canceled the Bud Bowl, so I imagine not |
| 17:21.03 | jmls | putnopvut: in 1.4, where it sets the MEMBERINTERFACE |
| 17:21.25 | eliel | M11255 |
| 17:21.26 | MuffinMan | [new] [Asterisk] Applications/app_queue 0011255: crashast_queue_hangup (chan=0x0) reported by enst http://bugs.digium.com/view.php?id=11255 |
| 17:21.27 | blitzrage | Bud? gross |
| 17:21.33 | putnopvut | In 1.4, it's not actually accessing or changing any data from the queue, so there's no need to lock it. |
| 17:21.38 | eliel | Why this issue was moved to Applications/app_queue? |
| 17:21.57 | jmls | in 1.6 it does lock before, though. |
| 17:21.58 | jmls | ao2_lock(qe->parent) |
| 17:22.04 | Corydon76-vcch | blitzrage: like Molson is any better? |
| 17:22.16 | jmls | pbx_builtin_setvar(qe->chan, interfacevar) |
| 17:22.29 | jmls | ao2_unlock(qe->parent) |
| 17:22.31 | blitzrage | Molson is probably some of the grossest beer ever |
| 17:22.39 | blitzrage | I don't drink domestic beer |
| 17:22.41 | Corydon76-vcch | Precisely |
| 17:22.49 | Juggie | outtolunc, no change... played w/ as many settings i could think of, no change, i would understand more if it was affecting one pri, but its affecting multiple w/ different configs :( |
| 17:22.58 | putnopvut | jmls: the lock could probably be moved actually. |
| 17:23.02 | Corydon76-vcch | Could be worse, though... Could be Maddog 2020 |
| 17:23.04 | blitzrage | unless it's something like Keith's |
| 17:23.15 | putnopvut | The setinterfacevar part doesn't actually get any queue data. |
| 17:23.25 | putnopvut | The setqueueentryvar, however, does. |
| 17:23.33 | Corydon76-vcch | or Schlitz |
| 17:23.37 | jmls | ooooohhh, ok |
| 17:23.55 | jmls | so if I want to port setqueueentryvar to 1.4, I would need to lock . |
| 17:24.08 | putnopvut | Well, actually, I'm thinking it may be unnecessary... |
| 17:24.44 | putnopvut | But I'm not 100% sure, though. |
| 17:24.46 | blitzrage | Pabst, what?! |
| 17:25.04 | jmls | he == jmls, that is ;) |
| 17:25.35 | puzzled | who's stealing my identity?! |
| 17:25.36 | putnopvut | jmls: heh, nothing seems to be going right for me lately development-wise, so I'm being overly cautious with everything I say/do. |
| 17:25.57 | jmls | cmad ? |
| 17:26.23 | *** join/#asterisk-dev joetester (n=patrick@216.191.34.13) |
| 17:26.41 | putnopvut | jmls: what? |
| 17:26.55 | jmls | Cover My Ass Development. /* don't know why I was told to do this but I was, so I have. I don't think that this is the right way to do it but hey, I'm just the developer here */ |
| 17:27.16 | putnopvut | Ah. I wasn't familiar with that acronym :() |
| 17:27.18 | putnopvut | Ooops. |
| 17:27.19 | putnopvut | :) |
| 17:27.22 | putnopvut | That's what I meant. |
| 17:28.12 | jmls | I'm called the "Supreme Head of IT" at work |
| 17:29.15 | jmls | so, should I lock the queue if I backport setqueueentryvar ? |
| 17:29.34 | putnopvut | I would play it safe and lock. |
| 17:29.51 | jmls | okay, thanks |
| 17:31.00 | putnopvut | yes ;) |
| 17:38.19 | outtolunc | Juggie: it would still help to see what the pri is seeing when that happens |
| 17:43.48 | Juggie | outtolunc, ya, someone else is working on it now, i think its a timeing issue |
| 17:44.00 | Juggie | since there are multiple t1s, different providers |
| 17:45.25 | Juggie | i told them to try it w/ 1 t1 connected and get back to me |
| 17:45.45 | outtolunc | are they using the same device to dial into the pris? like maybe a cell phone <G> |
| 17:48.11 | *** join/#asterisk-dev _ys (n=yuri@236-069.nat.mns.ru) |
| 17:48.14 | Juggie | we have tried multiple devices, same result. |
| 17:48.20 | outtolunc | k |
| 17:52.17 | Juggie | multiple devices, multiple pris, and i've checked the configs over about 20 times and our working server matches |
| 17:52.50 | Juggie | so, its either a config issue i'm not seeing, two bad t1 cards in a row, or timeing, my guess is timeing, so someone is checking into that now. |
| 17:54.41 | *** join/#asterisk-dev steliosk (n=Stelios@ipa226.211.tellas.gr) |
| 18:18.56 | Corydon76-vcch | russellb: ping |
| 18:44.04 | *** join/#asterisk-dev agx (n=badpengu@81-174-44-24.dynamic.ngi.it) |
| 18:48.58 | _ys | destination unreachable |
| 18:56.00 | jtodd | ping: sendto: Host is down |
| 19:09.07 | *** join/#asterisk-dev pjezek (n=pj@193.85.164.154) |
| 19:11.38 | pjezek | hi, is possible to report issues with devel branch (eg. bbryant/sip-tcptls) via asterisk bugtracker? |
| 19:13.50 | Corydon76-vcch | It's best to report the issue directly to the developer involved |
| 19:14.40 | pjezek | via irc, eg. private message? |
| 19:15.18 | Corydon76-vcch | or email |
| 19:15.40 | De_Mon | its generally bad practice to privmsg someone in irc |
| 19:16.36 | file | unless you know them... or they ask you |
| 19:16.41 | file | although it could be a trap |
| 19:19.13 | pjezek | ok, I will try to post to Russel B. via email |
| 19:19.25 | _ys | where is init w/kill weapon :) |
| 19:29.54 | De_Mon | I wonder if anyone has created a dialplan > flowchart script yet |
| 19:30.15 | De_Mon | sorry wondering in the wrong channel |
| 19:36.33 | russellb | pjezek: you can put that info in the existing TCP/TLS issue |
| 19:36.35 | russellb | or contact citats |
| 19:53.06 | pjezek | I was post mail to you right now, first issue is about unregistering peers with any reason after some time... |
| 19:55.34 | Simon-- | is digium bugs "tilghman" around here? |
| 19:56.01 | file | "tilghman" is also known as Corydon76 |
| 20:02.51 | Corydon76-vcch | Nein |
| 20:03.27 | Corydon76-vcch | russellb: ping |
| 20:03.57 | russellb | pong, maybe |
| 20:04.09 | Corydon76-vcch | Feeling well enough for a release? |
| 20:04.46 | Qwell | russellb: if not, I don't mind doing it, fyi |
| 20:04.53 | Qwell | actually, I take that back |
| 20:04.57 | russellb | feeling well enough, but way too busy |
| 20:05.00 | russellb | maybe tomorrow |
| 20:05.02 | Qwell | same |
| 20:05.14 | russellb | or maybe late this afternoon ... |
| 20:05.55 | Corydon76-vcch | k |
| 20:07.05 | _ys | release - 25 open bug for branch 1.4 |
| 20:07.19 | Qwell | _ys: we're never going to be at 0 |
| 20:07.23 | Qwell | ever |
| 20:07.32 | russellb | well we have fixed 150 since 1.4.13 |
| 20:07.37 | Qwell | nice |
| 20:07.55 | Qwell | trouble |
| 20:07.59 | file | svn ps r0x0rz 'devteam' . |
| 20:08.05 | Corydon76-vcch | and that's just for things that bugs were filed for |
| 20:08.12 | _ys | Qwell 7 crash bug found |
| 20:08.25 | Qwell | _ys: feel free to fix them all before we make a release |
| 20:20.19 | eliel | M11219 |
| 20:20.20 | MuffinMan | [new] [Asterisk] Core-General 0011219: [patch] Avoid including not needed header files or already included. reported by eliel http://bugs.digium.com/view.php?id=11219 |
| 20:20.43 | eliel | Qwell: we are waiting for OSX feedback? |
| 20:21.07 | Qwell | eliel: yep |
| 20:23.56 | _ys | OSX is BSD like? |
| 20:24.18 | _ys | ah |
| 20:24.20 | _ys | yes |
| 20:28.04 | _ys | eliel, why astman_send_error must be locked? |
| 20:28.43 | eliel | read the astman_send_error documentation :-) the mansession must be locked unless you are calling astman_send_error from an action callback |
| 20:29.35 | eliel | because when you call astman_send_error from an action callback only one at a time is being executed |
| 20:30.21 | eliel | but outside of an action callback we have many threads "fighting" to get access to the shared memory (for example the sessions structure). |
| 20:31.26 | _ys | eliel, i see note: "XXX this comment is unclear and possibly wrong." |
| 20:32.43 | *** join/#asterisk-dev Laureano (n=Laureano@host172038.metrored.net.ar) |
| 20:34.45 | eliel | _ys: yes but if you review the code, there are locking the mansession before calling astman_send_error() outside of an action callback like the documentation says, so if I consider the documentation true, then there are missing locks in the code, if the documentation is wrong then we need to cleanup the code a remove the mutex_locks() of mansession. |
| 20:37.18 | _ys | lock: "__lock" in mansession is strange lock, AST_LIST_LOCK(&sessions); can do this itself. |
| 20:38.20 | _ys | or we must held mansession lock at all, there used mansession |
| 20:40.04 | *** join/#asterisk-dev twilson (n=twilson@CPE-65-30-30-20.kc.res.rr.com) |
| 20:41.50 | _ys | eliel: I find, that purge_old_stuff() <- is called anisochronous, and need the lock stuff |
| 20:50.06 | eliel | _ys: great |
| 20:51.55 | eliel | Qwell: fell free to close #11096 I will not submit any new file, If I have the time to continue with this janitor, I could reopen this or create a new report. |
| 20:52.04 | eliel | s/fell/feel |
| 20:52.07 | Qwell | M11096 |
| 20:52.08 | MuffinMan | [new] [Asterisk] Core-General 0011096: [patch] Modify the return values on load_module(). reported by eliel http://bugs.digium.com/view.php?id=11096 |
| 20:52.14 | Qwell | ok |
| 20:52.23 | Qwell | but there are more? |
| 20:53.24 | eliel | yes, but they need a deeper code review in my opinion. |
| 20:56.03 | eliel | and what about |
| 20:56.04 | eliel | M11123 |
| 20:56.05 | MuffinMan | [new] [Asterisk] Core-General 0011123: [patch] Implement asterisk CLI permissions. reported by eliel http://bugs.digium.com/view.php?id=11123 |
| 20:56.06 | eliel | :-( |
| 20:56.39 | eliel | I will continue supporting this report to make it compatible with the last revision |
| 20:56.45 | eliel | but could be assisgned¿? |
| 21:01.38 | *** join/#asterisk-dev moy (n=moyhu@dsl-200-67-94-114.prod-empresarial.com.mx) |
| 21:02.50 | moy | Qwell: bug report 11096 was suspended, even when I just uploaded patches yesterday, Eliel was not the only one uploading :) ... can you re-open? more are coming this week |
| 21:03.01 | Qwell | oh, d'oh |
| 21:03.23 | Qwell | should've commented :) |
| 21:03.49 | moy | yeah I should have added a comment. Don't you guys get notification of uploads? |
| 21:03.58 | Qwell | nope |
| 21:04.05 | moy | ok good to know |
| 21:05.55 | moy | additionally, does anybody know why __ast_alloc_region does not return after malloc failure? yesterday night I asked here but nobody was around to confirm this is an error and fix it |
| 21:09.15 | Corydon76-vcch | because malloc failure calls abort(3) which never returns |
| 21:11.02 | moy | Corydon76-vcch: Thanks, I see... so is this a MALLOC_CHECK_ thing I suppose |
| 21:11.22 | Corydon76-vcch | No, this is a libc thing |
| 21:15.04 | moy | if malloc itself calls abort(3), what is the purpose of having if (!(reg = malloc( ...) ) astmm_log() .... if it is not going to be reached? |
| 21:23.35 | kpfleming | it only calls abort(3) if MALLOC_CHECK is set to 2 or 3 and heap corruption is found |
| 21:25.31 | snuff-work | codefreeze: posted those hashtab changes |
| 21:27.03 | snuff-work | M11265 |
| 21:27.04 | MuffinMan | [new] [Asterisk] Core-General 0011265: [patch] Reuse code in hashtab.c reported by snuffy http://bugs.digium.com/view.php?id=11265 |
| 21:33.09 | *** join/#asterisk-dev moy (n=moyhu@dsl-200-67-94-114.prod-empresarial.com.mx) |
| 21:37.06 | moy | Corydon76-vcch: sorry, lost the internet connection :( .... did not see if you answered my question |
| 21:38.48 | Qwell | moy: <kpfleming> it only calls abort(3) if MALLOC_CHECK is set to 2 or 3 and heap corruption is found |
| 21:40.02 | Corydon76-vcch | moy: also, malloc() can return NULL if the requested memory amount is not available |
| 21:40.23 | Corydon76-vcch | As it turns out, that will never happen on Linux, but it could still happen on other systems |
| 21:41.06 | Corydon76-vcch | or rather, that will never happen on Linux with the default memory settings (optimistic memory allocation) |
| 21:41.12 | moy | ok, so it is a MALLOC_CHECK thing as I thought, but, if no malloc check, return NULL should follow malloc() failure, isnt't it? just after the log |
| 21:45.36 | moy | ok, that's up to you guys. Thanks for the clarification ... out to lunch, see you later |
| 21:59.32 | *** join/#asterisk-dev snuff-work (n=bradl@61.29.30.137) |
| 21:59.32 | *** join/#asterisk-dev wedhorn (n=wedhorn@dsl-58-6-89-11.act.westnet.com.au) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev tzafrir (n=tzafrir@62.90.10.53) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev pnlarsson (n=pnlarsso@c83-248-96-159.bredband.comhem.se) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev _charly_ (i=kroseneg@sunrise.schmidham.net) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev Simon-- (n=sim@staff-nat.netnation.com) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev snuff-home (i=snuff@220-253-28-151.VIC.netspace.net.au) |
| 21:59.40 | *** join/#asterisk-dev smurf (n=smurf@debian/developer/smurf) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev Damin (n=damin@nucleus.nacs.net) [NETSPLIT VICTIM] |
| 21:59.40 | *** join/#asterisk-dev corramor (i=corramor@nat/digium/x-d1e79f972f247aba) [NETSPLIT VICTIM] |
| 21:59.40 | *** mode/#asterisk-dev [+o tzafrir] by irc.freenode.net |
| 22:00.05 | *** join/#asterisk-dev Deeewayne (i=dwayne@nat/digium/x-78db5d584ebf2189) [NETSPLIT VICTIM] |
| 22:00.06 | *** join/#asterisk-dev alex-pilosoft (i=nobody@colo-69-31-40-106.pilosoft.com) [NETSPLIT VICTIM] |
| 22:00.06 | *** join/#asterisk-dev xpot (n=jim@c-71-195-241-115.hsd1.ut.comcast.net) [NETSPLIT VICTIM] |
| 22:00.06 | *** mode/#asterisk-dev [+o Deeewayne] by irc.freenode.net |
| 22:00.50 | *** join/#asterisk-dev russellb (i=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 22:00.50 | *** join/#asterisk-dev fakhir (n=fakhir@unaffiliated/fakhir) |
| 22:00.51 | *** join/#asterisk-dev qdk (n=qdk@0x573fe57e.bynqu2.broadband.tele.dk) |
| 22:00.51 | *** join/#asterisk-dev puzzled (n=patrick@puzzled.xs4all.nl) |
| 22:00.51 | *** join/#asterisk-dev davevg-btwtech (n=davevg-b@nj-67-76-177-147.sta.embarqhsd.net) |
| 22:00.51 | *** join/#asterisk-dev Juggie (n=Juggie@CPE001601df17fb-CM001a6682d7b6.cpe.net.cable.rogers.com) |
| 22:00.51 | *** join/#asterisk-dev jameswf (n=jameswf@dsl093-157-131.phx1.dsl.speakeasy.net) |
| 22:00.51 | *** join/#asterisk-dev putnopvut (i=putnopvu@nat/digium/x-724b8ba603112084) |
| 22:00.51 | *** join/#asterisk-dev GreggB (n=GreggB@66.206.86.107) |
| 22:00.51 | *** join/#asterisk-dev bmd (n=bmd@72.54.252.34) |
| 22:00.51 | *** join/#asterisk-dev kpfleming (i=kpflemin@nat/digium/x-ee9a72ebe0879471) |
| 22:00.52 | *** join/#asterisk-dev BadPacket (n=John@unaffiliated/badpacket) |
| 22:00.52 | *** join/#asterisk-dev denon (n=denon@tooth.decay.org) |
| 22:00.52 | *** join/#asterisk-dev d3wayne (n=deeewayn@76.29.245.9) |
| 22:00.52 | *** mode/#asterisk-dev [+oooo russellb putnopvut kpfleming d3wayne] by irc.freenode.net |
| 22:00.52 | *** join/#asterisk-dev Corydon76-vcch (n=tilghman@pdpc/supporter/bronze/Corydon76-home) |
| 22:00.52 | *** join/#asterisk-dev bkruse (i=bkruse@nat/digium/x-4eba4c0444defb72) |
| 22:00.52 | *** join/#asterisk-dev MuffinMan (n=muffins@neutrino.joshua-colp.com) |
| 22:00.52 | *** mode/#asterisk-dev [+o Corydon76-vcch] by irc.freenode.net |
| 22:04.21 | *** join/#asterisk-dev anthm (n=anthm@CPE-72-131-113-50.wi.res.rr.com) |
| 22:04.21 | *** mode/#asterisk-dev [+o anthm] by ChanServ |
| 22:49.15 | *** join/#asterisk-dev agx (n=badpengu@81-174-45-170.dynamic.ngi.it) |
| 23:38.27 | Corydon76-vcch | Qwell: ping |
| 23:38.33 | Qwell | pongish |
| 23:38.43 | Corydon76-vcch | You know what's wrong with 11266? |
| 23:38.52 | Qwell | M11266 |
| 23:38.55 | MuffinMan | [new] [Asterisk] Channels/chan_iax2 0011266: When invalid IP address is specified chan_iax2 crashes. reported by johann8384 http://bugs.digium.com/view.php?id=11266 |
| 23:39.27 | Qwell | nope, but I'm hoping my suspicion is incorrect |
| 23:39.38 | Corydon76-vcch | Last argument to the stringfield init is -1... but it's a size_t |
| 23:39.53 | Corydon76-vcch | and then we're asking if the argument is > 0 |
| 23:39.57 | Qwell | cute |
| 23:40.12 | Qwell | so, is it only an issue with the config parser? |
| 23:41.05 | Corydon76-vcch | Dunno |
| 23:41.05 | Qwell | see msg |
| 23:43.16 | Qwell | so, how are we checking arg there? |
| 23:51.32 | Corydon76-vcch | Good news, it was only this way since 88454 |
| 23:51.37 | Qwell | cool |
| 23:52.27 | snuff-work | mm.. elils manager lock patch i think he has a typo.. calling lock twice.. instead of a lock/unlock |
| 23:52.48 | Qwell | snuff-home: could you note it, so nobody commits it by accident? |
| 23:54.06 | snuff-work | k |
| 23:54.21 | Corydon76-vcch | corramor: ping |
| 23:56.05 | Corydon76-vcch | Is there an effect on the number of cards possible in a system, with PCI-Express cards? |
| 23:56.22 | Corydon76-vcch | i.e. can you put more than 3 into a system without causing interrupt overload? |