IRC log for #arl on 20160802

00:22.21Ressymy poor back
00:22.27RessyI just wanted to go to chiro on saturday.
00:22.54TorhalWhy didn't you?
00:24.46Ressyclosed because its a long weekend. today was a holiday
00:36.04TorhalAh
00:44.29*** join/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net)
00:44.29*** mode/#arl [+v pompy] by ChanServ
07:35.42sidjimoin
09:41.19TorhalYola
12:27.52*** part/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net)
13:05.31*** join/#arl Ressy (~Ressy@WoWUIDev/WoWAce/ARL/Ressy)
13:05.31*** mode/#arl [+v Ressy] by ChanServ
13:09.43TorhalRessy: Yola.
13:10.25TorhalJust pushed something to help with fixing https://www.wowace.com/addons/arl/tickets/1695-recipes-that-dont-exist/
13:10.42Torhal[08:09:24] Repo:83a2f04: Add detection for invalid recipes when running a development build - when found, they will be removed so a new recipe dump will correct the issue.
13:12.53TorhalOn my enchanter: https://www.dropbox.com/s/z5h4rynjxddzk2m/Screenshot%202016-08-02%2008.12.00.png
13:13.37TorhalGoing to bed, now.
14:06.36Ressyhow do you know about invalid recipes?
15:59.54TorhalRessy: As I iterate through all of the recipeID entries in the list of IDs I get from C_TradeSkillUI, I tag each corresponding recipe in professionRecipes with recipe.isValidated = true
16:00.13TorhalAfter that, I iterate through the professionRecipes themselves and nuke the ones without the tag.
16:00.53TorhalAnd yes, I woke up about 10 minutes ago.
16:09.41Ressygeez
16:09.46RessyYou got like no sleep
16:09.53TorhalIndeed :/
16:11.21Ressyso it gets everything via the UI, then checks if its displayed
16:11.41TorhalPretty much.
16:11.47Ressymkay.
16:12.02RessySo I've got stuff to do tonight in taking them out of the database, and adding them to the blacklist
16:15.22RessyWanna hear the funniest thing?
16:15.38RessyOne of the enchanting recipes..
16:15.43Ressyin the UI..
16:15.46RessyI had to blacklist.
16:15.57RessyBecause it's not actually available from the source blizzard says it is
16:16.29Ressy2 actually. I made notes in the blacklist list about them.
16:41.42Torhal[11:12:02] +Ressy:So I've got stuff to do tonight in taking them out of the database, and adding them to the blacklist <-- No.
16:42.06TorhalThey're taken out of the DB by the scan, because they aren't in the default UI.
16:42.29RessyBut they're in the database or they wouldn't be showing up
16:43.01TorhalYeah, but they don't need to be added to the blacklist. The blacklist is for shit the UI erroneously tells us about.
16:43.21RessyUI erroneously tells me theres 2 recipes live, when they're not.
16:43.34TorhalYes
16:43.39Ressywhen they never made it out of beta.
16:43.39TorhalThat is what the blacklist is for.
16:43.41RessyLike those ones.
16:44.00TorhalThe ones that are being auto-removed are being done so because the default UI has no record of them.
16:44.17TorhalSo they don't need blacklisting
16:44.36RessyThe problem is, I'm not doing dumps except with the original skeleton entries.
16:44.41RessyCuz if I go hit up vendors...
16:45.04RessyTheres 3 different ranks of many profession recipes.
16:45.09TorhalYes
16:45.09RessyIt'll add the vendor to all 3.
16:45.14TorhalThat is taken into account now.
16:45.15Ressyit can't distinguish .
16:45.18TorhalOh
16:45.22Ressyyeah
16:45.28TorhalThat's different but irrelevant,
16:45.35RessySo I'm doing it by hand
16:45.39RessyWhich is why it's taking so long.
16:46.07RessyAnd with the database..
16:46.09TorhalThe blacklist is for stuff the UI knows about but is wrong for whatever reason. Adding stuff to the blacklist that the UI doesn't know about is WAT.
16:46.20RessyI'm doing (1 star) v (2 stars) (3 stars)
16:46.48RessyI've been adding stuff to the blacklist which never went live
16:46.54TorhalYes
16:46.57Ressywhich never showed up on live, but is still in UI.
16:47.03RessyAnd 2 recipes which SAY are live, but aren't
16:47.07TorhalThe UI still "knows" about that stuff, which is WHY it needs blacklisting.
16:47.23RessyThose are the only ones I've been blacklisting.
16:47.28TorhalThis stuff, the stuff being removed, the UI is saying "I don't know what the fuck that is"
16:47.38TorhalSo it does NOT need blacklisting.
16:47.42Ressymkay.
16:47.49RessyProbably previously on beta, but never made it live?
16:47.57Ressyconsidering its 6.0 stuff
16:47.58TorhalAnd didn't stick around in records, I guess.
16:48.00RessyOr it was removed.
16:48.18TorhalThe spells are obviously still in existence, because they have names
16:48.23Ressyya
16:48.26TorhalBut the TradeSkillUI doesn't count them at all.
16:49.27TorhalThat's the only way I was able to find those extra "recipes" that guy had in the ticket.
16:50.12TorhalAll off the ones that were in that ticket were removed in my screenshot
16:50.23Ressymkay..
16:50.29Ressyso how is it removed.
16:50.40RessyAre they still in the database or does it just say "I'm not showing them anymore."
16:51.43Torhal[08:12:53] @Torhal:On my enchanter: https://www.dropbox.com/s/z5h4rynjxddzk2m/Screenshot%202016-08-02%2008.12.00.png
16:51.50TorhalLast line
16:52.00Ressyah
16:52.02Ressyalright then.
16:52.16RessyWell, I'd rather not do a dump, because I'm actively working on Enchanting.
16:52.28TorhalThat's why it provides the other info.
16:52.32Ressynods
16:52.33Ressyperfect
16:52.55RessyI'll manually remove them tonight and push an update.
16:53.43TorhalHere's another commit:
16:53.45TorhalAdd IsRecipeInfoLearnedByDescendant and IsRecipeInfoUnlearnedByAncestor helpers to ignore irrelevant recipe ranks, since the information is now available via C_TradeSkillUI.
16:56.29Ressyawesome
16:56.38RessyI'll go through and remove the previousrankid stuffs
16:57.13TorhalSo now the code reads as
16:57.21Torhalif learned then
16:57.27Torhal<PROTECTED>
16:57.31Torhalelseif IsRecipeInfoLearnedByDescendant(recipeInfo) or IsRecipeInfoUnlearnedByAncestor(recipeInfo) then
16:57.31Torhalrecipe:AddState("IGNORED")
16:57.31Torhalelse
16:57.31Torhalrecipe:RemoveState("KNOWN")
16:57.32Torhalrecipe:RemoveState("LINKED")
16:57.33Torhalend
17:01.16RessyMkays.
17:01.31RessyAdded 2 asana tasks for myself so I remember everything that needs done.
17:03.25Torhal:D
17:12.52*** join/#arl Thaoky (~thaoky@59.107-240-81.adsl-dyn.isp.belgacom.be)
17:13.57RessyYou can set them up for me. :P
17:22.57TorhalI can do what, now?
17:33.02TorhalBack to bed.
17:49.38sidjiat 7:30 pm?
18:12.40Ressylol. You're also 6 hrs ahead of him, and his schedule has been wonky.
18:12.53Ressyerr, 7 hrs ahead of him.
23:12.43*** join/#arl Ressy (Ressy@192-0-172-185.cpe.teksavvy.com)
23:12.43*** join/#arl Ressy (Ressy@WoWUIDev/WoWAce/ARL/Ressy)
23:12.43*** mode/#arl [+v Ressy] by ChanServ
23:14.42RessyUm Torhal
23:14.44RessyWhatever you did...
23:15.02TorhalRessy: Time to throw in the towel on ARL, apparently. "Now that Blizz baked this into the UI on the default professions tab, what does this addon do now that is not done in the Blizz default UI?  Great addon, been using it since 2008, but not sure if it's needed now."
23:15.03RessyIts no longer making skeleton entries for spells in the UI
23:15.15RessySays who?
23:15.35TorhalSome dude in comments on mods.curse.com
23:15.44Ressyo.O
23:15.52TorhalHow do you know it isn't creating skeleton entries anymore?
23:16.00RessyCuz I just tried it with enchanting?
23:16.02TorhalDid for me this morning.
23:16.11TorhalNot enchanting, cooking I think.
23:16.20RessyI'm trying with enchanting.
23:16.26Ressyand theres 18 to be made.
23:16.29Ressynone of which were.
23:16.41TorhalExample?
23:16.56TorhalI didn't touch the skeleton code, BTW.
23:16.59TorhalSo...
23:17.01Torhal¯\_(ツ)_/¯
23:17.19RessyWelp...
23:17.22RessyIts not making them.
23:18.17Ressylemme push all my changes.
23:18.21Ressyand you can open enchanting.
23:18.34RessyAnd because you didn't put it on the guild panel, you'll need an enchanting char.
23:19.59TorhalI have one. That's how I gave you that screenshot...
23:20.06Ressyk
23:20.16Ressylemme push Core updates and then my enchanting changes
23:20.25RessyTrying to do localizations and its hanging
23:24.34Ressypushed both
23:25.42RessyIts pulling Retired recipes out.
23:26.46Ressyall 5 Engineering ones are retired.
23:27.47TorhalEasy fix.
23:28.22RessyI commented out a TON of recipes in Engineering..
23:28.26RessyCuz they were just skeletons.
23:28.32RessyIt recognized they weren't in the db
23:28.40Ressybut it didn't print the skeleton entries in the dump
23:29.30TorhalBRB, moar coffee.
23:30.40Ressyheh
23:30.40Ressyk
23:31.53*** join/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net)
23:31.53*** mode/#arl [+v pompy] by ChanServ
23:34.09TorhalRessy: Do me a favor, please; check whether or not those retired recipes' items are still obtainable at all, even from AH. The fact that the default UI doesn't know anything about them tells me they've likely been completely removed from the game, since I'm grabbing ALL the IDs, which is the reason we even need a blacklist to begin with.
23:38.57Ressymkay.
23:39.08RessyI'm more worried about the new legion stuff that its not even making skeleton entries for
23:39.14Ressywhich will be obtainable in a few weeks.
23:39.38RessyBut, Retired means unobtainable.
23:40.42TorhalActually, Retired was supposed to mean "This was removed from the game for all intents and purposes, but it's still possible to get it if you find someone who has the recipe item."
23:40.52TorhalNow it's "Lol, this used to exist."
23:41.15TorhalWe shouldn't be tracking anything that isn't current; the purpose is to help people get things they're missing, not show them things they can never have.
23:41.49RessyI'm more concerned about it not creating entries for things that do exist and will be obtainable.
23:42.00TorhalThough there may be a reasoning behind the current behavior I'm not grasping because I'm very tired and half asleep.
23:42.16TorhalYeah, I'll look at it.
23:42.20Ressyty <3
23:42.38TorhalBut if the retired stuff is still obtainable, I need to figure out why the default UI has no damn clue about it.
23:42.46TorhalBecause that would be a weird false-positive.
23:42.47RessyI'll double check them.
23:42.57RessyI know that some of them aren't obtainable still.

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.